Compare commits

..

4 commits

Author SHA1 Message Date
shafi54
8f1e40f8b2 enh 2026-10-07 00:27:11 +05:30
shafi54
5af1afd8ba enh 2026-10-06 11:53:12 +05:30
shafi54
e88f82c4c9 enh 2026-10-05 20:43:25 +05:30
shafi54
ac31dc2010 enh 2026-10-05 11:46:47 +05:30
1249 changed files with 521980 additions and 148362 deletions

View file

@ -1,55 +0,0 @@
# Phase boundaries
A **phase** is a chunk of work inside a session: the grilling, the implementation, the QA. The definition is fuzzy on purpose: a phase ends when you think *"ok, we're done with that"*.
The **phase boundary** is the gap between two phases, and it is the only place this decision belongs. Mid-phase there is no decision to make: continue, or split the work that's left into subagents. Compacting mid-phase makes the agent lose the thread.
## The five options
| Option | What it does |
| ------------ | --------------------------------------------------------------- |
| **Continue** | Stay in the session. No context switch at all. |
| **`/clear`** | Empty the context window and start from nothing. |
| **`/handoff`** | Write a portable markdown file and seed a session anywhere with it. |
| **Subagent** | Send the task to its own context window and get a report back. |
| **`/compact`** | Compress this context and seed a fresh session with the summary. |
## The tree
Work top to bottom at the boundary. The first **yes** wins.
**1. Can you continue in this session?** Two things make the answer yes: the next phase needs this phase as a **primary source**, or you have enough [smart zone](https://www.aihero.dev/ai-coding-dictionary/smart-zone) left (~150k tokens) for the next phase to fit. Grilling → implementation is the standard yes: the implementation wants the reasoning verbatim, not a summary of it. Continue costs nothing and loses nothing, so rule it out before anything else.
**2. Is the context irrelevant to what comes next?** Is everything in this session (the exploration, the decisions, the dead ends) disposable? If so, **`/clear`**. It is the cheapest move on the board: it takes no time and hands back the whole window. `/clear` also isn't terminal: the old session stays resumable.
The cost of getting this wrong is one-way. Clear a *relevant* context and you lose the **why** behind what you built, and no amount of reading the diff back gets it returned.
**3. Do you need to hand off?** `/handoff` is narrow. You need it only when you are:
- swapping to a **new harness** (Claude → Codex),
- moving to a **new directory** or repo,
- sending the work to a **colleague**,
- or forking a side task you found **mid-phase** without derailing what you're doing.
That list is the whole clause. What `/handoff` buys is **portability**: a file that travels. If nothing is travelling, you don't need it.
**4. Can the task be done AFK?** Is it scoped tightly enough to run with you away from the keyboard, no steering? Then send it to a **subagent** and leave this session untouched. Automated review is the standard case: the agent reads the diff and reports, and you aren't needed while it does.
**5. Otherwise, `/compact`.** Relevant context, same harness, same directory, and you need to stay in the loop: this is where the tree lands, and it lands here often. Pass it an instruction (`/compact we're going to QA this area`) so the summary keeps what the next phase needs.
`/compact` is the **default, not the first reach**. It sits at the bottom because the four questions above it are all cheaper or more precise. The failure mode when people start here is a fresh session that is confidently wrong about a decision the summary flattened.
## Primary and secondary sources
Every move except **Continue** turns a **primary source** into a **secondary source**: the session as it happened, replaced by a summary of it. The trade is always the same shape:
| Source | Information | Noise | Room to move |
| --------------------------------- | ----------- | ----- | ------------ |
| Primary (Continue) | Full | Lots | Little |
| Secondary (`/compact`, `/handoff`) | Lossy | Less | Lots |
This is why question 1 comes first. You only pay the lossiness when staying costs more than it saves.
## These are judgement calls
The questions are not objective: each has taste in it, and the same boundary can go two ways on two days. The value is in asking them **in order**, at the boundary rather than in the middle of the work.

View file

@ -1,97 +0,0 @@
---
name: ask-matt
description: Ask which skill or flow fits your situation. A router over the skills in this repo.
disable-model-invocation: true
---
# Ask Matt
You don't remember every skill, so ask.
Before stating what a skill does or recommending a step be skipped, read that skill's SKILL.md: the summaries here are for orientation only.
A **flow** is a path through the skills. Most paths run along one **main flow**, and two **on-ramps** merge onto it. Everything else is standalone, or a vocabulary layer that runs underneath.
## The main flow: idea → ship
The route most work travels. You have an idea and want it built.
1. **`/grill-with-docs`** sharpens the idea by interview. Start here whenever you are **working in a working directory**: it's stateful, retaining what it learns in `GLOSSARY.md` and ADRs. (No working directory? Use `/grill-me` instead, covered under Standalone. Both run the same `/grilling` primitive; `grill-with-docs` is the one that leaves a paper trail, which makes it the better of the two whenever a repo is there to leave it in.)
2. **Branch: can you settle every question in conversation?** If a question needs a runnable answer (state, business logic, a UI you have to see), detour through a prototype, bridged by **`/handoff`** in both directions (a prototype lives in its own directory, which is exactly what `/handoff` is for; see Phase boundaries):
- **`/handoff`** out, then open a fresh session against that file,
- **`/prototype`** to answer the question with throwaway code,
- **`/handoff`** back what you learned, and reference it from the original idea thread.
3. **Branch: is this a multi-session build?**
- **Yes** → **`/to-spec`** (turn the thread into a spec), then **`/to-tickets`** to split it into tracer-bullet tickets, each declaring its **blocking edges**. Then work the tickets one of two ways:
- **`/implement`** per ticket, **`/clear`ing context between each one**. On a local tracker that's one file per ticket under `.scratch/<feature>/issues/`, worked blockers-first by hand; on a real tracker the edges become native blocking links, so any ticket whose blockers are done can be grabbed. Each ticket is self-contained, so the last one's context is disposable.
- **`/implement-spec`** for the whole spec in one run. It reads the tickets as a **task graph**, runs implementer subagents across the ready **frontier** in parallel, and lands everything on one **integration branch**. Reach for it when you'd rather orchestrate the build than drive each ticket yourself.
- **No** → **`/implement`** right here, in the same context window.
Either way, the code gets built by driving **`/tdd`** (one red-green slice at a time) and closes out with **`/code-review`**, a two-axis review (Standards + Spec) of the diff. `/implement` runs both per ticket; `/implement-spec`'s implementers each drive `/tdd`, and it runs one `/code-review` over the integration branch. Reach for **`/tdd`** on its own when you just want to build a concrete behaviour test-first without a full spec, and **`/code-review`** on its own whenever you want to review a branch or PR against a fixed point.
When the work goes up as a pull request, **`/pr`** shapes the body: the smallest visual that shows the change, before/after evidence that it works, and a one-way or two-way door call. It's model-invoked, so the agent reaches for it whenever it writes a PR.
4. **`/retro`** closes the loop. After a build, and especially one that went sideways, it looks back over the session and suggests changes to the agent's **environment**, not the code: navigation pointers, automated checks, the coding standards `/code-review` enforces, steering files, tooling. Mechanical mistakes become deterministic checks; judgement calls become coding standards. The next build then starts from a better environment.
### Context hygiene
Keep steps 1–3 in **one unbroken context window** (don't compact or clear until after `/to-tickets`) so the grilling, spec, and tickets all build on the same thinking. Each `/implement` then starts fresh, working from the ticket. Run `/retro` in the session it's looking back on, before you clear; after clearing, point it at that session's log instead.
The limit on this is the **[smart zone](https://www.aihero.dev/ai-coding-dictionary/smart-zone)**: the window (~150k tokens on state-of-the-art models) within which the model still reasons sharply. If a session approaches it before `/to-tickets`, don't push on degraded; `/compact` at the nearest phase boundary and carry on (see Phase boundaries).
## On-ramps
A starting situation that generates work, then merges onto the main flow.
- **Bugs and requests piling up** → **`/triage`**. It moves issues through triage roles and produces agent-ready issues, which **`/implement`** later picks up.
Triage is only for issues **you didn't create**: bug reports, incoming feature requests, anything that arrives raw. Tickets that `/to-tickets` produced are already agent-ready, so **don't triage them**.
- **Something's broken** → **`/diagnosing-bugs`**. For the hard ones: the bug that resists a first glance, the intermittent flake, the regression that crept in between two known-good states. It refuses to theorise until it has a **tight feedback loop** (one command that already goes red on *this* bug), then fixes with a regression test. Once the fix is in, run **`/retro`** in the same session to ask what would have prevented the bug; where the real finding is that there's no good seam to lock it down, that's a job for **`/improve-codebase-architecture`**.
- **A huge, foggy effort: a greenfield project or a huge feature build, too big for one session** → **`/wayfinder`**, the most cognitively demanding flow here. When the way from here to the destination isn't visible yet, it charts a **shared map** of **decision tickets** on the issue tracker and resolves them one at a time, producing **decisions, not deliverables**, until the fog is pushed back and the way is clear. Where **`/grill-with-docs`** sharpens an idea you can hold in one session, wayfinder is for the idea you can't, and it's slower and denser, so save it for exactly that, never a well-scoped feature.
When the map clears, **it hands off, it doesn't build**: merge onto the main flow at **`/to-spec`**, which collapses the map's linked decisions into a buildable plan, then `/to-tickets` and `/implement` as usual. Looping the map straight into `/implement` skips that collapse and throws the linked detail away, so go straight to `/implement` only when the effort turned out genuinely small.
## Codebase health
Not feature work, just upkeep.
- **`/improve-codebase-architecture`** runs whenever you have a spare moment to keep the codebase good for agents to operate in. It surfaces **deepening opportunities**; picking one _generates an idea_ you can take into the main flow at `/grill-with-docs`. It's the survey that finds the candidates; **`/codebase-design`** (below) is the bench you design the chosen one on.
## Vocabulary underneath
Two model-invoked references that run *beneath* the other skills, each the single source of truth for its vocabulary. Reach for them directly when the **words**, not the process, are the problem; or let the skills above pull them in.
- **`/domain-modeling`**: sharpen the project's *domain* language: challenge a fuzzy term, resolve an overloaded word ("account" doing three jobs), record a hard-to-reverse decision as an ADR. It's the active discipline `/grill-with-docs` drives to keep `GLOSSARY.md` a clean glossary.
- **`/codebase-design`** is the deep-module vocabulary (module, interface, depth, seam, adapter, leverage, locality) for designing a module's *shape*: a lot of behaviour behind a small interface at a clean seam. `/tdd` and `/improve-codebase-architecture` both speak it.
## Phase boundaries
A **phase** is a chunk of work inside a session: the grilling, the implementation, the QA. At the **boundary** between two of them you have five options, and picking between them is the fuzziest decision in this whole map:
- **Continue**: stay put. Costs nothing, loses nothing.
- **`/clear`**: empty the window, when nothing here matters to what's next.
- **`/handoff`** writes a portable markdown file. Narrow: only for a **new harness**, a **new directory**, a **colleague**, or forking a side task **mid-phase**. What it buys is portability.
- **Subagent**: send a tightly-scoped task to its own window and get a report back.
- **`/compact`** compresses this context and seeds a fresh session with it. The **default**, at the bottom of the tree rather than the first reach.
Read [PHASE-BOUNDARIES.md](PHASE-BOUNDARIES.md) for the ordered tree: the five questions, the reasoning behind each branch, and why the primary-source cost makes **Continue** the one to rule out first. Make the decision **at** a boundary; mid-phase, continue or split the rest into subagents.
## Standalone
Off the main flow entirely.
- **`/grill-me`**: the same relentless interview as `/grill-with-docs`, but **stateless**: it saves nothing locally and builds no `GLOSSARY.md`. Reach for it when you are **not working in a working directory** (sharpening a plan, a design, a piece of writing, anything with no repo under it). If you are in a working directory, use `/grill-with-docs` instead: it runs the same interview and leaves a paper trail, so it is strictly the better one.
- **`/grilling`** is the interview primitive itself: rounds, the frontier, facts are the agent's job and decisions are yours. `/grill-me` and `/grill-with-docs` are the two named ways in, and `/triage`, `/wayfinder` and `/improve-codebase-architecture` all run it internally. Reach for it directly only when you want the interview with no wrapper around it.
- **`/prototype`** is a small, throwaway program that answers one design question: does this state model feel right, or what should this UI look like. Throwaway is a constraint on how the code is written, not a promise to destroy it: the answer folds into the real code, and the prototype itself is kept as a **primary source** on a `prototype/<name>` branch out of main, pointed at from the implementation issue. It's the detour in step 2 of the main flow, but reach for it any time a design question is hard to settle on paper.
- **`/research`**: delegate reading legwork to a **background agent**: it investigates a question against **primary sources**, then leaves a cited Markdown file in the repo. Keep working while it reads. The file it produces is something to take *into* the main flow at `/grill-with-docs`, since research feeds the thinking rather than replacing it.
- **`/to-questionnaire`** comes in when the thing blocking you isn't in your head or the codebase but in **someone else's**, and it writes them a questionnaire to fill in. It's the inverse of `/grill-me`: instead of interviewing you about the subject, it interviews you about the **send** (who it's going to, what you need back) and aims the questions at the gap. What comes back is material for `/grill-with-docs` or `/to-spec`.
- **`/wizard`** is for the steps only a **human** can take: provisioning infrastructure, setting up credentials or CI secrets, clicking through an unfamiliar third-party dashboard, running a one-off migration or cutover. It generates an interactive bash script that opens each URL, captures each value, and writes it into `.env` and GitHub secrets, so the procedure stops being something you re-explain to an agent every time. Model-invoked, so the agent reaches for it the moment it hits a wall only you can pass. If the agent could just do it itself, it should; this is for where a human is genuinely in the loop.
- **`/wait-what`** is the corrective for a message that didn't land. Use it mid-conversation, inside any other skill, and the agent re-pitches what it just said with the context you were missing, in plain English, using the `GLOSSARY.md` vocabulary. It works after the fact; `/grill-with-docs` is the upfront cure, because a shared language agreed early is what stops the jargon arriving at all.
- **`/teach`**: learn a concept over multiple sessions, using the current directory as a stateful workspace.
- **`/writing-for-agents`** is the reference for writing documents agents consume: skills, AGENTS.md, pointed-at docs.
## Precondition
**`/setup-matt-pocock-skills`**: run before your first engineering flow to configure the issue tracker, triage labels, and doc layout the other skills assume. Custom issue trackers also work.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Ask Matt"
short_description: "Find the right skill or workflow"
policy:
allow_implicit_invocation: false

View file

@ -1,89 +0,0 @@
---
name: code-review
description: "Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes: Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/spec asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to \"review since X\"."
---
Two-axis review of the diff between `HEAD` and a fixed point the user supplies:
- **Standards**: does the code conform to this repo's documented coding standards?
- **Spec**: does the code faithfully implement the originating issue / spec?
Both axes run as **parallel sub-agents** so they don't pollute each other's context, then this skill aggregates their findings.
The issue tracker should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
## Process
### 1. Pin the fixed point
Whatever the user said is the fixed point (a commit SHA, branch name, tag, `main`, `HEAD~5`, etc.). If they didn't specify one, ask for it.
Capture the diff command once: `git diff <fixed-point>...HEAD` (three-dot, so the comparison is against the merge-base). Also note the list of commits via `git log <fixed-point>..HEAD --oneline`.
Before going further, confirm the fixed point resolves (`git rev-parse <fixed-point>`) and the diff is non-empty. A bad ref or empty diff should fail here, not inside two parallel sub-agents.
### 2. Identify the spec source
Look for the originating spec, in this order:
1. Issue references in the commit messages (`#123`, `Closes #45`, GitLab `!67`, etc.), fetched via the workflow in the tracker doc.
2. A path the user passed as an argument.
3. A spec file under `docs/`, `specs/`, or `.scratch/` matching the branch name or feature.
4. If nothing is found, ask the user where the spec is. If they say there isn't one, the **Spec** sub-agent will skip and report "no spec available".
### 3. Identify the standards sources
Search the repo for every file that documents how code should be written. When `CODING_STANDARDS.md` or `CONTRIBUTING.md` exists, it must be on the list.
On top of whatever the repo documents, the Standards axis always carries the **smell baseline** below: a fixed set of Fowler code smells (_Refactoring_, ch.3) that applies even when a repo documents nothing. Two rules bind it:
- **The repo overrides.** A documented repo standard always wins; where it endorses something the baseline would flag, suppress the smell.
- **Always a judgement call.** Each smell is a labelled heuristic ("possible Feature Envy"), never a hard violation. Like any standard here, skip anything tooling already enforces.
Each smell reads *what it is* → *how to fix*; match it against the diff:
- **Mysterious Name**: a function, variable, or type whose name doesn't reveal what it does or holds. → rename it; if no honest name comes, the design's murky.
- **Duplicated Code**: the same logic shape appears in more than one hunk or file in the change. → extract the shared shape, call it from both.
- **Feature Envy**: a method that reaches into another object's data more than its own. → move the method onto the data it envies.
- **Data Clumps**: the same few fields or params keep travelling together (a type wanting to be born). → bundle them into one type, pass that.
- **Primitive Obsession**: a primitive or string standing in for a domain concept that deserves its own type. → give the concept its own small type.
- **Repeated Switches**: the same `switch`/`if`-cascade on the same type recurs across the change. → replace with polymorphism, or one map both sites share.
- **Shotgun Surgery**: one logical change forces scattered edits across many files in the diff. → gather what changes together into one module.
- **Divergent Change**: one file or module is edited for several unrelated reasons. → split so each module changes for one reason.
- **Speculative Generality**: abstraction, parameters, or hooks added for needs the spec doesn't have. → delete it; inline back until a real need shows.
- **Message Chains**: long `a.b().c().d()` navigation the caller shouldn't depend on. → hide the walk behind one method on the first object.
- **Middle Man**: a class or function that mostly just delegates onward. → cut it, call the real target direct.
- **Refused Bequest**: a subclass or implementer that ignores or overrides most of what it inherits. → drop the inheritance, use composition.
### 4. Spawn both sub-agents in parallel
Issue both sub-agent calls together, in the foreground, and aggregate the reports they return.
**Standards sub-agent prompt** should include:
- The full diff command and commit list.
- The list of standards-source files you found in step 3, **plus the smell baseline from step 3** pasted in full (the sub-agent has no other access to it).
- The brief: "Report, per file/hunk where relevant, (a) every place the diff violates a documented standard: cite the standard (file + the rule); and (b) any baseline smell you spot: name it and quote the hunk. Distinguish hard violations from judgement calls: documented-standard breaches can be hard, but baseline smells are always judgement calls, and a documented repo standard overrides the baseline. Skip anything tooling enforces. Under 400 words."
**Spec sub-agent prompt** should include:
- The diff command and commit list.
- The path or fetched contents of the spec.
- The brief: "Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words."
If the spec is missing, skip the Spec sub-agent and note this in the final report.
### 5. Aggregate
Present the two reports under `## Standards` and `## Spec` headings, verbatim or lightly cleaned. Do **not** merge or rerank findings, because the two axes are deliberately separate (see _Why two axes_).
End with a one-line summary: total findings per axis, and the worst issue _within each axis_ (if any). Don't pick a single winner across axes: that's the reranking the separation exists to prevent.
## Why two axes
A change can pass one axis and fail the other:
- Code that follows every standard but implements the wrong thing → **Standards pass, Spec fail.**
- Code that does exactly what the issue asked but breaks the project's conventions → **Spec pass, Standards fail.**
Reporting them separately stops one axis from masking the other.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Code Review"
short_description: "Review a diff on standards and spec"

View file

@ -1,37 +0,0 @@
# Deepening
How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**.
## Dependency categories
When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam.
### 1. In-process
Pure computation, in-memory state, no I/O. Always deepenable: merge the modules and test through the new interface directly. No adapter needed.
### 2. Local-substitutable
Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface.
### 3. Remote but owned (Ports & Adapters)
Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter.
Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."*
### 4. True external (Mock)
Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter.
## Seam discipline
- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection.
- **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them.
## Testing strategy: replace, don't layer
- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist; delete them.
- Write new tests at the deepened module's interface. The **interface is the test surface**.
- Tests assert on observable outcomes through the interface, not internal state.
- Tests should survive internal refactors, since they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface.

View file

@ -1,44 +0,0 @@
# Design It Twice
When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout): your first idea is unlikely to be the best.
Uses the vocabulary in [SKILL.md](SKILL.md): **module**, **interface**, **seam**, **adapter**, **leverage**.
## Process
### 1. Frame the problem space
Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate:
- The constraints any new interface would need to satisfy
- The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md))
- A rough illustrative code sketch to ground the constraints, not a proposal, just a way to make the constraints concrete
Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel.
### 2. Spawn sub-agents
Spawn 3+ sub-agents in parallel. Each must produce a **radically different** interface for the deepened module.
Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint:
- Agent 1: "Minimize the interface: aim for 1–3 entry points max. Maximise leverage per entry point."
- Agent 2: "Maximise flexibility: support many use cases and extension."
- Agent 3: "Optimise for the most common caller: make the default case trivial."
- Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies."
Include both [SKILL.md](SKILL.md) vocabulary and GLOSSARY.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language.
Each sub-agent outputs:
1. Interface (types, methods, params, plus invariants, ordering, error modes)
2. Usage example showing how callers use it
3. What the implementation hides behind the seam
4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md))
5. Trade-offs: where leverage is high, where it's thin
### 3. Present and compare
Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**.
After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated: the user wants a strong read, not a menu.

View file

@ -1,114 +0,0 @@
---
name: codebase-design
description: Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary.
---
# Codebase Design
Design **deep modules**: a lot of behaviour behind a small interface, placed at a clean seam, testable through that interface. Use this language and these principles wherever code is being designed or restructured. The aim is leverage for callers, locality for maintainers, and testability for everyone.
## Glossary
Use these terms exactly: don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point.
**Module**: anything with an interface and an implementation. Deliberately scale-agnostic: a function, class, package, or tier-spanning slice. _Avoid_: unit, component, service.
**Interface**: everything a caller must know to use the module correctly: the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics. _Avoid_: API, signature (too narrow, they refer only to the type-level surface).
**Implementation**: what's inside a module, its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise.
**Depth**: leverage at the interface. The amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface, **shallow** when the interface is nearly as complex as the implementation.
**Seam** _(Michael Feathers)_: a place where you can alter behaviour without editing in that place; the *location* at which a module's interface lives. Where to put the seam is its own design decision, distinct from what goes behind it. _Avoid_: boundary (overloaded with DDD's bounded context).
**Adapter**: a concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside).
**Leverage**: what callers get from depth. More capability per unit of interface they learn. One implementation pays back across N call sites and M tests.
**Locality**: what maintainers get from depth. Change, bugs, knowledge, and verification concentrate in one place rather than spreading across callers. Fix once, fixed everywhere.
## Deep vs shallow
**Deep module** = small interface + lots of implementation:
```
┌─────────────────────┐
│ Small Interface │ ← Few methods, simple params
├─────────────────────┤
│ │
│ Deep Implementation│ ← Complex logic hidden
│ │
└─────────────────────┘
```
**Shallow module** = large interface + little implementation (avoid):
```
┌─────────────────────────────────┐
│ Large Interface │ ← Many methods, complex params
├─────────────────────────────────┤
│ Thin Implementation │ ← Just passes through
└─────────────────────────────────┘
```
When designing an interface, ask:
- Can I reduce the number of methods?
- Can I simplify the parameters?
- Can I hide more complexity inside?
## Principles
- **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts; they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface.
- **The deletion test.** Imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep.
- **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape.
- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it.
## Designing for testability
Good interfaces make testing natural:
1. **Accept dependencies, don't create them.**
```typescript
// Testable
function processOrder(order, paymentGateway) {}
// Hard to test
function processOrder(order) {
const gateway = new StripeGateway();
}
```
2. **Return results, don't produce side effects.**
```typescript
// Testable
function calculateDiscount(cart): Discount {}
// Hard to test
function applyDiscount(cart): void {
cart.total -= discount;
}
```
3. **Small surface area.** Fewer methods = fewer tests needed. Fewer params = simpler test setup.
## Relationships
- A **Module** has exactly one **Interface** (the surface it presents to callers and tests).
- **Depth** is a property of a **Module**, measured against its **Interface**.
- A **Seam** is where a **Module**'s **Interface** lives.
- An **Adapter** sits at a **Seam** and satisfies the **Interface**.
- **Depth** produces **Leverage** for callers and **Locality** for maintainers.
## Rejected framings
- **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead.
- **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow: interface here includes every fact a caller must know.
- **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**.
## Going deeper
- **Deepening a cluster given its dependencies**, see [DEEPENING.md](DEEPENING.md): dependency categories, seam discipline, and replace-don't-layer testing.
- **Exploring alternative interfaces**, see [DESIGN-IT-TWICE.md](DESIGN-IT-TWICE.md): spin up parallel sub-agents to design the interface several radically different ways, then compare on depth, locality, and seam placement.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Codebase Design"
short_description: "Vocabulary for deep-module design"

View file

@ -1,138 +0,0 @@
---
name: diagnosing-bugs
description: Diagnosis loop for hard bugs and performance regressions. Use when the user says "diagnose"/"debug this", or reports something broken/throwing/failing/slow.
---
# Diagnosing Bugs
A discipline for hard bugs. Skip phases only when explicitly justified.
When exploring the codebase, read `GLOSSARY.md` (if it exists) to get a clear mental model of the relevant modules, and check ADRs in the area you're touching.
## Redact
This skill has you show commands, outputs and captured artifacts. **Redact every secret first**: write `<REDACTED>` in its place. Build loops against env vars, so the credential stays in the environment rather than in what you show. Captured artifacts carry auth headers: quote only the lines that carry the signal.
If the redacted output is not enough to diagnose the bug, say so and ask the user.
## Phase 1: Build a feedback loop
**This is the skill.** Everything else is mechanical. If you have a **tight** pass/fail signal for the bug (one that goes red on _this_ bug), you will find the cause; bisection, hypothesis-testing, and instrumentation all just consume it. If you don't have one, no amount of staring at code will save you.
Spend disproportionate effort here. **Be aggressive. Be creative. Refuse to give up.**
### Ways to construct one, in roughly this order
1. **Failing test** at whatever seam reaches the bug: unit, integration, e2e.
2. **Curl / HTTP script** against a running dev server.
3. **CLI invocation** with a fixture input, diffing stdout against a known-good snapshot.
4. **Headless browser script** (Playwright / Puppeteer) that drives the UI and asserts on DOM/console/network.
5. **Replay a captured trace.** Save a real network request / payload / event log to disk; replay it through the code path in isolation.
6. **Throwaway harness.** Spin up a minimal subset of the system (one service, mocked deps) that exercises the bug code path with a single function call.
7. **Property / fuzz loop.** If the bug is "sometimes wrong output", run 1000 random inputs and look for the failure mode.
8. **Bisection harness.** If the bug appeared between two known states (commit, dataset, version), automate "boot at state X, check, repeat" so you can `git bisect run` it.
9. **Differential loop.** Run the same input through old-version vs new-version (or two configs) and diff outputs.
10. **HITL bash script.** Last resort. If a human must click, drive _them_ with `scripts/hitl-loop.template.sh` so the loop is still structured. Captured output feeds back to you.
Build the right feedback loop, and the bug is 90% fixed.
### Tighten the loop
Treat the loop as a product. Once you have _a_ loop, **tighten** it:
- Can I make it faster? (Cache setup, skip unrelated init, narrow the test scope.)
- Can I make the signal sharper? (Assert on the specific symptom, not "didn't crash".)
- Can I make it more deterministic? (Pin time, seed RNG, isolate filesystem, freeze network.)
A 30-second flaky loop is barely better than no loop; a 2-second deterministic one is tight, a debugging superpower.
### Non-deterministic bugs
The goal is not a clean repro but a **higher reproduction rate**. Loop the trigger 100×, parallelise, add stress, narrow timing windows, inject sleeps. A 50%-flake bug is debuggable; 1% is not, so keep raising the rate until it's debuggable.
### When you genuinely cannot build a loop
Stop and say so explicitly. List what you tried. Ask the user for: (a) access to whatever environment reproduces it, (b) a redacted captured artifact (HAR file, log dump, core dump, screen recording with timestamps), or (c) permission to add temporary production instrumentation. Do **not** proceed to hypothesise without a loop.
### Completion criterion: a tight loop that goes red
Phase 1 is done when the loop is **tight** and **red-capable**: you can name **one command** (a script path, a test invocation, a curl) that you have **already run at least once** (show the invocation and its output, redacted), and that is:
- [ ] **Red-capable**: it drives the actual bug code path and asserts the **user's exact symptom**, so it can go red on this bug and green once fixed. Not "runs without erroring"; it must be able to _catch this specific bug_.
- [ ] **Deterministic**: same verdict every run (flaky bugs: a pinned, high reproduction rate, per above).
- [ ] **Fast**: seconds, not minutes.
- [ ] **Agent-runnable**: you can run it unattended; a human in the loop only via `scripts/hitl-loop.template.sh`.
If you catch yourself reading code to build a theory before this command exists, **stop: jumping straight to a hypothesis is the exact failure this skill prevents.** No red-capable command, no Phase 2.
## Phase 2: Reproduce + minimise
Run the loop. Watch it go red as the bug appears.
Confirm:
- [ ] The loop produces the failure mode the **user** described, not a different failure that happens to be nearby. Wrong bug = wrong fix.
- [ ] The failure is reproducible across multiple runs (or, for non-deterministic bugs, reproducible at a high enough rate to debug against).
- [ ] You have captured the exact symptom (error message, wrong output, slow timing) so later phases can verify the fix actually addresses it.
### Minimise
Once it's red, shrink the repro to the **smallest scenario that still goes red**. Cut inputs, callers, config, data, and steps **one at a time**, re-running the loop after each cut, and keep only what's load-bearing for the failure.
Why bother: a minimal repro shrinks the hypothesis space in Phase 3 (fewer moving parts left to suspect) and becomes the clean regression test in Phase 5.
Done when **every remaining element is load-bearing**: removing any one of them makes the loop go green.
Do not proceed until you have reproduced **and** minimised.
## Phase 3: Hypothesise
Generate **3–5 ranked hypotheses** before testing any of them. Single-hypothesis generation anchors on the first plausible idea.
Each hypothesis must be **falsifiable**: state the prediction it makes.
> Format: "If <X> is the cause, then <changing Y> will make the bug disappear / <changing Z> will make it worse."
If you cannot state the prediction, the hypothesis is a vibe: discard or sharpen it.
**Show the ranked list to the user before testing.** They often have domain knowledge that re-ranks instantly ("we just deployed a change to #3"), or know hypotheses they've already ruled out. Cheap checkpoint, big time saver. Don't block on it; proceed with your ranking if the user is AFK.
## Phase 4: Instrument
Each probe must map to a specific prediction from Phase 3. **Change one variable at a time.**
Tool preference:
1. **Debugger / REPL inspection** if the env supports it. One breakpoint beats ten logs.
2. **Targeted logs** at the boundaries that distinguish hypotheses.
3. Never "log everything and grep".
**Tag every debug log** with a unique prefix, e.g. `[DEBUG-a4f2]`. Cleanup at the end becomes a single grep. Untagged logs survive; tagged logs die.
**Perf branch.** For performance regressions, logs are usually wrong. Instead: establish a baseline measurement (timing harness, `performance.now()`, profiler, query plan), then bisect. Measure first, fix second.
## Phase 5: Fix + regression test
Write the regression test **before the fix**, but only if there is a **correct seam** for it.
A correct seam is one where the test exercises the **real bug pattern** as it occurs at the call site. If the only available seam is too shallow (single-caller test when the bug needs multiple callers, unit test that can't replicate the chain that triggered the bug), a regression test there gives false confidence.
**If no correct seam exists, that itself is the finding.** Note it. The codebase architecture is preventing the bug from being locked down. Flag this for the next phase.
If a correct seam exists:
1. Turn the minimised repro into a failing test at that seam.
2. Watch it fail. If you forced the red by mutating code or a fixture, `diff` against a pristine copy to prove the mutation landed before you trust it.
3. Apply the fix.
4. Watch it pass.
5. Re-run the Phase 1 feedback loop against the original (un-minimised) scenario.
## Phase 6: Cleanup
Required before declaring done:
- [ ] Original repro no longer reproduces (re-run the Phase 1 loop)
- [ ] Regression test passes (or absence of seam is documented)
- [ ] All `[DEBUG-...]` instrumentation removed (`grep` the prefix)
- [ ] Throwaway prototypes deleted (or moved to a clearly-marked debug location)
- [ ] The hypothesis that turned out correct is stated in the commit / PR message, so the next debugger learns

View file

@ -1,3 +0,0 @@
interface:
display_name: "Diagnosing Bugs"
short_description: "Diagnose hard bugs and regressions"

View file

@ -1,44 +0,0 @@
#!/usr/bin/env bash
# Human-in-the-loop reproduction loop.
# Copy this file, edit the steps below, and run it.
# The agent runs the script; the user follows prompts in their terminal.
#
# Usage:
# bash hitl-loop.template.sh
#
# Two helpers:
# step "<instruction>" → show instruction, wait for Enter
# capture VAR "<question>" → show question, read response into VAR
#
# At the end, captured values are printed as KEY=VALUE for the agent to parse.
#
# `capture` prints its value back to the terminal, where the agent reads it,
# so capture observations, and leave signing in to the user as a `step`.
set -euo pipefail
step() {
printf '\n>>> %s\n' "$1"
read -r -p " [Enter when done] " _
}
capture() {
local var="$1" question="$2" answer
printf '\n>>> %s\n' "$question"
read -r -p " > " answer
printf -v "$var" '%s' "$answer"
}
# --- edit below ---------------------------------------------------------
step "Open the app at http://localhost:3000 and sign in."
capture ERRORED "Click the 'Export' button. Did it throw an error? (y/n)"
capture ERROR_MSG "Paste the error message (or 'none'):"
# --- edit above ---------------------------------------------------------
printf '\n--- Captured ---\n'
printf 'ERRORED=%s\n' "$ERRORED"
printf 'ERROR_MSG=%s\n' "$ERROR_MSG"

View file

@ -1,47 +0,0 @@
# ADR Format
ADRs live in `docs/adr/` and use sequential numbering: `0001-slug.md`, `0002-slug.md`, etc.
Create the `docs/adr/` directory lazily: only when the first ADR is needed.
## Template
```md
# {Short title of the decision}
{1-3 sentences: what's the context, what did we decide, and why.}
```
That's it. An ADR can be a single paragraph. The value is in recording *that* a decision was made and *why*, not in filling out sections.
## Optional sections
Only include these when they add genuine value. Most ADRs won't need them.
- **Status** frontmatter (`proposed | accepted | deprecated | superseded by ADR-NNNN`): useful when decisions are revisited
- **Considered Options**: only when the rejected alternatives are worth remembering
- **Consequences**: only when non-obvious downstream effects need to be called out
## Numbering
Scan `docs/adr/` for the highest existing number and increment by one.
## When to offer an ADR
All three of these must be true:
1. **Hard to reverse**: the cost of changing your mind later is meaningful
2. **Surprising without context**: a future reader will look at the code and wonder "why on earth did they do it this way?"
3. **The result of a real trade-off**: there were genuine alternatives and you picked one for specific reasons
If a decision is easy to reverse, skip it: you'll just reverse it. If it's not surprising, nobody will wonder why. If there was no real alternative, there's nothing to record beyond "we did the obvious thing."
### What qualifies
- **Architectural shape.** "We're using a monorepo." "The write model is event-sourced, the read model is projected into Postgres."
- **Integration patterns between contexts.** "Ordering and Billing communicate via domain events, not synchronous HTTP."
- **Technology choices that carry lock-in.** Database, message bus, auth provider, deployment target. Not every library: just the ones that would take a quarter to swap out.
- **Boundary and scope decisions.** "Customer data is owned by the Customer context; other contexts reference it by ID only." The explicit no-s are as valuable as the yes-s.
- **Deliberate deviations from the obvious path.** "We're using manual SQL instead of an ORM because X." Anything where a reasonable reader would assume the opposite. These stop the next engineer from "fixing" something that was deliberate.
- **Constraints not visible in the code.** "We can't use AWS because of compliance requirements." "Response times must be under 200ms because of the partner API contract."
- **Rejected alternatives when the rejection is non-obvious.** If you considered GraphQL and picked REST for subtle reasons, record it; otherwise someone will suggest GraphQL again in six months.

View file

@ -1,60 +0,0 @@
# GLOSSARY.md Format
## Structure
```md
# {Context Name}
{One or two sentence description of what this context is and why it exists.}
## Language
**Order**:
{A one or two sentence description of the term}
_Avoid_: Purchase, transaction
**Invoice**:
A request for payment sent to a customer after delivery.
_Avoid_: Bill, payment request
**Customer**:
A person or organization that places orders.
_Avoid_: Client, buyer, account
```
## Rules
- **Be opinionated.** When multiple words exist for the same concept, pick the best one and list the others under `_Avoid_`.
- **Keep definitions tight.** One or two sentences max. Define what it IS, not what it does.
- **Only include terms specific to this project's context.** General programming concepts (timeouts, error types, utility patterns) don't belong even if the project uses them extensively. Before adding a term, ask: is this a concept unique to this context, or a general programming concept? Only the former belongs.
- **Group terms under subheadings** when natural clusters emerge. If all terms belong to a single cohesive area, a flat list is fine.
## Single vs multi-context repos
**Single context (most repos):** One `GLOSSARY.md` at the repo root.
**Multiple contexts:** A `GLOSSARY-MAP.md` at the repo root lists the contexts, where they live, and how they relate to each other:
```md
# Glossary Map
## Contexts
- [Ordering](./src/ordering/GLOSSARY.md): receives and tracks customer orders
- [Billing](./src/billing/GLOSSARY.md): generates invoices and processes payments
- [Fulfillment](./src/fulfillment/GLOSSARY.md): manages warehouse picking and shipping
## Relationships
- **Ordering → Fulfillment**: Ordering emits `OrderPlaced` events; Fulfillment consumes them to start picking
- **Fulfillment → Billing**: Fulfillment emits `ShipmentDispatched` events; Billing consumes them to generate invoices
- **Ordering ↔ Billing**: Shared types for `CustomerId` and `Money`
```
The skill infers which structure applies:
- If `GLOSSARY-MAP.md` exists, read it to find contexts
- If only a root `GLOSSARY.md` exists, single context
- If neither exists, create a root `GLOSSARY.md` lazily when the first term is resolved
When multiple contexts exist, infer which one the current topic relates to. If unclear, ask.

View file

@ -1,74 +0,0 @@
---
name: domain-modeling
description: Build and sharpen a project's domain model. Use when discussing codebase terminology, writing or editing a GLOSSARY.md, or recording or editing an ADR.
---
# Domain Modeling
Actively build and sharpen the project's domain model as you design. This is the *active* discipline: challenging terms, inventing edge-case scenarios, and writing the glossary and decisions down the moment they crystallise. (Merely *reading* `GLOSSARY.md` for vocabulary is not this skill: that's a one-line habit any skill can do. This skill is for when you're changing the model, not just consuming it.)
## File structure
Most repos have a single context:
```
/
├── GLOSSARY.md
├── docs/
│ └── adr/
│ ├── 0001-event-sourced-orders.md
│ └── 0002-postgres-for-write-model.md
└── src/
```
If a `GLOSSARY-MAP.md` exists at the root, the repo has multiple contexts. The map points to where each one lives:
```
/
├── GLOSSARY-MAP.md
├── docs/
│ └── adr/ ← system-wide decisions
├── src/
│ ├── ordering/
│ │ ├── GLOSSARY.md
│ │ └── docs/adr/ ← context-specific decisions
│ └── billing/
│ ├── GLOSSARY.md
│ └── docs/adr/
```
Create files lazily: only when you have something to write. If no `GLOSSARY.md` exists, create one when the first term is resolved. If no `docs/adr/` exists, create it when the first ADR is needed.
## During the session
### Challenge against the glossary
When the user uses a term that conflicts with the existing language in `GLOSSARY.md`, call it out immediately. "Your glossary defines 'cancellation' as X, but you seem to mean Y. Which is it?"
### Sharpen fuzzy language
When the user uses vague or overloaded terms, propose a precise canonical term. "You're saying 'account': do you mean the Customer or the User? Those are different things."
### Discuss concrete scenarios
When domain relationships are being discussed, stress-test them with specific scenarios. Invent scenarios that probe edge cases and force the user to be precise about the boundaries between concepts.
### Cross-reference with code
When the user states how something works, check whether the code agrees. If you find a contradiction, surface it: "Your code cancels entire Orders, but you just said partial cancellation is possible. Which is right?"
### Update GLOSSARY.md inline
When a term is resolved, update `GLOSSARY.md` right there. Don't batch these up: capture them as they happen. Use the format in [GLOSSARY-FORMAT.md](./GLOSSARY-FORMAT.md).
`GLOSSARY.md` should be totally devoid of implementation details. Do not treat `GLOSSARY.md` as a spec, a scratch pad, or a repository for implementation decisions. It is a glossary and nothing else.
### Offer ADRs sparingly
Only offer to create an ADR when all three are true:
1. **Hard to reverse**: the cost of changing your mind later is meaningful
2. **Surprising without context**: a future reader will wonder "why did they do it this way?"
3. **The result of a real trade-off**: there were genuine alternatives and you picked one for specific reasons
If any of the three is missing, skip the ADR. Use the format in [ADR-FORMAT.md](./ADR-FORMAT.md).

View file

@ -1,3 +0,0 @@
interface:
display_name: "Domain Modeling"
short_description: "Build and sharpen a domain model"

View file

@ -1,7 +0,0 @@
---
name: grill-me
description: A relentless interview to sharpen a plan or design.
disable-model-invocation: true
---
Call the Skill tool with "grilling".

View file

@ -1,5 +0,0 @@
interface:
display_name: "Grill Me"
short_description: "Sharpen a plan through interview"
policy:
allow_implicit_invocation: false

View file

@ -1,7 +0,0 @@
---
name: grill-with-docs
description: A relentless interview to sharpen a plan or design, which also creates docs (ADR's and glossary) as we go.
disable-model-invocation: true
---
Call the Skill tool twice, for "grilling" and "domain-modeling".

View file

@ -1,5 +0,0 @@
interface:
display_name: "Grill with Docs"
short_description: "Grill a design and write its docs"
policy:
allow_implicit_invocation: false

View file

@ -1,30 +0,0 @@
---
name: grilling
description: Grill the user relentlessly about a plan, decision, or idea. Use when the user wants to stress-test their thinking, or uses any 'grill' trigger phrases.
---
Interview the user relentlessly until you reach a shared understanding. Map this as a **design tree**: every decision branches into the decisions that hang off it.
Work the tree in **rounds**. The **frontier** is every decision whose prerequisites are already settled: the questions you can ask _now_ without guessing at answers you haven't heard yet. Ask the whole frontier in one round: number each question and give your recommended answer. Then wait for the user's answers before the next round.
Format a round like so:
```
❓ **Q1** - **<question title>**: <question body, might be multiple paragraphs, including multiple choices>
➡️ <your recommended answer>
---
❓ **Q2** - **<question title>**: <question body, might be multiple paragraphs, including multiple choices>
➡️ <your recommended answer>
```
Word each question so "yes" accepts your recommended answer.
Each round the user answers reshapes the tree: settled decisions push the frontier outward and unblock questions that depended on them. Recompute the frontier and ask the next round. A question whose answer depends on another question still open in this round belongs to a _later_ round, not this one.
Finding _facts_ is your job, never the user's. When a frontier question needs a fact from the environment (filesystem, tools, etc.), dispatch a sub-agent to find it; don't ask the user for anything you could look up yourself. Don't block on it: a running exploration is an unsettled prerequisite, so only the questions downstream of it wait for the sub-agent to report; ask the rest of the frontier now. The _decisions_ are the user's: put each to them and wait.
The session is done when the frontier is empty: every branch of the design tree visited, nothing left silently assumed. Do not act on it until the user confirms you have reached a shared understanding.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Grilling"
short_description: "Stress-test thinking a round of questions at a time"

View file

@ -1,16 +0,0 @@
---
name: handoff
description: Compact the current conversation into a handoff document for another agent to pick up.
argument-hint: "What will the next session be used for?"
disable-model-invocation: true
---
Write a handoff document summarising the current conversation so a fresh agent can continue the work. Save to the temporary directory of the user's OS (`$TMPDIR`, else `/tmp`; `%TEMP%` on Windows) - not the current workspace.
Include a "suggested skills" section in the document, naming which skills the next agent should call the Skill tool for.
Do not duplicate content already captured in other artifacts (specs, plans, ADRs, issues, commits, diffs). Reference them by path or URL instead.
Redact any sensitive information, such as API keys, passwords, or personally identifiable information.
If the user passed arguments, treat them as a description of what the next session will focus on and tailor the doc accordingly.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Handoff"
short_description: "Compact a conversation into a handoff"
policy:
allow_implicit_invocation: false

View file

@ -1,40 +0,0 @@
---
name: implement-spec
description: "Implement the result of /to-spec and /to-tickets in code."
disable-model-invocation: true
---
You have been provided a spec. This spec should have tickets associated with it, describing how to implement the spec.
The issue tracker should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
The goal is the entire spec implemented on a single **integration branch**, with every ticket resolved the way the issue tracker closes work.
The tickets are not a list of steps. They are a **task graph** with blocking relationships between them. This means there is always a **frontier** of tickets which are ready to be grabbed.
Communication to and from subagents should be sparse. Communicate primarily through **context pointers**: to the spec, tickets, research notes, and previous commits. Don't duplicate information already available via pointers.
**Implementer subagents** should be run in the background where possible for maximum concurrency.
## Steps
1. Read the spec and tickets to understand the task graph.
2. (optional) Use an **exploration subagent** to conduct any exploration required by the tickets - relevant codebase files or external documentation. Ensure the exploration subagent can save files - it should save its markdown notes in a directory outside the repo, accessible by all future subagents. This lets **implementer subagents** focus on implementation rather than exploration.
3. Create the integration branch. If the issue tracker closes work through PRs, or the user asks for one, open a draft PR after the first merge in step 5 (a branch with no commits ahead of main can't open one), marked as closing the spec and tickets.
4. Use **implementer subagents** to implement each ticket, each in its own worktree on its own branch. Each implementer subagent:
- confirms its worktree is based on the integration branch before starting, and resets onto it if not;
- calls the Skill tool with `tdd` to build the ticket;
- merges the integration branch tip into its own branch before reporting done
5. Once an **implementer subagent** completes, merge its work to the integration branch with a **merger subagent**.
6. If this changes the **frontier** of available tickets, kick off more **implementer subagents** to work on the new tickets. This allows for maximum concurrency.
7. Once all tickets are complete, call the Skill tool with `code-review` on the integration branch. Fix all issues raised by the code review in a single **implementer subagent**.
8. If a draft PR exists, mark it ready for review. Otherwise, resolve each ticket the way the issue tracker closes work, and report the integration branch.
9. Clean up all **implementer subagent** worktrees.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Implement Spec"
short_description: "Implement the result of /to-spec and /to-tickets in code."
policy:
allow_implicit_invocation: false

View file

@ -1,17 +0,0 @@
---
name: implement
description: "Implement a piece of work based on a spec or set of tickets."
disable-model-invocation: true
---
Implement the work described by the user in the spec or tickets.
If the user passes a ticket reference, fetch it from the issue tracker and state its title before starting. If the reference is ambiguous, ask.
Call the Skill tool with "tdd" where possible, at pre-agreed seams.
Run typechecking regularly, single test files regularly, and the full test suite once at the end.
Once done, call the Skill tool with "code-review" to review the work.
Commit your work to the current branch.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Implement"
short_description: "Build work from a spec or tickets"
policy:
allow_implicit_invocation: false

View file

@ -1,123 +0,0 @@
# HTML Report Format
The architectural review is rendered as a single self-contained HTML file in the OS temp directory. Tailwind and Mermaid both come from CDNs. Mermaid handles graph-shaped diagrams reliably; hand-built divs and inline SVG handle the more editorial visuals (mass diagrams, cross-sections). Mix the two: don't lean on Mermaid for everything, it'll start to look generic.
## Scaffold
```html
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<title>Architecture review for {{repo name}}</title>
<script src="https://cdn.tailwindcss.com"></script>
<script type="module">
import mermaid from "https://cdn.jsdelivr.net/npm/mermaid@11/dist/mermaid.esm.min.mjs";
mermaid.initialize({ startOnLoad: true, theme: "neutral", securityLevel: "loose" });
</script>
<style>
/* small custom layer for things Tailwind doesn't cover cleanly:
dashed seam lines, hand-drawn-feeling arrow heads, etc. */
.seam { stroke-dasharray: 4 4; }
.leak { stroke: #dc2626; }
.deep { background: linear-gradient(135deg, #0f172a, #1e293b); }
</style>
</head>
<body class="bg-stone-50 text-slate-900 font-sans">
<main class="max-w-5xl mx-auto px-6 py-12 space-y-12">
<header>...</header>
<section id="candidates" class="space-y-10">...</section>
<section id="top-recommendation">...</section>
</main>
</body>
</html>
```
## Header
Repo name, date, and a compact legend: solid box = module, dashed line = seam, red arrow = leakage, thick dark box = deep module. No introduction paragraph. Straight into the candidates.
## Candidate card
The diagrams carry the weight. Prose is sparse, plain, and uses the glossary terms (from the `/codebase-design` skill) without ceremony.
Each candidate is one `<article>`:
- **Title**: short, names the deepening (e.g. "Collapse the Order intake pipeline").
- **Badge row**: recommendation strength (`Strong` = emerald, `Worth exploring` = amber, `Speculative` = slate), plus a tag for the dependency category (`in-process`, `local-substitutable`, `ports & adapters`, `mock`).
- **Files**: monospaced list, `font-mono text-sm`.
- **Before / After diagram**: the centrepiece. Two columns, side by side. See patterns below.
- **Problem**: one sentence. What hurts.
- **Solution**: one sentence. What changes.
- **Wins**: bullets, ≤6 words each. e.g. "Tests hit one interface", "Pricing logic stops leaking", "Delete 4 shallow wrappers".
- **ADR callout** (if applicable): one line in an amber-tinted box.
No paragraphs of explanation. If the diagram needs a paragraph to be understood, redraw the diagram.
## Diagram patterns
Pick the pattern that fits the candidate. Mix them. Don't make every diagram look the same. Variety is part of the point.
### Mermaid graph (the workhorse for dependencies / call flow)
Use a Mermaid `flowchart` or `graph` when the point is "X calls Y calls Z, and look at the mess." Wrap it in a Tailwind-styled card so it doesn't feel parachuted in. Style with classDef to colour leakage edges red and the deep module dark. Sequence diagrams work well for "before: 6 round-trips; after: 1."
```html
<div class="rounded-lg border border-slate-200 bg-white p-4">
<pre class="mermaid">
flowchart LR
A[OrderHandler] --> B[OrderValidator]
B --> C[OrderRepo]
C -.leak.-> D[PricingClient]
classDef leak stroke:#dc2626,stroke-width:2px;
class C,D leak
</pre>
</div>
```
### Hand-built boxes-and-arrows (when Mermaid's layout fights you)
Modules as `<div>`s with borders and labels. Arrows as inline SVG `<line>` or `<path>` elements positioned absolutely over a relative container. Reach for this when you want the "after" diagram to feel like one thick-bordered deep module with greyed-out internals, since Mermaid won't render that with the right weight.
### Cross-section (good for layered shallowness)
Stack horizontal bands (`h-12 border-l-4`) to show layers a call passes through. Before: 6 thin layers each doing nothing. After: 1 thick band labelled with the consolidated responsibility.
### Mass diagram (good for "interface as wide as implementation")
Two rectangles per module: one for interface surface area, one for implementation. Before: interface rectangle is nearly as tall as the implementation rectangle (shallow). After: interface rectangle is short, implementation rectangle is tall (deep).
### Call-graph collapse
Before: a tree of function calls rendered as nested boxes. After: the same tree collapsed into one box, with the now-internal calls shown faded inside it.
## Style guidance
- Lean editorial, not corporate-dashboard. Generous whitespace. Serif optional for headings (`font-serif` works well with stone/slate).
- Colour sparingly: one accent (emerald or indigo) plus red for leakage and amber for warnings.
- Keep diagrams ~320px tall so before/after sits comfortably side by side without scrolling.
- Use `text-xs uppercase tracking-wider` for module labels inside diagrams, so they read as schematic, not as UI.
- The only scripts are the Tailwind CDN and the Mermaid ESM import. The report is otherwise static: no app code, no interactivity beyond Mermaid's own rendering.
## Top recommendation section
One larger card. Candidate name, one sentence on why, anchor link to its card. That's it.
## Tone
Plain English, concise, but the architectural nouns and verbs come straight from the `/codebase-design` skill. Concision is not an excuse to drift.
**Use exactly:** module, interface, implementation, depth, deep, shallow, seam, adapter, leverage, locality.
**Never substitute:** component, service, unit (for module) · API, signature (for interface) · boundary (for seam) · layer, wrapper (for module, when you mean module).
**Phrasings that fit the style:**
- "Order intake module is shallow: interface nearly matches the implementation."
- "Pricing leaks across the seam."
- "Deepen: one interface, one place to test."
- "Two adapters justify the seam: HTTP in prod, in-memory in tests."
**Wins bullets** name the gain in glossary terms: *"locality: bugs concentrate in one module"*, *"leverage: one interface, N call sites"*, *"interface shrinks; implementation absorbs the wrappers"*. Don't write *"easier to maintain"* or *"cleaner code"*, because those terms aren't in the glossary and don't earn their place.
No hedging, no throat-clearing, no "it's worth noting that…". If a sentence could be a bullet, make it a bullet. If a bullet could be cut, cut it. If a term isn't in the `/codebase-design` glossary, reach for one that is before inventing a new one.

View file

@ -1,71 +0,0 @@
---
name: improve-codebase-architecture
description: Scan a codebase for deepening opportunities, present them as a visual HTML report, then grill through whichever one you pick.
disable-model-invocation: true
---
# Improve Codebase Architecture
Surface architectural friction and propose **deepening opportunities**: refactors that turn shallow modules into deep ones. The aim is testability and AI-navigability.
This command is _informed_ by the project's domain model and built on a shared design vocabulary:
- Call the Skill tool with "codebase-design" for the architecture vocabulary (**module**, **interface**, **depth**, **seam**, **adapter**, **leverage**, **locality**) and its principles (the deletion test, "the interface is the test surface", "one adapter = hypothetical seam, two = real"). Use these terms exactly in every suggestion, and don't drift into "component," "service," "API," or "boundary."
- The domain language in `GLOSSARY.md` gives names to good seams; ADRs in `docs/adr/` record decisions this command should not re-litigate.
## Process
### 1. Explore
**Scope before you scan: YAGNI.** Deepening a module pays off by making future changes to it easier, so put extra weight on the parts of the codebase that have recently changed. Decide *where* to look before you look:
- If the user named a direction (a module, a subsystem, a pain point), take it, and skip the inference below.
- Otherwise, walk back a good stretch of the commit history (`git log --oneline`) to find the codebase's hot spots, the files and areas that keep coming up, and let those paths pull your attention first. If the changes are scattered with no clear hot spot, widen the net.
Read the project's domain glossary (`GLOSSARY.md`) and any ADRs in the area you're touching first.
Then spawn a sub-agent to walk the codebase. Don't follow rigid heuristics; explore organically and note where you experience friction:
- Where does understanding one concept require bouncing between many small modules?
- Where are modules **shallow**, with an interface nearly as complex as the implementation?
- Where have pure functions been extracted just for testability, but the real bugs hide in how they're called (no **locality**)?
- Where do tightly-coupled modules leak across their seams?
- Which parts of the codebase are untested, or hard to test through their current interface?
Apply the **deletion test** to anything you suspect is shallow: would deleting it concentrate complexity, or just move it? A "yes, concentrates" is the signal you want.
### 2. Present candidates as an HTML report
Write a self-contained HTML file to the OS temp directory so nothing lands in the repo. Resolve the temp dir from `$TMPDIR`, falling back to `/tmp` (or `%TEMP%` on Windows), and write to `<tmpdir>/architecture-review-<timestamp>.html` so each run gets a fresh file. Open it for the user (`xdg-open <path>` on Linux, `open <path>` on macOS, `start <path>` on Windows) and tell them the absolute path.
The report uses **Tailwind via CDN** for layout and styling, and **Mermaid via CDN** for diagrams where a graph/flow/sequence reliably communicates the structure. Mix Mermaid with hand-crafted CSS/SVG visuals: use Mermaid when relationships are graph-shaped (call graphs, dependencies, sequences), and hand-built divs/SVG when you want something more editorial (mass diagrams, cross-sections, collapse animations). Each candidate gets a **before/after visualisation**. Be visual.
For each candidate, render a card with:
- **Files**: which files/modules are involved
- **Problem**: why the current architecture is causing friction
- **Solution**: plain English description of what would change
- **Benefits**: explained in terms of locality and leverage, and how tests would improve
- **Before / After diagram**: side-by-side, custom-drawn, illustrating the shallowness and the deepening
- **Recommendation strength**: one of `Strong`, `Worth exploring`, `Speculative`, rendered as a badge
End the report with a **Top recommendation** section: which candidate you'd tackle first and why.
**Use GLOSSARY.md vocabulary for the domain, and the `/codebase-design` vocabulary for the architecture.** If `GLOSSARY.md` defines "Order," talk about "the Order intake module," not "the FooBarHandler," and not "the Order service."
**ADR conflicts**: if a candidate contradicts an existing ADR, only surface it when the friction is real enough to warrant revisiting the ADR. Mark it clearly in the card (e.g. a warning callout: _"contradicts ADR-0007, but worth reopening because…"_). Don't list every theoretical refactor an ADR forbids.
See [HTML-REPORT.md](HTML-REPORT.md) for the full HTML scaffold, diagram patterns, and styling guidance.
Do NOT propose interfaces yet. After the file is written, ask the user: "Which of these would you like to explore?"
### 3. Grilling loop
Once the user picks a candidate, call the Skill tool with "grilling" to walk the decision tree with them: constraints, dependencies, the shape of the deepened module, what sits behind the seam, what tests survive.
Side effects happen inline as decisions crystallize; call the Skill tool with "domain-modeling" to keep the domain model current as you go:
- **Naming a deepened module after a concept not in `GLOSSARY.md`?** Add the term to `GLOSSARY.md`. Create the file lazily if it doesn't exist.
- **Sharpening a fuzzy term during the conversation?** Update `GLOSSARY.md` right there.
- **User rejects the candidate with a load-bearing reason?** Offer an ADR, framed as: _"Want me to record this as an ADR so future architecture reviews don't re-suggest it?"_ Only offer when the reason would actually be needed by a future explorer to avoid re-suggesting the same thing; skip ephemeral reasons ("not worth it right now") and self-evident ones.
- **Want to explore alternative interfaces for the deepened module?** Call the Skill tool with "codebase-design" and use its design-it-twice parallel sub-agent pattern.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Improve Codebase Architecture"
short_description: "Find and grill architecture improvements"
policy:
allow_implicit_invocation: false

View file

@ -1,3 +0,0 @@
# Credits
The **Summary** section's menu of visuals (pseudocode, call trees, component trees, file trees, Mermaid, diffs) and its placement guidance come from [Dex Horthy](https://github.com/dexhorthy)'s [`show-me`](https://github.com/humanlayer/humanlayer) skill, reproduced almost word for word and aimed at a diff instead of a live conversation. `pr` does not depend on `show-me` as a skill (it isn't part of this repo, and a hard dependency would break standalone installs), so the content is copied in rather than pointed at; this file is the attribution a dependency would otherwise have carried.

View file

@ -1,170 +0,0 @@
---
name: pr
description: "Use when writing a PR body."
metadata:
credits:
skill: show-me
author: Dex Horthy
organisation: Humanlayer
url: "https://github.com/humanlayer/skills/blob/main/plugins/show-me/skills/show-me/SKILL.md"
---
Use this template for writing the PR body:
```markdown
## Summary
<diagram, diff-sketch, or tree>
## Evidence
- **Before:** <screenshot/output/failing test run>
**After:** <screenshot/output/passing test run>
## Merge Danger
**Door:** <one-way or two-way>
<optional: description>
**Blast Radius:** <one-word description>
<optional: potential ramifications of merge>
```
## Sections
Skip all preambles and keep prose brief. Use the user's domain language from `GLOSSARY.md`.
### Summary
Pick the smallest view that makes the key point clear.
- Show logic or an algorithm as pseudocode:
```text
on(save)
if content is unchanged
return cached result
write new content
return fresh result
```
- Show runtime control flow as a call tree:
```text
submitForm
createSession
persistPrompt
launchAgent
navigateToSession
```
- Show UI structure as a component tree, including state and module boundaries that matter:
```text
<SessionPage> (apps/example/src/routes/session.tsx)
useSessionEvents()
<SessionToolbar>
<RunSkillButton> (packages/ui)
```
- Show file responsibility or a broad refactor as a shallow file tree:
```text
src/
├── commands/ # parses user actions
├── sessions/ # owns session state
└── transport/ # sends API requests
```
- Show component interaction, control flow, or data flow with Mermaid:
```mermaid
sequenceDiagram
participant User
participant UI
participant Daemon
User->>UI: choose command
UI->>Daemon: send expanded prompt
Daemon-->>UI: stream result
```
- Use `diff` when the point is what changes and the surrounding shape already exists. Match the diff shape to the topic.
For a component change:
```diff
<SessionPage>
useSessionEvents()
<SessionToolbar>
+ <RunSkillButton />
<SessionTimeline>
+ <SkillResultCard />
```
For a file-layout change:
```diff
src/
├── commands/
+│ └── show-me.ts # expands the slash command
├── sessions/
-└── transport.ts
+└── transport/
+ ├── client.ts
+ └── stream.ts
```
For a call-tree or call-stack change:
```diff
submitForm
createSession
persistPrompt
+ expandSkillMention
launchAgent
- navigateToSession
+ navigateToSession
+ subscribeToEvents
```
For a state or control-flow change:
```diff
on(save)
- write content
+ if content is unchanged
+ return cached result
+ write new content
+ invalidate cache
```
- Show the whole block when most of it is new, when omitted context would hide ownership or order, or when the user needs a copyable target shape:
```ts
function expandSkill(command: string): string {
const skillName = command.slice(1);
return `use the ${skillName} skill`;
}
```
#### Guidance
Place each visual next to the short text it supports. Keep only the calls, files, props, states, and boundaries needed to answer the user's current question or the options to resolve the current discussion point.
You may use one of these, you may use several, it is unlikely you will use all of them. Use your judgement and don't overwhelm the user.
### Evidence
Concrete evidence that the change works. Show a before and after.
Screenshots are S-tier - when the environment is set up for it and the change is visual.
Execution-based evidence is A-tier. Test results, console output. Show the exact test that now fails and passes, using pseudocode.
### Merge Danger
Describe whether it's a one-way or two-way door. You can walk back through two-way doors, but not one-way doors. A PR that is cheap to roll back is lower risk. Changes that involve destructive actions or hard-to-reverse decisions are one-way doors.
The blast radius is the potential impact or scope of the changes introduced by this PR. Consider all possibilities. Examples are layout shift, breakages for consumers, mobile responsiveness, etc.

View file

@ -1,3 +0,0 @@
interface:
display_name: "PR"
short_description: "Write a PR body that's fast to review"

View file

@ -1,67 +0,0 @@
# Logic Prototype
A single, self-contained HTML file (a **shareable demo**) that lets anyone drive a state model by clicking buttons. Use this when the question is about **business logic, state transitions, or data shape**: the kind of thing that looks reasonable on paper but only feels wrong once you push it through real cases.
Because it's one file with nothing to install, you can hand it to a non-developer (a designer, a PM, a domain expert) and let them feel the model for themselves. So it speaks their language, not the code's.
## When this is the right shape
- "I'm not sure if this state machine handles the edge case where X then Y."
- "Does this data model actually let me represent the case where..."
- "I want to feel out what the API should look like before writing it."
- Anything where someone wants to **press buttons and watch state change**.
If the question is "what should this look like," this is the wrong branch. Use [UI.md](UI.md).
## Process
### 1. State the question
Before writing code, write down what state model and what question you're prototyping. One paragraph, at the top of the demo (in a visible intro, not just a comment). A logic prototype that answers the wrong question is pure waste, so make the question explicit so it can be checked later, whether the user is watching now or returning to it AFK.
### 2. Isolate the logic in a portable module
Put the actual logic (the bit that's answering the question) in a single `<script>` block written as a small, pure module that could be lifted out and dropped into the real codebase later. The page around it is throwaway; this module isn't.
The right shape depends on the question:
- **A pure reducer**: `(state, action) => state`. Good when actions are discrete events and state is a single value.
- **A state machine**: explicit states and transitions. Good when "which actions are even legal right now" is part of the question.
- **A small set of pure functions** over a plain data type. Good when there's no implicit current state, just transformations.
- **A class or module with a clear method surface** when the logic genuinely owns ongoing internal state.
Pick whichever shape best fits the question being asked, *not* whichever is easiest to wire to a page. Keep it pure: no DOM, no `document`, no button handlers reaching inside it. The page calls into it; nothing flows the other direction. This is what makes the prototype useful past its own lifetime: once the question's answered, the validated reducer / machine / function set lifts into the real module on its own.
### 3. Build the shareable HTML file
One file, plain HTML/CSS/JS: no framework, no bundler, no server, everything inline so it opens by double-click and survives being emailed around. Anyone should be able to run it by opening it.
Write it for a non-developer. Every label is in **domain language**, not code: buttons and state read like the business, not the reducer. Explain in plain words what's happening.
Lay it out with a clean hierarchy, top to bottom:
1. **Title and one-line explanation** of what this demo lets you explore (the question from step 1).
2. **Current state**: the full relevant state, rendered as a readable panel (labelled fields, not a raw JSON dump), re-rendered after every click so the change is visible. Where it helps a non-developer follow, call out what just changed.
3. **Free-play buttons**: one button per action, always available, so anyone can poke at the model in any order. Each click dispatches its action and re-renders the state.
4. **Guided walkthroughs**: a set of **scenarios**, one per tab. Each tab holds a short plain-language description of the scenario (the situation it sets up and what to watch for) and underneath it, the ordered **buttons to press** for that scenario. Each step is a real button: clicking it performs that action and moves to the next step. Starting a walkthrough resets to a known initial state so the scenario runs the same way every time.
Choose scenarios that demonstrate the awkward cases, the ones hard to reason about on paper: the happy path, a tricky edge case, an attempt at something that should be illegal.
Keep it beautiful but restrained: clean typography, generous spacing, one accent colour. No animations, no gimmicks: nothing that competes with the state and the buttons.
### 4. Hand it over
Send them the file, or open it for them. They'll click through the walkthroughs and free-play whenever they get to it; the interesting moments are when they say "wait, that shouldn't be possible" or "huh, I assumed X would be different"; those are the bugs in the _idea_, which is the whole point. If they want new actions or a new scenario, add them. Prototypes evolve.
### 5. Capture the answer and the prototype
Once the prototype has answered its question, capture the answer, then capture the prototype the way the [SKILL](SKILL.md) describes. The logic-specific mapping: the validated reducer / machine / function set lifts into the real module (the decision, absorbed); the HTML shell rides along to the throwaway branch that keeps the prototype as a primary source, and being one self-contained file, it stays trivially re-runnable there.
## Anti-patterns
- **Don't add tests.** A prototype that needs tests is no longer a prototype.
- **Don't wire it to the real database.** Use in-memory state unless the question is specifically about persistence.
- **Don't generalise.** No "what if we wanted to support X later." The prototype answers one question.
- **Don't blur the logic and the page together.** If the pure module references the DOM, `document`, or button handlers, it's no longer liftable. Keep the page as a thin shell over a pure module.
- **Don't reach for a framework, bundler, or server.** One file the recipient double-clicks; a React app or a dev server defeats "shareable".
- **Don't ship the HTML shell into production.** The page is optimised for being clicked through by hand. The logic module behind it is the bit worth keeping.

View file

@ -1,26 +0,0 @@
---
name: prototype
description: Build a throwaway prototype to answer a design question. Use when the user wants to sanity-check whether a state model or logic feels right, or explore what a UI should look like.
---
# Prototype
A prototype is **throwaway code that answers a question**. The question decides the shape.
## Pick a branch
Identify which question is being answered, using the user's prompt, the surrounding code, or by asking if the user is around:
- **"Does this logic / state model feel right?"** → [LOGIC.md](LOGIC.md). Build a single shareable HTML file (free-play buttons plus tabbed guided walkthroughs) that pushes the state machine through cases that are hard to reason about on paper, and that a non-developer can drive.
- **"What should this look like?"** → [UI.md](UI.md). Generate several radically different UI variations on a single route, switchable via a URL search param and a floating bottom bar.
The two branches produce very different artifacts, so getting this wrong wastes the whole prototype. If the question is genuinely ambiguous and the user isn't reachable, default to whichever branch better matches the surrounding code (a backend module → logic; a page or component → UI) and state the assumption at the top of the prototype.
## Rules that apply to both
1. **Throwaway from day one, and clearly marked as such.** Locate the prototype code close to where it will actually be used (next to the module or page it's prototyping for) so context is obvious, but name it so a casual reader can see it's a prototype, not production. For throwaway UI routes, obey whatever routing convention the project already uses; don't invent a new top-level structure.
2. **Trivial to run.** A UI prototype starts from one command in the project's task runner: `pnpm <name>`, `python <path>`, `bun <path>`, etc. A logic demo is a single HTML file the user double-clicks. Either way, no thinking required to start it.
3. **No persistence by default.** State lives in memory. Persistence is the thing the prototype is _checking_, not something it should depend on. If the question explicitly involves a database, hit a scratch DB or a local file with a clear "PROTOTYPE, wipe me" name.
4. **Skip the polish.** No tests, no error handling beyond what makes the prototype _runnable_, no abstractions. The point is to learn something fast.
5. **Surface the state.** After every action (logic) or on every variant switch (UI), print or render the full relevant state so the user can see what changed.
6. **Capture it when done.** Fold any validated decision into the real code, then capture the prototype itself as a **primary source**: commit it to a throwaway branch, out of main, and leave a context pointer to that branch on the implementation issue. Capture the answer too (the verdict and the question it settled) in the issue or a commit. The main branch keeps only the validated decision.

View file

@ -1,112 +0,0 @@
# UI Prototype
Generate **several radically different UI variations** on a single route, switchable from a floating bottom bar. The user flips between variants in the browser, picks one (or steals bits from each), then throws the rest away.
If the question is about logic/state rather than what something looks like, this is the wrong branch. Use [LOGIC.md](LOGIC.md).
## When this is the right shape
- "What should this page look like?"
- "I want to see a few options for this dashboard before committing."
- "Try a different layout for the settings screen."
- Any time the user would otherwise spend a day picking between three vague mockups in their head.
## Two sub-shapes: strongly prefer sub-shape A
A UI prototype is much easier to judge when it's **butting up against the rest of the app**: real header, real sidebar, real data, real density. A throwaway route on its own is a vacuum: every variant looks fine in isolation. Default to sub-shape A whenever there's a plausible existing page to host the variants. Only reach for sub-shape B if the prototype genuinely has no nearby home.
### Sub-shape A: adjustment to an existing page (preferred)
The route already exists. Variants are rendered **on the same route**, gated by a `?variant=` URL search param. The existing data fetching, params, and auth all stay. Only the rendering swaps. This is the default; pick it unless there's a specific reason not to.
If the prototype is for something that doesn't yet have a page but *would naturally live inside one* (a new section of the dashboard, a new card on the settings screen, a new step in an existing flow), it's still sub-shape A. Mount the variants inside the host page.
### Sub-shape B: a new page (last resort)
Only use this when the thing being prototyped genuinely has no existing page to live inside (e.g. an entirely new top-level surface, or a flow that can't be embedded anywhere sensible).
Create a **throwaway route** following whatever routing convention the project already uses. Don't invent a new top-level structure. Name it so it's obviously a prototype (e.g. include the word `prototype` in the path or filename). Same `?variant=` pattern.
Before committing to sub-shape B, sanity-check: is there really no existing page this could be embedded in? An empty route hides design problems that a populated one would expose.
In both sub-shapes the floating bottom bar is identical.
## Process
### 1. State the question and pick N
Default to **3 variants**. More than 5 stops being radically different and starts being noise, so cap there.
Write down the plan in one line, in the prototype's location or a top-of-file comment:
> "Three variants of the settings page, switchable via `?variant=`, on the existing `/settings` route."
This works whether the user is here to push back or not.
### 2. Generate radically different variants
Draft each variant. Hold each one to:
- The page's purpose and the data it has access to.
- The project's component library / styling system (TailwindCSS, shadcn, MUI, plain CSS, whatever).
- A clear exported component name, e.g. `VariantA`, `VariantB`, `VariantC`.
Variants must be **structurally different**: different layout, different information hierarchy, different primary affordance, not just different colours. Three slightly-tweaked card grids isn't a UI prototype, it's wallpaper. If two drafts come out too similar, redo one with explicit "do not use a card grid" guidance.
### 3. Wire them together
Create a single switcher component on the route:
```tsx
// pseudo-code, adapt to the project's framework
const variant = searchParams.get('variant') ?? 'A';
return (
<>
{variant === 'A' && <VariantA {...data} />}
{variant === 'B' && <VariantB {...data} />}
{variant === 'C' && <VariantC {...data} />}
<PrototypeSwitcher variants={['A','B','C']} current={variant} />
</>
);
```
For sub-shape A (existing page): keep all the existing data fetching above the switcher; only the rendered subtree changes per variant.
For sub-shape B (new page): the throwaway route under `/prototype/<name>` mounts the same switcher.
### 4. Build the floating switcher
A small fixed-position bar at the bottom-centre of the screen with three pieces:
- **Left arrow**: cycles to the previous variant (wraps around).
- **Variant label**: shows the current variant key and, if the variant exports a name, that name too. e.g. `B (Sidebar layout)`.
- **Right arrow**: cycles forward (wraps around).
Behaviour:
- Clicking an arrow updates the URL search param (use the framework's router, e.g. `router.replace` on Next, `navigate` on React Router, etc) so the variant is shareable and reload-stable.
- Keyboard: `←` and `→` arrow keys also cycle. Don't intercept arrow keys when an `<input>`, `<textarea>`, or `[contenteditable]` is focused.
- Visually distinct from the page (e.g. high-contrast pill, subtle shadow) so it's obviously not part of the design being evaluated.
- Hidden in production builds: gate on `process.env.NODE_ENV !== 'production'` or an equivalent check, so a stray prototype merge can't ship the bar to users.
Put the switcher in a single shared component so both sub-shapes can reuse it. Locate it wherever shared UI lives in the project.
### 5. Hand it over
Surface the URL (and the `?variant=` keys). The user will flip through whenever they get to it. The interesting feedback is usually **"I want the header from B with the sidebar from C"**, which is the actual design they want.
### 6. Capture the answer and clean up
Once a variant has won, capture the answer (which variant and why), then capture the prototype the way the [SKILL](SKILL.md) describes. Fold the winner into the real code and move the rest onto the throwaway branch, not into main:
- **Sub-shape A**: fold the winner into the existing page; drop the losing variants and the switcher from main.
- **Sub-shape B**: promote the winning variant to a real route; drop the throwaway route and the switcher from main.
The full set of variants is the primary source, so it lands on the throwaway branch, not the bin, since variant components and the switcher left in the main branch rot fast and confuse the next reader.
## Anti-patterns
- **Variants that differ only in colour or copy.** That's a tweak, not a prototype. Real variants disagree about structure.
- **Sharing too much code between variants.** A shared `<Header>` is fine; a shared `<Layout>` defeats the point. Each variant should be free to throw out the layout.
- **Wiring variants to real mutations.** Read-only prototypes are fine. If a variant needs to mutate, point it at a stub: the question is "what should this look like", not "does the backend work".
- **Promoting the prototype directly to production.** The variant code was written under prototype constraints (no tests, minimal error handling). Rewrite it properly when you fold it in.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Prototype"
short_description: "Prototype to answer a design question"

View file

@ -1,12 +0,0 @@
---
name: research
description: Investigate a question against high-trust primary sources and capture the findings as a Markdown file in the repo. Use when the user wants a topic researched, docs or API facts gathered, or reading legwork delegated to a background agent.
---
Spin up a **background agent** to do the research, so you keep working while it reads.
Its job:
1. Investigate the question against **primary sources** (official docs, source code, specs, first-party APIs), not a secondary write-up of them. Follow every claim back to the source that owns it.
2. Write the findings to a single Markdown file, citing each claim's source.
3. Save it where the repo already keeps such notes; match the existing convention, and if there is none, put it somewhere sensible and say where.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Research"
short_description: "Research from high-trust sources"

View file

@ -1,44 +0,0 @@
---
name: retro
description: "Conduct a retrospective on a coding session."
disable-model-invocation: true
---
The user has asked for a **retrospective**. You are suggesting improvements to the coding agent's **environment** to improve future runs.
## Steps
1. Call the Skill tool with `writing-for-agents` for the writing style guide.
2. Read the primary sources for the session the user specifies. This may mean searching through session logs on this machine. If the user doesn't specify a session, default to the current one.
3. Look for candidates for improvement in these categories.
- **Navigation**: how easy was it for the agent to find the right files? Are there hidden dependencies between files? Would a **navigation pointer** make it easier? _Use when_ the session took a long time to find a piece of information.
- **Automated checks**: are there automated checks that could catch errors the agent made? Linting, typing, tests, filesystem linters? Read the repo's own check command first (its `package.json`/build-tool `lint`/`check` scripts, its CI workflow), so a check that already exists but sits unwired or silently broken is the finding, not a reinvention. A repo with no **guardrail** (no pre-commit hook and no CI job running its lint/typecheck/test command) is itself a finding: an un-linted repo is a standing missed opportunity, not a neutral default. _Use when_ the agent made a mistake an automated check could have caught, or the repo has no guardrail at all.
- **Coding standards**: should the **reviewer agent** be given a new rule to enforce? Should an existing rule be removed or clarified? Classify the violation first: a **mechanical** one (a fixed syntactic pattern, a banned API, an import shape, a file-location rule) gets a deterministic check, full stop: a custom rule in the repo's own linter, a new pre-commit hook, or a new CI job, whichever the repo's language and existing guardrail make cheapest. Default to building the check over writing the rule. Reserve `CODING_STANDARDS.md` for genuine **judgement calls** (cross-file consistency, "matches the surrounding style," anything no guardrail could ever substitute for). _Use when_ the reviewer agent failed to catch a mistake.
- **Global AGENTS.md**: are there any steering instructions that should be moved to coding standards (or automated checks) instead? _Use when_ the AGENTS.md file is particularly large - in the repo OR the user's global scope.
- **Tool economy**: did the agent make expensive tool calls that could be streamlined? Is there any custom tooling (CLI's, MCP's) that is particularly token-inefficient? _Use when_ the agent made an expensive tool call.
- **No-ops**: look for instructions in steering files that don't modify the agent's behavior. _Use when_ the steering files are large and unwieldy.
- **Information access**: look for opportunities to increase the agent's access to information. Teeing dev server logs, readonly access to third-party services. _Use when_ a crucial piece of information was not available to the agent.
4. Present these candidates to the user, in order of severity.
## Reference
### Implementation vs Review
Remember that all work goes through two stages: implementation and review. The implementation agent has the most **context pressure**. They are responsible for exploration, writing code, and debugging failures.
The review agent has the least context pressure - it receives a diff, so no exploration needed. It often does not need to write code or debug.
This means that the review agent should be responsible for imposing coding standards, not the implementation agent.
### Files
You have access to several files in the repo:
- `CLAUDE.md`/`AGENTS.md`: these files are pushed to the context window of any agent working in this repo. They should be used incredibly sparingly, usually only for **navigation pointers** to other files.
- `CODING_STANDARDS.md`: this file is read during review, not implementation. Add **navigation pointers** to docs folders if the standards file gets more than 1,000 lines long.
- Docs: use docs as references files, pointed to by other files. Look for existing docs before writing new ones.
- Skills: use skills for docs (since their description goes into the agent's context window), or for user-invoked commands. Follow the advice in the `writing-for-agents` skill.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Retro"
short_description: "Conduct a retrospective on a coding session."
policy:
allow_implicit_invocation: false

View file

@ -1,120 +0,0 @@
---
name: setup-matt-pocock-skills
description: "Configure this repo for the engineering skills: set up its issue tracker, triage label vocabulary, and domain doc layout. Run once before first use of the other engineering skills."
disable-model-invocation: true
---
# Setup Matt Pocock's Skills
Scaffold the per-repo configuration that the engineering skills assume:
- **Issue tracker**: where issues live (GitHub by default; local markdown is also supported out of the box)
- **Triage labels**: the strings used for the five canonical triage roles
- **Domain docs**: where `GLOSSARY.md` and ADRs live, and the consumer rules for reading them
This is a prompt-driven skill, not a deterministic script. Explore, present what you found, confirm with the user, then write.
## Process
### 1. Explore
Look at the current repo to understand its starting state. Read whatever exists; don't assume:
- `git remote -v` and `.git/config`: is this a GitHub repo? Which one?
- `AGENTS.md` and `CLAUDE.md` at the repo root: does either exist? Is there already an `## Agent skills` section in either?
- `GLOSSARY.md` and `GLOSSARY-MAP.md` at the repo root, and the legacy `CONTEXT.md` / `CONTEXT-MAP.md`. If a legacy file exists, offer to `git mv` it to its `GLOSSARY` name and rewrite those names in `docs/agents/domain.md`.
- `docs/adr/` and any `src/*/docs/adr/` directories
- `docs/agents/`: does this skill's prior output already exist?
- `.scratch/`: a sign that a local-markdown issue tracker convention is already in use
- Is the `triage` skill installed? (a `triage` skill folder alongside this one, or `triage` in your available skills.) This decides whether Section B runs at all.
- Monorepo signals: a `pnpm-workspace.yaml`, a `workspaces` field in `package.json`, or a populated `packages/*` with its own `src/`. These are present only in a genuinely large multi-package repo; their absence means single-context, which is almost every repo.
### 2. Present findings and ask
Summarise what's present and what's missing. Then take the sections in order. One section, one answer, then the next.
Lead each section with the recommended answer so the user can accept it in a word. Give a one-line explainer only when the choice genuinely branches; skip the section entirely when exploration already settled it (Section B when `triage` isn't installed, Section C when there's no monorepo).
**Section A: Issue tracker.**
> Explainer: The "issue tracker" is where issues live for this repo. Skills like `to-tickets`, `triage`, and `to-spec` read from and write to it. They need to know whether to call `gh issue create`, write a markdown file under `.scratch/`, or follow some other workflow you describe. Pick the place you actually track work for this repo.
Default posture: these skills were designed for GitHub. If a `git remote` points at GitHub, propose that. If a `git remote` points at GitLab (`gitlab.com` or a self-hosted host), propose GitLab. Otherwise (or if the user prefers), offer:
- **GitHub**: issues live in the repo's GitHub Issues (uses the `gh` CLI)
- **GitLab**: issues live in the repo's GitLab Issues (uses the [`glab`](https://gitlab.com/gitlab-org/cli) CLI)
- **Local markdown**: issues live as files under `.scratch/<feature>/` in this repo (good for solo projects or repos without a remote)
- **Other** (Jira, Linear, etc.): ask the user to describe the workflow in one paragraph; the skill will record it as freeform prose
Record the choice in `docs/agents/issue-tracker.md`. The GitHub and GitLab templates carry a "PRs as a request surface" flag, defaulted **off**. Leave it off and don't raise it: a user who wants external PRs in the triage queue can flip the flag in the file later.
A GitHub or GitLab tracker needs a reachable repo. When the user picks one and no `git remote` points at that host, get the repo URL from them and wire it up (`git init` if needed, `git remote add origin <url>`) before going further. Done when `gh repo view` / `glab repo view` prints the project from inside this directory; if it can't, stop and tell the user what's missing.
**Section B: Triage label vocabulary.** Skip this section entirely if the `triage` skill isn't installed (exploration told you), since an uninstalled skill needs no labels.
If it is installed, ask exactly one question:
> Do you want to keep the default triage labels? (recommended: **yes**)
The defaults are the five canonical roles, each label string equal to its name: `needs-triage`, `needs-info`, `ready-for-agent`, `ready-for-human`, `wontfix`. On **yes**, write them as-is. Only if the user says no, usually because their tracker already uses other names (e.g. `bug:triage` for `needs-triage`), collect the overrides so `triage` applies existing labels instead of creating duplicates.
**Section C: Domain docs.** Default to **single-context** (one `GLOSSARY.md` + `docs/adr/` at the repo root). This fits almost every repo; write it without asking.
Offer **multi-context** (a root `GLOSSARY-MAP.md` pointing to per-context `GLOSSARY.md` files) only when exploration found monorepo signals. Then confirm which layout they want.
### 3. Confirm and edit
Show the user a draft of:
- The `## Agent skills` block to add to whichever of `CLAUDE.md` / `AGENTS.md` is being edited (see step 4 for selection rules)
- The contents of `docs/agents/issue-tracker.md`, `docs/agents/domain.md`, and `docs/agents/triage-labels.md` (the last only when `triage` is installed)
Let them edit before writing.
### 4. Write
**Pick the file to edit:**
- If `CLAUDE.md` exists, edit it.
- Else if `AGENTS.md` exists, edit it.
- If neither exists, ask the user which one to create; don't pick for them.
Never create `AGENTS.md` when `CLAUDE.md` already exists (or vice versa); always edit the one that's already there.
If an `## Agent skills` block already exists in the chosen file, update its contents in-place rather than appending a duplicate. Don't overwrite user edits to the surrounding sections.
The block:
```markdown
## Agent skills
### Issue tracker
[one-line summary of where issues are tracked]. See `docs/agents/issue-tracker.md`.
### Triage labels
[one-line summary of the label vocabulary]. See `docs/agents/triage-labels.md`.
### Domain docs
[one-line summary of layout: "single-context" or "multi-context"]. See `docs/agents/domain.md`.
```
Include the `### Triage labels` sub-block, and write `docs/agents/triage-labels.md`, only when `triage` is installed and Section B ran. When it isn't, both are omitted.
When Section B ran on GitHub or GitLab, create each configured label the tracker lacks (`gh label create` / `glab label create`).
Then write the docs files using the seed templates in this skill folder as a starting point:
- [issue-tracker-github.md](./issue-tracker-github.md): GitHub issue tracker
- [issue-tracker-gitlab.md](./issue-tracker-gitlab.md): GitLab issue tracker
- [issue-tracker-local.md](./issue-tracker-local.md): local-markdown issue tracker
- [triage-labels.md](./triage-labels.md): label mapping (only if `triage` is installed)
- [domain.md](./domain.md): domain doc consumer rules + layout
For "other" issue trackers, write `docs/agents/issue-tracker.md` from scratch using the user's description.
### 5. Done
Tell the user the setup is complete and which engineering skills will now read from these files. Mention they can edit `docs/agents/*.md` directly later; re-running this skill is only necessary if they want to switch issue trackers or restart from scratch.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Setup Matt Pocock Skills"
short_description: "Configure a repo for the skills"
policy:
allow_implicit_invocation: false

View file

@ -1,51 +0,0 @@
# Domain Docs
How the engineering skills should consume this repo's domain documentation when exploring the codebase.
## Before exploring, read these
- **`GLOSSARY.md`** at the repo root, or
- **`GLOSSARY-MAP.md`** at the repo root if it exists: it points at one `GLOSSARY.md` per context. Read each one relevant to the topic.
- **`docs/adr/`**: read ADRs that touch the area you're about to work in. In multi-context repos, also check `src/<context>/docs/adr/` for context-scoped decisions.
If any of these files don't exist, **proceed silently**. Don't flag their absence; don't suggest creating them upfront. The `/domain-modeling` skill (reached via `/grill-with-docs` and `/improve-codebase-architecture`) creates them lazily when terms or decisions actually get resolved.
## File structure
Single-context repo (most repos):
```
/
├── GLOSSARY.md
├── docs/adr/
│ ├── 0001-event-sourced-orders.md
│ └── 0002-postgres-for-write-model.md
└── src/
```
Multi-context repo (presence of `GLOSSARY-MAP.md` at the root):
```
/
├── GLOSSARY-MAP.md
├── docs/adr/ ← system-wide decisions
└── src/
├── ordering/
│ ├── GLOSSARY.md
│ └── docs/adr/ ← context-specific decisions
└── billing/
├── GLOSSARY.md
└── docs/adr/
```
## Use the glossary's vocabulary
When your output names a domain concept (in an issue title, a refactor proposal, a hypothesis, a test name), use the term as defined in `GLOSSARY.md`. Don't drift to synonyms the glossary explicitly avoids.
If the concept you need isn't in the glossary yet, that's a signal: either you're inventing language the project doesn't use (reconsider) or there's a real gap (note it for `/domain-modeling`).
## Flag ADR conflicts
If your output contradicts an existing ADR, surface it explicitly rather than silently overriding:
> _Contradicts ADR-0007 (event-sourced orders), but worth reopening because…_

View file

@ -1,50 +0,0 @@
# Issue tracker: GitHub
Issues and specs for this repo live as GitHub issues. Use the `gh` CLI for all operations.
## Conventions
- **Create an issue**: `gh issue create --title "..." --body "..."`. Use a heredoc for multi-line bodies.
- **Read an issue**: `gh issue view <number> --json number,title,body,labels,comments`.
- **List issues**: `gh issue list --state open --json number,title,body,labels,comments --jq '[.[] | {number, title, body, labels: [.labels[].name], comments: [.comments[].body]}]'` with appropriate `--label` and `--state` filters.
- **Make an issue a sub-issue of a parent**: `gh issue create --parent <parent> ...`, or `gh issue edit <parent> --add-sub-issue <child>` afterwards (`gh` 2.94+). Older `gh`: `gh api --method POST repos/<owner>/<repo>/issues/<parent>/sub_issues -F sub_issue_id=<child-db-id>` (database id, as in **Blocking** below). Without sub-issues, put `Part of #<parent>` at the top of the child body.
- **Blocking**: GitHub's **native issue dependencies**, the canonical, UI-visible representation. Add an edge with `gh issue create --blocked-by <n>,<n> ...` or `gh issue edit <child> --add-blocked-by <blocker>` (`gh` 2.94+). Older `gh`: `gh api --method POST repos/<owner>/<repo>/issues/<child>/dependencies/blocked_by -F issue_id=<blocker-db-id>`, where `<blocker-db-id>` is the blocker's numeric **database id** (`gh api repos/<owner>/<repo>/issues/<n> --jq .id`, _not_ the `#number` or `node_id`). Where dependencies aren't available, fall back to a `Blocked by: #<n>, #<n>` line at the top of the child body. A ticket is unblocked when every blocker is closed.
- **Count open blockers**: `gh api repos/<owner>/<repo>/issues/<n> --jq .issue_dependencies_summary.blocked_by` (open blockers only; 0 means startable). `gh issue view <n> --json blockedBy` also lists closed blockers, so filter it: `--jq '[.blockedBy.nodes[] | select(.state == "OPEN")] | length'`.
- **Comment on an issue**: `gh issue comment <number> --body "..."`
- **Apply / remove labels**: `gh issue edit <number> --add-label "..."` / `--remove-label "..."`
- **Close**: post the explanation with `gh issue comment <number> --body "..."`, then `gh issue close <number>`. On an already-closed issue, `gh issue close --comment` drops the comment and still exits 0.
Infer the repo from `git remote -v`; `gh` does this automatically when run inside a clone.
File issues only into the user's own repo. Never file into `mattpocock/skills` (the repo these skills come from) unless the user owns it. In a fork, `gh` can default to the upstream parent, so before the first `gh issue create` of a session, check the target with `gh repo view --json nameWithOwner` and confirm it with the user if it is not their repo.
## Pull requests as a triage surface
**PRs as a request surface: no.** _(Set to `yes` if this repo treats external PRs as feature requests; `/triage` reads this flag.)_
When set to `yes`, PRs run through the same labels and states as issues, using the `gh pr` equivalents:
- **Read a PR**: `gh pr view <number>`, then `gh pr view <number> --comments` (off a TTY, `--comments` prints only the comments, not the body), and `gh pr diff <number>` for the diff.
- **List external PRs for triage**: `gh api --paginate 'repos/{owner}/{repo}/pulls?state=open' --jq '.[] | select(.author_association | IN("OWNER","MEMBER","COLLABORATOR") | not) | {number, title, author: .user.login, author_association, labels: [.labels[].name]}'`.
- **Comment / label / close**: `gh pr comment`, `gh pr edit --add-label`/`--remove-label`, `gh pr close`.
GitHub shares one number space across issues and PRs, so a bare `#42` may be either: resolve with `gh pr view 42` and fall back to `gh issue view 42`.
## When a skill says "publish to the issue tracker"
Create a GitHub issue.
## When a skill says "fetch the relevant ticket"
Read it as in **Read an issue** above.
## Wayfinding operations
Used by `/wayfinder`. The **map** is a single issue with **child** issues as tickets.
- **Map**: a single issue labelled `wayfinder:map`, holding the Notes / Decisions-so-far / Fog body. `gh issue create --label wayfinder:map`.
- **Child ticket**: an issue linked to the map as a GitHub sub-issue (see **Make an issue a sub-issue of a parent**). Where sub-issues aren't enabled, add the child to a task list in the map body and put `Part of #<map>` at the top of the child body. Labels: `wayfinder:<type>` (`research`/`prototype`/`grilling`/`task`). Once claimed, the ticket is assigned to the driving dev.
- **Blocking**: see **Blocking** under Conventions.
- **Frontier query**: list the map's open children (`gh issue list --state open`, scoped to the map's sub-issues / task list), drop any with an open blocker (see **Count open blockers**, or an open issue in the `Blocked by` line) or an assignee; first in map order wins.
- **Claim**: `gh issue edit <n> --add-assignee @me`, the session's first write.
- **Resolve**: `gh issue comment <n> --body "<answer>"`, then `gh issue close <n>`, then append a context pointer (gist + link) to the map's Decisions-so-far.

View file

@ -1,46 +0,0 @@
# Issue tracker: GitLab
Issues and specs for this repo live as GitLab issues. Use the [`glab`](https://gitlab.com/gitlab-org/cli) CLI for all operations.
## Conventions
- **Create an issue**: `glab issue create --title "..." --description "..."`. Use a heredoc for multi-line descriptions. Pass `--description -` to open an editor.
- **Read an issue**: `glab issue view <number> --comments`. Use `-F json` for machine-readable output.
- **List issues**: `glab issue list -O json` with appropriate `--label` filters.
- **Comment on an issue**: `glab issue note <number> --message "..."`. GitLab calls comments "notes".
- **Apply / remove labels**: `glab issue update <number> --label "..."` / `--unlabel "..."`. Multiple labels can be comma-separated or by repeating the flag.
- **Close**: `glab issue close <number>`. `glab issue close` does not accept a closing comment, so post the explanation first with `glab issue note <number> --message "..."`, then close.
- **Merge requests**: GitLab calls PRs "merge requests". Use `glab mr create`, `glab mr view`, `glab mr note`, etc., the same shape as `gh pr ...` with `mr` in place of `pr` and `note`/`--message` in place of `comment`/`--body`.
Infer the repo from `git remote -v`; `glab` does this automatically when run inside a clone.
## Merge requests as a triage surface
**MRs as a request surface: no.** _(Set to `yes` if this repo treats external merge requests as feature requests; `/triage` reads this flag.)_
When set to `yes`, MRs run through the same labels and states as issues, using the `glab mr` equivalents:
- **Read an MR**: `glab mr view <number> --comments` and `glab mr diff <number>` for the diff.
- **List external MRs for triage**: `glab mr list -O json`, then keep only MRs whose author is not a project member/owner (a contributor's MR, not a maintainer's in-flight work).
- **Comment / label / close**: `glab mr note`, `glab mr update --label`/`--unlabel`, `glab mr close`.
Unlike GitHub, GitLab numbers issues and MRs separately, so `#42` is unambiguous once you know which surface the maintainer means.
## When a skill says "publish to the issue tracker"
Create a GitLab issue.
## When a skill says "fetch the relevant ticket"
Run `glab issue view <number> --comments`.
## Wayfinding operations
Used by `/wayfinder`. The **map** is a single issue with **child** issues as tickets.
- **Map**: a single issue labelled `wayfinder:map`, holding the Notes / Decisions-so-far / Fog body. `glab issue create --label wayfinder:map`. (On GitLab tiers with native epics, an epic may hold the map instead; a labelled issue works everywhere.)
- **Child ticket**: an issue carrying `Part of #<map>` at the top of its description, linked to the map (`glab issue create --linked-issues <map> --link-type relates_to`), and labels `wayfinder:<type>` (`research`/`prototype`/`grilling`/`task`). Once claimed, the ticket is assigned to the driving dev.
- **Blocking**: GitLab's **native blocking link**, the canonical, UI-visible representation. Add it with the `/blocked_by #<n>` quick action, posted as a note (`glab issue note <child> --message "/blocked_by #<blocker>"`). Native blocking links are a Premium/Ultimate feature; on the free tier (or where unavailable) fall back to a `Blocked by: #<n>, #<n>` line at the top of the description. A ticket is unblocked when every blocker is closed.
- **Frontier query**: list the map's children with `glab api projects/:id/issues/<map>/links`, keeping open issues that carry a `wayfinder:<type>` label; drop any with an open blocker: a native `blocked_by` link to an open issue (`glab api projects/:id/issues/<child-iid>/links`), or an open issue in the `Blocked by` line, or an assignee; first in map order wins.
- **Claim**: `glab issue update <n> --assignee @me`, the session's first write.
- **Resolve**: `glab issue note <n> --message "<answer>"`, then `glab issue close <n>`, then append a context pointer (gist + link) to the map's Decisions-so-far.

View file

@ -1,30 +0,0 @@
# Issue tracker: Local Markdown
Issues and specs for this repo live as markdown files in `.scratch/`.
## Conventions
- One feature per directory: `.scratch/<feature-slug>/`
- The spec is `.scratch/<feature-slug>/spec.md`
- Implementation issues are one file per ticket at `.scratch/<feature-slug>/issues/<NN>-<slug>.md`, numbered from `01`, never a single combined tickets file
- Triage state is recorded as a `Status:` line near the top of each issue file (see `triage-labels.md` for the role strings)
- Comments and conversation history append to the bottom of the file under a `## Comments` heading
## When a skill says "publish to the issue tracker"
Create a new file under `.scratch/<feature-slug>/` (creating the directory if needed).
## When a skill says "fetch the relevant ticket"
Read the file at the referenced path. The user will normally pass the path or the issue number directly.
## Wayfinding operations
Used by `/wayfinder`. The **map** is a file with one **child** file per ticket.
- **Map**: `.scratch/<effort>/map.md` (the Notes / Decisions-so-far / Fog body).
- **Child ticket**: `.scratch/<effort>/issues/NN-<slug>.md`, numbered from `01`, with the question in the body. A `Type:` line records the ticket type (`research`/`prototype`/`grilling`/`task`); a `Status:` line records `claimed`/`resolved`.
- **Blocking**: a `Blocked by: NN, NN` line near the top. A ticket is unblocked when every file it lists is `resolved`.
- **Frontier**: scan `.scratch/<effort>/issues/` for files that are open, unblocked, and unclaimed; first by number wins.
- **Claim**: set `Status: claimed` and save before any work.
- **Resolve**: append the answer under an `## Answer` heading, set `Status: resolved`, then append a context pointer (gist + link) to the map's Decisions-so-far in `map.md`.

View file

@ -1,15 +0,0 @@
# Triage Labels
The skills speak in terms of five canonical triage roles. This file maps those roles to the actual label strings used in this repo's issue tracker.
| Label in mattpocock/skills | Label in our tracker | Meaning |
| -------------------------- | -------------------- | ---------------------------------------- |
| `needs-triage` | `needs-triage` | Maintainer needs to evaluate this issue |
| `needs-info` | `needs-info` | Waiting on reporter for more information |
| `ready-for-agent` | `ready-for-agent` | Fully specified, ready for an AFK agent |
| `ready-for-human` | `ready-for-human` | Requires human implementation |
| `wontfix` | `wontfix` | Will not be actioned |
When a skill mentions a role (e.g. "apply the AFK-ready triage label"), use the corresponding label string from this table.
Edit the "Label in our tracker" column to match whatever vocabulary you actually use.

View file

@ -1,38 +0,0 @@
---
name: tdd
description: Test-driven development. Use when the user wants to build features or fix bugs test-first, mentions "red-green-refactor", or wants integration tests.
---
# Test-Driven Development
TDD is the red → green loop. This skill is the reference that makes that loop produce tests worth keeping: what a good test is, where tests go, the anti-patterns, and the rules of the loop. Every section applies on every cycle: consult them before and during the loop, not after.
When exploring the codebase, read `GLOSSARY.md` (if it exists) so test names and interface vocabulary match the project's domain language, and respect ADRs in the area you're touching.
## What a good test is
Tests verify behavior through public interfaces, not implementation details. Code can change entirely; tests shouldn't. A good test reads like a specification: "user can checkout with valid cart" tells you exactly what capability exists, and it survives refactors because it doesn't care about internal structure.
See [tests.md](tests.md) for examples and [mocking.md](mocking.md) for mocking guidelines.
## Seams: where tests go
A **seam** is the public boundary you test at: the interface where you observe behavior without reaching inside. Tests live at seams, never against internals.
**Test only at pre-agreed seams.** Before writing any test, write down the seams under test and confirm them with the user. No test is written at an unconfirmed seam. You can't test everything, so agreeing the seams up front is how testing effort lands on the critical paths and complex logic instead of every edge case.
Ask: "What's the public interface, and which seams should we test?" Give each proposed seam a one-line note on what it catches and what it misses.
When the shape of that interface is itself in question (how deep the module is, where the seam belongs, what the interface should expose), call the Skill tool with "codebase-design" for the vocabulary. It is the shared source of the module, interface, depth, seam, adapter, leverage and locality terms, and it is a reference to consult, not a session to run.
## Anti-patterns
- **Implementation-coupled**: mocks internal collaborators, tests private methods, or verifies through a side channel (querying the database instead of using the interface). The tell: the test breaks when you refactor but behavior hasn't changed.
- **Tautological**: the assertion recomputes the expected value the way the code does (`expect(add(a, b)).toBe(a + b)`, a snapshot derived by hand the same way, a constant asserted equal to itself), so it passes by construction and can never disagree with the code. Expected values must come from an independent source of truth: a known-good literal, a worked example, the spec.
- **Horizontal slicing**: writing all tests first, then all implementation. Bulk tests verify _imagined_ behavior: you test the _shape_ of things rather than user-facing behavior, the tests go insensitive to real changes, and you commit to test structure before understanding the implementation. Work in **vertical slices** instead: one test → one implementation → repeat, each test a **tracer bullet** that responds to what the last cycle taught you.
## Rules of the loop
- **Red before green.** Write the failing test first, then only enough code to pass it. Don't anticipate future tests or add speculative features.
- **One slice at a time.** One seam, one test, one minimal implementation per cycle.
- **Refactoring is not part of the loop.** It belongs to the review stage (see the `code-review` skill), not the red → green implementation cycle.

View file

@ -1,3 +0,0 @@
interface:
display_name: "TDD"
short_description: "Test-driven red-green-refactor"

View file

@ -1,59 +0,0 @@
# When to Mock
Mock at **system boundaries** only:
- External APIs (payment, email, etc.)
- Databases (sometimes - prefer test DB)
- Time/randomness
- File system (sometimes)
Don't mock:
- Your own classes/modules
- Internal collaborators
- Anything you control
## Designing for Mockability
At system boundaries, design interfaces that are easy to mock:
**1. Use dependency injection**
Pass external dependencies in rather than creating them internally:
```typescript
// Easy to mock
function processPayment(order, paymentClient) {
return paymentClient.charge(order.total);
}
// Hard to mock
function processPayment(order) {
const client = new StripeClient(process.env.STRIPE_KEY);
return client.charge(order.total);
}
```
**2. Prefer SDK-style interfaces over generic fetchers**
Create specific functions for each external operation instead of one generic function with conditional logic:
```typescript
// GOOD: Each function is independently mockable
const api = {
getUser: (id) => fetch(`/users/${id}`),
getOrders: (userId) => fetch(`/users/${userId}/orders`),
createOrder: (data) => fetch('/orders', { method: 'POST', body: data }),
};
// BAD: Mocking requires conditional logic inside the mock
const api = {
fetch: (endpoint, options) => fetch(endpoint, options),
};
```
The SDK approach means:
- Each mock returns one specific shape
- No conditional logic in test setup
- Easier to see which endpoints a test exercises
- Type safety per endpoint

View file

@ -1,77 +0,0 @@
# Good and Bad Tests
## Good Tests
**Integration-style**: Test through real interfaces, not mocks of internal parts.
```typescript
// GOOD: Tests observable behavior
test("user can checkout with valid cart", async () => {
const cart = createCart();
cart.add(product);
const result = await checkout(cart, paymentMethod);
expect(result.status).toBe("confirmed");
});
```
Characteristics:
- Tests behavior users/callers care about
- Uses public API only
- Survives internal refactors
- Describes WHAT, not HOW
- One logical assertion per test
## Bad Tests
**Implementation-detail tests**: Coupled to internal structure.
```typescript
// BAD: Tests implementation details
test("checkout calls paymentService.process", async () => {
const mockPayment = jest.mock(paymentService);
await checkout(cart, payment);
expect(mockPayment.process).toHaveBeenCalledWith(cart.total);
});
```
Red flags:
- Mocking internal collaborators
- Testing private methods
- Asserting on call counts/order
- Test breaks when refactoring without behavior change
- Test name describes HOW not WHAT
- Verifying through external means instead of interface
```typescript
// BAD: Bypasses interface to verify
test("createUser saves to database", async () => {
await createUser({ name: "Alice" });
const row = await db.query("SELECT * FROM users WHERE name = ?", ["Alice"]);
expect(row).toBeDefined();
});
// GOOD: Verifies through interface
test("createUser makes user retrievable", async () => {
const user = await createUser({ name: "Alice" });
const retrieved = await getUser(user.id);
expect(retrieved.name).toBe("Alice");
});
```
**Tautological tests**: Expected value restates the implementation, so the test passes by construction.
```typescript
// BAD: Expected value is recomputed the way the code computes it
test("calculateTotal sums line items", () => {
const items = [{ price: 10 }, { price: 5 }];
const expected = items.reduce((sum, i) => sum + i.price, 0);
expect(calculateTotal(items)).toBe(expected);
});
// GOOD: Expected value is an independent, known literal
test("calculateTotal sums line items", () => {
expect(calculateTotal([{ price: 10 }, { price: 5 }])).toBe(15);
});
```

View file

@ -1,35 +0,0 @@
# GLOSSARY.md Format
`GLOSSARY.md` is the canonical language for this teaching workspace. All explainers, exercises, and learning records should adhere to its terminology. Building it is itself part of learning: compressing a concept into a tight definition is evidence the user understands it.
## Structure
```md
# {Topic} Glossary
{One or two sentence description of the topic this glossary covers.}
## Terms
**Hypertrophy**:
Muscle growth driven by mechanical tension and metabolic stress over repeated training sessions.
_Avoid_: Bulking, getting big
**Progressive overload**:
Systematically increasing the demand on a muscle over time, via load, volume, or intensity.
_Avoid_: Pushing harder, levelling up
**RPE (Rate of Perceived Exertion)**:
A 1–10 self-rating of how hard a set felt, where 10 is failure and 8 means two reps left in the tank.
_Avoid_: Effort score, intensity rating
```
## Rules
- **Add a term only when the user understands it.** The glossary is a record of compressed knowledge, not a dictionary the user reads to learn. If the user has just been introduced to a concept, wait until they can use it correctly before promoting it here.
- **Be opinionated.** When several words exist for the same concept, pick the best one and list the rest as aliases to avoid. This is how language compresses.
- **Keep definitions tight.** One or two sentences. Define what the term IS, not what it does or how to do it.
- **Use the glossary's own terms inside definitions.** Once a term is in the glossary, prefer it everywhere, including inside other definitions. This is what makes complex terms easier to grasp later.
- **Group under subheadings** when natural clusters emerge (e.g. `## Anatomy`, `## Programming`). A flat list is fine when terms cohere.
- **Flag ambiguities explicitly.** If a term is used loosely in the wider field, note the resolution: "In this workspace, 'set' always means a working set; warm-ups are tracked separately."
- **Revise as understanding deepens.** A definition the user wrote in week one may be wrong by week six. Update in place; do not leave stale entries.

View file

@ -1,46 +0,0 @@
# Learning Record Format
Learning records live in `./learning-records/` and use sequential numbering: `0001-slug.md`, `0002-slug.md`, etc. Create the directory lazily: only when the first record is written.
They are the teaching equivalent of ADRs: they capture non-obvious lessons, key insights, and stated prior knowledge that will steer future sessions. They are used to calculate the zone of proximal development.
## Template
```md
# {Short title of what was learned or established}
{1-3 sentences: what was learned (or what prior knowledge was established), and why it matters for future sessions.}
```
That is the whole format. A learning record can be a single paragraph. The value is recording _that_ this is now known and _why_ it changes what to teach next, not in filling out sections.
## Optional sections
Only include these when they add genuine value. Most records won't need them.
- **Status** frontmatter (`active | superseded by LR-NNNN`): useful when an earlier understanding turns out to be wrong and is replaced.
- **Evidence**: how the user demonstrated the understanding (a question answered, an exercise completed, prior experience cited). Useful when the claim might be revisited.
- **Implications**: what this unlocks or rules out for future sessions. Worth recording when non-obvious.
## Numbering
Scan `./learning-records/` for the highest existing number and increment by one.
## When to write a learning record
Write one when any of these is true:
1. **The user demonstrated genuine understanding of something non-trivial**: not just exposure, but evidence they can use the concept correctly. This sets a new floor for what to teach next.
2. **The user disclosed prior knowledge**: "I already know X." Record it so future sessions don't re-teach it. Also record the _depth_ claimed.
3. **A misconception was corrected**: the user previously believed something wrong and now sees why. These are high-value: they predict future stumbling blocks for related topics.
4. **The mission shifted in response to learning**: the user discovered they cared about something different than they thought. Cross-link to [[MISSION.md]] and update it.
### What does _not_ qualify
- Material that was merely covered. Coverage is not learning. Wait for evidence.
- Anything already captured tersely in [[GLOSSARY.md]] as a term definition. Don't duplicate.
- Session-by-session activity logs. Learning records are not a journal: they are decision-grade insights.
## Supersession
When a later record contradicts an earlier one (the user's understanding deepened or corrected), mark the old record `Status: superseded by LR-NNNN` rather than deleting it. The history of how understanding evolved is itself useful signal.

View file

@ -1,31 +0,0 @@
# MISSION.md Format
`MISSION.md` lives at the workspace root. It captures the _reason_ the user is learning this topic. Every teaching decision (what to teach next, which resources to surface, which exercises to design) should trace back to this document.
## Template
```md
# Mission: {Topic}
## Why
{1-3 sentences. The concrete real-world goal the user is chasing. What changes in their life or work when they have this skill? Avoid abstract framings like "to understand X"; push for the underlying outcome.}
## Success looks like
- {A specific, observable thing the user will be able to do}
- {Another specific thing}
- {…}
## Constraints
- {Time, budget, prior commitments, learning preferences, anything that bounds the approach}
## Out of scope
- {Adjacent topics the user explicitly does not want to chase right now, protecting the zone of proximal development}
```
## Rules
- **One mission per workspace.** If the user wants to learn two unrelated things, that is two workspaces.
- **Concrete over abstract.** "Run a half marathon by October" beats "get fitter." "Ship a Rust CLI to my team" beats "learn Rust."
- **Push back on vagueness.** If the user cannot articulate why, interview them before writing anything. A bad mission is worse than no mission.
- **Revise when reality shifts.** Missions change. When the user's goal moves, update this file: don't leave a stale mission steering future sessions.
- **Keep it short.** If `MISSION.md` runs past a screen, it has stopped being a compass and started being a plan.

View file

@ -1,32 +0,0 @@
# RESOURCES.md Format
`RESOURCES.md` is the curated set of trusted sources for this topic. Knowledge for explainers should be drawn from here, not from parametric guesses. Wisdom comes from the communities listed here.
## Structure
```md
# {Topic} Resources
## Knowledge
- [Book: _The Science and Practice of Strength Training_ by Zatsiorsky & Kraemer](https://example.com)
Foundational text on programming and adaptation. Use for: anything to do with periodisation, recovery, intensity zones.
- [Article: "How Much Should I Train?" by Greg Nuckols (Stronger By Science)](https://example.com)
Evidence-based review of volume landmarks. Use for: weekly set targets per muscle group.
## Wisdom (Communities)
- [r/weightroom](https://reddit.com/r/weightroom)
High-signal subreddit, moderated against bro-science. Use for: programme critique, plateau troubleshooting.
- Local: Tuesday strength class at {gym name}
Use for: real-time coaching feedback on lifts.
```
## Rules
- **High-trust only.** Prefer primary sources, recognised experts, peer-reviewed work, and communities with strong moderation. If a resource is marketing dressed as education, leave it out.
- **Annotate every entry.** A bare link is useless in three months. Add one line: what it covers and when to reach for it.
- **Group by Knowledge / Wisdom.** Mirrors the philosophy in [SKILL.md](./SKILL.md). It is fine for a resource to appear in only one group.
- **Surface gaps explicitly.** If no good resource exists for an area the mission needs, write a `## Gaps` section listing what is missing. This drives future search.
- **Prune ruthlessly.** A resource that turned out to be wrong, shallow, or off-mission should be removed, not buried. Better five sharp sources than thirty mediocre ones.
- **Record community preferences.** If the user has opted out of joining communities, note it here so future sessions don't keep proposing them.

View file

@ -1,140 +0,0 @@
---
name: teach
description: Teach the user a new skill or concept, within this workspace.
disable-model-invocation: true
argument-hint: "What would you like to learn about?"
---
The user has asked you to teach them something. This is a stateful request - they intend to learn the topic over multiple sessions.
## Teaching Workspace
Treat the current directory as a teaching workspace. Workspace paths (`./lessons/` and the rest) resolve from the directory `/teach` was run in; only the `*-FORMAT.md` links resolve from this skill's folder. The state of their learning is captured in this directory in several files:
- `MISSION.md`: A document capturing the _reason_ the user is interested in the topic. This should be used to ground all teaching. Use the format in [MISSION-FORMAT.md](./MISSION-FORMAT.md).
- `./reference/*.html`: A directory of reference materials. These are the compressed learnings from the lessons - cheat sheets, reference algorithms, syntax, yoga poses, glossaries. They are the raw units of learning. They should be beautiful documents which print out well, and are designed for quick reference.
- `RESOURCES.md`: A list of resources which can be explored to ground your teaching in contextual knowledge, or to acquire knowledge and wisdom. Use the format in [RESOURCES-FORMAT.md](./RESOURCES-FORMAT.md).
- `./learning-records/*.md`: A directory of learning records, which capture what the user has learned. These are loosely equivalent to architectural decision records in software development - they capture non-obvious lessons and key insights that may need to be revised later, or drive future sessions. These should be used to calculate the zone of proximal development. They are titled `0001-<dash-case-name>.md`, where the number increments each time. Use the format in [LEARNING-RECORD-FORMAT.md](./LEARNING-RECORD-FORMAT.md).
- `./lessons/*.html`: A directory of lessons. A **lesson** is a single, self-contained HTML output that teaches one tightly-scoped thing tied to the mission. This is the primary unit of teaching in this workspace.
- `./assets/*`: Reusable **components** shared across lessons. See [Assets](#assets).
- `NOTES.md`: A scratchpad for you to jot down user preferences, or working notes.
## Philosophy
To learn at a deep level, the user needs three things:
- **Knowledge**, captured from high-quality, high-trust resources
- **Skills**, acquired through highly-relevant interactive lessons devised by you, based on the knowledge
- **Wisdom**, which comes from interacting with other learners and practitioners
Before the `RESOURCES.md` is well-populated, your focus should be to find high-quality resources which will help the user acquire knowledge. Never trust your parametric knowledge.
Some topics may require more skills than knowledge. Learning more about theoretical physics might be more knowledge-based. For yoga, more skills-based.
### Fluency vs Storage Strength
You should be careful to split between two types of learning:
- **Fluency strength**: in-the-moment retrieval of knowledge
- **Storage strength**: long-term retention of knowledge
Fluency can give the user an illusory sense of mastery, but storage strength is the real goal. Try to design lessons which build long-term retention by desirable difficulty:
- Using retrieval practice (recall from memory)
- Spacing (distributing practice over time)
- Interleaving (mixing up different but related topics in practice - for skills practice only)
## Lessons
A lesson is the main thing you produce: the unit in which knowledge and skills reach the user. Each lesson is one self-contained HTML file, saved to `./lessons/` and titled `0001-<dash-case-name>.html` where the number increments each time.
A lesson should be **beautiful**, with clean, readable typography and layout, since the user will return to these later to review. Think Tufte.
The lesson should be short, and completable very quickly. Learners' working memory is very small, and we need to stay within it. But each lesson should give the user a single tangible win that they can build on. It should be directly tied to the mission, and should be in the user's zone of proximal development.
If possible, open the lesson file for the user by running a CLI command.
Each lesson should link via HTML anchors to other lessons and reference documents.
Each lesson should recommend a primary source for the user to read or watch. This should be the most high-quality, high-trust resource you found on the topic.
Each lesson should contain a reminder to ask followup questions to the agent. The agent is their teacher, and can assist with anything that's unclear.
## Assets
Lessons are built from reusable **components**, stored in `./assets/`: stylesheets, quiz widgets, simulators, diagram helpers, and anything else a second lesson could reuse.
Reuse is the default, not the exception. Before authoring a lesson, read `./assets/` and build from the components already there. When a lesson needs something new and reusable, write it as a component in `./assets/` and link to it; never inline code a future lesson would duplicate.
A shared stylesheet is the first component every workspace earns: every lesson links it, so the lessons look like one consistent course rather than a pile of one-offs. As the workspace grows, so should the component library.
## The Mission
Every lesson should be tied into the mission - the reason that the user is interested in learning about the topic.
If the user is unclear about the mission, or the `MISSION.md` is not populated, your first job should be to question the user on why they want to learn this.
Failing to understand the mission will mean knowledge acquisition is not grounded in real-world goals. Lessons will feel too abstract. You will have no way of judging what the user should do next.
Missions may change as the user develops more skills and knowledge. This is normal - make sure to update the `MISSION.md` and add a learning record to capture the change. Confirm with the user before changing the mission.
## Zone Of Proximal Development
Each lesson, the user should always feel as if they are being challenged 'just enough'.
The user may specify an exact thing they want to learn. If they don't, figure out their zone of proximal development by:
- Reading their `learning-records`
- Figuring out the right thing to teach them based on their mission
- Teach the most relevant thing that fits in their zone of proximal development
## Knowledge
Lessons should be designed around a skill the user is going to learn. The knowledge in the lesson should be only what's required to acquire that skill. You teach the knowledge first, then get the user to practice the skills via an interactive feedback loop.
Knowledge should first be gathered from trusted resources. Use `RESOURCES.md` to keep track of them. Lessons should be littered with citations - links to external resources to back up any claim made. This increases the trustworthiness of the lesson.
For acquiring knowledge, difficulty is the enemy. It eats working memory you need for understanding.
## Skills
If knowledge is all about acquisition, skills are about durability and flexibility. Make the knowledge stick.
For skill acquisition, difficulty is the tool. Effortful retrieval is what builds storage strength. Skills should be taught through interactive lessons. There are several tools at your disposal:
- Interactive lessons, using quizzes and light in-browser tasks
- Lessons which guide the user through a list of real-world steps to take (for instance, yoga poses)
Each of these should be based on a **feedback loop**, where the user receives feedback on their performance. This feedback loop should be as tight as possible, giving feedback immediately - and ideally automatically.
For quizzes, each answer should be exactly the same number of words (and characters, if possible). Vary which position holds the correct answer across questions. Don't give the user any clues about the answer through formatting or order.
## Acquiring Wisdom
Wisdom comes from true real-world interaction - testing your skills outside the learning environment.
When the user asks a question that appears to require wisdom, your default posture should be to attempt to answer - but to ultimately delegate to a **community**.
A community is a place (online or offline) where the user can test their skills in the real world. This might be a forum, a subreddit, a real-world class (budget permitting) or a local interest group.
You should attempt to find high-reputation communities the user can join. If the user expresses a preference that they don't want to join a community, respect it.
## Reference Documents
While creating lessons, you should also create reference documents. Lessons can reference these documents - they are useful for tracking raw units of knowledge useful across lessons.
Lessons will rarely be revisited later - reference documents will be. They should be the compressed essence of the lesson, in a format designed for quick reference.
Some learning topics lend themselves to reference:
- Syntax and code snippets for programming
- Algorithms and flowcharts for processes
- Yoga poses and sequences for yoga
- Exercises and routines for fitness
- Glossaries for any topic with its own nomenclature
Glossaries, in particular, are an essential reference. Once one is created, it should be adhered to in every lesson.
## `NOTES.md`
The user will sometimes express preferences of how they want to be taught, or things you should keep in mind. This is the place to record those preferences, so you can refer back to them when designing lessons or working with the user.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Teach"
short_description: "Learn a concept in a guided workspace"
policy:
allow_implicit_invocation: false

View file

@ -1,54 +0,0 @@
---
name: to-questionnaire
description: Turn a decision you can't fully answer into a questionnaire for someone else to fill in.
disable-model-invocation: true
---
Turn something the user can't answer alone into a **questionnaire**: a Markdown document they hand to one person to fill in async, or fill out together over a meeting. The recipient holds knowledge the user lacks; the questionnaire pulls it out of them.
**Grill the send, not the subject.** Interview the user only about the _send_, which they can always answer: who it goes to, and what they need back. The questions in the document then target the **gap** between what the recipient knows and what the user needs.
1. **Who is it going to?** Ask, in one exchange, the recipient's role, expertise, and relationship to the user. This fixes the questionnaire's tone and how much context it must carry. Done when you know who the recipient is and what they know that the user doesn't.
2. **What do you need back?** Ask, in one exchange, the specific decisions or facts the user can't resolve alone and needs from this person. Done when you have a concrete list of what the user must walk away able to do or decide.
3. **Write the questionnaire.** Draft questions aimed at the gap from steps 1–2, following the Document structure below. Write it to `to-questionnaire-<slug>.md` in the current directory (slug from the topic) and report the path. Done when the file exists and every item the user named in step 2 is covered by a question.
## Document structure
Frame the document as a **discovery questionnaire**: the user lacks context, the recipient holds it. Order questions most-important-first, since async means you may only get one pass, and group them under `##` headings by theme once there are more than a handful. Write it using the template below.
<questionnaire-template>
# <Questionnaire title>
**Purpose:** why this questionnaire exists and the decision riding on it.
**From:** <the user>, **To:** <the recipient>, **How your answers will be used:** <where they go>
## Context
One paragraph orienting a recipient who wasn't in the user's head. Enough to answer well, not a page.
## How to answer
Deadline and rough effort. Partial answers and "I don't know" are useful: flag anything you're unsure of rather than skipping it.
## <Theme heading>
One `##` section per theme. Under each, its questions, most-important-first. Every question is one idea, never compound, with an answer stub directly beneath, and a one-line _why this matters_ only where the question could be misread or invite a throwaway answer.
<question-example>
### What load is the system expected to handle at launch?
_Why this matters: it decides whether we provision for burst traffic now or defer it._
>
</question-example>
## Anything else?
A closing catch-all: anything we didn't ask that we should know?
</questionnaire-template>

View file

@ -1,5 +0,0 @@
interface:
display_name: "To Questionnaire"
short_description: "Front-load questions into a doc for someone to answer"
policy:
allow_implicit_invocation: false

View file

@ -1,75 +0,0 @@
---
name: to-spec
description: "Turn the current conversation into a spec and publish it to the project issue tracker: no interview, just synthesis of what you've already discussed."
disable-model-invocation: true
---
This skill takes the current conversation context and codebase understanding and produces a spec. Do NOT interview the user; just synthesize what you already know.
The issue tracker and triage label vocabulary should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
## Process
1. Explore the repo to understand the current state of the codebase, if you haven't already. Use the project's domain glossary vocabulary throughout the spec, and respect any ADRs in the area you're touching.
2. Sketch out the seams at which you're going to test the feature. Existing seams should be preferred to new ones. Use the highest seam possible. If new seams are needed, propose them at the highest point you can. The fewer seams across the codebase, the better - the ideal number is one.
Check with the user that these seams match their expectations.
3. Write the spec using the template below, then publish it to the project issue tracker. Apply the `ready-for-agent` triage label - no need for additional triage.
<spec-template>
## Problem Statement
The problem that the user is facing, from the user's perspective.
## Solution
The solution to the problem, from the user's perspective.
## User Stories
A LONG, numbered list of user stories. Each user story should be in the format of:
1. As an <actor>, I want a <feature>, so that <benefit>
<user-story-example>
1. As a mobile bank customer, I want to see balance on my accounts, so that I can make better informed decisions about my spending
</user-story-example>
This list of user stories should be extremely extensive and cover all aspects of the feature.
## Implementation Decisions
A list of implementation decisions that were made. This can include:
- The modules that will be built/modified
- The interfaces of those modules that will be modified
- Technical clarifications from the developer
- Architectural decisions
- Schema changes
- API contracts
- Specific interactions
Do NOT include specific file paths or code snippets. They may end up being outdated very quickly.
Exception: if a prototype produced a snippet that encodes a decision more precisely than prose can (state machine, reducer, schema, type shape), inline it within the relevant decision and note briefly that it came from a prototype. Trim to the decision-rich parts, not a working demo, just the important bits.
## Testing Decisions
A list of testing decisions that were made. Include:
- A description of what makes a good test (only test external behavior, not implementation details)
- Which modules will be tested
- Prior art for the tests (i.e. similar types of tests in the codebase)
## Out of Scope
A description of the things that are out of scope for this spec.
## Further Notes
Any further notes about the feature.
</spec-template>

View file

@ -1,5 +0,0 @@
interface:
display_name: "To Spec"
short_description: "Turn a conversation into a spec"
policy:
allow_implicit_invocation: false

View file

@ -1,105 +0,0 @@
---
name: to-tickets
description: Break a plan, spec, or the current conversation into a set of tracer-bullet tickets, each declaring its blocking edges, published to the configured tracker (edges as text in one file per ticket locally, or native blocking links on a real tracker).
disable-model-invocation: true
---
# To Tickets
Break a plan, spec, or conversation into a set of **tickets**: tracer-bullet vertical slices, each declaring the tickets that **block** it.
The issue tracker and triage label vocabulary should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
## Process
### 1. Gather context
Work from whatever is already in the conversation context. If the user passes a reference (a spec path, an issue number or URL) as an argument, fetch it and read its full body and comments.
### 2. Explore the codebase (optional)
If you have not already explored the codebase, do so to understand the current state of the code. Ticket titles and descriptions should use the project's domain glossary vocabulary, and respect ADRs in the area you're touching.
Look for opportunities to prefactor the code to make the implementation easier. "Make the change easy, then make the easy change."
### 3. Draft vertical slices
Break the work into **tracer bullet** tickets.
<vertical-slice-rules>
- Each slice cuts a narrow but COMPLETE path through every layer (schema, API, UI, tests): vertical, NOT a horizontal slice of one layer
- A completed slice is demoable or verifiable on its own
- Each slice is sized to fit in a single fresh context window
- Any prefactoring should be done first
</vertical-slice-rules>
Give each ticket its **blocking edges**: the other tickets that must complete before it can start. A ticket with no blockers can start immediately.
**Wide refactors are the exception to vertical slicing.** A **wide refactor** is one mechanical change (rename a column, retype a shared symbol) whose **blast radius** fans across the whole codebase, so a single edit breaks thousands of call sites at once and no vertical slice can land green. Don't force it into a tracer bullet; sequence it as **expand–contract**. First expand: add the new form beside the old so nothing breaks. Then migrate the call sites over in batches sized by blast radius (per package, per directory), each batch its own ticket blocked by the expand, keeping CI green batch to batch because the old form still exists. Finally contract: delete the old form once no caller remains, in a ticket blocked by every migrate batch. When even the batches can't stay green alone, keep the sequence but let them share an integration branch that all block a final integrate-and-verify ticket; green is promised only there.
### 4. Quiz the user
Present the proposed breakdown as a numbered list. For each ticket, show:
- **Title**: short descriptive name
- **Blocked by**: which other tickets (if any) must complete first
- **What it delivers**: the end-to-end behaviour this ticket makes work
Ask the user:
- Does the granularity feel right? (too coarse / too fine)
- Are the blocking edges correct: does each ticket only depend on tickets that genuinely gate it?
- Should any tickets be merged or split further?
Iterate until the user approves the breakdown.
### 5. Publish the tickets to the configured tracker
Publish the approved tickets. **How** depends on the tracker `/setup-matt-pocock-skills` configured; the tickets are the same either way, only the shape of the blocking edges changes:
- **Local files** → write one file per ticket under `.scratch/<feature-slug>/issues/<NN>-<slug>.md`, numbered from `01` in dependency order (blockers first). Each file's "Blocked by" lists the numbers/titles it depends on. Use the per-ticket file template below: one ticket per file, never a single combined file.
- **A real issue tracker (GitHub, Linear, …)** → publish one issue per ticket in dependency order (blockers first) so each ticket's blocking edges can reference real identifiers. Use the platform's native blocking relationship where it has one; otherwise set each ticket's "Blocked by" to the blocking issues. If the source was an existing issue, make each ticket its sub-issue (tracker doc's operation). Apply the `ready-for-agent` triage label unless instructed otherwise; the tickets are agent-grabbable by construction.
Work the **frontier**: any ticket whose blockers are all done. For a purely linear chain that means top to bottom.
Do NOT close or modify any parent issue.
<local-ticket-template>
# <NN>: <Ticket title>
**What to build:** the end-to-end behaviour this ticket makes work, from the user's perspective, not a layer-by-layer implementation list.
**Blocked by:** the numbers/titles of the tickets that gate this one, or "None (can start immediately)".
**Status:** ready-for-agent
- [ ] Acceptance criterion 1
- [ ] Acceptance criterion 2
</local-ticket-template>
<issue-template>
## Parent
A reference to the parent issue on the tracker (if the source was an existing issue, otherwise omit this section).
## What to build
The end-to-end behaviour this ticket makes work, from the user's perspective, not layer-by-layer implementation.
## Acceptance criteria
- [ ] Criterion 1
- [ ] Criterion 2
## Blocked by
- A reference to each blocking ticket, or "None (can start immediately)". Omit this section when blockers were set as native edges.
</issue-template>
In either form, avoid specific file paths or code snippets: they go stale fast. Exception: if a prototype produced a snippet that encodes a decision more precisely than prose can (state machine, reducer, schema, type shape), inline it and note briefly that it came from a prototype. Trim to the decision-rich parts, not a working demo, just the important bits.

View file

@ -1,5 +0,0 @@
interface:
display_name: "To Tickets"
short_description: "Split a plan into tracer-bullet tickets"
policy:
allow_implicit_invocation: false

View file

@ -1,207 +0,0 @@
# Writing Agent Briefs
An agent brief is a structured comment posted on a GitHub issue or PR when it moves to `ready-for-agent`. It is the authoritative specification that an AFK agent will work from. The original body and discussion are context: the agent brief is the contract.
The brief states **what the agent should do**, which stretches to both surfaces: for an issue, that's building the change from nothing; for a PR, it's what's left to do *to the existing diff*: finish it, close gaps, address review points. Same principles either way; the PR example below shows the difference.
## Principles
### Durability over precision
The issue may sit in `ready-for-agent` for days or weeks. The codebase will change in the meantime. Write the brief so it stays useful even as files are renamed, moved, or refactored.
- **Do** describe interfaces, types, and behavioral contracts
- **Do** name specific types, function signatures, or config shapes that the agent should look for or modify
- **Don't** reference file paths: they go stale
- **Don't** reference line numbers
- **Don't** assume the current implementation structure will remain the same
### Behavioral, not procedural
Describe **what** the system should do, not **how** to implement it. The agent will explore the codebase fresh and make its own implementation decisions.
- **Good:** "The `SkillConfig` type should accept an optional `schedule` field of type `CronExpression`"
- **Bad:** "Open src/types/skill.ts and add a schedule field on line 42"
- **Good:** "When a user runs `/triage` with no arguments, they should see a summary of issues needing attention"
- **Bad:** "Add a switch statement in the main handler function"
### Complete acceptance criteria
The agent needs to know when it's done. Every agent brief must have concrete, testable acceptance criteria. Each criterion should be independently verifiable.
- **Good:** "Running `gh issue list --label needs-triage` returns issues that have been through initial classification"
- **Bad:** "Triage should work correctly"
### Explicit scope boundaries
State what is out of scope. This prevents the agent from gold-plating or making assumptions about adjacent features.
## Template
```markdown
## Agent Brief
**Category:** bug / enhancement
**Summary:** one-line description of what needs to happen
**Current behavior:**
Describe what happens now. For bugs, this is the broken behavior.
For enhancements, this is the status quo the feature builds on.
**Desired behavior:**
Describe what should happen after the agent's work is complete.
Be specific about edge cases and error conditions.
**Key interfaces:**
- `TypeName`: what needs to change and why
- `functionName()` return type: what it currently returns vs what it should return
- Config shape: any new configuration options needed
**Acceptance criteria:**
- [ ] Specific, testable criterion 1
- [ ] Specific, testable criterion 2
- [ ] Specific, testable criterion 3
**Out of scope:**
- Thing that should NOT be changed or addressed in this issue
- Adjacent feature that might seem related but is separate
```
## Examples
### Good agent brief (bug)
```markdown
## Agent Brief
**Category:** bug
**Summary:** Skill description truncation drops mid-word, producing broken output
**Current behavior:**
When a skill description exceeds 1024 characters, it is truncated at exactly
1024 characters regardless of word boundaries. This produces descriptions
that end mid-word (e.g. "Use when the user wants to confi").
**Desired behavior:**
Truncation should break at the last word boundary before 1024 characters
and append "..." to indicate truncation.
**Key interfaces:**
- The `SkillMetadata` type's `description` field: no type change needed,
but the validation/processing logic that populates it needs to respect
word boundaries
- Any function that reads SKILL.md frontmatter and extracts the description
**Acceptance criteria:**
- [ ] Descriptions under 1024 chars are unchanged
- [ ] Descriptions over 1024 chars are truncated at the last word boundary
before 1024 chars
- [ ] Truncated descriptions end with "..."
- [ ] The total length including "..." does not exceed 1024 chars
**Out of scope:**
- Changing the 1024 char limit itself
- Multi-line description support
```
### Good agent brief (enhancement)
```markdown
## Agent Brief
**Category:** enhancement
**Summary:** Add `.out-of-scope/` directory support for tracking rejected feature requests
**Current behavior:**
When a feature request is rejected, the issue is closed with a `wontfix` label
and a comment. There is no persistent record of the decision or reasoning.
Future similar requests require the maintainer to recall or search for the
prior discussion.
**Desired behavior:**
Rejected feature requests should be documented in `.out-of-scope/<concept>.md`
files that capture the decision, reasoning, and links to all issues that
requested the feature. When triaging new issues, these files should be
checked for matches.
**Key interfaces:**
- Markdown file format in `.out-of-scope/`: each file should have a
`# Concept Name` heading, a `**Decision:**` line, a `**Reason:**` line,
and a `**Prior requests:**` list with issue links
- The triage workflow should read all `.out-of-scope/*.md` files early
and match incoming issues against them by concept similarity
**Acceptance criteria:**
- [ ] Closing a feature as wontfix creates/updates a file in `.out-of-scope/`
- [ ] The file includes the decision, reasoning, and link to the closed issue
- [ ] If a matching `.out-of-scope/` file already exists, the new issue is
appended to its "Prior requests" list rather than creating a duplicate
- [ ] During triage, existing `.out-of-scope/` files are checked and surfaced
when a new issue matches a prior rejection
**Out of scope:**
- Automated matching (human confirms the match)
- Reopening previously rejected features
- Bug reports (only enhancement rejections go to `.out-of-scope/`)
```
### Good agent brief (PR)
For a PR, "Current behavior" describes the state of the diff, and the brief asks the agent to finish or fix it rather than build from scratch.
```markdown
## Agent Brief
**Category:** enhancement
**Summary:** Finish the contributor's `--json` output flag for `triage list`
**Current behavior:**
The PR adds a `--json` flag that serializes the issue list to JSON. The happy
path works and the diff matches the project's command structure. Two gaps
remain: errors are still printed as human text (not JSON), and the new flag has
no test coverage.
**Desired behavior:**
With `--json`, all output (including errors) is well-formed JSON on stdout,
and the command's exit codes are unchanged. The existing human-readable output
is untouched when the flag is absent.
**Key interfaces:**
- The command's error path should emit `{ "error": string }` under `--json`
instead of the plain-text error
- Reuse the existing serializer the PR already added; don't introduce a second
**Acceptance criteria:**
- [ ] `triage list --json` emits valid JSON for both success and error cases
- [ ] Exit codes match the non-JSON command
- [ ] A test covers the `--json` success output and one error case
- [ ] Default (non-JSON) output is byte-for-byte unchanged
**Out of scope:**
- Adding `--json` to any other command
- Changing the JSON shape of the success payload the PR already defined
```
### Bad agent brief
```markdown
## Agent Brief
**Summary:** Fix the triage bug
**What to do:**
The triage thing is broken. Look at the main file and fix it.
The function around line 150 has the issue.
**Files to change:**
- src/triage/handler.ts (line 150)
- src/types.ts (line 42)
```
This is bad because:
- No category
- Vague description ("the triage thing is broken")
- References file paths and line numbers that will go stale
- No acceptance criteria
- No scope boundaries
- No description of current vs desired behavior

View file

@ -1,105 +0,0 @@
# Out-of-Scope Knowledge Base
The `.out-of-scope/` directory in a repo stores persistent records of rejected feature requests. It serves two purposes:
1. **Institutional memory**: why a feature was rejected, so the reasoning isn't lost when the issue is closed
2. **Deduplication**: when a new issue comes in that matches a prior rejection, the skill can surface the previous decision instead of re-litigating it
## Directory structure
```
.out-of-scope/
├── dark-mode.md
├── plugin-system.md
└── graphql-api.md
```
One file per **concept**, not per issue. Multiple issues requesting the same thing are grouped under one file.
## File format
The file should be written in a relaxed, readable style, more like a short design document than a database entry. Use paragraphs, code samples, and examples to make the reasoning clear and useful to someone encountering it for the first time.
```markdown
# Dark Mode
This project does not support dark mode or user-facing theming.
## Why this is out of scope
The rendering pipeline assumes a single color palette defined in
`ThemeConfig`. Supporting multiple themes would require:
- A theme context provider wrapping the entire component tree
- Per-component theme-aware style resolution
- A persistence layer for user theme preferences
This is a significant architectural change that doesn't align with the
project's focus on content authoring. Theming is a concern for downstream
consumers who embed or redistribute the output.
```ts
// The current ThemeConfig interface is not designed for runtime switching:
interface ThemeConfig {
colors: ColorPalette; // single palette, resolved at build time
fonts: FontStack;
}
```
## Prior requests
- #42: "Add dark mode support"
- #87: "Night theme for accessibility"
- #134: "Dark theme option"
```
### Naming the file
Use a short, descriptive kebab-case name for the concept: `dark-mode.md`, `plugin-system.md`, `graphql-api.md`. The name should be recognizable enough that someone browsing the directory understands what was rejected without opening the file.
### Writing the reason
The reason should be substantive: not "we don't want this" but why. Good reasons reference:
- Project scope or philosophy ("This project focuses on X; theming is a downstream concern")
- Technical constraints ("Supporting this would require Y, which conflicts with our Z architecture")
- Strategic decisions ("We chose to use A instead of B because...")
The reason should be durable. Avoid referencing temporary circumstances ("we're too busy right now"); those aren't real rejections, they're deferrals.
## When to check `.out-of-scope/`
During triage (Step 1: Gather context), read all files in `.out-of-scope/`. When evaluating a new issue:
- Check if the request matches an existing out-of-scope concept
- Matching is by concept similarity, not keyword: "night theme" matches `dark-mode.md`
- If there's a match, surface it to the maintainer: "This is similar to `.out-of-scope/dark-mode.md`. We rejected this before because [reason]. Do you still feel the same way?"
The maintainer may:
- **Confirm**: the new issue gets added to the existing file's "Prior requests" list, then closed
- **Reconsider**: the out-of-scope file gets deleted or updated, and the issue proceeds through normal triage
- **Disagree**: the issues are related but distinct, proceed with normal triage
## When to write to `.out-of-scope/`
Only when an **enhancement** (not a bug) is *rejected* as `wontfix`. This applies to enhancement PRs exactly as it does to issues: a rejected PR is recorded here so the same request doesn't return as fresh code.
Do **not** write here when something is closed as `wontfix` because it's **already implemented**. That's a built feature, not a rejected one; recording it would poison the dedup checks with false rejections. Instead, the closing comment points to where the feature already lives.
The flow:
1. Maintainer decides a feature request is out of scope
2. Check if a matching `.out-of-scope/` file already exists
3. If yes: append the new issue to the "Prior requests" list
4. If no: create a new file with the concept name, decision, reason, and first prior request
5. Post a comment on the issue explaining the decision and mentioning the `.out-of-scope/` file
6. Close the issue with the `wontfix` label
## Updating or removing out-of-scope files
If the maintainer changes their mind about a previously rejected concept:
- Delete the `.out-of-scope/` file
- The skill does not need to reopen old issues; they're historical records
- The new issue that triggered the reconsideration proceeds through normal triage

View file

@ -1,112 +0,0 @@
---
name: triage
description: Move issues and external PRs through a state machine of triage roles, categorise, verify, grill if needed, and write agent-ready briefs.
disable-model-invocation: true
---
# Triage
Move issues on the project issue tracker through a small state machine of triage roles.
If this repo treats external pull requests as a request surface (see the issue-tracker config), triage covers them too: **a PR is an issue with attached code**, using the same roles, same states, and same machine, with a few deltas marked "for a PR" below. Resolve a bare `#42` to an issue or PR per the tracker config.
Every comment or issue posted to the issue tracker during triage **must** start with this disclaimer:
```
> *This was generated by AI during triage.*
```
## Reference docs
- [AGENT-BRIEF.md](AGENT-BRIEF.md): how to write durable agent briefs
- [OUT-OF-SCOPE.md](OUT-OF-SCOPE.md): how the `.out-of-scope/` knowledge base works
## Roles
Two **category** roles:
- `bug`: something is broken
- `enhancement`: new feature or improvement
Five **state** roles:
- `needs-triage`: maintainer needs to evaluate
- `needs-info`: waiting on reporter for more information
- `ready-for-agent`: fully specified, ready for an AFK agent
- `ready-for-human`: needs human implementation
- `wontfix`: will not be actioned
For a PR, the same states read against the attached code: `ready-for-agent` means a brief is attached and an agent should take the next step on the diff; `ready-for-human` means it's ready for a human to merge.
Every triaged issue should carry exactly one category role and one state role. If state roles conflict, flag it and ask the maintainer before doing anything else.
These are canonical role names. The actual label strings used in the issue tracker may differ. The mapping should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`.
State transitions: an unlabeled issue normally goes to `needs-triage` first; from there it moves to `needs-info`, `ready-for-agent`, `ready-for-human`, or `wontfix`. `needs-info` returns to `needs-triage` once the reporter replies. The maintainer can override at any time; flag transitions that look unusual and ask before proceeding.
## Invocation
The maintainer invokes `/triage` and describes what they want in natural language. Interpret the request and act. Examples:
- "Show me anything that needs my attention"
- "Let's look at #42" (issue or PR)
- "Move #42 to ready-for-agent"
- "What's ready for agents to pick up?"
## Show what needs attention
Query the issue tracker and present three buckets, oldest first:
1. **Unlabeled**: never triaged.
2. **`needs-triage`**: evaluation in progress.
3. **`needs-info` with reporter activity since the last triage notes**: needs re-evaluation.
When PRs are in scope, include external PRs in these buckets and tag each line `[PR]` or `[issue]`. Discovery surfaces only *external* PRs (the tracker config defines who counts as external), so a collaborator's in-flight PR is not triage work. This filter is discovery-only; an explicitly named PR is always triaged regardless of author.
Show counts and a one-line summary per item. Let the maintainer pick.
## Triage a specific issue or PR
1. **Gather context.** Read the full issue or PR (body, comments, labels, author, dates; for a PR, the diff too). Parse any prior triage notes so you don't re-ask resolved questions. Explore the codebase using the project's domain glossary, respecting ADRs in the area. Run two checks against the codebase: (a) **redundancy**: search for an existing implementation of the requested behavior by domain concept (not just the request's wording), and report where you looked. If found, it's an already-implemented `wontfix` (step 5). (b) **prior rejection**: read `.out-of-scope/*.md` and surface any that resembles this request.
2. **Recommend.** Tell the maintainer your category and state recommendation with reasoning, plus a brief codebase summary relevant to the request (including whether it's already implemented). Wait for direction.
3. **Verify the claim.** Before any grilling, check that the claim holds up. For a bug, reproduce it from the reporter's steps. For a PR, confirm the diff does what it claims: check it out, run the relevant tests or commands. Report what happened: confirmed (with code path), failed, or insufficient detail (a strong `needs-info` signal). A confirmed verification makes a much stronger agent brief.
4. **Grill (if needed).** If the request needs fleshing out, call the Skill tool twice, for "grilling" and "domain-modeling", and grill it into shape a round of questions at a time, sharpening domain terms and updating `GLOSSARY.md`/ADRs inline as decisions land.
5. **Apply the outcome:**
- `ready-for-agent`: post an agent brief comment ([AGENT-BRIEF.md](AGENT-BRIEF.md)).
- `ready-for-human`: same structure as an agent brief, but note why it can't be delegated (judgment calls, external access, design decisions, manual testing).
- `needs-info`: post triage notes (template below).
- For `wontfix`, close the issue, with the comment depending on *why*:
- **Already implemented**: the change already exists in the codebase. Point to where it lives; do **not** write to `.out-of-scope/` (that KB is for *rejected* requests, not built ones).
- **Rejected (bug)**: give a polite explanation, then close.
- **Rejected (enhancement)**: write to `.out-of-scope/`, link to it from a comment, then close ([OUT-OF-SCOPE.md](OUT-OF-SCOPE.md)).
- `needs-triage`: apply the role. Optional comment if there's partial progress.
## Quick state override
If the maintainer says "move #42 to ready-for-agent", trust them and apply the role directly. Confirm what you're about to do (role changes, comment, close), then act. Skip grilling. If moving to `ready-for-agent` without a grilling session, ask whether they want to write an agent brief.
## Needs-info template
```markdown
## Triage Notes
**What we've established so far:**
- point 1
- point 2
**What we still need from you (@reporter):**
- question 1
- question 2
```
Capture everything resolved during grilling under "established so far" so the work isn't lost. Questions must be specific and actionable, not "please provide more info".
## Resuming a previous session
If prior triage notes exist on the issue or PR, read them, check whether the reporter has answered any outstanding questions, and present an updated picture before continuing. Don't re-ask resolved questions.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Triage"
short_description: "Move issues through triage roles"
policy:
allow_implicit_invocation: false

View file

@ -1,7 +0,0 @@
---
name: wait-what
description: "Stop. That last message did not land: re-pitch it."
disable-model-invocation: true
---
Wait, I don't understand where you've got to here. Re-pitch that: give me a little bit of context, talk in ASD-STE100 Simplified Technical English, and use the ubiquitous language from `GLOSSARY.md` (follow `GLOSSARY-MAP.md` to the right one if the repo has more than one).

View file

@ -1,5 +0,0 @@
interface:
display_name: "Wait What"
short_description: "Re-pitch that: simpler, with the context I'm missing"
policy:
allow_implicit_invocation: false

View file

@ -1,128 +0,0 @@
---
name: wayfinder
description: Plan a huge chunk of work (more than one agent session can hold) as a shared map of decision tickets on your issue tracker, and resolve them one at a time until the way to the destination is clear.
disable-model-invocation: true
---
A loose idea has arrived, too big for one agent session, and wrapped in fog: the way from here to the **destination** isn't visible yet. Wayfinding is about finding that way, not charging at the destination. This skill charts the way as a **shared map** on the repo's issue tracker, then works its **decision tickets** (questions whose resolution is a decision, not slices of a build to execute) one at a time until the route is clear.
The destination varies per effort, and naming it is the first act of charting: it shapes every ticket. It might be a spec to hand off and iterate on, a decision to lock before planning starts, or a change made in place like a data-structure migration. The map is domain-agnostic: engineering work, course content, whatever fits the shape.
## Plan, don't do
Wayfinder is **planning** by default: each ticket resolves a decision, and the map is done when the way is clear, with nothing left to decide before someone goes and does the thing. The pull to just do the work is usually the signal you've reached the edge of the map and it's time to hand off. An effort can override this in its **Notes**, carrying execution into the map itself, but absent that, produce decisions, not deliverables.
## Refer by name
Every map and ticket is an issue, so it has a **name**: its title. In everything the human reads (narration, the map's Decisions-so-far), refer to it by that name, never by a bare id, number, or slug. A wall of `#42, #43, #44` is illegible; names read at a glance. The id and URL don't vanish; a name wraps its link, but they ride _inside_ the name, never stand in for it.
## The Map
The map is a single issue on this repo's issue tracker, labelled `wayfinder:map`, the canonical artifact. Its tickets are child issues of the map.
The map is an **index**, not a store. It lists the decisions made and points at the tickets that hold their detail; a decision lives in exactly one place, its ticket, so the map never restates it, only gists it and links.
**Where the map, its child tickets, blocking, and frontier queries physically live is tracker-specific.** The issue tracker should have been provided to you. If not, tell the user to run `/setup-matt-pocock-skills`. Consult the tracker doc's "Wayfinding operations" section for how _this_ repo expresses them. If no tracker has been provided, default to the local-markdown tracker.
### The map body
The whole map at low resolution, loaded once per session. Open tickets are **not** listed: they are open child issues, found by query.
```markdown
## Destination
<what reaching the end of this map looks like: the spec, decision, or change this effort is finding its way to. One or two lines; every session orients to it before choosing a ticket.>
## Notes
<domain; skills every session should consult; standing preferences for this effort>
## Decisions so far
<!-- the index: one line per closed ticket, enough to judge relevance, then zoom the link for the detail the ticket holds -->
- [<closed ticket title>](link): <one-line gist of the answer>
## Not yet specified
<!-- see "Fog of war": in-scope fog you can't ticket yet; graduates as the frontier advances -->
## Out of scope
<!-- see "Out of scope": work ruled beyond the destination; closed, never graduates -->
```
### Tickets
Each ticket is a **child issue** of the map; the tracker's issue id is its identity. Its body is the question, sized to one 100K token agent session:
```markdown
## Question
<the decision or investigation this ticket resolves>
```
Each ticket carries a `wayfinder:<type>` label, one of `research`, `prototype`, `grilling`, `task` (see [Ticket Types](#ticket-types)). `wayfinder:` labels are the only labels a map and its tickets carry, never a triage label like `ready-for-agent`: they are decisions, not implementation work.
A session **claims** a ticket by assigning it to the dev driving the map, **first**, before any work, so concurrent sessions skip it. That assignee _is_ the claim: an open, unassigned ticket is unclaimed.
Blocking uses the tracker's **native** dependency relationship: essential because it renders the frontier _visually_ in the tracker's own UI, so the human sees what's takeable without opening the map. Only a tracker that lacks native blocking falls back to a body convention. A ticket is **unblocked** when every ticket blocking it is closed; the **frontier** is the open, unblocked, unclaimed children, the edge of the known.
The answer isn't part of the body; it's recorded on resolution (see [Work through the map](#work-through-the-map)). Assets created while resolving a ticket are linked from the issue, not pasted in.
## Ticket Types
Every ticket is either **HITL** (human in the loop, worked _with_ a human who speaks for themselves) or **AFK**, driven by the agent alone. A HITL ticket only resolves through that live exchange; the agent never stands in for the human's side of it (a grilling agent that answers its own questions has broken this).
- **Research** (AFK): Reading documentation, third-party APIs, or local resources like knowledge bases to surface a fact a decision waits on. Resolved by a subagent that calls the Skill tool with "research". Use when knowledge outside the current working directory is required.
- **Prototype** (HITL): Raise the fidelity of the discussion by making a cheap, rough, concrete artifact to react to (an outline, a rough take, a stub, or UI/logic code) by calling the Skill tool with "prototype". Links the prototype as an asset. Use when "how should it look" or "how should it behave" is the key question.
- **Grilling** (HITL): Conversation. The default case. Always call the Skill tool twice, for "grilling" and "domain-modeling".
- **Task** (HITL or AFK): Manual work that must happen before a _decision_ can be made: nothing to decide, prototype, or research, but the discussion is blocked until it's done. Signing up for a service so its API can be judged, provisioning access, moving data so its shape can be seen. This is the one type that _does_ rather than decides, and it earns its place by unblocking a decision, not by delivering the destination. The agent drives it alone where it can (AFK); otherwise it hands the human a precise checklist (HITL). Resolved when the work is done; the answer records what was done and any resulting facts (credentials location, new URLs, row counts) later tickets depend on.
## Fog of war
The map is _deliberately_ incomplete: don't chart what you can't yet see. Beyond the live tickets lies the **fog of war**: the dim view of decisions and investigations you can tell are coming but can't yet pin down, because they hang on questions still open. Resolving a ticket clears the fog ahead of it, graduating whatever's now specifiable into fresh tickets, one at a time, until the way to the destination is clear and no tickets remain.
The map's **Not yet specified** section is where that dim view is written down: the suspected question, the area to revisit later. It's the undiscovered frontier _toward_ the destination: everything here is in scope, just not sharp enough to ticket. Write as loosely or as fully as the view allows; it doubles as a signpost for collaborators reading where the effort is headed.
**Fog or ticket?** The test is whether you can state the question precisely now, _not_ whether you can answer it now.
- **Ticket when** the question is already sharp, even if it's blocked and you can't act on it yet.
- **Not yet specified when** you can't yet phrase it that sharply. Don't pre-slice the fog into ticket-sized pieces: it's coarser than a ticket, and one patch may graduate into several tickets, or none, once the frontier reaches it.
**Not yet specified** excludes what's already decided (Decisions so far), what's already a live ticket, and what's out of scope (the next section).
## Out of scope
Fog only ever gathers _toward_ the destination. The destination fixes the scope, so work beyond it is **out of scope**: it isn't fog, and it doesn't belong in **Not yet specified**. It gets its own **Out of scope** section on the map: work you've consciously ruled out of _this_ effort. Scope, not sharpness, lands it here.
Out-of-scope work never graduates (the frontier stops at the destination), so it returns only if the destination is redrawn, and then as a fresh effort, not a resumption.
Ruling something out of scope is a scoping act, not a step on the route. When a ticket that already exists turns out to sit past the destination (mis-scoped in while charting, or exposed by a resolution), **close it** (a closed ticket is unambiguously off the frontier) and leave one line in the **Out of scope** section: the gist plus why it's out of scope, linking the closed ticket. It stays out of **Decisions so far**, which records the route actually walked; a scope boundary isn't a step on it.
## Invocation
Two modes. Either way, **never resolve more than one ticket per session**, with the exception of research tickets.
### Chart the map
User invokes with a loose idea.
1. **Name the destination.** Call the Skill tool twice, for "grilling" and "domain-modeling", to pin down what this map is finding its way to: the spec, decision, or change. The destination fixes the scope, so it's settled first.
2. **Map the frontier.** Grill again, **breadth-first** this time: fan out across the whole space rather than deep on any one thread, surfacing the open decisions and the first steps takeable now. **If this surfaces no fog** (the way to the destination is already clear, the whole journey small enough for one session), you don't need a map. Stop and ask the user how they'd like to proceed.
3. **Create the map** (label `wayfinder:map`): Destination and Notes filled in, Decisions-so-far empty, the fog sketched into **Not yet specified**.
4. **Create the tickets you can specify now** as child issues of the map, then wire blocking edges in a **second pass** (issues need ids before they can reference each other). Write cross-references in that pass too, with real ids: a placeholder `#<n>` auto-links to an unrelated issue. Wiring sorts them into the frontier and the blocked; everything you can't yet specify stays in the fog: the **Not yet specified** section.
5. **Fire the research subagents.** For each `research` ticket you just created, spin up a subagent that calls the Skill tool with "research" to resolve it in parallel, capturing its findings on a throwaway `research/<name>` branch with a context pointer from the ticket. Push the branch but open no PR: it is never merged.
6. Stop: charting is one session's work; it hand-resolves nothing.
### Work through the map
User invokes with a map (URL or number). A ticket is **optional**: without one, you pick the next decision, not the user.
1. Load the **map**: the low-res view, not every ticket body.
2. Choose the ticket. If the user named one, use it. Otherwise take the first frontier ticket in order. **Claim it**: assign it to yourself before any work.
3. Resolve it as the type its `wayfinder:<type>` label names (see [Ticket Types](#ticket-types)). Read the label, not just the body: the body never states the type. **Zoom as needed**: fetch the full body of any related or closed ticket on demand; call the Skill tool for whichever skills the `## Notes` block names. If in doubt, call the Skill tool twice, for "grilling" and "domain-modeling".
4. Record the resolution: post the answer as a **resolution comment**, **close** the issue, and **append a context pointer** to the map's Decisions-so-far.
5. Add newly-surfaced tickets (create-then-wire); graduate any fog the answer has made specifiable, clearing each graduated patch from **Not yet specified** so it lives only as its new ticket. If the answer reveals that a ticket (this one or another) sits beyond the destination, **rule it out of scope** rather than resolving it on the route. If the decision invalidates other parts of the map, update or delete those tickets.
The user may run unblocked tickets in parallel, so expect other sessions to be editing the tracker concurrently.

View file

@ -1,5 +0,0 @@
interface:
display_name: "Wayfinder"
short_description: "Map a large effort as decision tickets"
policy:
allow_implicit_invocation: false

View file

@ -1,44 +0,0 @@
---
name: wizard
description: Generate an interactive bash wizard that walks a human through steps only they can perform. Use when provisioning infrastructure, setting up credentials or CI secrets, walking an unfamiliar third-party dashboard, or running a one-off migration or cutover. Don't invoke this for steps the agent can perform itself.
---
# Wizard
A **wizard** is a bash script that walks a human, step by step, through a manual procedure that's tedious to do by hand and tedious to re-explain to an AI every time. It opens each URL, says exactly what to click and copy, captures the values, writes them where they belong (`.env`, GitHub secrets), confirms at every stage, and shows how many stages are left. It might configure third-party services, run a one-off migration, or move the project from one state to another.
The delightful UX is already solved by [template.sh](template.sh): stage-by-stage progress, confirmation gates, cross-platform URL opening (including WSL), hidden secret entry, idempotent `.env` upserts, `gh secret`/`gh variable` writes, and a closing summary. **Your job is only to scope the procedure and author its stages.** The library above the `STAGES` marker is identical in every wizard; that consistency is the point: never hand-edit it.
A wizard is ephemeral by default: built for one run, saved to a scratch or `scripts/` path, deleted when the job's done. Commit it only when the user wants a repeatable setup path that should live in the repo.
## Process
### 1. Scope the procedure
Work out every manual step the human must take and every value that gets captured along the way. Read the repo first, don't ask cold:
- For setup: `.env`, `.env.example`, `.env.*`, `README`, `docker-compose*`, framework config, and `.github/workflows/*` (every `secrets.*` / `vars.*` reference is a value the wizard must produce).
- For a migration or transition: the current state, the target state, and the irreversible actions between them.
Then show the user the ordered list of stages and the values each produces, and confirm: they may add, drop, or reorder.
**Done when:** every stage is named in order, and for each captured value you know (a) where the human gets it, (b) where it's written (`.env`, a GitHub secret, both, or nowhere; some stages are pure actions), and (c) whether it's secret (hidden entry) or public.
### 2. Map each stage's journey
For each stage, write the precise path a human follows: which URL to open, what to do there, where a value is shown, which variable it fills: e.g. "Dashboard → Developers → API keys → Reveal test key → copy". Where you don't actually know the current UI or the exact command, say so and ask the user or check the docs: never invent steps that may not exist.
**Done when:** every stage traces to concrete instructions a stranger could follow.
### 3. Author the wizard
Copy `template.sh` to the target path. Replace the example stage with one `stage` per step, in dependency order. Use the library helpers: `stage`, `say`/`step`, `open_url`, `ask`/`ask_secret`, `write_env`, `set_secret`/`set_var`, `pause`/`confirm`. Set `TOTAL_STAGES` to the number of stages you wrote.
Hold the bar the template sets: open the URL before asking for its value, use `ask_secret` for anything secret, `write_env` every persisted value, `set_secret` only the values CI actually needs, and `confirm` before any irreversible action. Each `stage` clears the screen so only the current step is visible: keep a stage to one focused task so nothing the human needs scrolls away. Don't touch the library above the marker.
### 4. Verify and hand off
- `bash -n <script>`; run `shellcheck` if available.
- `chmod +x <script>`.
- Don't run it end-to-end yourself: it opens browsers and blocks on human input. Trace it statically instead: every value from step 1 is captured and lands where step 1 said, and every `set_secret` name exactly matches a `secrets.*` reference in CI.
- Tell the user how to run it. If it's a repeatable setup path, commit it and link it from the README so the next person runs the script instead of asking an AI.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Wizard"
short_description: "Generate an interactive setup wizard"

View file

@ -1,223 +0,0 @@
#!/usr/bin/env bash
#
# A wizard walks a human through a manual procedure, step by step.
# Generated by the /wizard skill.
#
# Everything above the "STAGES" marker is the wizard library: do not hand-edit
# it. Author the per-step stages below the marker.
set -euo pipefail
# ──────────────────────────────────────────────────────────────────────────
# Wizard library: delightful, consistent UX, identical across every wizard.
# ──────────────────────────────────────────────────────────────────────────
if [[ -t 1 ]] && command -v tput >/dev/null 2>&1 && [[ "$(tput colors 2>/dev/null || echo 0)" -ge 8 ]]; then
BOLD=$(tput bold); DIM=$(tput dim); RESET=$(tput sgr0)
BLUE=$(tput setaf 4); GREEN=$(tput setaf 2); YELLOW=$(tput setaf 3)
else
BOLD=""; DIM=""; RESET=""; BLUE=""; GREEN=""; YELLOW=""
fi
# Author sets this at the top of the stages section.
TOTAL_STAGES=0
_STAGE_INDEX=0
ENV_FILE="${ENV_FILE:-.env}"
WRITTEN_ENV=() # KEYs written to ENV_FILE this run
WRITTEN_SECRET=() # secret NAMEs set this run
SKIPPED=() # things we couldn't do (e.g. gh missing)
# _clear wipes the terminal so only the current step is on screen. No-op when
# output isn't a terminal, so piped logs stay readable.
_clear() {
[[ -t 1 ]] || return 0
if command -v tput >/dev/null 2>&1 && tput clear 2>/dev/null; then return 0; fi
printf '\033[2J\033[3J\033[H'
}
# banner "Title" shows the opening frame: what this wizard does.
banner() {
_clear
printf '\n%s%s %s%s\n' "$BOLD" "$BLUE" "$1" "$RESET"
printf '%s %s stages%s\n\n' "$DIM" "$TOTAL_STAGES" "$RESET"
printf '%s You drive the browser; this wizard tells you exactly what to do and\n' "$DIM"
printf ' captures the values you copy back. Stop any time with Ctrl-C and re-run\n'
printf ' later, since it remembers values already saved.%s\n' "$RESET"
pause "Ready to start?"
}
# stage "Name" clears the screen, then announces a stage and shows progress.
# Clearing keeps only the current step on screen.
stage() {
_clear
_STAGE_INDEX=$((_STAGE_INDEX + 1))
printf '\n%s%s▸ Stage %s/%s · %s%s\n' \
"$BOLD" "$BLUE" "$_STAGE_INDEX" "$TOTAL_STAGES" "$1" "$RESET"
}
# say "..." prints a plain instruction line.
say() { printf ' %s\n' "$1"; }
# step "..." is a numbered-feeling action the human takes in the browser.
step() { printf ' %s•%s %s\n' "$BLUE" "$RESET" "$1"; }
note() { printf ' %s%s%s\n' "$DIM" "$1" "$RESET"; }
warn() { printf ' %s⚠ %s%s\n' "$YELLOW" "$1" "$RESET"; }
# open_url URL opens it in the human's browser, cross-platform incl. WSL.
open_url() {
local url="$1"
printf ' %s↗ opening%s %s\n' "$GREEN" "$RESET" "$url"
{ if command -v wslview >/dev/null 2>&1; then wslview "$url"
elif command -v explorer.exe >/dev/null 2>&1; then explorer.exe "$url"
elif command -v xdg-open >/dev/null 2>&1; then xdg-open "$url"
elif command -v open >/dev/null 2>&1; then open "$url"
else false; fi
} >/dev/null 2>&1 || warn "couldn't open a browser, so visit it manually: $url"
}
# pause "msg" waits for the human to confirm they've done the manual part.
pause() {
printf ' %s%s%s ' "$DIM" "${1:-Press Enter to continue}" "$RESET"
read -r _ || true
}
# confirm "question" is a y/N gate; returns success on yes.
confirm() {
local reply=""
printf ' %s? %s [y/N] ' "$YELLOW" "$1"
read -r reply || true
[[ "$reply" =~ ^[Yy] ]]
}
# _existing KEY: current value of KEY in ENV_FILE, if any, with write_env's single
# quotes or a plain dotenv double-quoted value undone.
_existing() {
[[ -f "$ENV_FILE" ]] || return 1
local line value sq="'\\''"; line=$(grep -E "^${1}=" "$ENV_FILE" | tail -n1) || return 1
value="${line#*=}"
if [[ "$value" == \'*\' ]]; then value="${value:1:${#value}-2}"; value="${value//"$sq"/\'}"
elif [[ "$value" == \"*\" ]]; then
value="${value:1:${#value}-2}"
[[ "$value" == *[\\\$\"]* ]] && return 1 # escapes, $ or ": can't decode safely; ask again
fi
printf '%s' "$value"
}
# ask KEY "Prompt" reads a value into $KEY. Offers the existing .env value as
# a default on re-runs (Enter keeps it). Visible input (non-secret), edited
# with Readline. Fails at EOF with no input.
ask() {
local key="$1" prompt="$2" current input s=$'\001' e=$'\002' p rc=0
current=$(_existing "$key" || true)
# Readline needs the colour codes wrapped in \001..\002 to place the cursor.
p=" $s$BOLD$e$prompt$s$RESET$e "
[[ -n "$current" ]] && p+="$s$DIM$e[Enter keeps current]$s$RESET$e "
read -e -r -p "$p" input || rc=1
if (( rc )) && [[ -z "$input" ]]; then return 1; fi
[[ -z "$input" && -n "$current" ]] && input="$current"
printf -v "$key" '%s' "$input"
}
# ask_secret KEY "Prompt" is like ask, but input is hidden.
ask_secret() {
local key="$1" prompt="$2" current input rc=0
current=$(_existing "$key" || true)
if [[ -n "$current" ]]; then
printf ' %s%s%s %s[Enter keeps current]%s ' "$BOLD" "$prompt" "$RESET" "$DIM" "$RESET"
else
printf ' %s%s%s ' "$BOLD" "$prompt" "$RESET"
fi
read -rs input || rc=1
printf '\n'
if (( rc )) && [[ -z "$input" ]]; then return 1; fi
[[ -z "$input" && -n "$current" ]] && input="$current"
printf -v "$key" '%s' "$input"
}
# write_env KEY VALUE upserts KEY='VALUE' into ENV_FILE (replaces any existing
# line) and sets $KEY. Idempotent. Creates ENV_FILE at mode 0600; writes through
# a symlink and keeps an existing file's mode.
write_env() {
local key="$1" value="$2" tmp sq="'\\''"
[[ -e "$ENV_FILE" ]] || (umask 077 && : > "$ENV_FILE")
tmp=$(mktemp)
grep -vE "^${key}=" "$ENV_FILE" > "$tmp" || true
printf "%s='%s'\n" "$key" "${value//\'/$sq}" >> "$tmp"
cat "$tmp" > "$ENV_FILE"
rm -f "$tmp"
printf -v "$key" '%s' "$value"
WRITTEN_ENV+=("$key")
printf ' %s✓ wrote%s %s → %s\n' "$GREEN" "$RESET" "$key" "$ENV_FILE"
}
# set_secret NAME VALUE sets a GitHub Actions repo secret via gh. Falls back
# to a warning (and records it) if gh is unavailable or unauthenticated.
set_secret() {
local name="$1" value="$2"
if command -v gh >/dev/null 2>&1 && gh auth status >/dev/null 2>&1; then
if printf '%s' "$value" | gh secret set "$name" >/dev/null 2>&1; then
WRITTEN_SECRET+=("$name")
printf ' %s✓ set%s GitHub secret %s\n' "$GREEN" "$RESET" "$name"
return
fi
fi
SKIPPED+=("GitHub secret $name (set it manually: gh secret set $name)")
warn "skipped GitHub secret $name: gh not ready; set it later"
}
# set_var NAME VALUE sets a GitHub Actions repo variable (non-secret).
set_var() {
local name="$1" value="$2"
if command -v gh >/dev/null 2>&1 && gh auth status >/dev/null 2>&1; then
if gh variable set "$name" --body "$value" >/dev/null 2>&1; then
printf ' %s✓ set%s GitHub variable %s\n' "$GREEN" "$RESET" "$name"
return
fi
fi
SKIPPED+=("GitHub variable $name")
warn "skipped GitHub variable $name, gh not ready; set it later"
}
# finish clears, then shows a closing summary of everything configured.
finish() {
_clear
printf '\n%s%s ✓ Setup complete%s\n' "$BOLD" "$GREEN" "$RESET"
(( ${#WRITTEN_ENV[@]} )) && note "wrote ${#WRITTEN_ENV[@]} value(s) to $ENV_FILE: ${WRITTEN_ENV[*]}"
(( ${#WRITTEN_SECRET[@]} )) && note "set ${#WRITTEN_SECRET[@]} GitHub secret(s): ${WRITTEN_SECRET[*]}"
if (( ${#SKIPPED[@]} )); then
printf '\n'; warn "still to do by hand:"
for s in "${SKIPPED[@]}"; do note " - $s"; done
fi
printf '\n'
}
# ──────────────────────────────────────────────────────────────────────────
# STAGES: author this section. One stage() per step the human takes.
# Replace the example below. Set TOTAL_STAGES to match the stages you write.
# Keep every stage inside run_wizard and the last line as is: bash then parses
# the whole file before the first prompt, so an edit mid-run can't break it.
# ──────────────────────────────────────────────────────────────────────────
run_wizard() {
TOTAL_STAGES=1
banner "Stripe setup"
# ── Example stage: replace with your real steps ───────────────────────────
stage "Stripe: API keys"
say "We'll grab your Stripe test keys and store them for local dev + CI."
open_url "https://dashboard.stripe.com/test/apikeys"
step "On the API keys page, copy the Publishable key (starts pk_test_)."
ask STRIPE_PUBLISHABLE_KEY "Paste the publishable key:"
step "Click 'Reveal test key' on the Secret key row, then copy it."
ask_secret STRIPE_SECRET_KEY "Paste the secret key:"
write_env STRIPE_PUBLISHABLE_KEY "$STRIPE_PUBLISHABLE_KEY"
write_env STRIPE_SECRET_KEY "$STRIPE_SECRET_KEY"
set_secret STRIPE_SECRET_KEY "$STRIPE_SECRET_KEY" # CI needs this one
# ──────────────────────────────────────────────────────────────────────────
finish
}
run_wizard "$@"; exit

View file

@ -1,22 +0,0 @@
# Skill mechanics
The skill-specific branch of [`writing-for-agents`](SKILL.md): what changes when the document is a skill (frontmatter, the invocation choice, and router skills). Everything else about writing it is the universal reference in `SKILL.md`.
## Invocation
Two choices, trading the two loads:
- A **model-invoked** skill keeps a `description`, so the agent can fire it autonomously, and other skills can reach it. You can still type its name: model-invocation always _includes_ user reach; a description only ever adds agent discovery, never removes the human's. The description is the skill's top-level context pointer, forced to stay loaded at all times: permanent context load in exchange for discoverability. A model-invoked skill whose content is all reference is also one home for shared reference: another skill can invoke it, so reference needed by several skills lives in one place. Mechanics: omit `disable-model-invocation`, and write a model-facing description carrying the trigger branches (the pointer-writing rules in `SKILL.md` apply in full).
- A **user-invoked** skill strips the description from the agent's reach: only the human typing its name can invoke it, and no other skill can. Zero context load, but it spends cognitive load: you are the index that must remember it exists. Mechanics: set `disable-model-invocation: true`; the `description` becomes human-facing: a one-line summary, trigger lists stripped.
Pick model-invocation only when the agent must reach the skill on its own, or another skill must. If it only ever fires by hand, make it user-invoked and pay no context load.
Shared reference that two user-invoked skills both need can live in neither: with no descriptions, neither can fire the other. Push it to a plain file outside the skill system: external reference any skill can point at.
## Splitting by invocation
The invocation cut of splitting (the sequence cut lives in `SKILL.md`): split off a model-invoked skill when you have a distinct leading word that should trigger it on its own (a trigger word you actually use in your prompts), or another skill must reach it. You pay context load for the new always-loaded description, so that independent reach has to be worth it.
## Router skills
When user-invoked skills multiply past what you can remember, that piled-up cognitive load is cured by a **router skill**: one user-invoked skill that names the others and when to reach for each, so the human has one skill to remember instead of many. It can only hint, never fire them: user-invoked skills have no description, so nothing but the human can reach them.

View file

@ -1,81 +0,0 @@
---
name: writing-for-agents
description: Writing documents for agents. Use when creating or editing skills, or modifying AGENTS.md or CLAUDE.md.
---
Reference for writing any document an agent consumes: a skill, an `AGENTS.md` / `CLAUDE.md`, a doc reached by a pointer. The packaging differs; the writing does not: the same levers make each one predictable, since the agent takes the same _process_ every run rather than producing the same output.
When the document you're writing is a skill, read [`SKILL-MECHANICS.md`](SKILL-MECHANICS.md) for frontmatter, invocation choice, and router skills.
## Context pointers
A **context pointer** is a reference held in the agent's context that names some out-of-context material and encodes the condition for reaching it. A skill's description is one; a line in `AGENTS.md` naming a doc is the same object. The pointer's _wording_, not its target, decides when the agent reaches the material, and how reliably. A must-have target behind a weakly worded pointer is a variance bug: sharpen the wording first, and inline the material only if sharpening fails.
A pointer does two jobs: state what the material is, and list the **branches** that should trigger reaching it (a branch is a distinct case the document handles, so different runs take different paths through it). Every word of an always-loaded pointer costs on every turn, so it earns even harder pruning than the body:
- **Front-load the leading word**: the pointer is where it does its triggering work.
- **One trigger per branch.** Synonyms that rename a single branch are one branch written twice; collapse them and keep only genuinely distinct branches.
- **Cut identity the body already carries.**
## The two loads
Every document and pointer you add spends one of two budgets:
- **Context load** is the cost of always-loaded material on the agent's window: an `AGENTS.md` line, a skill description, anything sitting in context every turn, spending tokens and attention whether or not it fires.
- **Cognitive load** is the cost on the human: which documents exist and when to reach for each. The human is the index. Not a cost to minimise: it is the price of human agency; spend it where human judgement matters, remove it where it does not.
Material reached only through a pointer escapes context load at the price of the pointer's own line; material with no pointer at all rides entirely on cognitive load.
## Information hierarchy
A document is built from two content types: **steps** (the ordered actions the agent performs) and **reference** (definitions, rules, facts consulted on demand). The two mix freely: all steps (a recipe), all reference (a review's rules, this skill), or both. The core decision is where each piece sits on the **information hierarchy**, a ladder ranked by how immediately the agent needs the material:
1. **In-file step** is the primary tier: what the agent does, in order.
2. **In-file reference** is consulted on demand. Often a legitimately flat peer-set (every rule of a review on one rung), which is a fine arrangement, not a smell.
3. **Disclosed reference** is pushed out into a separate file, reached by a context pointer, loaded only when the pointer fires. Spans a sibling file in the same folder through fully external reference that lives anywhere and any document can point at.
Push too little down and the top bloats; push too much and you hide material the agent actually needs. That tension is the whole decision.
**Progressive disclosure** is the move down the ladder (out of the main file and behind a pointer) so the top stays legible. Not primarily a token optimisation: it is how the hierarchy is protected. Branching is the cleanest disclosure test: inline what every branch needs, and push behind a pointer what only some branches reach. When a document has steps, in-file reference that should be disclosed buries them and turns attending to them into a coin-flip: a variance lever, not just a legibility one.
**Co-location** is the within-file companion: where the ladder decides _how far down_ a piece sits, co-location decides _what sits beside it_ once there. Keep a concept's definition, rules, and caveats under one heading rather than scattered, so reading one part brings its neighbours with it. The test: the document should read like documentation written for the agent. Grouped material reads that way; scattered material does not. (Distinct from duplication: that repeats one meaning in two places; scattering fragments one meaning across many.)
**Sprawl** is the failure mode here: a document simply too long, even when every line is live and unique. Attention thins across the excess, and every extra line is one more to keep relevant. The cure is the ladder: disclose reference behind pointers, and split by branch or sequence so each path carries only what it needs.
## Steps and completion criteria
Every step ends on a **completion criterion**, the condition that tells the agent the work is done. Two properties make it a lever:
- **Clarity**: can the agent tell done from not-done? A vague bound ("understanding reached") invites **premature completion**: ending the step before it is genuinely done, attention slipping to _being done_. The visible steps still ahead (the **post-completion steps**) supply the pull; the criterion's clarity is the resistance. Defend in order: **sharpen the bound first** (local and cheap); only if it is irreducibly fuzzy _and_ you observe the rush, hide the later steps by splitting the sequence. Hiding only works across a real context boundary (a hand-off or a subagent dispatch; an inline call leaves the later steps in context and clears nothing).
- **Demand**: how much it requires. "Every modified model accounted for" forces thorough work where "produce a change list" does not. Demand drives **legwork** (the digging the agent does within the work, latent in the wording rather than written as its own step), and it is not step-bound: "every rule applied" binds a body of flat reference just as "every step done" binds a sequence, which is how an all-reference document still carries an exhaustiveness bar.
The strongest criteria are both checkable and exhaustive.
## When to split
Splitting one document into two spends one of the two loads, so split only when the cut earns it:
- **By sequence**: split a run of steps where the post-completion steps tempt the agent to rush the one in front of it. Keeping them out of view drives more legwork on the current task. Beware the reverse: merging sequences exposes each step's later steps to what follows, inviting premature completion.
- **By invocation**, skill-specific: see [`SKILL-MECHANICS.md`](SKILL-MECHANICS.md).
## Leading words
A **leading word** is a compact concept already living in the model's pretraining that the agent thinks with while running the document (_lesson_, _fog of war_, _tracer bullets_). Repeated as a token, never as a sentence, it accumulates a distributed definition and anchors a whole region of behaviour in the fewest tokens, by recruiting priors the model already holds. Coining your own works if you define it clearly, but a made-up word recruits no priors: you pay in definition tokens what a pretrained word gives free; reach for an existing word first.
It anchors twice. In the body, _execution_: the agent reaches for the same behaviour every time the word appears, and inside flat reference it focuses attention on a class of thing to look for. In a pointer, _invocation_: when the same word lives in your prompts, your docs, and your codebase, the agent links that shared language to the material and reaches it more reliably.
Hunt for opportunities to refactor with leading words. A triad spelled out at three sites, a pointer spending a sentence to gesture at one idea. Each is a passage begging to collapse into a single token:
- "fast, deterministic, low-overhead" → _tight_ (a _tight_ loop).
- "a loop you believe in" → _red_, turning a fuzzy gate into a binary observable state (the loop goes _red_ on the bug, or it doesn't).
You win twice: fewer tokens, and a sharper hook for the agent to hang its thinking on. Assume every document is carrying restatements that leading words retire. Go find them.
**Negation** is the failure mode beside this lever: steering by prohibition drags the forbidden behaviour into context and makes it _more_ available, not less. _Don't think of an elephant_, and the elephant is all there is; the negation is a weak modifier the strongly-activated concept overruns, so the ban half-reads as an instruction to do the thing. Prompt the **positive**: state the target behaviour ("write one-line comments") so the banned one is never spoken. A prohibition earns its place only as a hard guardrail you cannot phrase positively; even then, pair it with the positive target so attention lands on what to do.
## Pruning
- Keep each meaning in a **single source of truth**: one authoritative place, so changing the behaviour is a one-place edit. **Duplication** (the same meaning in more than one place) costs maintenance and tokens, and inflates a meaning's prominence on the ladder past its real rank. (The accidental inverse of a leading word, which repeats a token on purpose, never the meaning.)
- The **environment** is a source of truth too (`package.json` scripts, config files, the directory layout, `--help` output), and a document that restates it is a **cache**: a copy of a lookup, earning its load only when the lookup is expensive. Cache what the agent cannot find by looking: the unwritten convention, the reason behind a choice, the gotcha no config confesses. Leave the one-file, one-command lookups to the environment, where they cannot go stale.
- Check every line for **relevance**: does it still bear on what the document does? A line loses relevance by never bearing on the task (mere exposition, or a branch that should be disclosed) or by going stale as the behaviour or world it describes changes. Shorter documents are easier to keep relevant. Without a pruning discipline the default fate is **sediment**: stale layers that settle because adding feels safe and removing feels risky, until you must core down through them to find what is still live.
- Hunt **no-ops** sentence by sentence: an instruction the model already obeys by default pays load to say nothing. The test (does it change behaviour versus the default?) is model-relative, not reader-relative: two people disagreeing about a no-op disagree about the default, and settle it by running the document, not by debate. When a sentence fails, delete the whole sentence rather than trim words from it. The test also grades leading words: a word too weak to beat the default (_be thorough_ when the agent is already thorough-ish) is a no-op, and the fix is a stronger word (_relentless_), not a different technique.

View file

@ -1,3 +0,0 @@
interface:
display_name: "Writing for Agents"
short_description: "Write documents agents consume"

View file

@ -98,11 +98,7 @@
"Shell(NODE_ENV=test bunx jest --config tests/jest.config.js tests/home-page/navigation.test.tsx 2 >& 1)",
"Shell(NODE_ENV=test bunx jest --config tests/jest.config.js tests/home-page/navigation.test.tsx -t routes to the slot view 2 >& 1)",
"Shell(node inspect.cjs)",
"Shell(node -e \" const s=require('/Users/mohammedshafiuddin/WebDev/freshyo/apps/user-ui/tests/mocks/mock-slots-response.json'); for (const id of [2,40,23]) { const idx = s.slots.findIndex(sl=>sl.products.some(p=>p.id===id)); const sl = s.slots[idx]; console.log('product', id, '-> slot index', idx, 'slotId', sl && sl.id, 'delivery', sl && sl.deliveryTime); } console.log('slot order:', s.slots.map(sl=>sl.id).join(',')); \")",
"Shell(cmd:*)",
"Shell(which maestro || ls -la ~/.maestro 2>/dev/null | head -20; echo \"---\"; ls ~/.commandcode/mcp.json 2>/dev/null; echo \"--- project mcp\"; cat .mcp.json 2>/dev/null; echo \"--- other agent configs\"; grep -ril \"maestro\" ~/.claude.json ~/.cursor/mcp.json ~/.config/opencode/opencode.json ~/Library/Application\\ Support/Claude/claude_desktop_config.json 2>/dev/null)",
"Shell(~/.maestro/bin/maestro:*)",
"Shell(xcrun:*)"
"Shell(node -e \" const s=require('/Users/mohammedshafiuddin/WebDev/freshyo/apps/user-ui/tests/mocks/mock-slots-response.json'); for (const id of [2,40,23]) { const idx = s.slots.findIndex(sl=>sl.products.some(p=>p.id===id)); const sl = s.slots[idx]; console.log('product', id, '-> slot index', idx, 'slotId', sl && sl.id, 'delivery', sl && sl.deliveryTime); } console.log('slot order:', s.slots.map(sl=>sl.id).join(',')); \")"
],
"deny": [],
"defaultMode": "default"

View file

@ -7,7 +7,7 @@
- Prefers detailed analysis and explicit error/mistake checking before executing destructive operations, rather than just performing the action — e.g., before a git merge, or before deleting a row directly from the DB (asked "Can I simply delete the row from db. Will it cause any problems" about an unclaimed reserved coupon, expecting the agent to trace all referencing tables/FKs — couponUsages, couponApplicableUsers/Products — before answering). Confidence: 0.7
- Do not run `git stash` or other destructive git operations that would discard or modify working-tree changes without explicit permission. Confidence: 0.9
- When removing unused code (e.g., an unused tRPC procedure), prefers a complete cleanup: also remove internal helper methods used only by it, associated types, re-exports, orphaned hook/API files and their shared types, and even commented-out imports, leaving zero remaining references. Confidence: 0.9
- Before removing or deciding on code, likes to first verify where it is actually used across the codebase (asks questions like "where is X used"), rather than removing based on assumption. Confidence: 0.5
- Before removing or deciding on code, likes to first verify where it is actually used across the codebase (asks questions like "where is X used"), rather than removing based on assumption. Confidence: 0.4
- Prefers light/pastel colors for randomized or accent UI elements (e.g., tabs, chips). Confidence: 0.7
- Prefers minimal, flat tab/navigation UI: active state shown with a thick underline, no pill/chip backgrounds or rounded fills; communicates desired visual styles by sharing reference images/screenshots. Confidence: 0.8
- Wants the agent to come up with a plan first before implementing code changes. Confidence: 0.9
@ -134,7 +134,6 @@ er-ui/app/(drawer)/(tabs)/home/index.tsx, I want similar here") and expects the
- Dislikes long lists of CLI flags for supplying run-time/test values and asks for a "better way" ("isn't there a better way to supply the values"). Expects values supplied declaratively: non-secret defaults committed in a config file (e.g. Maestro `config.yaml` `env:` block), secrets in a gitignored `.env`-style file, and a thin wrapper/runner script wired to a single package-manager entry point (`bun run e2e`) so one short command runs everything — with extra flags still passable through. Secrets should never be passed inline on the command line or committed. Confidence: 0.7
- When he doubts the current approach ("isn't there a better way"), expects the agent to actually research the tool's documented capabilities (check `--help`, official docs) before proposing alternatives, rather than answering from memory. Confidence: 0.6
- For mobile app E2E testing, wants Android ONLY and never iOS — stated explicitly: "I want to test only on android. Never on ios." The test runner/harness should be wired so it can never target an iOS simulator (e.g., pin the Android package id and always pass `--platform android`), rather than auto-detecting the platform from booted devices. Confidence: 0.9
- The Android-only rule applies to the automated E2E suite, not to ad-hoc/interactive driving of a running app: when he just wants the app operated and inspected, he is happy to use whatever device is already booted, iOS included — "I have maestro mcp installed. I want you to use maestro to control my ios simulator." Expects the agent to check what tooling/MCP servers are actually available in the session, use the installed Maestro setup (MCP or CLI) rather than declaring it unavailable, and tell him how to register the MCP server so it loads in future sessions. Confidence: 0.45
- For React Native / Expo mobile E2E automation, prefers **Maestro** (not Detox/Appium), with its flow configs in a folder at the repo ROOT named `e2e/` — "I want test end to end test automation with maestro. have a folder at the root named e2e" — mirroring his `tests/`-at-root convention for Playwright. Expects the tool's own YAML workspace layout inside it (`config.yaml`, `flows/`, reusable `subflows/`), not per-app test dirs. Confidence: 0.85
- Wants E2E flows to take the shortest realistic user path and skip unnecessary intermediate screens — e.g., add to the cart directly from the home product card's cart icon instead of opening the product-detail screen first ("don't open any product detail. Just click on the cart icon of any product, then go to the cart page and then place order"). Confidence: 0.5
- When he pastes a runtime error/log (e.g., a tRPC/D1 `Failed query: select ... from "key_val_store"` 500), he asks for an explanation first — "what does this error mean. Why am I seeing it" — expecting the agent to investigate and explain the root cause (local D1 state, migrations/config) before changing any code, not to jump straight to a fix. Confidence: 0.5
@ -151,11 +150,6 @@ er-ui/app/(drawer)/(tabs)/home/index.tsx, I want similar here") and expects the
- When he asks where/why some behavior lives ("where are we creating the product. show me the test code of it"), expects the answer to show the ACTUAL code — the exact file path, the function that performs the action, and the relevant snippet — not just a prose description of the flow or a high-level summary. Confidence: 0.55
- For feature coverage, expects the test to span roles end-to-end: exercise the admin/staff CRUD (create → read-back → update → delete) and THEN drive the same entity from the user's end to prove it actually takes effect — e.g. create a coupon as staff, then pass its id to the user's `placeOrder` and assert the order reflects the discount, and that deleting it drops it from eligibility and gets rejected on apply. Stated as "I want to test coupon crud, I then want to test it too. Apply it from user's end for an order." Prefers this combined admin-CRUD-plus-user-application flow in a single suite over an admin-only CRUD test. Confidence: 0.72
- Excludes flows that depend on real third-party services from automated test scope — payment-gateway flows (Razorpay-signed payloads) and OTP/SMS login are deliberately left out, while everything else must be covered. Repeats the exclusion across requests ("don't test payments, OTP Login do the rest"; "except the OTP, payments test rest all of the thingss"), treating untestable external-service paths as an accepted gap rather than investing in mocks/bypasses. Confidence: 0.6
- When asking a narrow, targeted factual question (e.g. "tell me which table has that data"), wants the answer scoped to exactly what was asked — the direct fact (the table name) — not another expansive multi-section explanation; corrects over-answering explicitly ("I meant tell me which table has that data"). The broad end-to-end breakdowns he requests elsewhere are for when he asks for them, not a default response length. Confidence: 0.5
- Prefers API payloads that are FLAT and fully resolved server-side: when a value can come from stacked scopes (bound → region → global), the backend must merge them into one flat JSON object so the client reads the final value directly, with no nested blocks and no client-side merge/precedence logic — "every bound should have all it's bound data, it's region's data and global data. It should be a flat json". Confidence: 0.7
- When redesigning a data model, prefers a clean slate over patching the existing shape — instructs the agent to ignore the current implementation ("forget the current pattern") and re-specify storage from scratch, splitting what was one catch-all table into tables by natural scope instead of preserving legacy structure. Confidence: 0.6
- When he changes a shared backend contract (response shape / query input), expects every consumer to be updated to the new shape in the same change and names the affected apps explicitly ("@apps/user-ui should be accomodated to expect this flat json and use this flat json") — a contract change is not done while any client still reads the old shape. Confidence: 0.65
- Wants MCP servers configured at PROJECT scope (repo-root `.mcp.json`) rather than user/global scope — on being told a server would have to be added globally, he corrected with "I want mcp server in this project." So when registering MCP tooling (e.g. maestro), prefer `--scope project` so the config is scoped to and shareable with the repo. Confidence: 0.6
e changes. Confidence: 0.95
er-ui/app/(drawer)/(tabs)/home/index.tsx, I want similar here") and expects the agent to mirror that pattern exactly, including details like item counts and container styling. Confidence: 0.9
als) rather than introducing new brand palettes; approval of a redesign's layout/composition does not imply approval of color or theme changes. Confidence: 0.95

16
.gitignore vendored
View file

@ -138,15 +138,17 @@ type-clusters/*
apps/user-ui/android/
apps/admin-ui/android/
apps/user-ui/ios/
apps/admin-ui/ios/
.maestro-output/*
apps/admin-ui/.expo/cache/*
# Playwright web-test outputs (tests/web)
/test-results/
/playwright-report/
/playwright/.auth/
tests/web/.env
.playwright-mcp
/apps/admin-ui/.expo/prebuild
# Full-suite E2E generated files (tests/e2e/full-suite)
tests/e2e/full-suite/.env.e2e
tests/e2e/full-suite/gen/
# Local wrangler dev vars (may hold local-only secrets)
.dev.vars
apps/*/.dev.vars
tests/e2e/full-suite/.env

View file

@ -3,10 +3,7 @@
"maestro": {
"transport": "stdio",
"enabled": true,
"command": "/Users/mohammedshafiuddin/.maestro/bin/maestro",
"args": [
"mcp"
]
"command": ["maestro", "mcp"]
}
}
}

View file

@ -1,29 +0,0 @@
{
"mcpServers": {
"maestro": {
"command": "maestro",
"args": [
"mcp"
],
"description": "Maestro mobile/web UI automation: list devices, drive and inspect the screen, run YAML flows locally or on Maestro Cloud."
}
},
"_notes": {
"added": "2026-10-18 (FR-2026-10-18-01 regression run)",
"known_issues": [
"MCP can wedge with 'Device became unreachable during deviceInfo'. Later calls then fail instantly because the failure state is cached, so retrying does not help.",
"Observed cause: a stale/duplicate 'maestro.cli.AppKt mcp' java process and/or stale '~/.maestro/deps/simulator-server ios --id <udid>' children. Killing the simulator-server children alone did not recover it.",
"Recovery that worked: kill the java process running 'maestro.cli.AppKt mcp' (pgrep -f 'maestro.cli.AppKt mcp'). pi respawns it on the next tool call; list_devices and run then work again.",
"After a respawn the Maestro Viewer URL changes (seen at http://127.0.0.1:10000/ and http://127.0.0.1:9999/). Surface the URL from the tool output instead of hardcoding it.",
"take_screenshot returns null content on iOS (the image is still shown to the assistant). On iOS prefer 'xcrun simctl io <udid> screenshot <file>'. On the 'chromium' device take_screenshot returns real base64 image content.",
"Maestro text matchers are FULL-STRING regex with IGNORE_CASE: text 'Foo' does not match 'Foo bar'. Use '.*Foo.*' or an anchored regex.",
"React Native placeholders are not accessibility text nodes (e.g. the cart's 'Select a coupon'); tap/assert those by point.",
"Leftover modals (Remove Item / Delete Address / iOS Save Password) silently block every subsequent tap in a flow; dismiss them explicitly.",
"The MCP server is a long-lived JVM; after heavy flow churn restart it before starting a new batch."
],
"device_ids": {
"ios_simulator": "5A64695E-F4D4-4E2E-90F3-EC3493A2B457",
"web": "chromium"
}
}
}

View file

@ -40,7 +40,6 @@ react-native. They are available in the common-ui as MyText, MyTextInput, MyTouc
- No test framework currently configured
- When adding tests, use Jest + React Native Testing Library
- Test files: `*.test.tsx` or `*.spec.tsx`
- Even when explicitly asked for, don't test push notifications or anything related to OTP
### Architecture
- Monorepo with Turbo
@ -49,23 +48,7 @@ react-native. They are available in the common-ui as MyText, MyTextInput, MyTouc
- Database: Drizzle ORM with PostgreSQL
## Important Notes
- Don't do anything with git unless the user explicitly asks for. Don't do git add or git commit. That will be managed entirely by the user.
- Don't do anything with git. Don't do git add or git commit. That will be managed entirely by the user
## Change Log
- there should be a change log file. unless explicitly specified, assume change-log.txt as the name of the log file. Ensure the file exists. If it doesn't exist create it. Before changing any file which is not a md file or txt file write the change to that file exactly. Write the diff to it and then start making changes. for every change add the current time stamp.
## before editing
- there are proper tests for code. While changing code, also scope what changes are needed in the
tests. Tests and code should go hand in hand. One shouldn't be left behind while one is going
forward. Most of the Projects have a test directory.
## mirror projects
- admin-ui is a react native app. It has a web counterpart admin-web. user-ui is also react native
app. It's web counterpart is web-ui. Any changes you do in the react native should have exactly
same changes in their web counterparts too.
## relevant projects
- the db_helper_postgres is an abandoned project. Don't make any changes there or don't report any
errors from there.

313
ANY_USAGE_REPORT.md Normal file
View file

@ -0,0 +1,313 @@
# `any` Usage Audit — what each one should be
**Branch:** `DEAD_CODE_CLEAN`
**Scope:** all `any` keyword usages in `apps/*` and `packages/*` source (`.ts`/`.tsx`), excluding `node_modules`, `dist`, `.wrangler`, `.output`, `.expo`, `.turbo`, `.tanstack`, dumps, `*.sql`, and generated route trees (`routeTree.gen.ts`).
**Nature:** documentation only — no code changed.
## Totals (type-level `any`, excluding prose/comments/generated)
| Area | Count | Dominant cause |
|---|---|---|
| `apps/backend` | ~85 | `as any` casts on JWT/Drizzle/error shapes; `: any` where a shared type exists |
| `packages/db_helper_sqlite` + `_postgres` | ~105 | `(x: any)` on already-typed Drizzle results; `Promise<any>` helpers |
| `apps/admin-ui` | ~161 | `onError/catch (e: any)`; `router.push(... as any)`; entity `useState<any>` |
| `apps/user-ui` + `apps/fallback-ui` | ~137 | `catch/onError`; Expo/TanStack `as any`; catalog/cart `item: any` |
| `apps/web-ui` | ~138 | `Record<number, any>`/`(p: any)` product+slot callbacks; `onError` |
| `apps/admin-web` | ~128 | `onError/catch` (36); domain rows; `navigate({ to: ... as any })` |
| `packages/shared` + `web-components` + `ui` + `migrator` | ~28 | untyped component props; RN style/asset props; migrator rows |
| **Total** | **~780** | |
Regex-based raw totals are a bit higher because the word "any" also appears in comments/prose and `tsconfig` files; those are excluded here.
## The replacement playbook ("what it should have been")
1. **`catch (e: any)` / `onError: (e: any)` → `unknown`** (and narrow with `e instanceof Error ? e.message : '…'`). This is the single largest mechanical category (~100 sites across the repo).
2. **`onError: (error: any)` on tRPC hooks → delete the annotation.** tRPC v11 already infers `TRPCClientError<AppRouter>`; `.message` keeps working.
3. **Callback params on typed Drizzle/array results → delete `: any`.** Because `db_index.ts` passes the full `schema` to `drizzle(...)`, `db.query.*` and `.select()` results are fully inferred; `(x: any) => …` is pure noise.
4. **`(item: any)` / `(product: any)` in catalog/cart lists → the real entity type:** `MergedProduct` (catalog), `CartItem` (carts), `AdminSku`, `AdminSlotWithProducts`, `AdminOrderDetails`, `UserOrderSummary`, etc.
5. **`router.push(… as any)` → typed routes** (`Href` from `expo-router`; `FileRouteTypes['to']`/generated union for TanStack Router). Static routes can simply drop the cast.
6. **`Record<string, any>` → `Record<string, unknown>`** for heterogeneous bags.
7. **`z.any()` → `z.unknown()`** in Zod schemas (or a precise union).
8. **RN/Expo props → their real types:** `StyleProp<ViewStyle>` / `StyleProp<ImageStyle>`, `NativeSyntheticEvent<NativeScrollEvent>`, `TextStyle['fontWeight']`, `ImagePicker.ImagePickerAsset`.
9. **Icon `name={x as any}` → `React.ComponentProps<typeof MaterialIcons>['name']`** (the glyph-key union).
10. **`Promise<any>` db-helper returns → `InferSelectModel<typeof table>` / explicit `Pick<Row, …>`.**
## Highest-leverage shared fixes (fix once, removes many)
These untyped *shared* declarations force `any` at dozens of call sites — tighten them first:
| Fix | File | Impact |
|---|---|---|
| `value: any` → a `ConstValueType \| ConstValueType[]` union (union already defined at line 18) | `packages/shared/types/const.types.ts:8` | Removes `value.map((id: any) => …)` in admin-ui **and** admin-web reorder screens |
| `ListItemProps.item: any`, `CompactProductCardProps.item: any`, `OffersSectionProps.products: any[]`, `AddedToCartProduct.product: any` → hoist a shared structural product type (or make the props generic) | `packages/shared/types/app-common.types.ts:60,78,87,96` | Caps how far web-ui/user-ui flash/offers/complaints props can be tightened |
| `queryParams?: Record<string, any>` → `Record<string, unknown>` | `packages/shared/types/app-common.types.ts:20` | Consumer only does `String(value)` |
| `setFile: (file: any) => void` → `ImagePickerAsset \| ImagePickerAsset[] \| null` | `packages/ui/src/components/use-pick-image.tsx:13` | Type flows into admin-ui `setFile: (assets: any)` (3 sites) and `profile-image`/`ImageUploaderNeo` |
| Export app-local entity types: `MergedProduct`, `CartItem`, `SlotInfo`/`ProductSlotMap` (web-ui/user-ui); `ProductFormData`, `Variant`, `Attribute`, `CouponFormValues` (admin-ui/admin-web) | respective hook/component files | Removes dozens of `values: any` / `item: any` in mutations and list callbacks |
| Backend procedures returning `any[]` (coupon getAll/getReservedCoupons, admin `getUserIncidents`, store) → concrete shared types | `apps/backend/.../admin-apis/apis/{coupon,user,store}.ts` | Removes the downstream `Coupon`/`UserIncident` `any`s in both admin frontends |
---
## apps/backend
### Summary
- **85** `any` keywords across **83 lines / 31 files**.
- **Top files:** `coupon.ts` & `const-store.ts` (7 each), `admin/user.ts`, `post-order-handler.ts`, `app.ts` (6 each), `admin/product.ts` (5), `auth.ts`, `cache-creator.ts` (4).
- **Dominant patterns:** (1) `x as any` around JWT payloads, Drizzle `json` columns, and untyped db-helper returns; (2) `: any` params/locals where a concrete shared type exists (`OrderWithFullData`, `AdminVendorSnippet`, `TagBasicData`, `StaffRole`); (3) generic defaults `<T = any>` and catch clauses.
- **10 of the 85 are inside commented-out "Old implementation" blocks** → delete, don't retype.
| Location | Current code | Should be | Why |
|---|---|---|---|
| `app.ts:57`, `middleware/auth.middleware.ts:19` | `const decoded = payload as any` | `AppJwtPayload` = `{ userId?: number; staffId?: number; name?: string }` | jose `JWTPayload`; tokens are signed as `SignJWT({ userId })` / `SignJWT({ staffId, name })` |
| `app.ts:131,132` | `(err as any).statusCode` | `err instanceof ApiError ? err.statusCode` | `ApiError` is the only error with `statusCode` |
| `app.ts:134,135` | `(err as any).status` | `err instanceof HTTPException ? err.status` | Hono `HTTPException` |
| `app.ts:141` | `c.json({ message }, status as any)` | `status as StatusCode` | Hono status union |
| `types/hono.d.ts:5`, `trpc/trpc-index.ts:7` | `user?: any` | `AppJwtPayload` | consumed as `ctx.user?.userId` |
| `trpc/trpc-index.ts:37` | `const err = error as any` | `unknown` + narrow | catch var; reads name/message/code/stack/meta/sql |
| `jobs/cache-creator.ts:10,13` | `state: any` | `DurableObjectState` | uses storage/alarm |
| `jobs/cache-creator.ts:11,13` | `env: any` | `WorkerEnv` (needs domain input) | passed to `ensureWorkerInit` |
| `jobs/payment-status-checker.ts:3,4,5` | `payment:any; order:any; slot:any` | `typeof payments.$inferSelect` / `{id;userId}` / row types | stub interface; only `order.id/.userId` read |
| `lib/queue-consumer.ts:4,27,40` | `batch: any` | `MessageBatch<NotifQueueMessage>` / `<{orderIds:number[]}>` / `<CancellationMessage>` | pushed message shapes are known |
| `lib/const-store.ts:34,58` | `<T = any>` | `<T = unknown>` | generic default |
| `lib/const-store.ts:90,102,107` | `Record<…, any>` | `Record<…, unknown>` | opaque KV values |
| `lib/api-error.ts:3,5` | `details?: any` | `unknown` | never consumed typed |
| `lib/notif-job.ts:11,22` | `notificationQueue:any`, `notificationWorker:any` | bullmq `Queue`/`Worker` or `Record<string, never>` | stubbed (`{}`) |
| `lib/notif-job.ts:91` | `scheduleNotification(userId, payload: any, …)` | `{ title; body; type; orderId? }` | callers pass exactly this |
| `lib/worker-init.ts:3,4` | `env: any`, `(globalThis as any).ENV` | `WorkerEnv` / typed global | matches existing typed-global pattern |
| `lib/post-order-handler.ts:44,52,95,167,168` | `ordersData: any[]`, `(item: any)`, `createdOrders: any[]`, `Map<…, any[]>` | `OrderWithFullData[]`, `OrderWithFullData['orderItems'][number]`, `PlacedOrder[]` | db-helper return types |
| `lib/post-order-handler.ts:86` | `orderData: any` | `OrderWithCancellationData & { refundStatus: string }` | known shape |
| `lib/flash-delivery-cron.ts:12` | `env: any` | `WorkerEnv` | |
| `lib/env-exporter.ts:62` | `(globalThis as any).ENV \|\| (globalThis as any).process?.env` | typed structural cast | matches rest of codebase |
| `lib/notif-job.ts:91`, `trpc/.../staff-user.ts:64,112` | mixture | `AdminVendorSnippet`, `StaffRole` | concrete shared types exist |
| `admin-apis/apis/store.ts:17,37` | `stores: any[]`, `store: any` | `Store & { owner: User }` | query includes `owner` |
| `admin-apis/apis/banner.ts:59`, `user-apis/apis/auth.ts:274` | `catch (e: any)` | `unknown` + narrow | |
| `admin-apis/apis/const.ts:38` | `z.any()` | `z.unknown()` | |
| `admin-apis/apis/slots.ts:74` | `deliverySequence: z.any()` | `Record<string, number[]>` union | shared `AdminDeliverySequence` |
| `user-apis/apis/payments.ts:129` | `payload as any` | `Record<string, unknown>` | schema is `jsonText<unknown>` |
| `admin-apis/apis/product.ts:265,357,754` | `as any` casts / `product: any` | `CreateProductInput` / `AdminProductTagWithProducts` | helpers/return types exist |
| `user-apis/apis/user.ts:61`, `auth.ts:110,374` | `new Date(userDetail.dateOfBirth as any)` | drop cast | field is `Date \| null` |
| `user-apis/apis/order.ts:293` | `slotId: null as any` | `null` | param is `number \| null` |
| `admin-apis/apis/coupon.ts:129,141,153,154,351,366,440` | `coupons: any[]`, `Promise<any>`, `(au:any)`, `(ap:any)`, `coupon: any` | `Coupon & { applicableUsers; applicableProducts }` / `ReservedCoupon` (needs domain input) | relations not modelled in shared |
| `common-apis/common.ts:79,84,85` | `(id:any)`, `(tag:any)`, `orderedTags:any[]` | `number`, `TagBasicData`, `TagBasicData[]` | `getConstant<T>` default; `getAllTagsForCache()` |
| `admin-apis/apis/user.ts:48,60,98,117,170,258` | `(u:any)` etc | `Pick<User,…>`, `Pick<PlacedOrder,…>`, `UserIncident` (needs domain input) | select shapes |
| Dead-code `any`s (delete) | `product.ts:565,700`, `banner.ts:194`, `slots.ts:176,347`, `address.ts:192`, `admin/order.ts:384`, `vendor-snippets.ts:260`, `const-store.ts:91,97` | — | commented-out old impls |
**Easy wins:** drop redundant `as any` (`product.ts:265/357`, `order.ts:293`, `user.ts:61`, `auth.ts:110/374`, `payments.ts:129`); `: any`→`unknown` (`api-error`, `const-store` generics, `payment-status-checker`, `payments-utils`); `catch`→`unknown` (`banner.ts:59`, `auth.ts:274`); `z.any()`→`z.unknown()`; delete dead `any`s; define `AppJwtPayload` once.
---
## packages/db_helper_sqlite + db_helper_postgres
**Summary:** **105** tokens across **98 lines / 17 files**. Top: `sqlite/admin-apis/product.ts` (27), `sqlite/admin-apis/order.ts` (19), `run-batched.ts` (7), `admin-apis/user.ts` (7 each pkg), `admin-apis/coupon.ts` (6 each). Dominant: `(x: any)` on already-typed Drizzle results (~60) — just delete. `Row<T>` = `InferSelectModel<typeof T>`, `Insert<T>` = `InferInsertModel<typeof T>`.
| Location | Current code | Should be | Why |
|---|---|---|---|
| `sqlite/admin-apis/product.ts:182,235,385,483,530` | `(ci\|f: any)` | `CreateComboItemInput` / `SkuFeatureLike` | element types of typed relations |
| `product.ts:185,238` | `(f: any)` | `Row<skuFeatures>` | |
| `product.ts:596` | `(tag: any)` | inferred (cast at 594) | |
| `product.ts:598,669,709` | `(assignment: any)` | `Row<productTags> & { sku: … }` | |
| `product.ts:756` | `(review: any)` | inferred select shape | |
| `product.ts:817,822` | `(group:any)`, `(membership:any)` | inferred | |
| `product.ts:367` | `updateProduct(id, input: any)` | `UpdateProductInput` (domain) | |
| `product.ts:39,41,114,340,498,545` | `any[]`/`(ci:any)` | `CreateComboItemInput` / `AdminProductComboItem[]` | |
| `product.ts:384,398,401` | `(sku: any)` | `CreateSkuInput & { id?: number }` | |
| `product.ts:956` | `const updateData: any` | `Partial<Insert<productMarketStats>>` | |
| `sqlite/admin-apis/order.ts:174,239,250,364,369,378,388,412,523,528,538,549,554,577,615,616,622,643` | `(u\|item\|f\|order\|acc: any)` | delete → inferred | typed query results |
| `sqlite/admin-apis/slots.ts:122,125,133,199` | `(item\|s\|sku: any)` | delete → inferred | |
| `slots.ts:194` | `(item: any)` + reads `item.isDeleted` | inferred; **add `isDeleted: true` to `columns` at :191** | hidden bug surfaced by typing |
| `slots.ts:56` | `fetchExistingSkuIds(tx: any, …)` | Drizzle tx type (`Parameters<Parameters<typeof db.transaction>[0]>[0]`) | |
| `stores/store-helpers.ts:312,315,326` | `(item\|s\|sku: any)` | delete → inferred | |
| `admin-apis/store.ts:7,17` (both pkgs) | `Promise<any[]>` / `Promise<any\|null>` | `Array<Row<storeInfo> & { owner: Row<staffUsers>\|null }>` | |
| `admin-apis/staff-user.ts:22,78` (both) | `Promise<any[]>` | inferred relation / `StaffRole[]` | |
| `admin-apis/user.ts:5,28,95,122,184,224,245` (both) | `Promise<any…>` | `Row<users>`, `Pick<Row<users>,…>`, `Row<userIncidents>`, etc. | select shapes |
| `admin-apis/coupon.ts:10,53,175,211,213,300` (both) | `any[]`/`Promise<any…>`/`input: any` | `Row<coupons> & {…}`, `Row<reservedCoupons>`, `ReservedCouponInput` | InferInsertModel |
| `user-apis/auth.ts:102,119` (both) | `const userUpdate: any` | `Partial<Insert<users>>` / `Partial<Insert<userDetails>>` | |
| `user-apis/auth.ts:184` (both) | `catch (error: any)` | `unknown` + narrow | `23505` is pg-only |
| `lib/run-batched.ts:3,19` | `(cb: (tx: infer Tx) => any, ...args: any[]) => any` | `unknown` | unused callback return/args |
| `lib/automated-jobs.ts:25` (both) | `value: any` | `unknown` | |
**Easy wins:** delete `: any` from ~60 map/filter callbacks; `run-batched` `any`→`unknown`; `automated-jobs` `value: unknown`; object literals → `Partial<Insert<…>>`; `catch`→`unknown`; **free bug fix** at `slots.ts:191/194`; ~35 `Promise<any>` return annotations via `Row`/`Insert`.
---
## apps/admin-ui
**Summary:** **161** code occurrences / 49 files. Top: `delivery-sequences/index.tsx` (10), `prices-overview` (11), `products/add+edit` (14), `_layout.tsx` (13). Dominant: `catch/onError (error: any)` (35) and `router.* as any` (36) — both mechanical.
| Location | Current code | Should be | Why |
|---|---|---|---|
| `_layout.tsx:53…137`, `dashboard/index.tsx:32,99,242`, banners/products/slots/stores/prices/manage-orders (≈18 files) | `router.push("…" as any)` | `as Href` (`expo-router`); drop cast for static routes | typed routes |
| `dashboard/index.tsx:39,250,275`, `manage-orders/index.tsx:77` | `name={item.icon as any}` | `keyof typeof MaterialIcons.glyphMap` | glyph union |
| `TagMenu.tsx:62`, `stores/edit:28`, `send-notifications:48`, `coupons/*`, `prices:286`, `SlotForm:92,107`, `delivery-sequences`, `order-details`, `orders` (≈24) | `onError: (error: any)` | delete annotation | tRPC infers |
| VendorSnippet/ProductGroupForm/products/coupons/stores/vendor-snippets/product-tags/send-notifications (≈11) | `catch (error: any)` | `unknown` + narrow | |
| `coupons/index.tsx:11,111` | `item: any` | `Coupon & {relations}` / reserved (domain) | backend returns `any[]` |
| `stores/index.tsx:15` | `item: any` | `Store` | |
| `products/index.tsx:148` | `{ item: any }` | `Omit<AdminProductWithRelations,'skus'> & { skus: SerializedAdminSku[] }` | |
| `slots/index.tsx:11`, `rebalance-orders:10` | `item: any` | `AdminSlotWithProducts` | |
| `slots/slot-details.tsx:24`, `product-groupings:130`, `products/detail:146` | `useState<any…>` | `AdminSlotProductSummary[]`, `AdminSku[]`, `AdminProductReviewWithSignedUrls` | |
| `slots/index:238`, `rebalance:123` | `useState<any[]>` | `string[]` | product names |
| `products/add:15,64,29,36,80`, `edit` (same) | `values: any`, `(variant:any)`, `(a:any)`, `(ci:any)` | `ProductFormData`, `Variant`, `Attribute`, `CreateComboItemInput` (export from ProductForm) | |
| `BannerForm:66`, `StoreForm:72`, `products/detail:32` | `setFile: async (assets: any)` | `ImagePicker.ImagePickerAsset \| ImagePickerAsset[]` | |
| `TagForm.tsx:40` | `forwardRef<any,…>` | `unknown` | no imperative handle |
| `TagForm.tsx:57` | `(sku: any)` | `SkuSummary` | |
| `toaster.tsx:39` | `data: any` | `{ rideId?; carId? } \| null` (domain) | |
| `CouponForm.tsx:60,66,156,191,192,205,237,238` | `function(value:any)`, `(values as any)`, `(errors.couponCodes as any)` | `CouponFormValues`, narrow error shapes | |
| `ProductGroupForm:13`, `SnippetOrdersView:21`, `SlotForm:37,48,191` | `products: any[]`, `sequence: any[]`, `(snippet/p: any)` | `AdminSku[]`, `number[]`, `AdminVendorSnippetWithAccess`, `AdminSlotProductSummary` | |
| `UserIncidentsView:141` | `(incident: any)` | `UserIncident` (domain) | |
| `customize-app/index:9,58,59,60` | `Record<string,any>`, `value:any`, `setFieldValue(any)`, `router:any` | `Record<string,unknown>`, `unknown`, `Router` | |
| `popular-items:139`, `all-items-order:111`, `product-tags/order:102` | `value.map((id: any) => parseInt(id))` | `number` (root: `Constant.value`) | |
| `prices-overview:25,28,29,30,46,153,204,224,270` | `sku:any`, `Record<string,any>`, `const update:any` | local `PriceSku`, existing `PendingChange`, mutation input | |
| `delivery-sequences:53,354,373,389,438,588,622` | `orders:any[]`, `(deliverySequence as any)` | `AdminSlotOrder[]`, drop cast (`AdminDeliverySequence`) | |
| `order-details:148` | `const mutationData:any` | `initiateRefund` input | |
| `coupons/create:27` | `values: any` | `CouponFormValues` | |
**Easy wins:** drop `: any` on 24 `onError`; `catch`→`unknown` (11); `as any`→`as Href` (36); icon glyph types (4); drop `deliverySequence as any` (6); remove `products/edit:180 as any`; `triggerStyle` → `StyleProp<ViewStyle>`; export `ProductFormData/Variant/Attribute`.
---
## apps/user-ui + apps/fallback-ui
**Summary:** **137** real type-level / 46 files (4 non-type "any" words ignored). Top: `home/index.tsx` (20), `cart-page` (11), `ProductDetail` (11). Dominant: `catch/onError` (29); router casts (23); catalog/cart `item: any` (30+).
| Location | Current code | Should be | Why |
|---|---|---|---|
| login/register/edit-profile/ComplaintForm/OrderMenu/ProductDetail/registration-form + fallback create-coupon/demo | `catch (error: any)` | `unknown` + narrow | |
| many `onError: (error: any)` (14+) | `onError: (error: any)` | `unknown` / delete (tRPC infers) | |
| `me/index`, `SlotSpecificView`, `cart-page` (≈12) | `router.replace/push(target as any)` | `Href` | |
| fallback AuthWrapper/home/login/super-admin/user-home (≈13) | `navigate({ to: '…' as any })` | drop cast | routes registered |
| `me/index:137`, `my-orders:111,278` | icon `as any` | `ComponentProps<typeof Ionicons/MaterialIcons>['name']` | |
| `my-orders:68,69` | `getStatusColor(): any` | typed `StatusColor` | |
| `home/index.tsx` (many) | `slot: any`, `(p: any)`, `dashboardTags:any[]`, `Record<number,any[]>`, `useRef<any>`, `onLayout(e:any)`, `useState<any[]>` | `UserSlotWithProducts`, `UserSlotProduct`, `AllProductsApiType['tags']`, `MergedProduct[]`, `ComponentRef<typeof ScrollView>`, `LayoutChangeEvent` | catalog types exist |
| `ProductDetail:48,75,76,79,87,147,710` | `useState<any[]>`, `(slot/p/a/b/item:any)`, `setFile(assets:any)` | review/cart/slot types + `ImagePickerAsset` | shared `UserProductReviewWithSignedUrls` missing `adminResponse`/`signedAdminImageUrls` (domain) |
| `cart-page:60` | `coupon: any` | `UserCouponWithRelations` | |
| `registration-form:29` | `useState<any>` | `ImagePicker.ImagePickerAsset` | |
| `useUploadToObjectStore:26` | `contextString as any` | drop cast | shared `ContextString` assignable |
| `notif-context:45,46` | `useRef<any>` | listener return types | |
| `toaster:5` | `data: any` | `Record<string, unknown>` | |
| `AddToCartDialog` (6) | `(item/slot/p: any)`, `Record<number,any>` | `CartItem`, `UserSlotWithProducts`, `UserSlotProduct` | |
| `AuthContext:14` | `Record<string,any>` | tighten shared `AuthRedirectOptions.queryParams` | |
| `getCurrentUserId:8` | `jwtDecode(token)` any | `jwtDecode<{id?;userId?}>` | |
| fallback `order-details:33,51,223`, `user-details:44,45,141`, `login:23`, `demo:11,76`, `inauguration:74` | `as any` / `any[]` / `any` | `AdminOrderDetails`, inferred, `ReturnType<typeof setInterval>`, local `DemoResponse` | |
| `ProductCard:22,29,84,93,94` | `item:any`, `ComponentType<any>`, `(cartItem:any)`, `Record<number,any>`, `(slot:any)` | `MergedProduct`, `ComponentType<PropsWithChildren>`, `CartItem`, `UserSlotWithProducts` | |
| `SlotSpecificView:232,252,457` | `item:any`, `(cartItem:any)`, `(p:any)` | `MergedProduct`, `CartItem` | |
| `PaymentAndOrderComponent:17,24,25` | `cartItems:any[]`, `constsData:any`, `selectedCoupons:any[]` | `CartItem[]`, `EssentialConstsApiType`, `EligibleCoupon[]` | |
| `hooks/useProductSlotIdentifier:18,25`, `prominent-api-hooks:127` | `(slot/a/b/p: any)` | drop → inferred | |
**Easy wins:** bulk `unknown` (29); delete fallback `as any` casts (≈18 incl. `contextString`); catalog/cart annotations (≈30) → `MergedProduct`/`CartItem`; icon types (4); trivial typed `any`s (jwt, setInterval, notif refs, toaster, styles).
---
## apps/web-ui
**Summary:** **138** annotations / 35 files (2 prose excluded). Top: `slot-view` (20), `home.index` (18), `flash` (10), `home.product.$id` (9). Dominant: untyped list callbacks over cached API data (`MergedProduct`, `UserSlotWithProducts`), then `(error: any)`.
| Location | Current code | Should be | Why |
|---|---|---|---|
| `FloatingCartBar:43,44`, `PaymentAndOrderComponent:34,35`, `cart:18,19`, `checkout:38,39`, `home.cart:18,19` | `Record<number,any>` / `(p:any)` | `Record<number, MergedProduct>` / `(p: MergedProduct)` | from `useAllProducts()` |
| `AddToCartDialog:45,78`, `ProductCard:38`, `home.product.$id:63`, `flash:205` | `(item:any)` | `CartItem` | `useGetCart()` |
| `slot-view:399` | `(cartItem:any).productId` | `(cartItem: CartItem).skuId` | **latent bug** |
| `AddToCartDialog:53,57,59,143`, `usePopulateCentralStores:15,30,31,43`, `home.product.$id:51,52,55,94,316,397`, `slot-view:58…153`, `home.index:623` | `(slot:any)`, `slot.products.forEach((p:any)`, slot maps, `(a/b:any)` | `UserSlotWithProducts`, `UserSlotProduct`, `Record<number, UserSlotWithProducts>` | `useSlots()` |
| `usePopulateCentralStores:15` (+43–48) | extra fields `deliveryDate/displayDate/displayTime` | **domain**: not on `UserSlotWithProducts` but required by `SlotInfo` | stale/dead-field mismatch |
| `usePopulateCentralStores:25` | `Record<number,any>` | `ProductSlotMap[number]` (export) | |
| `flash:38,67,77,83,166`, `home.index:154,155,225,326`, `home.search:87,166`, `offers:32,67,68`, `slot-view:139…238`, `stores.$storeId:44,125,163`, `usePopulateCentralStores:28`, `prominent-api-hooks:167` | `(product/p/a/b:any)` | `MergedProduct` | |
| `stores.$storeId:28,38` | `new Map<number,any>`, `(product:any)` | `Map<number, MergedProduct>`, `(product: UserStoreProduct)` | |
| `home.index:133,135,142,143` | `Record<number,any[]>`, `Map<number,any>`, `const ordered/rest: any[]` | `MergedProduct[]` etc | |
| `ProductCard:11` | `item:any` | `MergedProduct` | |
| `flash:36,54,124,156`, `home.index:378,530`, `slot-view:228,294,339`, `stores:78,104`, `stores:161` | `(store:any)`, `stores:any[]`, `(product:any)` | `UserStoreSummary`, `UserStoreSampleProduct` | |
| `checkout-hooks:16,44,67`, `CheckoutAddressSelector:11,72`, `checkout:31`, `flash.checkout:74`, `home.checkout:75` | `useState<any>`, `(addr/address:any)` | `UserAddress` | |
| `AddressForm:48,59,90,92`, `MeOrderMenu:68,95`, `PaymentAndOrderComponent:67`, `me.addresses:121,149`, `me.edit-profile:46,56,103`, `me.orders.$id:42,54` | `onError/catch (e:any)`, `(error:any)` | delete / `unknown`; `AddressForm` narrow `Yup.ValidationError` | |
| `me.orders.$id:99` | `order as any` | drop (`UserOrderDetail`) | |
| `me.orders.$id:117,301`, `me.orders:189,75,325` | `(item/product:any)`, `useState<any[]>` | `UserOrderItemSummary`, `UserOrderSummary` | |
| `BottomNavigation:72`, `Sidebar:81`, `me:167` | `to: … as any` | generated route union | |
| `Topbar:27` | `'/home/search' as any` | drop cast | |
| `home.index:122,291,472,474,513` | `(t/tag/b/_:any)`, `banners:any[]` | tag type, `UserBanner`, `string` | |
| `home.product.$id:379` | `(deal:any)` | `SpecialDealCore` | |
| `lib/auth-context:15,24,110` | `userDetails:any`, `(details:any)` | local `User` | |
| `flash-cart-store:4,5` | `any \| null` | `MergedProduct \| null` (domain) | |
| `useUploadToObjectStorage:26` | `contextString as any` | drop | |
| `ProductCard:47,48`, `PaymentAndOrderComponent:13`, `slot-view:101,104`, `me.complaints:168` | `Record<number,any>`, `(slot:any)`, `cartItems:any[]`, `as any` time, `(complaint:any)` | `SlotInfo`, `CartItem[]`, widen helper, `UserComplaint` | |
**Easy wins:** drop redundant annotations on tRPC `onError` (10) and `cartData.items.find` (5); replace 5-file `productsById` boilerplate (10); `catch`→`unknown` (4); export `CartItem` + `SlotInfo`/`ProductSlotMap`; drop `navigate` casts; **fix `slot-view:399` bug**.
---
## apps/admin-web
**Summary:** **128** annotations (3 prose excluded) / 50 files. Top: `orders.sequence` (11), `prices` (10), `products.edit` (9). Dominant: `onError/catch` (36 = 28%), untyped rows, route casts.
| Location | Current code | Should be | Why |
|---|---|---|---|
| 24 sites (`stores.edit:35`, `orders.sequence:471,623,665`, `orders.list:71,171`, `coupons.*`, `slots:51`, `complaints:81`, `SlotForm:91,106`, `notifications:35`, `TagMenu:56`, `UserIncidentsView:31`, `staff-auth:62`, `orders.$id:68,84,95,105`, `CancelOrderDialog:34`, `prices:281`, `stores.new:27`) | `onError: (error:any)` | delete | tRPC infers |
| 13 sites (`product-tags.new:50`, `product-tags.edit:65`, `coupons.new:57`, `products.$id:81`, `notifications:72`, `vendor-snippets:54,296`, `OrderOptionsMenu:69`, `products.new:106`, ProductGroupForm:68, VendorSnippetForm:87, products.edit:189, stores:114) | `catch (error:any)` | `unknown` + narrow | |
| `orders.sequence:363,382,398,456,603,635` | `(deliverySequence as any)` | drop → `AdminDeliverySequence` | |
| `slots.$id.edit:48`, `slots:28`, `rebalance:28`, `slots.new:43`, `SlotForm:47` | `(p:any)` | `AdminSlotProductSummary` | |
| `SlotForm:36` | `(snippet:any)` | `AdminVendorSnippetWithAccess` (shape mismatch, domain) | |
| `SlotForm:189`, `TagForm:114`, `prices:41` | `(prod/sku/f:any)` | `AdminSku`, `SkuSummary`, `AdminSkuFeature` | |
| `product-tags.edit:92` | `(p:any)` | `AdminProductTagAssignment` | |
| `ProductGroupForm:12`, `product-groupings:25,108` | `products:any[]`, `useState<any[]>` | `AdminSku[]` | |
| `UserIncidentsView:142` | `(incident:any)` | `UserIncident` (domain) | |
| `products:149` | `(product:any)` | `AdminProductWithRelations` | |
| `rebalance:13`, `slots:14` | `item:any` | `AdminSlotWithProducts` | |
| `rebalance:16,128`, `slots:15,242` | `Dispatch<…any[]>`, `useState<any[]>` | `string[]` | |
| `slots.detail:31` | `useState<any[]>` | domain (`AdminSlotProductSummary` lacks `shortDescription`) | |
| `orders.sequence:69` | `orders:any[]` | `AdminSlotOrder[]` | |
| `prices:20,23,24,25,148,199,219,265` | `sku:any`, `Record<string,any>`, `const update:any` | `SkuRow`, existing `PendingChange`, mutation input | |
| `vendor-snippets:233` | `useState<any>` | `{ orders; snippetCode }` (align `totalAmount` number/string) | |
| `SnippetOrdersView:20` | `sequence:any[]` | `unknown`/`number[]` | shared is `unknown` |
| `coupons.new:30`, `products.edit:87`, `products.new:19` | `values: any` | export `CouponFormValues` / `ProductFormData` | |
| `CouponForm:78,84,171,206,207,220,252,253` | `function(value:any)`, `(values as any)`, `(errors as any)` | `CouponFormValues`, narrow | |
| `coupons.tsx:14,17,114,220,363` | `item/coupon:any` | `Coupon & {relations}` / reserved (domain) | |
| `MultiSelect:25`, `SearchableSelect:23`, `coupons:302,430` | `triggerComponent?: any` | `(props:{onClick:()=>void}) => ReactNode` | |
| `SnippetMenu:20`, `TagMenu:11` | `triggerStyle?: any` | `string \| CSSProperties` | |
| `TagForm:96` | `forwardRef<any,…>` | `unknown` (ref unused) | |
| `customize-app:12,61,62,63` | `Record<string,any>`, `value:any`, `setFieldValue(any)`, `router:any` | `Record<string,unknown>`, `unknown`, local router shape | |
| `customize-app.ordering:113`, `popular:126`, `product-tags.order:106` | `value.map((id:any)=>parseInt(id))` | root: `Constant.value` | |
| `stores.edit:33`, `dashboard.index:82`, `customize-app:173`, `orders.tsx:24`, `dashboard.tsx:108` | `navigate({to: … as any})` | generated route union / drop | |
| `products.edit:66,101,108,139,162,166,183`, `products.new:33,40,68,84,88` | `(variant/ci/a/attr:any)`, `as any` | `Variant`, `AdminProductComboItem`, `SkuFeatureLike`, `CreateComboItemInput` | |
| `orders.$id:159` | `const mutationData:any` | `initiateRefund` input | |
| `toaster:16`, `event-bus:6,11` | `_data:any`, `...args: any[]` | `unknown` | |
**Easy wins:** drop 23 `onError`; 13 `catch`→`unknown`; type slot rows (9); `prices` `SkuRow`+`PendingChange` (10); export `ProductFormData/Variant/Attribute/CouponFormValues`; fix shared `Constant.value`; typed routes (5).
---
## packages/shared + web-components + ui + migrator
**Summary:** **28** tokens / 17 files. Top: `app-common.types.ts` (5), `migrator/sqliteToPostgres` (4), `web-components/data-table.tsx` (4). Dominant: untyped component props + RN style/asset props. (No `catch (e: any)` in scope.)
| Location | Current code | Should be | Why |
|---|---|---|---|
| `packages/shared/types/app-common.types.ts:20` | `queryParams?: Record<string, any>` | `Record<string, unknown>` | only `String(value)` |
| `app-common.types.ts:60` | `item: any` | generic `ListItemProps<T>` (domain) | shared list renderer |
| `app-common.types.ts:78` | `item: any` | hoist shared product type (domain) | consumers use id/images/name/flashPrice/incrementStep |
| `app-common.types.ts:87` | `products: any[]` | shared product type (domain) | offers section |
| `app-common.types.ts:96` | `product: any` | shared product type (domain) | AddToCartDialog |
| `packages/shared/types/const.types.ts:8` | `value: any` | `ConstValueType \| ConstValueType[]` (defined line 18) | consumers branch/narrow |
| `migrator/sqliteToPostgres/index.ts:47` | `.all() as any[]` | named `SqliteColumnRow` | PRAGMA shape fixed |
| `migrator/.../index.ts:113` | `parseValue(value:any): any` | `unknown` | returns JSON.parse/raw |
| `migrator/.../index.ts:181` | `.all() as any[]` | `Record<string, unknown>[]` | dynamic `SELECT *` |
| `packages/ui/src/services/axios.ts:56` | `(err as any).original = error` | `Object.assign` / typed `Error & { original: unknown }` | |
| `packages/ui/src/lib/refresh-context.tsx:7` | `queryClient: any` | `QueryClient` | dep exists |
| `packages/ui/src/lib/tailwind.ts:6` | `create(tailwindConfig as any)` | `as TwConfig` (`twrnc`) | |
| `packages/ui/src/components/image-viewer.tsx:16` | `style?: any` | `StyleProp<ImageStyle>` | |
| `packages/ui/src/components/info-dialog.tsx:15`, `dropdown.tsx:17` | `style?: any` | `StyleProp<ViewStyle>` | |
| `packages/ui/src/components/search-bar.tsx:21` | `forwardRef<any,…>` | `React.ElementRef<typeof PaperTextInput>` | |
| `packages/ui/src/components/text.tsx:25` | `let fontWeight: any` | `TextStyle['fontWeight']` | |
| `packages/ui/src/components/profile-image.tsx:11,25` | `file?: any`, `setFile:(file:any)` | `ImagePickerAsset & { name }` | |
| `packages/ui/src/components/use-pick-image.tsx:13` | `setFile: (file: any) => void` | `ImagePickerAsset \| ImagePickerAsset[] \| null` | root of many `assets: any` |
| `packages/ui/src/components/ImageUploaderNeo.tsx:22` | `(files: any)` | `ImagePickerAsset \| ImagePickerAsset[] \| null` | |
| `packages/ui/src/components/ImageCarousel.tsx:27` | `(event: any)` | `NativeSyntheticEvent<NativeScrollEvent>` | |
| `packages/web-components/.../my-text-input.tsx:45` | `{...(props as any)}` | `TextareaHTMLAttributes` union | spread onto `<textarea>` |
| `packages/web-components/.../data-table.tsx:7,12,13` | `(value:any,row:any)`, `data:any[]`, `(row:any,index)` | generic `Column<T>` / `DataTableProps<T>`, `T extends Record<string, unknown>` | |
**Easy wins:** `queryParams`/`Constant.value`; migrator `unknown` + typed PRAGMA row; `QueryClient`/`TwConfig`; RN prop types (10); `Object.assign`; make `DataTable` generic. **4 domain items:** product-shaped props in `app-common.types.ts`.
---
## Suggested remediation order
1. **Mechanical, huge payoff (~200 sites, no domain knowledge):** `catch`/`onError` → `unknown`; delete tRPC `onError` annotations; `Record<string, any>` → `unknown`; `z.any()` → `z.unknown()`; delete `: any` from typed Drizzle callbacks.
2. **Shared root causes (removes dozens downstream):** `Constant.value`, `app-common.types.ts`, `use-pick-image.tsx`, export `CartItem`/`SlotInfo`/`MergedProduct` and `ProductFormData`/`CouponFormValues`.
3. **Backend result typing:** replace `Promise<any…>` db-helper returns and `any[]` procedures with `InferSelectModel`/shared types — unblocks both admin frontends.
4. **Typed routes:** Expo `Href` / TanStack generated union (removes ~50 `as any`).
5. **Domain-input types to define:** `UserIncident`, reserved-coupon/client-coupon-with-relations, `RefundInput`, shared product type, `NotificationToast` payload.
6. **Bugs masked by `any` (fix while typing):** `web-ui/src/routes/slot-view.tsx:399` (`cartItem.productId` → `skuId`), `db_helper_sqlite/src/admin-apis/slots.ts:191/194` (`isDeleted` not selected), `usePopulateCentralStores.ts:15` (`deliveryDate`/`displayDate`/`displayTime` fields not on the slot type).

162
DEAD_CODE_REPORT.md Normal file
View file

@ -0,0 +1,162 @@
# Dead Code Report — branch `DEAD_CODE_CLEAN`
> **Status: EXECUTED.** The dead code listed below has been removed (see "Removal status" at the bottom). The one exception is the Drizzle relation exports, which were kept after verification.
Static-analysis sweep for reachable-code / caller-less code across the monorepo.
**Method:** ripgrep-based caller search + manual verification.
- **tRPC endpoints:** every procedure in `admin`/`user`/`common` routers was enumerated, then searched for callers (`trpc.<path>` and `trpcClient.<path>`) in `apps/admin-ui`, `apps/user-ui`, `apps/web-ui`, `apps/admin-web`, `apps/fallback-ui`, `apps/info-site`.
- **Methods/functions:** exported + local `function`/`const` definitions in `apps/backend/src` and `packages/db_helper_sqlite/src` were searched repo-wide; classified as *truly uncalled* only when they appear nowhere except their definition (and pure re-export files).
- **Files:** inbound-reference scan by module name.
- Excludes `node_modules`, `dist`, `.wrangler`, `.output`, `.expo`, `.turbo`, `.tanstack`.
> Caveats at the bottom — some of these may be intentional (manual tooling, external API consumers, planned features). Verify before deleting.
---
## 1. Dead tRPC endpoints (15)
No caller in any client app (native or web). Each is still registered on the router, so it is reachable over HTTP but unused by this repo.
| Endpoint | File | Line | Note |
|---|---|---|---|
| `trpc.admin.coupon.validate` | `apps/backend/src/trpc/apis/admin-apis/apis/coupon.ts` | 265 | Admin coupon validation |
| `trpc.admin.vendorSnippets.getById` | `.../admin-apis/apis/vendor-snippets.ts` | 184 | Single snippet fetch |
| `trpc.admin.vendorSnippets.getVendorOrders` | `.../admin-apis/apis/vendor-snippets.ts` | 464 | Vendor orders |
| `trpc.admin.slots.getSlotsProductIds` | `.../admin-apis/apis/slots.ts` | 138 | Dup of product.* variant |
| `trpc.admin.slots.updateSlotProducts` | `.../admin-apis/apis/slots.ts` | 194 | Dup of product.* variant |
| `trpc.admin.slots.getSlots` | `.../admin-apis/apis/slots.ts` | 387 | Only `trpc.user.slots.getSlots` is used |
| `trpc.admin.slots.deleteSlot` | `.../admin-apis/apis/slots.ts` | 583 | No delete-slot UI |
| `trpc.admin.product.updateSlotProducts` | `.../admin-apis/apis/product.ts` | 392 | Duplicate router entry |
| `trpc.admin.product.getSlotsProductIds` | `.../admin-apis/apis/product.ts` | 462 | Duplicate router entry |
| `trpc.admin.staffUser.getUsers` | `.../admin-apis/apis/staff-user.ts` | 79 | `admin.user.getAllUsers` is the used one |
| `trpc.admin.staffUser.getUserDetails` | `.../admin-apis/apis/staff-user.ts` | 104 | `admin.user.getUserDetails` is used |
| `trpc.admin.staffUser.updateUserSuspension` | `.../admin-apis/apis/staff-user.ts` | 128 | `admin.user.updateUserSuspension` is used |
| `trpc.admin.user.createUserByMobile` | `.../admin-apis/apis/user.ts` | 29 | No caller |
| `trpc.common.product.getDashboardTags` | `.../common-apis/common.ts` | 144 | Home reads tags from `products.json`, not this |
| `trpc.hello` | `apps/backend/src/trpc/router.ts` | 14 | Scaffold sample endpoint |
**Notable:** the `slots` ↔ `product` routers have **four duplicated** procedures (`getSlotsProductIds`, `updateSlotProducts`) — both copies are dead. The `staffUser` router duplicates three user-management procedures that are only ever called via the `admin.user` router.
---
## 2. Dead backend functions / constants (truly uncalled)
Defined/exported but never referenced anywhere else in the repo.
### Env / config
| Symbol | File |
|---|---|
| `getJwtSecret` | `apps/backend/src/lib/env-exporter.ts` |
| `getRedisUrl` | `apps/backend/src/lib/env-exporter.ts` |
| `getPhonePeBaseUrl` | `apps/backend/src/lib/env-exporter.ts` |
| `getPhonePeClientId` | `apps/backend/src/lib/env-exporter.ts` |
| `getPhonePeClientVersion` | `apps/backend/src/lib/env-exporter.ts` |
| `getPhonePeClientSecret` | `apps/backend/src/lib/env-exporter.ts` |
| `getPhonePeMerchantId` | `apps/backend/src/lib/env-exporter.ts` |
| `READABLE_ORDER_ID_KEY` | `apps/backend/src/lib/const-strings.ts` |
| `WELCOME_MESSAGE` | `apps/backend/src/lib/const-strings.ts` |
| `defaultRole` | `apps/backend/src/lib/roles-manager.ts` |
### Notifications / jobs
| Symbol | File | Note |
|---|---|---|
| `sendPushNotificationsMany` | `apps/backend/src/lib/expo-service.ts` | Whole file has no importers (see §4) |
| `sendOrderPlacedNotification` | `apps/backend/src/lib/notif-job.ts` | Only an unused import + a commented call in `user-apis/order.ts` |
| `sendOrderCancelledNotification` | `apps/backend/src/lib/notif-job.ts` | Same — imported, call commented |
| `sendPaymentFailedNotification` | `apps/backend/src/lib/notif-job.ts` | No reference |
| `sendOrderOutForDeliveryNotification` | `apps/backend/src/lib/notif-job.ts` | No reference |
| `sendRefundInitiatedNotification` | `apps/backend/src/lib/notif-job.ts` | No reference |
*(Alive: `sendAdminNotification` via `queue-consumer.ts` ← `worker.ts`; `sendOrderPackagedNotification` and `sendOrderDeliveredNotification` via admin order api; `scheduleNotification` via those.)*
### Stores / cache / misc
| Symbol | File |
|---|---|
| `getOrderDetailsWrapper` | `apps/backend/src/dbService.ts` |
| `clearAllCache` | `apps/backend/src/lib/cloud_cache.ts` |
| `getAllBanners` | `apps/backend/src/stores/banner-store.ts` |
| `getTagById` | `apps/backend/src/stores/product-tag-store.ts` |
| `getAllTags` | `apps/backend/src/stores/product-tag-store.ts` |
| `getProductSlots` | `apps/backend/src/stores/slot-store.ts` |
| `getAllProductsSlots` | `apps/backend/src/stores/slot-store.ts` |
| `getUserNegativity` | `apps/backend/src/stores/user-negativity-store.ts` |
| `createTRPCRouter` | `apps/backend/src/trpc/trpc-index.ts` (alias re-export, unused) |
---
## 3. Dead exports in `db_helper_sqlite`
| Symbol | File | Note |
|---|---|---|
| `mergeDuplicateProducts` | `packages/db_helper_sqlite/src/admin-apis/merge-duplicate-products.ts` | Exported via index + `sqliteImporter`, but **no code calls it** (function had a "how to use manually" doc comment → manual utility). **Removed.** |
`productSkusRelations`, `productMarketStatsRelations`, `skuFeaturesRelations`, `productCombosRelations` (`src/db/schema.ts`) looked unreferenced but are **NOT dead** — Drizzle registers relation exports via `import * as schema` in `db_index.ts`, and `db.query.*.findMany({ with: … })` depends on them. **Kept.**
Used only inside their own file (helpers of live code — **not dead**): `parseDuplicateProductsMd` (deleted with the merge utility), `splitQuantityFeature`, `cleanFeatureValue`, `productTypeEnum`.
---
## 4. Dead / unreachable files & endpoints
| Item | File | Note |
|---|---|---|
| Expo push service | `apps/backend/src/lib/expo-service.ts` | No module imports it; its only export is uncalled |
| `av-router` | `apps/backend/src/apis/admin-apis/apis/av-router.ts` | Mounted at `/api/v1/av` but registers **zero routes** (staff-auth middleware only) |
| REST product summary | `apps/backend/src/apis/common-apis/apis/common-product.controller.ts` (`getAllProductsSummary`) | Reachable at `/api/v1/cm/products/summary`, but **no client calls it** (apps use tRPC) |
`/api/test` (`test-controller.ts`) is referenced only by `apps/fallback-ui/src/routes/demo.tsx` (a demo page).
---
## 5. Unused imports that point at dead code
| File | Unused import | Reality |
|---|---|---|
| `apps/backend/src/trpc/apis/user-apis/apis/order.ts` | `sendOrderPlacedNotification` (line 29) | Call is commented out (line 235) |
| `apps/backend/src/trpc/apis/user-apis/apis/order.ts` | `sendOrderCancelledNotification` (line 30) | Call is commented out (line 598) |
---
## 6. Commented-out / unreachable code blocks
Not "callers-less" but unreachable. Many "Old implementation" blocks were kept across the backend; the most notable registered-looking ones:
- `apps/backend/src/trpc/apis/common-apis/common.ts:160-176` — `getStoresSummary` and `healthCheck` procedures inside a `/* … */` block (NOT registered; the live ones are in `common-trpc-index.ts`).
- `apps/backend/src/main-router.ts` — `// router.route('/av', avRouter)` (route disabled).
- Numerous `// Old implementation - direct DB queries:` blocks in `admin-apis/*`, `user-apis/*`, and db helpers (historical only).
---
## 7. Checked and NOT dead (for reference)
- `apps/admin-ui` / `user-ui` / `web-ui` exports: **0 truly-unused**. 18 shared exports (`AdminOrderItemCore`, `SkuFlagCore`, `UserStoreSummaryCore`, …) are referenced only within their own file to compose other types — that's normal, not dead.
- Backend functions used only inside their own file (e.g. `cloud_cache` internals `createProductsFileInternal`, `constructCacheUrl`, `clearUrlCache`; `slot-store` `transformSlotToStoreSlot`/`extractSlotInfo`/`fetchAllTransformedSlots`; `trpc-index` `createCallerFactory`) — all reachable via their parent functions, **not dead**.
- `queue-consumer.ts` — although it imports only-in-backend, it IS used by `worker.ts`, so alive.
---
## Caveats
1. **Static analysis only.** A tRPC procedure can still be called by an external/undisclosed client (mobile build, partner integration). Confirm before removing public procedures.
2. **`mergeDuplicateProducts`** and **`expo-service`** look intentionally kept for manual/one-off use — decide whether to delete or document.
3. The `admin-web` tree is present on disk but **untracked** on this branch; it was included in the caller search.
4. Some "dead" management procedures (`staffUser.*`, duplicated `slots`/`product` entries) may be leftovers from older UI screens; safe to remove once confirmed.
## Removal status (executed)
**Removed — 15 tRPC procedures:** `admin.coupon.validate`; `admin.vendorSnippets.getById`, `getVendorOrders`; `admin.slots.getSlotsProductIds`, `updateSlotProducts`, `getSlots`, `deleteSlot`; `admin.product.updateSlotProducts`, `getSlotsProductIds`; `admin.staffUser.getUsers`, `getUserDetails`, `updateUserSuspension`; `admin.user.createUserByMobile`; `common.product.getDashboardTags`; `trpc.hello`.
**Removed — backend functions/constants:** `getJwtSecret`, `getRedisUrl`, `getExpoAccessToken`, `getPhonePeBaseUrl/ClientId/ClientVersion/ClientSecret/MerchantId`, `READABLE_ORDER_ID_KEY`, `WELCOME_MESSAGE`, `defaultRole`, `getOrderDetailsWrapper`, `clearAllCache`, `getAllBanners`, `getTagById`, `getAllTags`, `getDashboardTags`, `getProductSlots`, `getAllProductsSlots`, `getUserNegativity`, `createTRPCRouter`, `createCallerFactory`, and the notification senders `sendOrderPlacedNotification`, `sendPaymentFailedNotification`, `sendOrderOutForDeliveryNotification`, `sendOrderCancelledNotification`, `sendRefundInitiatedNotification` + their message constants.
**Removed — DB helper functions orphaned by the procedures above (from BOTH `db_helper_sqlite` and `db_helper_postgres`, plus their barrel exports and `sqliteImporter` re-exports):**
`createUserByMobile`, `deleteSlotById`, `getVendorOrders`, `updateSlotProducts`, `getSlotsProductIds` (the five behind the deleted endpoints) **and** `getActiveSlots`, `getAllUsers`, `getUserWithDetails`, `validateCoupon`, `checkUnitExists`, `getProductImagesById`, `replaceProductTags` (same class, missed by the first scan because their names also exist in the parallel package).
**Removed — files:** `apps/backend/src/lib/expo-service.ts`, `apps/backend/src/middleware/staff-auth.ts` (only used by the empty `av-router`), `apps/backend/src/apis/admin-apis/apis/av-router.ts` (empty router), `packages/db_helper_sqlite/src/admin-apis/merge-duplicate-products.ts`.
**Removed — wiring:** `avRouter` import/route from `main-router.ts` + `v1-router.ts`; `mergeDuplicateProducts` exports from `db_helper_sqlite/index.ts` and `sqliteImporter.ts`; unused `sendOrder*Notification` import + commented calls in `user-apis/order.ts`; orphaned imports in all touched files.
**Kept (false positives / intentional):** the four Drizzle relation exports (implicitly registered); `mergeDuplicateProducts` was deleted per §3.
**Verification:** `tsc` clean for `apps/backend`, `packages/db_helper_sqlite`, `apps/web-ui`, `apps/admin-ui`, `apps/user-ui`, `apps/admin-web`. (`apps/fallback-ui` has one pre-existing `vite.config.ts` error unrelated to this change.)

105
MULTI_REGION_PROBLEMS.md Normal file
View file

@ -0,0 +1,105 @@
# Problems found — multi-region testing (2026-10-06, local dev)
Source: Maestro MCP runs (iOS sim `5A64695E`, Chromium) + tRPC API checks against
local backend `127.0.0.1:8787`. Test data: region 8 (`MCPTest-222329`),
products 157/158, tags 1–3, slot 1, user address 872. Full per-test report in
session notes; this file lists defects only.
## Open app defects
### P1 — Add Address silently drops the save (data-loss UX)
- Repro: Me → Addresses → + → fill Name/Phone/Line-1, Attach Current Location
(spoofed Jadcherla 16.76,78.14 → "Location Attached"), pick Jadcherla in the
region dropdown → Add Address. Sheet closes, no error — but `getUserAddresses`
still returns 1 address.
- Same payload via `user.address.createAddress` API succeeds (id 872, region 7),
so the app form never POSTs or swallows the error.
- Fix: surface backend errors; verify the payload mapping (city field still read
"Mahabubnagar"/pin "509001" while region=Jadcherla — check whether a
city/pin-vs-region validation rejects it server- or client-side without a toast).
### P2 — Changing default address to another region does not switch region
- Repro: set the Jadcherla address as default ("Success — Default address
updated") → Home still shows Mahabubnagar + MBNR data. No region switch, no
reconciliation notice.
- Product decision needed: should default-address drive the active region, or is
region strictly location/device-driven? Either way the silent no-op is wrong —
at minimum notify ("address saved; region unchanged").
### P3 — Availability cache goes stale; OOS persists after DB says in-stock
- DB `product_market_stats`: sku 160 in-stock @175 in region 6; slot 1 created
(region 6, skus 160+161). App still shows Out of Stock @₹100 after relaunch +
pull-to-refresh.
- Root cause: the app re-reads availability only when its version bumps, and
nothing in the tested writes bumped `availability_version_num`. Slot/product
writes go through fire-and-forget `scheduleStoreInitialization` (DO), which
never visibly ran locally.
- Impact: blocks all cart/checkout E2E (tests 16/17/19) — every item unreadable
as purchasable.
### P4 — Stale price display (same root cause as P3)
- Card shows ₹100/₹120 after backend price update to 175/200 (`admin.product.
updateProduct` verified via API). Products file is version-sticky the same way.
### P5 — Region name spelling: "Jadcherla" (app/region picker) vs "Jadcherla" (DB)
- `getRegions` returns `Jadcherla`; the app header, out-of-service cards, and the
address region picker render "Jadcherla". Maestro `tapOn: "Jadcherla"` fails —
only coordinate taps work. Confirm the intended spelling and fix one side.
### P6 — In-app location change alone does not re-resolve region
- Spoof MBNR→Jadcherla while the app is foregrounded: header stays Mahabubnagar.
Region re-resolves only on relaunch. If live re-resolution is intended, the
location listener is not firing/refreshing; if relaunch-only is intended,
document it (tests 14/15 depend on it).
### P7 — Region selector is sticky; spec expects scroll-out (test 20)
- After 2× swipe-up on Home, the region header + search remain visible.
Either the spec ("selector is scrolled out") is outdated or the sticky header
is a regression. Product call.
### P8 — No notif-creds endpoint fires on region change/detect (tests 23/24)
- No dedicated endpoint found in the user router; `notif_creds` table has a
`regionId` FK but nothing observed writing it on region switch or auto-detect.
Verify whether the mobile client is supposed to call something here or the
requirement is obsolete.
### P9 — Legacy default address points at dead region
- User 388's default address (id 285) has `regionId: 1`, but regions are now
6/7/8. Anything joining address→region for this user silently misses.
Data hygiene: re-point or null it.
## Test-harness notes (Maestro, not app bugs)
- Password `secureTextEntry` field: `inputText` never focuses it (no keyboard,
text goes nowhere). Working sequence: tap `user-login-password` by id →
`eraseText: 50` → `setClipboard` + `pasteText`. Note: `inputText` with `@`
keystroke-types an extra `y` (multilingual SIM keyboard `EN HI`); paste avoids it.
- Never tap a button with the keyboard up: the tap lands on the keyboard
(observed phantom `y` appended to the password when tapping Login).
- `inspect_screen` on the user app throws `RangeError: max depth 32` — used
screenshots + targeted `tapOn` instead.
- Out-of-service screen doubles as the region picker (lists all regions incl.
newly created ones) — useful fallback for region selection tests.
## Fixed during this session (for reference, not open)
- Store submit tap eaten by open keyboard → keyboard dismissal via static-text
tap + `assertVisible` before every button tap.
- BottomDialog sat under the iOS keyboard → manual `Keyboard`-driven inset;
the `maxHeight: 85%` cap choked the inset and was removed (verified live:
sheet bottom lands exactly at keyboard top).
- BottomDropdown option taps swallowed with keyboard open → added
`keyboardShouldPersistTaps="handled"` to the inner option-list ScrollView
(was only on the outer dialog scroll).
- Native iOS date picker: same-day picks never fire `onChange` (modal never
closes); freeze-picked-second crossed minute boundaries (`freeze > delivery`).
Now freeze-first + same-day force-change branch in `set-slot-time-ios.yaml`.
- Flow scoping: `output.*` from `evalScript` does not reach nested
`runFlow.when.commands` in subflows — all matchers compute slugs inline.
- `scrollUntilVisible` + `centerElement: true` re-nudges endlessly on visible
elements; screen-level scrolls move the page behind bottom sheets (superseded
by search-then-select in product pickers).
- BottomDropdown option ids now embed a label slug
(`<testID>-option-<value>-<slug>`); flow matchers anchor with `.*`.
- Exact slot times need the `slots/add.tsx` `dts`/`fts` deep-link prefill hook
(native picker is calendar-only).

183
PRODUCT-REPORT.txt Normal file
View file

@ -0,0 +1,183 @@
PRODUCT REPORT — Regions & Location Release
Date: 2026-10-04
Scope: everything currently uncommitted in the worktree (customer app, admin apps, superadmin console, backend).
Note: database migrations are written but not yet applied; nothing below is live until they run.
=====================================================================
1. CUSTOMER APP (user-ui)
=====================================================================
1.1 Automatic region detection on startup
- When the app opens, it asks for location permission and figures out which
service region the customer is in, using the delivery-area maps drawn for
each region. No manual setup needed for most users.
- If permission is denied, or the phone's location switch is off, the app
shows a clear "Unable to obtain location" screen explaining exactly which
of the two is the problem, with a button that opens the right Settings
page (app settings for permission, system location settings on Android).
The user can also just pick a region manually and continue.
- If the customer is outside every service area, the app says so plainly
and still lets them pick a region and browse.
1.2 Region display and switching
- The home screen shows the current region above the search bar. It slides
away as you scroll so the search bar stays visible.
- Tapping the region opens a dropdown to switch regions. The same dropdown
now appears on all main tabs (Home, Offers, Flash delivery, Stores, Me).
- Switching region reloads that region's products, prices, stores, slots
and offers automatically.
1.3 Cart is remembered per region
- The cart is saved separately for each region. Going back to a previous
region restores exactly what was left there, including quantities.
- When the cart is carried into a new region, every item is re-matched to
the closest available delivery slot. Items that can't be delivered there
are removed. A summary dialog shows what moved (old time vs new time,
with a warning when the shift is over an hour) and what was removed.
- Applies to both the regular cart and the 1-hour delivery cart.
1.4 Delivery addresses belong to regions
- The address form now ends with a mandatory region dropdown, pre-filled
with the customer's detected region.
- On the cart page there is an address selector. Adding a new address in
the current region selects it immediately. If the new address is in a
different region, the app shows all addresses in that region and asks the
user to pick one.
- Changing the selected address to one in another region triggers the same
cart check as switching regions: a confirmation dialog appears first when
slots would move or items would be removed; empty or unaffected carts
switch over silently.
- The checkout page no longer has its own address picker; it shows the
chosen address read-only. Address selection happens on the cart page.
1.5 Push notifications carry the region
- The device's push token is saved together with its region, both for
logged-in and logged-out users. If the same device is used by another
account or region later, the record moves with it instead of erroring.
- Older app installs that never reported a region are treated as region 1.
=====================================================================
2. ADMIN APPS (admin-ui + admin-web)
=====================================================================
2.1 Admins only see and touch their own region
- Product, store, slot, banner, tag, group, snippet and order screens are
all filtered to the logged-in admin's region. Cross-region editing is
blocked with a clear error, including:
- editing or deleting another region's product, store, prices or stock,
- narrowing an "available in all regions" product down to one region,
- widening a product to all regions.
- Only super-admins can perform cross-region actions.
- The "available in all regions" checkbox is locked (visible but disabled)
for non-super-admins on all-region products; the server enforces the
same rule regardless.
2.2 All-region products
- A product can be marked available in all regions. It carries one store
per region (chosen from per-region dropdowns in the product form, with
every region's stores visible), while price and stock stay per-region.
- Every region selection in the form is mandatory — a product cannot be
saved with a region missing its store.
- Editing a product's per-region stores later actually updates them
(previously those edits were silently lost).
2.3 Region-aware pickers
- Product/SKU/tag/store pickers in banners, groups, tags and campaign
screens now show the admin's own region data (super-admins see everything
combined), instead of always showing region 1.
2.4 App settings per area (customize-app)
- Settings such as delivery charges, free-delivery limits, flash delivery
charges and support contacts can now differ per delivery area (bound),
edited through tabs at the top of the customize screen — one tab per
area, the first marked Default.
- If an area has no value saved, it inherits from the default area, then
region-level values, then built-in defaults.
2.5 Broadcast notifications go region-wide only
- "Notify all users" from an admin reaches only devices registered in that
admin's region.
=====================================================================
3. SUPERADMIN CONSOLE
=====================================================================
3.1 Regions management
- Full list / create / edit screens for regions, each with any number of
delivery-area maps (GeoJSON polygons), a name, description and priority
per area. Areas are evaluated in priority order; priority 1 is the
region default. Duplicate priorities and missing names are rejected in
the form and on the server.
- Regions cannot be deleted (too much depends on them).
- The first region (Mahabubnagar) ships with its two delivery-area maps
already loaded.
3.2 Mandatory notification channels per region
- Every new region must be created with at least one Telegram channel
(bot + destination); the form won't submit without it.
- Staff admin accounts are created with an explicit region and role.
=====================================================================
4. ORDERS, NOTIFICATIONS & CHARGES (platform behavior)
=====================================================================
4.1 Order pricing follows the delivery address
- Item prices, flash availability, delivery charges and minimum-order
thresholds are all taken from the order address's area — not always
region 1 as before. An order placed in region 2 is validated and priced
with region 2's data.
4.2 Staff alerts are regional
- When an order is placed, only admins of that order's region get the push
alert (with a tap-through to the order). Orders with no determinable
region still alert everyone so nothing is missed.
- Order alerts also go to Telegram, one message per region, delivered to
every Telegram channel configured for that region. Regions with no
channel configured are logged and skipped.
- Raising a complaint also alerts the relevant region's admins (based on
the complaint's order, else the customer's default address).
4.3 Tags can repeat across regions
- The same tag name (e.g. "Fruits") can now exist in multiple regions;
names only need to be unique within one region. (Requires the pending
migration; until it runs, the old global uniqueness still applies.)
=====================================================================
5. EDGE CASES & SAFETY BEHAVIOR
=====================================================================
- No region match: user is told they are outside the service area and can
continue by picking a region manually.
- No permission / location off: distinct messages and correct Settings
destination for each case; manual region pick always available.
- App reinstall / corrupted saved data: stored region is validated on
launch; unknown values are discarded and the user is asked again.
- Empty cart on region/address change: switches over silently, no popups.
- Cart lines that survive a move keep working; only real changes are shown.
- Slot moves under an hour apply quietly on confirmation; moves over an
hour are flagged prominently in the confirmation.
- Canceling a region/address confirmation leaves everything exactly as it
was (cart, region, selected address).
- Rapid repeated switches: overlapping operations are guarded so carts
can't corrupt each other.
- Addresses without coordinates: area is resolved from the region default;
charges fall back down the chain (area → default area → region → built-in).
- Areas whose maps overlap: the highest-priority area wins, consistently
for detection, pricing and settings.
- Deleting a delivery area also cleans up its area-specific settings so
no orphaned values linger; editing an area keeps its identity (and its
settings) instead of recreating it.
- Old devices/tokens with no region recorded are treated as region 1, so
nobody silently stops receiving notifications after the upgrade.
=====================================================================
6. INTENTIONALLY UNCHANGED / KNOWN NOTES
=====================================================================
- Coupons, reviews, payments and complaint handling (other than the new
admin alert) are not region-dependent.
- Flash-delivery eligibility of a product is still decided per region.
- The legacy fallback vendor page and old REST summary endpoints were
removed; all screens use the current data paths.
- Super-admins retain full cross-region visibility and action rights in
every admin surface.

View file

@ -1,312 +0,0 @@
# Freshyo Monorepo — Full Code Review
- **Date:** 2026-11-02
- **Branch:** `main`, at commit `0ca0a95`
- **Method:** read-only review. No files under review were edited, and no tests or migrations were run.
- **Scope:** all apps and packages except `packages/db_helper_postgres`, which is abandoned.
- **Known issues:** anything already listed in `unfixed-issues-MULTI_REGION_I2.md` is left out.
- **Deployment model:** the git remote is private and self-hosted, so repository contents are not treated as an exposure vector. Findings that only matter if the repo leaks (committed credentials, database dumps, tracked `.env` files) are excluded.
Severity runs from Critical to High, Medium and Low. **✓** means the finding was checked directly in the source. Unmarked findings come from the area reviewers, with the confidence they reported.
---
## Round 1
### Critical
#### C1. The production superadmin is seeded with a test password and cannot be changed
- **Where:** `packages/db_helper_sqlite/drizzle/0006_regions_and_superadmins.sql:96-98` seeds the `superadmin` user with a fixed bcrypt hash that matches `TEST_SUPERADMIN_PASSWORD` in `apps/backend/tests/.env`. There is no endpoint for changing the superadmin password.
- **Why this still matters with a private repo:** the exposure is not "someone reads the repo". It is that the production credential is a *test* credential:
- anyone who has ever had a clone, a backup, a laptop, a CI log or a screenshare retains it;
- it cannot be rotated through the product, only by hand-editing the database;
- superadmin login (`superadmin-apis/apis/auth.ts:10`) has no throttling, so a weak or common test password is remotely brute-forceable.
- **Check:** confirm what the live production hash actually resolves to. If it is still the seeded value, log in and change it, or add a password-change endpoint.
#### C2. Admin endpoints can be called with a customer token ✓
- **Cause:** `adminRouter` (`admin-apis/apis/admin-trpc-index.ts`) has no staff-only gate, and `protectedProcedure` (`trpc-index.ts:121-128`) accepts customer tokens.
- **Confirmed reachable by a customer:**
- `admin.user.updateUserSuspension` (`admin-apis/apis/user.ts:143-157`) can suspend or unsuspend any user, with no region check either.
- `admin.user.sendNotification` (`user.ts:183-252`) sends any title, text and image to every device when `userIds: []`.
- `admin.staffUser.getStaff` and `getRoles` (`staff-user.ts:66,121`) list every staff member, role and permission.
- **Partly protected:** admin handlers that read `ctx.staffUser!.regionId` fail with a TypeError (a 500) when a customer calls them, so they are protected by accident.
- **Fix:** add a `staffProcedure` and use it for the whole admin router.
#### C3. The dev worker uses the production database ✓
- **Where:** `wrangler.dev.toml:14` and `wrangler.prod.toml:12` have the same D1 `database_id`, and the same JWT secret.
- **Impact:** a `deploy:dev` build reads and writes live orders, and a dev-issued token is accepted by production (it is the same signing key, so environment separation does not exist at the auth layer).
- **Also affected:** dev image uploads go to the `meatfarmer-dev` bucket while their database rows land in prod, so those images break in prod.
- **Related ✓:** `apps/backend/reset-remote-db.sh:24-25` runs `wrangler d1 delete` and then `create` on that database. Prod goes down, and the new database id no longer matches `wrangler.prod.toml`.
### High
#### H1. Database transactions do nothing ✓
- **Cause:** `packages/db_helper_sqlite/src/db/db_index.ts:29-33` replaces `transaction` with `handler(base)`, so the 36 call sites get no atomicity.
- **Order placement:** `placeOrderTransaction` (`user-apis/order.ts:339-368`) inserts the orders, then the items five at a time, then the statuses. Cart deletion and `recordUserCouponUsage` are separate writes.
- **Effect of a partial failure:** an order with no items or no `order_status` row. It can't be cancelled ("Order status not found"), or the discount is applied but the coupon usage is never recorded.
- **Other writers affected:** `createSlotWithRelations`, `rebalanceSlots`, product create/update, and user and admin cancel.
- **Fix:** use `db.batch`, as `redeemReservedCoupon` already does.
#### H2. Coupon limits can be beaten by placing two orders at once
- **Where:** `validateAndGetCoupons` (`user-apis/order.ts:150,168`) checks usage, and the usage row is only written after the orders are inserted.
- **Gap:** no unique constraint, conditional write or idempotency key prevents a second use.
- **Scenario:** two parallel `placeOrder` calls with a `maxLimitForUser=1` or first-order-only coupon both get the discount.
- **Related:** `orderGroupId = \`${Date.now()}-${userId}\`` (`order.ts:69`) can collide when one user sends two requests in the same millisecond.
#### H3. Suspended users keep full tRPC access ✓
- **Where:** `apps/backend/src/app.ts:80-94`.
- **Cause:** `user = decoded` is set before the suspension check, and the thrown `TRPCError` is swallowed by `catch {}`. Suspension is only enforced on the Hono `/api/v1` path.
#### H4. `vendorSnippets.updateOrderItemPackaging` needs no login ✓
- **Where:** `admin-apis/apis/vendor-snippets.ts:366-387`. It is a `publicProcedure`, and its auth check is commented out.
- **Impact:** anyone can flip `is_packaged` on any order item by trying sequential IDs.
- **Related:** `getOrdersBySnippetAndSlot` (`:278-298`) ignores snippet `validTill` and never checks that the slot belongs to the snippet or its region. One valid code returns another region's customer orders.
#### H5. An address outside every delivery area takes the region the client sends ✓
- **Where:** `user-apis/apis/order.ts:80-90`.
- **Cause:** when the address has coordinates but `resolveRegionAndBound` returns null, the `else if` skips `address.regionId`.
- **Impact:** the client's `regionId`/`boundId` then decides pricing, the delivery charge, the free-delivery threshold and whether flash is allowed.
#### H6. A customer can change their mobile number without OTP
- **Where:** `user-apis/apis/auth.ts:303-333`.
- **Scenario:** an attacker sets their account's mobile to a victim's unregistered number. When the victim later logs in by OTP, they land in the attacker's account.
#### H7. The profile image path can read other buckets
- **Where:** `user-apis/apis/auth.ts:129,173,180,282,335` → `s3-client.ts:160-179`.
- **Cause:** `profileImageUrl` accepts any string, and `new URL` collapses `../`. A value like `../meatfarmer-dev/<key>` returns a signed GET URL for another bucket's object.
- **Confidence:** medium. It depends on the R2 key having access to more than one bucket.
#### H8. The cart picks delivery slots that have already closed (user-ui and server) ✓
- **Where:** `apps/user-ui/components/cart-page.tsx:806-824` and `:450`, `hooks/useProductSlotIdentifier.ts:21-23`, `components/floating-cart-bar.tsx:144-152`, and the server's `getAllSlotsWithProductsForCache` (`packages/db_helper_sqlite/src/stores/store-helpers.ts:371-376`).
- **Cause:** all of these filter only `deliveryTime > now` and ignore `freezeTime`.
- **Scenario:** after a slot's freeze time, the cart still auto-selects it as the earliest slot, then shows "slot has closed" and blocks checkout.
#### H9. A slot picked in the user-ui cart reverts on any cart refetch
- **Where:** `cart-page.tsx:788-831`.
- **Cause:** the effect depends on `cartItems` and rewrites each slot from the saved `item.slotId`. The choices made in `setSelectedSlots` and "Deliver all at…" are never saved.
- **Scenario:** change a slot, then tap +/- or let the app regain focus. The slot jumps back.
#### H10. web-ui: lowering quantity to 0 never removes the item ✓
- **Where:** `apps/web-ui/src/components/ProductCard.tsx:68`, `routes/home.product.$id.tsx:77`, `routes/flash.tsx:433`.
- **Cause:** these pass the cart line's `id` (a `Date.now()` value), but `useRemoveFromCart` (`hooks/cart-query-hooks.ts:128-142`) filters by `skuId`.
#### H11. web-ui ignores the per-area "flash delivery enabled" setting
- **Where:** `apps/web-ui/src/components/AddToCartDialog.tsx:34` hardcodes `isFlashDeliveryEnabled = true`, and `/flash` has no gate. user-ui blocks the flash section in `flash-delivery/_layout.tsx:14`.
- **Impact:** production crons switch flash off every day, and web users can still check out. Their orders then fail with a 403.
#### H12. web-ui never repairs expired cart slots and can pick a past slot
- **Where:** `apps/web-ui/src/hooks/useProductSlotIdentifier.ts:16-21` returns `slots[0]` unsorted, with no time filter, and there is no `useReconcileCartSlots` equivalent. `PaymentAndOrderComponent.tsx:104` sends the stored `slotId` as is.
- **Impact:** checkout fails with "Selected delivery slot is closed for orders", and `/cart` gives no way to change the slot.
#### H13. web-ui checkout sends out-of-stock and non-flash items, so the whole order is rejected
- **Where:** `components/PaymentAndOrderComponent.tsx:101-111`, `routes/flash.checkout.tsx:93`, `routes/home.checkout.tsx:93`. user-ui filters these out (`PaymentAndOrderComponent.tsx:121-131`).
- **Impact:** one out-of-stock line blocks checkout on web, and `/cart` shows no out-of-stock indicator.
#### H14. Admin product edit puts every out-of-stock variant back in stock ✓
- **Where:** admin-ui `products/edit.tsx:163-183` and admin-web `dashboard.products.edit.tsx` leave `isOutOfStock` out of the variant payload.
- **Cause:** the server defaults the missing value to `false` (`admin-apis/apis/product.ts:62`) and writes it.
- **Scenario:** fix a typo in a product name, and every out-of-stock variant goes back on sale.
#### H15. Saving a product twice deletes all its images, from storage too
- **Where:** `products/edit.tsx:202` calls `clearImages()` after a successful save while the screen stays open. admin-web does the same (`dashboard.products.edit.tsx:195`).
- **Cause:** on the next save, `ProductForm.tsx:253-261` marks every existing key as deleted, and the server removes the R2 objects (`apis/product.ts:431-436`).
#### H16. Editing a slot that has vendor snippets fails or duplicates them
- **Where:** `SlotForm.tsx:65-70` reads `snippet.name`, but the server only returns `snippetCode` (`db_helper_sqlite/.../slots.ts:110-118`).
- **Effect:** the update fails validation. If the admin types a name, `updateSlotWithRelations` (`slots.ts:382-402`) creates a duplicate snippet with a new code.
#### H17. Admin delivery sequence saves the wrong driver's list
- **Where:** admin-ui `delivery-sequences/index.tsx:432-437, 485-491, 714`, admin-web `dashboard.orders.sequence.tsx:438-457`.
- **Cause:** the "unsaved changes" flag isn't reset when the selected driver changes.
- **Scenario A:** reorder driver A's list, switch to driver B, and save. B's unchanged list is saved, A's reorder is lost, and a success message is shown.
- **Scenario B:** saving while "All Users" (-2) is selected stores a corrupt `"-2"` key. After that, the Unassigned view is always empty and the assignment labels are wrong.
### Medium
#### Backend
- **Cancelled orders can be marked delivered.** `updateOrderDelivered` (`admin-apis/order.ts:134-155`) has no `isCancelled` check, and it sends a "delivered" notification. `updateOrderPackaged(false)` resets `isDelivered=false`, which reopens a delivered order. Neither path rejects archived orders.
- **Complaints can be filed against another user's order.** `user-apis/apis/complaint.ts:34-48` never checks `orderId` against the user.
- **Cache versions can collide.** `region-cache-versions.ts:40-60` reads the version and then writes +1. Concurrent slot, stock or price mutations can get the same version, and the client never refetches. Fix: `UPDATE … SET value = value + 1 RETURNING value`.
- **Fractional quantities can never be ordered.** `placeOrder` requires `quantity: z.number().int()` (`order.ts:375`), while `increment_step` is a `real` column.
- **Combo-only SKUs can be bought on their own.** `order.ts:164-171` doesn't check `isComboOnly`.
- **Staff roles are never enforced.** Any staff member, even a `marketer`, can call `createStaffUser` with a `super_admin` role.
- **OTP and login have no rate limits.** OTP inputs are also put into the provider URL without escaping (`otp-utils.ts:35,57`). User login and register also reveal whether an account exists.
- **Missing indexes.** The hot foreign keys have none: `orders.user_id`, `order_items.order_id`, `order_status.order_id`, `coupon_usage(user_id, coupon_id)`, `addresses.user_id`, `notifications.user_id`, `notif_creds.user_id`, `product_skus.product_id`. D1 bills per row read.
- **Schema and migration drift.** Snapshots stop at 0002 while the journal goes to 0006, so the next `drizzle-kit generate` will produce a wrong migration. `schema.ts` doesn't declare the `idx_*_region` indexes, so they would be dropped. Its `region_id` nullability also doesn't match the database, and `reserved_coupons.region_id` has no foreign key.
- **Migration 0006 reuses an old filename.** Databases that applied the old 0006–0009 files may never run the squashed content. Confidence: low–medium.
#### user-ui
- **Stale selected address.** `useAddressStore` isn't reset on logout (`AuthContext.tsx:50-64`) or on address delete. Checkout shows the default address but submits the stale id, and the order fails with "Invalid address".
- **The Add-to-Cart dialog allows quantity 0** (`AddToCartDialog.tsx:261-266`). The server then rejects the whole order.
- **The flash cart bill includes items that can't be delivered by flash** (`cart-page.tsx:357-373, 491-510`). The coupon and free-delivery thresholds pass in the cart but fail at checkout.
- **A successful order clears the whole local cart**, including items that weren't ordered (`PaymentAndOrderComponent.tsx:59-62,94`).
- **`useAuthenticatedRoute` can push the login screen several times** because its focus callback is an inline function (`hooks/useAuthenticatedRoute.ts:16`).
#### web-ui
- **Login shows no errors at all** (`routes/login.tsx`).
- **The address list doesn't refresh.** The invalidation calls use the wrong key format, `['user.address.getUserAddresses']`, so they do nothing (`CheckoutAddressSelector.tsx:35`, `checkout-hooks.ts:71`, `checkout.tsx:130`).
- **Flash cart, checkout and success screens show the wrong price.** They use `price` instead of `flashPrice`, and the flash delivery charge is left out.
- **Logout leaves the previous user's data.** It doesn't call `queryClient.clear()` (`lib/auth-context.tsx:101-112`). The next user sees the previous user's cached data, and `RegionGate` writes it into the new user's snapshot.
- **The success page shows a locally computed total** instead of the server's `totalAmount`.
#### admin-ui and admin-web
- **A price-dialog save with no real change fails the whole batch** ("No price fields to update"). It also drops an earlier Flash toggle.
- **Coupon edit can't switch discount type or clear optional fields**, because `undefined` means "keep the current value".
- **Every coupon edit cuts `validTill` down to midnight.**
- **Coupon edit doesn't load `exclusiveApply` or `applicableUsers`.** Picking users then replaces the existing list.
- **admin-web toggles stock for the whole product instead of per variant** (`dashboard.products.tsx:85-87`).
- **The admin-ui orders list may crash.** `orders/index.tsx:186` uses `{score && score > 0 && …}`, which renders a bare `0` outside `<Text>`. Not reproduced on a device.
- **Rebalance has no confirmation and no double-submit guard**, and it shows "Rebalance Complete" from `onSettled`, so it also appears on errors.
### Low
- **Unchecked env values.** `env-exporter.ts:104-106`: if `MIN_ORDER_VALUE` or `DELIVERY_CHARGE` is missing they become `NaN`, and the delivery charge is silently never applied.
- **Unused setting.** `minOrderAmountForCoupon` is editable but never enforced.
- **Blind SSRF.** Possible through `googleMapsUrl` (`license-util.ts:3`).
- **Loose upload URLs.** They don't sign Content-Type, customers can write to admin asset folders, and keys collide when several MIME types are requested at once.
- **Large build artifacts tracked.** `apps/admin-ui/mfa_20_mar_dev.apk` (92 MB), `apps/user-ui/user-ui-shafi-dev-arm.apk` (35 MB), a 17 MB binary in `.opencode/`, `.expo` caches and `web-ui/.output`. Not a secret risk, but every clone and CI checkout pays for it.
- **Stale Docker setup.** It targets the old Postgres/Node backend, so it no longer describes how the app actually runs.
- **ProductCard re-renders every 5 s.** user-ui `ProductCard.tsx:62-67` bumps an unused `updater` state.
- **Delivery notes carry over.** `useCheckoutStore.userNotes` survives a successful order and logout.
- **Malformed checkout links crash.** A `slots` deep link without `:` crashes the checkout screen (`checkout-page.tsx:83-90`).
- **Cancelling "Remove item" resets the displayed quantity to 1** instead of the stored quantity.
- **Cart writes have no locking.** Read-modify-write on AsyncStorage can lose updates.
- **web quantity buttons ignore min/max.** The web `Quantifier` doesn't enforce them for steps that don't divide evenly, and fractional steps build up float error.
- **superadmin-ui and fallback-ui don't check token expiry.** The superadmin profile is also not restored after a reload.
- **Suspending a user fails silently** in the admin UI.
- **Two admin delivery-sequence problems.** The order menu shows stale status after an update, and selected order ids carry over when switching slots.
- **Large reads.** Slot and cache reads load the whole `productSkus` table, and the `!item.isDeleted` filter is a no-op because the column isn't selected.
- **web flash memoisation doesn't hold.** web `flash.tsx`'s `handleAddToCart` depends on the `useMutation` result object, which is new on every render, so the memo is ineffective.
- **Home ordering goes stale.** user-ui `getQuickestSlot` is memoised but depends on time, so the home catalogue ordering goes stale as slots expire.
### Checked and fine
- Address queries filter by `userId`, so there is no address IDOR.
- `/api/test` routes are gated by `ENABLE_TEST_ROUTES`.
- JWTs use HS256 and carry an expiry.
- The raw `sql` usage that was checked is parameterised.
- Prices are computed on the server, and discounts are capped at the subtotal.
- Scheduled orders enforce freeze time on the server.
- Catalogue image cache-busting only touches public asset URLs.
- web-ui has no `dangerouslySetInnerHTML`.
---
## Round 2 — deeper review
Round 2 was done by reading the code directly, since the scheduled reviewers were unavailable. Items marked ✓ were read and confirmed in the source.
### High
#### R2-1. The test suite asserts the auth holes as "current" behaviour ✓
- **Where:** `apps/backend/tests/api/auth-matrix.test.ts`.
- **What it does:**
- `AUTH-03` asserts that a customer token succeeds on `admin.vendorSnippets.getAll` and `admin.staffUser.getStaff`, and gets 500s from the other admin reads.
- `AUTH-04` asserts that a customer token passes the admin write guard, then *actually suspends a throwaway user* with a customer token and asserts `isOk === true`.
- `HARNESS-13` and `AUTH-11` assert that a suspended user still passes tRPC.
- **Why it matters:** these tests pass today, so a green suite does not mean the authorization is correct. Fixing C2 and H3 requires rewriting these cases; until then the suite actively protects the vulnerability.
#### R2-2. `web-ui` and `admin-web` have no tests at all ✓
- **Counts:** user-ui 56 test files, admin-ui 65, backend 72, web-ui 0, admin-web 0.
- **Impact:** every web-only bug found in round 1 (cart removal, flash gate, address invalidation keys, logout cache, wrong flash prices) is uncovered. The project rule that admin-ui and user-ui changes must be mirrored on web makes this the highest-risk blind spot, because the web copies drift without any test to catch it.
### Medium
#### R2-3. Cancelling an order always returns a 500 with a generic message ✓
- **Where:** `apps/backend/src/trpc/apis/user-apis/apis/order.ts:633-690`.
- **Cause:** the handler `catch`es every error and rethrows `new ApiError("failed to cancel order")`. `ApiError` defaults to status 500.
- **Effect:** "Order not found" (404), "already cancelled" (400) and "Cannot cancel delivered order" (400) all reach the client as a 500 "failed to cancel order". The specific messages only reach the logs.
- **Second effect:** `publishCancellation` is awaited *after* the cancel transaction. If the queue publish fails, the user is told the cancellation failed even though it succeeded. Retrying then hits "already cancelled", which also surfaces as the same generic 500.
- **Fix:** rethrow `ApiError` unchanged, and only wrap unknown errors.
#### R2-4. A coupon can increase the amount the customer pays ✓
- **Where:** `packages/shared/cart-pricing.ts:493-494`.
- **Cause:** `finalTotal = goodsSubtotal - discountTotal`, then `deliveryTotal = finalTotal < threshold ? charge : 0`. The free-delivery threshold is tested **after** discounts.
- **Example:** goods ₹500, threshold ₹500, delivery charge ₹60, coupon ₹50. Without the coupon the total is ₹500 (free delivery). With it, ₹450 is below the threshold, so the total becomes ₹510. Applying the coupon costs ₹10 more.
- **Note:** the user-ui cart (`cart-page.tsx:620-638`) and the server agree, because both apply the same rule, so the bill is consistent but wrong from the customer's point of view.
- **Fix:** compare the threshold against the pre-discount goods subtotal, or never charge more than the no-coupon total.
#### R2-5. Queue consumers are not idempotent and have no per-message handling ✓
- **Where:** `apps/backend/src/lib/queue-consumer.ts`.
- **Cause:** `handleNotifQueue`, `handleOrderPlacedQueue` and `handleOrderCancelledQueue` loop over `batch.messages`, await each, and never call `ack()` or `retry()`.
- **Effect:** any throw inside the loop fails the whole batch, so Cloudflare retries all messages, including the ones already processed. That means duplicate pushes and repeated order-placed side effects. A single poison message retries the entire batch until the retry limit.
- **Fix:** catch per message, `message.ack()` on success and `message.retry()` on failure, or make the handlers idempotent (for example, keyed on order id).
#### R2-6. `runBatched` promises a rollback that cannot happen ✓
- **Where:** `packages/db_helper_sqlite/src/lib/run-batched.ts`.
- **Cause:** its doc comment says "All chunks commit together, or the whole thing rolls back", but it runs inside `db.transaction`, which is the no-op from H1.
- **Effect:** callers relying on the documented atomicity (archive and order-item chunking) get partial writes on failure.
#### R2-7. Checkout delivery notes leak between orders and between users ✓
- **Where:** `apps/user-ui/src/store/checkoutStore.ts`, used at `cart-page.tsx:287` and `PaymentAndOrderComponent.tsx:56`.
- **Cause:** `userNotes` is never reset after a successful order or on logout (`AuthContext.clearSession` clears the token and the query cache only).
- **Effect on a shared device:** the next user's first order is pre-filled with the previous user's delivery instructions, and is submitted with them unless the field is edited. On the same account, every order carries the previous order's note.
#### R2-8. Cart quantity 0 is displayed as the stored quantity ✓
- **Where:** `apps/user-ui/components/cart-page.tsx:488-499, 357-372`.
- **Cause:** `quantities[item.id] || item.quantity` treats a pending 0 as "not set".
- **Effect:** when a decrement to 0 is pending or was cancelled, the cart bill and coupon maths use the stored quantity while the row shows 0. This compounds the round-1 Low item "Cancelling 'Remove item' resets the displayed quantity to 1 instead of the stored quantity".
### Low
#### R2-9. Production CORS allows local and LAN origins with credentials ✓
- **Where:** `apps/backend/src/app.ts:17-22`.
- **What's allowed:** `http://localhost:5174/4174/4175/4176` and `http://192.168.100.126:4175`, with `credentials: true`, in the production worker.
- **Impact:** a process listening on the victim's machine at one of those ports can read authenticated cross-origin responses using the web session cookie. Unlikely, but it should be gated on `NODE_ENV`.
#### R2-10. `user.savePushToken` is a public procedure ✓
- **Where:** `apps/backend/src/trpc/apis/user-apis/apis/user.ts:73`.
- **Intent:** deliberately public so that signed-out devices can register a token, and the region comes from the address.
- **Risk:** an anonymous caller can register or reassign arbitrary Expo tokens and region ids. Worth rate-limiting, or requiring a signed-out device id.
#### R2-11. The flash cron comment is wrong (the logic is not) ✓
- **Where:** `apps/backend/src/lib/flash-delivery-cron.ts:8-9`.
- **Details:** `0 16 * * *` is 21:30 IST, which matches its "9:30 PM IST" comment. `0 1 * * *` is 06:30 IST, but the comment says "6:30 PM IST". That is a sign error in a comment only: flash turns on at 06:30 and off at 21:30.
- **Also:** the toggle calls `computeConstants()` and `refreshGenKv()`, so clients do receive the new bound setting.
#### R2-12. Customer-reachable admin reads confirmed ✓
- `admin.vendorSnippets.getAll` and `admin.staffUser.getStaff` fully succeed for a customer token, since they never touch `ctx.staffUser`. The other admin reads fail with a 500 (TypeError) rather than a 401, as documented in `AUTH-03`.
- **Fix:** route all of them through `staffProcedure`.
### Verified as correct (so these are not re-reported later)
- **Region scoping is sound.** A script check over every exported helper in `packages/db_helper_sqlite/src/{admin,user,superadmin}-apis`, `stores` and `lib` found that every function that accepts `regionId` uses it in its query.
- **User ownership is sound.** Every helper that accepts `userId` uses it. Address, order and complaint reads are properly scoped (the complaint *write* gap is listed separately).
- **Order money maths is server-authoritative.** Prices come from the database. The free-delivery threshold, coupon stacking, sub-order splitting and the single delivery charge on the primary sub-order all behave consistently, and the shared helper uses the same ordering on client and server.
- **Slot rules are enforced on the server.** Existence, region, active flag, freeze time, delivery time and SKU membership are all checked in `placeOrder` for scheduled orders. Flash is re-checked against the bound setting.
- **Cron wiring covers all three schedules.** Archive at `30 20`, flash off at `0 16`, flash on at `0 1`.
- **API tests target `localhost:8787` by default**, so they do not point at production.
---
## Suggested order of work
1. **Containment (do first, regardless of code fixes)**
- Verify and change the production superadmin password, and add a way to rotate it.
- Stop tracking the build artifacts (APKs, `.wrangler` state, `.expo`, `web-ui/.output`); they are repo bloat rather than a secret risk.
- Give dev its own D1 database, and fix or delete `reset-remote-db.sh`.
2. **Authorization**
- Add a `staffProcedure` gate to the whole admin router (C2).
- Fix the suspension check in `app.ts` (H3).
- Make `updateOrderItemPackaging` authenticated (H4).
- Then rewrite `AUTH-03/04`, `HARNESS-13` and `AUTH-11` so they assert the fixed behaviour (R2-1).
3. **Data integrity**
- Replace `db.transaction` with `db.batch` where atomicity is claimed (H1, R2-6).
- Add an atomic guard for coupon usage (H2).
4. **Slot correctness**
- Filter on `freezeTime` in the cart, `useProductSlotIdentifier`, `floating-cart-bar` and `getAllSlotsWithProductsForCache` (H8).
- Persist the user's slot choice in the cart (H9, H12).
5. **Admin data-loss bugs**
- Out-of-stock flags and images on product edit (H14, H15).
- Slot snippet editing (H16).
- Delivery sequence save-after-switch (H17).
6. **web-ui parity**
- Cart removal (H10).
- Flash gate (H11).
- Checkout filtering (H13).
- Logout cache and address invalidation.
- Add the missing web test coverage (R2-2).
## Coverage notes
- Every app and package was read in round 1: backend (auth, business logic, jobs), `user-ui`, `web-ui`, `admin-ui`, `admin-web`, `superadmin-ui`, `fallback-ui`, `shared`, `ui`, `web-components`, schema and migrations, and infra.
- Round 2 added a full authorization sweep, the order/coupon/slot code paths, jobs and queues, and the cart pricing helper.
- **Less deeply reviewed:** `superadmin-ui` beyond the auth-context issue, `fallback-ui`, `packages/migrator`, and the individual `packages/ui` components. These had a first-pass read only, so treat their sections as non-exhaustive.
- The abandoned `packages/db_helper_postgres` was excluded by project rule.

View file

@ -1,464 +0,0 @@
-- ============================================================
-- address-bound-coord-updates.sql
-- Generated from address_util/vague-address-bounds.txt (416 rows).
--
-- bound_id = 1: 332
-- bound_id = 2: 63
-- bound_id = NULL: 21 (blank Bound in the txt)
-- latitude/longitude updates (area coords): 130
-- vague_backfilled_coords = 1 for every row in this batch.
--
-- Every statement is idempotent and scoped to one id. Every row in the
-- batch also sets vague_backfilled_coords = 1, including the 130 rows that
-- receive area-level coordinates.
--
-- Apply:
-- wrangler d1 execute <db-name> --remote --config wrangler.prod.toml \
-- --file address_util/address-bound-coord-updates.sql
-- ============================================================
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 1;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 2;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 3;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 4;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 5;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 6;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 7;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 8;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 9;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 10;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 11;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 12;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 13;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 14;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 15;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 16;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 21;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 22;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 23;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 25;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 28;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 29;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 30;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 31;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 32;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 33;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 34;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 35;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 36;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 37;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 39;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 40;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 41;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 42;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 43;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 44;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 45;
UPDATE addresses SET bound_id = 2, latitude = 16.755649, longitude = 78.017013, vague_backfilled_coords = 1 WHERE id = 46;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 51;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 52;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 53;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 55;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 56;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 57;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 60;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 66;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 69;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 73;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 74;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 81;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 83;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 84;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 86;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 87;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 88;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 89;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 90;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 91;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 93;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 94;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 95;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 96;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 98;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 99;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 100;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 101;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 102;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 103;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 106;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 108;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 111;
UPDATE addresses SET bound_id = 1, latitude = 16.752972, longitude = 78.017824, vague_backfilled_coords = 1 WHERE id = 112;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 114;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 116;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 117;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 119;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 120;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 121;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 124;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 125;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 126;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 128;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 131;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 135;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 137;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 138;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 139;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 141;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 142;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 146;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 147;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 150;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 151;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 153;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 154;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 155;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 157;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 159;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 162;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 164;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 165;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 166;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 169;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 171;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 172;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 173;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 178;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 179;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 182;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 183;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 184;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 185;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 186;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 188;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 190;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 195;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 196;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 197;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 199;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 203;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 204;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 205;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 208;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 210;
UPDATE addresses SET bound_id = 2, latitude = 16.744645, longitude = 78.014443, vague_backfilled_coords = 1 WHERE id = 211;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 214;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 215;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 216;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 218;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 220;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 222;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 224;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 225;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 227;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 228;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 229;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 230;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 234;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 235;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 236;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 238;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 245;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 246;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 248;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 249;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 251;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 253;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 254;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 258;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 259;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 260;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 261;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 262;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 265;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 268;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 269;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 271;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 272;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 273;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 274;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 276;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 277;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 278;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 279;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 282;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 283;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 285;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 287;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 288;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 289;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 290;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 291;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 295;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 299;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 302;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 303;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 304;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 305;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 309;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 311;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 312;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 316;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 320;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 321;
UPDATE addresses SET bound_id = 2, latitude = 16.744645, longitude = 78.014443, vague_backfilled_coords = 1 WHERE id = 323;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 324;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 327;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 330;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 331;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 333;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 336;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 338;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 345;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 347;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 348;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 350;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 351;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 353;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 357;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 358;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 359;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 360;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 363;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 366;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 368;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 373;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 374;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 377;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 379;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 381;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 382;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 383;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 385;
UPDATE addresses SET bound_id = 2, latitude = 16.724600, longitude = 77.984973, vague_backfilled_coords = 1 WHERE id = 386;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 387;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 390;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 391;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 392;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 401;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 406;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 411;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 415;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 417;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 421;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 425;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 426;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 427;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 430;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 431;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 432;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 435;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 439;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 440;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 446;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 451;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 452;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 453;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 454;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 456;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 459;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 460;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 461;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 462;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 463;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 465;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 471;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 477;
UPDATE addresses SET bound_id = 2, latitude = 16.755649, longitude = 78.017013, vague_backfilled_coords = 1 WHERE id = 482;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 483;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 485;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 487;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 488;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 489;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 490;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 491;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 492;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 494;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 496;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 497;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 504;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 507;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 508;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 511;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 518;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 520;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 524;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 525;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 528;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 530;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 534;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 538;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 539;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 544;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 547;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 549;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 550;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 552;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 554;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 564;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 567;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 568;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 573;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 575;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 577;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 578;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 584;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 587;
UPDATE addresses SET bound_id = 1, latitude = 16.752972, longitude = 78.017824, vague_backfilled_coords = 1 WHERE id = 588;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 589;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 591;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 592;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 593;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 594;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 596;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 597;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 598;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 600;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 602;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 605;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 607;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 609;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 613;
UPDATE addresses SET bound_id = 2, latitude = 16.755649, longitude = 78.017013, vague_backfilled_coords = 1 WHERE id = 614;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 616;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 617;
UPDATE addresses SET bound_id = 2, latitude = 16.758734, longitude = 78.041012, vague_backfilled_coords = 1 WHERE id = 618;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 619;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 620;
UPDATE addresses SET bound_id = 2, latitude = 16.724600, longitude = 77.984973, vague_backfilled_coords = 1 WHERE id = 622;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 624;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 625;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 626;
UPDATE addresses SET bound_id = 2, latitude = 16.724600, longitude = 77.984973, vague_backfilled_coords = 1 WHERE id = 631;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 632;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 635;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 638;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 640;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 642;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 643;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 644;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 648;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 649;
UPDATE addresses SET bound_id = 2, latitude = 16.758734, longitude = 78.041012, vague_backfilled_coords = 1 WHERE id = 650;
UPDATE addresses SET bound_id = 1, latitude = 16.758734, longitude = 78.041012, vague_backfilled_coords = 1 WHERE id = 655;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 656;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 658;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 659;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 661;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 665;
UPDATE addresses SET bound_id = 2, latitude = 16.753344, longitude = 78.032133, vague_backfilled_coords = 1 WHERE id = 667;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 670;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 673;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 679;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 682;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 684;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 688;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 691;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 692;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 695;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 698;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 704;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 706;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 707;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 708;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 713;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 714;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 717;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 720;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 722;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 726;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 730;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 735;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 738;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 741;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 743;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 744;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 745;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 753;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 754;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 755;
UPDATE addresses SET bound_id = 2, latitude = 16.755649, longitude = 78.017013, vague_backfilled_coords = 1 WHERE id = 756;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 761;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 766;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 768;
UPDATE addresses SET bound_id = 2, latitude = 16.721995, longitude = 78.018658, vague_backfilled_coords = 1 WHERE id = 769;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 775;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 780;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 782;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 783;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 784;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 785;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 788;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 795;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 799;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 802;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 807;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 808;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 809;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 811;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 814;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 816;
UPDATE addresses SET bound_id = 1, latitude = 16.740450, longitude = 78.004159, vague_backfilled_coords = 1 WHERE id = 817;
UPDATE addresses SET bound_id = 2, latitude = 16.744645, longitude = 78.014443, vague_backfilled_coords = 1 WHERE id = 818;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 820;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 825;
UPDATE addresses SET bound_id = 2, vague_backfilled_coords = 1 WHERE id = 829;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 830;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 834;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 843;
UPDATE addresses SET bound_id = 2, latitude = 16.760099, longitude = 78.009772, vague_backfilled_coords = 1 WHERE id = 844;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 846;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 848;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 849;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 855;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 856;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 857;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 858;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 859;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 862;
UPDATE addresses SET bound_id = 1, latitude = 16.752972, longitude = 78.017824, vague_backfilled_coords = 1 WHERE id = 864;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 870;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 871;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 872;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 874;
UPDATE addresses SET bound_id = NULL, vague_backfilled_coords = 1 WHERE id = 875;
UPDATE addresses SET bound_id = 2, latitude = 16.749234, longitude = 78.027886, vague_backfilled_coords = 1 WHERE id = 877;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 882;
UPDATE addresses SET bound_id = 1, latitude = 16.733798, longitude = 77.999953, vague_backfilled_coords = 1 WHERE id = 883;
UPDATE addresses SET bound_id = 1, latitude = 16.752972, longitude = 78.017824, vague_backfilled_coords = 1 WHERE id = 886;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 887;
UPDATE addresses SET bound_id = 2, latitude = 16.754539, longitude = 78.035332, vague_backfilled_coords = 1 WHERE id = 897;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 898;
UPDATE addresses SET bound_id = 1, latitude = 16.743916, longitude = 78.012978, vague_backfilled_coords = 1 WHERE id = 900;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 903;
UPDATE addresses SET bound_id = 1, vague_backfilled_coords = 1 WHERE id = 909;
UPDATE addresses SET bound_id = 1, latitude = 16.747980, longitude = 78.005575, vague_backfilled_coords = 1 WHERE id = 912;
-- Verification (only the addressed rows):
-- SELECT COUNT(*) AS addressed,
-- SUM(bound_id = 1) AS bound_1,
-- SUM(bound_id = 2) AS bound_2,
-- SUM(bound_id IS NULL) AS bound_null,
-- SUM(vague_backfilled_coords = 1) AS vague
-- FROM addresses WHERE id IN (
-- 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 21, 22, 23, 25,
-- 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 39, 40, 41, 42, 43, 44, 45, 46, 51, 52,
-- 53, 55, 56, 57, 60, 66, 69, 73, 74, 81, 83, 84, 86, 87, 88, 89, 90, 91, 93, 94,
-- 95, 96, 98, 99, 100, 101, 102, 103, 106, 108, 111, 112, 114, 116, 117, 119, 120, 121, 124, 125,
-- 126, 128, 131, 135, 137, 138, 139, 141, 142, 146, 147, 150, 151, 153, 154, 155, 157, 159, 162, 164,
-- 165, 166, 169, 171, 172, 173, 178, 179, 182, 183, 184, 185, 186, 188, 190, 195, 196, 197, 199, 203,
-- 204, 205, 208, 210, 211, 214, 215, 216, 218, 220, 222, 224, 225, 227, 228, 229, 230, 234, 235, 236,
-- 238, 245, 246, 248, 249, 251, 253, 254, 258, 259, 260, 261, 262, 265, 268, 269, 271, 272, 273, 274,
-- 276, 277, 278, 279, 282, 283, 285, 287, 288, 289, 290, 291, 295, 299, 302, 303, 304, 305, 309, 311,
-- 312, 316, 320, 321, 323, 324, 327, 330, 331, 333, 336, 338, 345, 347, 348, 350, 351, 353, 357, 358,
-- 359, 360, 363, 366, 368, 373, 374, 377, 379, 381, 382, 383, 385, 386, 387, 390, 391, 392, 401, 406,
-- 411, 415, 417, 421, 425, 426, 427, 430, 431, 432, 435, 439, 440, 446, 451, 452, 453, 454, 456, 459,
-- 460, 461, 462, 463, 465, 471, 477, 482, 483, 485, 487, 488, 489, 490, 491, 492, 494, 496, 497, 504,
-- 507, 508, 511, 518, 520, 524, 525, 528, 530, 534, 538, 539, 544, 547, 549, 550, 552, 554, 564, 567,
-- 568, 573, 575, 577, 578, 584, 587, 588, 589, 591, 592, 593, 594, 596, 597, 598, 600, 602, 605, 607,
-- 609, 613, 614, 616, 617, 618, 619, 620, 622, 624, 625, 626, 631, 632, 635, 638, 640, 642, 643, 644,
-- 648, 649, 650, 655, 656, 658, 659, 661, 665, 667, 670, 673, 679, 682, 684, 688, 691, 692, 695, 698,
-- 704, 706, 707, 708, 713, 714, 717, 720, 722, 726, 730, 735, 738, 741, 743, 744, 745, 753, 754, 755,
-- 756, 761, 766, 768, 769, 775, 780, 782, 783, 784, 785, 788, 795, 799, 802, 807, 808, 809, 811, 814,
-- 816, 817, 818, 820, 825, 829, 830, 834, 843, 844, 846, 848, 849, 855, 856, 857, 858, 859, 862, 864,
-- 870, 871, 872, 874, 875, 877, 882, 883, 886, 887, 897, 898, 900, 903, 909, 912);

View file

@ -1,50 +0,0 @@
-- Generated by address_util/backfill-address-bounds.ts
-- generated_at: 2026-10-25T06:34:01.225Z
-- source_db: /Users/mohammedshafiuddin/WebDev/freshyo/apps/backend/.wrangler/state/v3/d1/miniflare-D1DatabaseObject/da3a80bd8d2cc8f1f070a313ef55c1800da50af994fa89a51c67a6d3e1f919f2.sqlite
-- thresholds: vague_backfilled_coords excluded=true, outside=set to NULL
-- addresses: total=882 no_coords=0 vague=484 no_region_bounds=0
-- unchanged: 361
-- outside: 28
-- updates: 37
-- resolved: bound=9 (1:0, 2:9, other:0)
--
-- Run against the remote DB with the generated file:
-- wrangler d1 execute <database-name> --remote --config wrangler.prod.toml --file <this file>
--
UPDATE addresses SET bound_id = 2 WHERE id = 70;
UPDATE addresses SET bound_id = NULL WHERE id = 250;
UPDATE addresses SET bound_id = NULL WHERE id = 280;
UPDATE addresses SET bound_id = NULL WHERE id = 310;
UPDATE addresses SET bound_id = 2 WHERE id = 388;
UPDATE addresses SET bound_id = 2 WHERE id = 389;
UPDATE addresses SET bound_id = NULL WHERE id = 394;
UPDATE addresses SET bound_id = 2 WHERE id = 409;
UPDATE addresses SET bound_id = NULL WHERE id = 428;
UPDATE addresses SET bound_id = NULL WHERE id = 442;
UPDATE addresses SET bound_id = NULL WHERE id = 448;
UPDATE addresses SET bound_id = NULL WHERE id = 509;
UPDATE addresses SET bound_id = NULL WHERE id = 517;
UPDATE addresses SET bound_id = 2 WHERE id = 546;
UPDATE addresses SET bound_id = NULL WHERE id = 586;
UPDATE addresses SET bound_id = NULL WHERE id = 599;
UPDATE addresses SET bound_id = NULL WHERE id = 603;
UPDATE addresses SET bound_id = NULL WHERE id = 606;
UPDATE addresses SET bound_id = 2 WHERE id = 611;
UPDATE addresses SET bound_id = NULL WHERE id = 621;
UPDATE addresses SET bound_id = NULL WHERE id = 629;
UPDATE addresses SET bound_id = NULL WHERE id = 637;
UPDATE addresses SET bound_id = NULL WHERE id = 647;
UPDATE addresses SET bound_id = NULL WHERE id = 660;
UPDATE addresses SET bound_id = 2 WHERE id = 664;
UPDATE addresses SET bound_id = NULL WHERE id = 678;
UPDATE addresses SET bound_id = NULL WHERE id = 694;
UPDATE addresses SET bound_id = NULL WHERE id = 696;
UPDATE addresses SET bound_id = NULL WHERE id = 699;
UPDATE addresses SET bound_id = NULL WHERE id = 721;
UPDATE addresses SET bound_id = NULL WHERE id = 734;
UPDATE addresses SET bound_id = 2 WHERE id = 737;
UPDATE addresses SET bound_id = NULL WHERE id = 740;
UPDATE addresses SET bound_id = NULL WHERE id = 765;
UPDATE addresses SET bound_id = NULL WHERE id = 778;
UPDATE addresses SET bound_id = 2 WHERE id = 847;
UPDATE addresses SET bound_id = NULL WHERE id = 881;

File diff suppressed because it is too large Load diff

View file

@ -1,568 +0,0 @@
==============================================================================
AREA / LOCALITY REPORT — vague-backfilled addresses
==============================================================================
Generated: 2026-10-25 13:01 IST
Source db: apps/backend/.wrangler/state/v3/d1/miniflare-D1DatabaseObject/da3a80bd8d2cc8f1f070a313ef55c1800da50af994fa89a51c67a6d3e1f919f2.sqlite
Rows: 416 (vague_backfilled_coords = 1, region 1)
Assigned: 352 (84.6%)
No area: 64
Areas 2+: 55
Areas 1: 38
Dropped: 3 area(s) whose addresses now have admin coords: GPY Colony, Mohamadia Colony, Premnagar
==============================================================================
REPEATED AREAS (2 or more addresses)
==============================================================================
count area
------------------------------------------------------------------------------
27 Shah Saheb Gutta
23 Marlu
20 Mothinagar
14 BK Reddy Colony
12 Habeebnagar
11 Bhageeratha Colony
11 Gol Masjid
11 Ramaiah Bowli
10 Yenugonda
9 Rajendranagar
9 Veerannapet
8 Old Palamoor
7 Lakshmi Nagar Colony
7 Noor Nagar
7 Srinivas Colony
7 TD Gutta
6 BC Colony
6 Hanumanpura
6 RB Palace
5 New Town
5 Shiva Shakti Nagar
4 Brundavan Colony
4 Metugadda
4 Padmavati Colony
4 Palasa Gutta
4 Tayyab Nagar
4 Teachers Colony
4 Venkateshwara Colony
3 Bandameedhi Pally
3 Bhavani Nagar Colony
3 Boyapalli Gate
3 Ganesh Nagar
3 Madina Masjid
3 Masoodnagar
3 Old Hospital Area
3 Palkonda
3 Sagara Colony
3 Vasavi Colony
3 Yedira
2 Alipur
2 Amistapur
2 BN Reddy Colony
2 Christianpally
2 Devuni Gutta
2 Employees Colony
2 Housing Board Colony
2 Kisan Nagar
2 Kurhinishetty Colony
2 Nalbowli
2 Police Line
2 Ravindra Nagar
2 SC Colony
2 Sriram Nagar
2 Tipu Sultan Chowk
2 Vigneshwara Colony
==============================================================================
NOTABLE SPELLING / TRANSLITERATION VARIANTS
==============================================================================
Same place written in more than one way in the address data:
Shah Saheb Gutta <- Shashabgutta, Shah Sahab Gutta, Shah Shab Gutta, Shab Gutta, Shasabgutta, S.S. Gutta, S Guyta
Mothinagar <- Motinagar, Mothi Nagar (incl. "FCD gown motinagar")
Habeebnagar <- Habeeb Nagar (spacing only)
Yenugonda <- Yanugonda, Yenukonda, Yengonda, Youngunda
Bhageeratha Colony <- Bhageritha, Bhagiratha, Bhageerata, Bhageratha
Ramaiah Bowli <- Ramiah Bowli, Ramaiya Bowli, Ramaiyah Bowli, Ramiya Boli, Rama Bouli
Veerannapet <- Veeranapet, Veernapet, Veerana Pet
Lakshmi Nagar Colony <- Laxmi Nagar, Laxminagar, Laxhmenager
Masoodnagar <- Masdoos Nagar, Masdusnagar, Masoosnagar
Tayyab Nagar <- Tayaabnagar
Kurhinishetty Colony <- Kuruhini Shetty Colony
Gol Masjid <- Goal Masjid, Golmasjid
Palasa Gutta <- Palsab Gutta
Tipu Sultan Chowk <- Tippu Sultan Chowk
Boyapalli Gate <- Boyapally, Boyepally
Palkonda <- Palakonda, Palkunda
BC Colony <- B.C. Colony
Kranti Nagar <- Kranti Nager
Srinivas Colony <- Srinivasa Colony, Srinivasa Coloney
Bhavani Nagar Colony <- Bhavaninagar Colony
Padmavati Colony <- Padmavathi, Padhmmavathi
Vigneshwara Colony <- Vigneswara Colony
Shiva Shakti Nagar <- Shiva Shakthi Nagar
Rajendranagar <- Rajendra Nagar
Noor Nagar <- Noori Nagar
Nalbowli <- Nailbowli
Old Palamoor <- Palamoor, Palamour
POSSIBLY DISTINCT — similar names, kept separate
BK Reddy Colony vs BN Reddy Colony <- different initials, not merged
Christianpally vs Christian Colony
New Gunj vs Gunj / Cheruvu Gunj
Pochamma Colony vs Pochamma temple (landmark only)
==============================================================================
AREA DETAIL + SPELLING VARIANTS
==============================================================================
Shah Saheb Gutta — 27 addresses
------------------------------------------------------------------------------
5x shashabgutta ids: 154, 392, 684, 834, 872
5x shah sahab gutta ids: 169, 182, 305, 383, 487
4x shah saheb gutta ids: 492, 785, 825, 912
3x shab gutta ids: 549, 594, 811
3x shashab gutta ids: 552, 593, 607
2x s s gutta ids: 141, 682
2x shah shab gutta ids: 245, 333
1x s guyta ids: 23
1x ss gutta ids: 116
1x shahab gutta ids: 755
Marlu — 23 addresses
------------------------------------------------------------------------------
23x marlu ids: 139, 142, 146, 162, 185, 228, 230, 235, 251, 254, 289, 302 ...
Mothinagar — 20 addresses
------------------------------------------------------------------------------
14x motinagar ids: 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15 ...
4x mothinagar ids: 22, 216, 278, 373
2x mothi nagar ids: 30, 178
BK Reddy Colony — 14 addresses
------------------------------------------------------------------------------
7x bk reddy colony ids: 52, 197, 248, 282, 321, 327, 635
5x b k reddy colony ids: 128, 288, 741, 766, 817
1x b k ready colony ids: 125
1x bk reddy ids: 446
Habeebnagar — 12 addresses
------------------------------------------------------------------------------
8x habeeb nagar ids: 42, 66, 73, 124, 135, 166, 347, 648
4x habeebnagar ids: 108, 150, 153, 874
Bhageeratha Colony — 11 addresses
------------------------------------------------------------------------------
6x bhageeratha ids: 151, 299, 381, 391, 589, 768
1x bhageerata ids: 45
1x bhageritha ids: 99
1x bhageerath ids: 225
1x bhagiratha ids: 587
1x bhageratha ids: 883
Gol Masjid — 11 addresses
------------------------------------------------------------------------------
6x gol masjid ids: 34, 93, 120, 463, 643, 909
3x goal masjid ids: 41, 55, 83
1x gaolnl masjid ids: 51
1x golmasjid ids: 119
Ramaiah Bowli — 11 addresses
------------------------------------------------------------------------------
7x ramaiah bowli ids: 98, 131, 171, 229, 262, 320, 518
1x ramaiyah bowli ids: 348
1x rama bouli ids: 426
1x ramaiahbowli ids: 508
1x ramiya boli ids: 830
Yenugonda — 10 addresses
------------------------------------------------------------------------------
6x yenugonda ids: 539, 626, 730, 816, 843, 897
2x yanugonda ids: 415, 491
1x youngunda ids: 204
1x yenukonda ids: 490
Rajendranagar — 9 addresses
------------------------------------------------------------------------------
5x rajendra nagar ids: 258, 269, 316, 511, 738
4x rajendranagar ids: 259, 260, 497, 638
Veerannapet — 9 addresses
------------------------------------------------------------------------------
4x veerannapet ids: 489, 620, 656, 783
2x veernapet ids: 57, 91
2x veeranapet ids: 425, 544
1x veerana pet ids: 111
Old Palamoor — 8 addresses
------------------------------------------------------------------------------
8x palamoor ids: 32, 155, 165, 291, 338, 351, 494, 692
Lakshmi Nagar Colony — 7 addresses
------------------------------------------------------------------------------
3x laxminagar ids: 273, 366, 390
2x lakshmi nagar ids: 659, 849
1x laxhmenager ids: 227
1x laxmi nagar ids: 368
Noor Nagar — 7 addresses
------------------------------------------------------------------------------
6x noor nagar ids: 1, 2, 3, 21, 25, 74
1x noori nagar ids: 137
Srinivas Colony — 7 addresses
------------------------------------------------------------------------------
3x srinivas colony ids: 84, 357, 877
3x srinivasa colony ids: 90, 613, 665
1x srinivasa coloney ids: 195
TD Gutta — 7 addresses
------------------------------------------------------------------------------
4x td gutta ids: 43, 261, 276, 485
3x t d gutta ids: 36, 101, 421
BC Colony — 6 addresses
------------------------------------------------------------------------------
4x b c colony ids: 451, 452, 453, 454
2x bc colony ids: 625, 698
Hanumanpura — 6 addresses
------------------------------------------------------------------------------
3x hanumanpura ids: 234, 524, 848
2x hanuman pura ids: 196, 520
1x hanmanpura ids: 870
RB Palace — 6 addresses
------------------------------------------------------------------------------
5x rb palace ids: 100, 103, 114, 188, 203
1x rb palce ids: 577
New Town — 5 addresses
------------------------------------------------------------------------------
3x newtown ids: 268, 287, 459
1x newton ids: 218
1x new town ids: 430
Shiva Shakti Nagar — 5 addresses
------------------------------------------------------------------------------
3x shiva shakti nagar ids: 106, 507, 753
2x shiva shakthi nagar ids: 164, 616
Brundavan Colony — 4 addresses
------------------------------------------------------------------------------
3x brundavan ids: 102, 324, 360
1x brundavanam ids: 186
Metugadda — 4 addresses
------------------------------------------------------------------------------
2x mettugadda ids: 440, 846
2x metugadda ids: 567, 717
Padmavati Colony — 4 addresses
------------------------------------------------------------------------------
2x padmavati ids: 112, 588
2x padmavathi ids: 864, 886
Palasa Gutta — 4 addresses
------------------------------------------------------------------------------
1x palsabgutta ids: 483
1x palsab guta ids: 591
1x palasa gutta ids: 857
1x palsab gutta ids: 882
Tayyab Nagar — 4 addresses
------------------------------------------------------------------------------
2x tayyab nagar ids: 173, 754
1x tayaabnagar ids: 530
1x tayyabnagar ids: 554
Teachers Colony — 4 addresses
------------------------------------------------------------------------------
3x teachers colony ids: 462, 722, 795
1x teacher s colony ids: 81
Venkateshwara Colony — 4 addresses
------------------------------------------------------------------------------
2x venkateshwara colony ids: 46, 482
2x venkateswara colony ids: 614, 756
Bandameedhi Pally — 3 addresses
------------------------------------------------------------------------------
1x bandameedipalli ids: 386
1x bandamidepally ids: 622
1x bandameedhi pally ids: 631
Bhavani Nagar Colony — 3 addresses
------------------------------------------------------------------------------
2x bhavani nagar ids: 95, 199
1x bhavaninagar ids: 550
Boyapalli Gate — 3 addresses
------------------------------------------------------------------------------
2x boyapally ids: 679, 784
1x boyapalli ids: 658
Ganesh Nagar — 3 addresses
------------------------------------------------------------------------------
3x ganesh nagar ids: 312, 411, 903
Madina Masjid — 3 addresses
------------------------------------------------------------------------------
3x madina masjid ids: 88, 89, 238
Masoodnagar — 3 addresses
------------------------------------------------------------------------------
1x masdusnagar ids: 274
1x masdoos nagar ids: 290
1x masoosnagar ids: 374
Old Hospital Area — 3 addresses
------------------------------------------------------------------------------
3x old hospital ids: 330, 331, 417
Palkonda — 3 addresses
------------------------------------------------------------------------------
1x palkunda ids: 211
1x palkonda ids: 323
1x palakonda ids: 818
Sagara Colony — 3 addresses
------------------------------------------------------------------------------
3x sagara colony ids: 35, 695, 871
Vasavi Colony — 3 addresses
------------------------------------------------------------------------------
2x vasavi ids: 183, 271
1x vasavidegree ids: 220
Yedira — 3 addresses
------------------------------------------------------------------------------
2x yedira ids: 688, 799
1x edira ids: 60
Alipur — 2 addresses
------------------------------------------------------------------------------
2x alipur ids: 504, 632
Amistapur — 2 addresses
------------------------------------------------------------------------------
1x amistapur ids: 534
1x amisthapur ids: 829
BN Reddy Colony — 2 addresses
------------------------------------------------------------------------------
1x bn reddy colony ids: 279
1x b n reddy colony ids: 379
Christianpally — 2 addresses
------------------------------------------------------------------------------
1x christianpally ids: 222
1x christian palli ids: 775
Devuni Gutta — 2 addresses
------------------------------------------------------------------------------
1x devunigutta ids: 359
1x tirumala devun gutta ids: 456
Employees Colony — 2 addresses
------------------------------------------------------------------------------
2x employees colony ids: 117, 121
Housing Board Colony — 2 addresses
------------------------------------------------------------------------------
2x housing board colony ids: 568, 670
Kisan Nagar — 2 addresses
------------------------------------------------------------------------------
2x kisan nagar ids: 345, 704
Kurhinishetty Colony — 2 addresses
------------------------------------------------------------------------------
1x kuruhini shetty ids: 619
1x kurhinishetty ids: 644
Nalbowli — 2 addresses
------------------------------------------------------------------------------
1x nailbowli ids: 179
1x nal bowli ids: 272
Police Line — 2 addresses
------------------------------------------------------------------------------
2x police line ids: 431, 432
Ravindra Nagar — 2 addresses
------------------------------------------------------------------------------
1x ravindra nagar ids: 303
1x ravindranagar ids: 745
SC Colony — 2 addresses
------------------------------------------------------------------------------
1x sc colony ids: 624
1x s c colony ids: 706
Sriram Nagar — 2 addresses
------------------------------------------------------------------------------
1x sri rama colony ids: 609
1x sriram nagar ids: 713
Tipu Sultan Chowk — 2 addresses
------------------------------------------------------------------------------
2x tipu sultan chowk ids: 236, 427
Vigneshwara Colony — 2 addresses
------------------------------------------------------------------------------
2x vigneshwara ids: 304, 649
==============================================================================
ADDRESSES THAT MENTION MORE THAN ONE AREA
==============================================================================
Grouped under the first (more specific) area; the others are listed too.
id grouped under also mentions
------------------------------------------------------------------------------
98 Ramaiah Bowli One Town
101 TD Gutta Nalbowli
139 Marlu Employees Colony
146 Marlu Employees Colony
222 Christianpally Bhavani Nagar Colony
271 Vasavi Colony Yenugonda
290 Masoodnagar Gol Masjid
304 Vigneshwara Colony Marlu
333 Shah Saheb Gutta Tipu Sultan Chowk
345 Kisan Nagar Old Hospital Area
366 Lakshmi Nagar Colony Venkateshwara Colony
451 BC Colony Yenugonda
452 BC Colony Yenugonda
453 BC Colony Yenugonda
454 BC Colony Yenugonda
550 Bhavani Nagar Colony Christianpally
554 Tayyab Nagar Ramaiah Bowli, RB Palace
578 Mythri Nagar Balaji Nagar
596 New Gunj Gunj
609 Sriram Nagar Yenugonda
625 BC Colony Amistapur
649 Vigneshwara Colony Marlu
655 Pochamma Colony Yenugonda
656 Veerannapet Madina Masjid
695 Sagara Colony Yenugonda
713 Sriram Nagar Yenugonda
761 Dhanalaxmi Colony Teachers Colony
858 Chaitanya Nagar Colony Yedira
887 Marlu Shah Saheb Gutta
==============================================================================
AREAS WITH EXACTLY ONE ADDRESS
==============================================================================
AZ Colony id 401 line2: Opp municipal park az colony ground floor
Ayodhyanagar Colony id 190 line2: Junaid ku maalum hai...
Balaji Nagar id 809 line2: (blank line2)
Chaitanya Nagar Colony id 858 line2: Chaitanya nagar colony yedira road
Chinndharpally id 714 line2: (blank line2)
Christian Colony id 807 line2: (blank line2)
Dhanalaxmi Colony id 761 line2: Beside anjaneya temple and behind oak ridge school
Divitipally id 538 line2: (blank line2)
Doddalonipally id 844 line2: Masjid arafath pillamari road
Jayashankar Colony id 385 line2: Near bypass road , near chowrasta
KTR Nagar id 253 line2: (blank line2)
Kamla Nehru Colony id 743 line2: Behind Avanthi hotel,kamla nehru colony
Khaleel Chowk id 461 line2: Khaleel chok
Kidwaipet id 673 line2: Old bustand
Kranti Nagar id 618 line2: (blank line2)
Madhuranagar Colony id 295 line2: (blank line2)
Madugu Nagar Colony id 600 line2: Madugu nagar colony opp Hanuman temple
Manikonda id 875 line2: Manikonda
Manyamkonda id 159 line2: (blank line2)
Maruthi Nagar id 708 line2: Maruthi Nagar road number 2
Mythri Nagar id 578 line2: House no 14-4-186-C
Nagireddy Colony id 575 line2: Road number 5
New Gate id 460 line2: Ali Masjid
New Gunj id 596 line2: New gunj
One Town id 172 line2: 1 town back side alis mart colony
Panchowrastha id 56 line2: Panchowrastha
Pasula Kistta Reddy Colony id 283 line2: (blank line2)
Pochamma Colony id 655 line2: (blank line2)
Pragathi Nagar id 309 line2: Near park
Raj Colony id 406 line2: Right second house
Sathyamanna Colony id 650 line2: (blank line2)
Siddarth Nagar id 769 line2: Back side eenadu office
Subhash Nagar id 782 line2: (blank line2)
Talab Katta id 44 line2: Talab katta
Veepurigeri id 780 line2: Near Hanuman temple
Veerabhadra Colony id 592 line2: Patha gate mahabubnagar
Vinayaka Nagar id 642 line2: Vinayaka nagar colony mahabubnagar bypass road str
Vivekananda Colony id 667 line2: Near ram reddy eye hospital
==============================================================================
NO AREA DETECTED (landmark / junk / city only)
==============================================================================
id 28 line2: H line1: Hh
id 29 line2: H line1: Hh
id 31 line2: 11 line1: 1-10
id 33 line2: (blank line2) line1: Yogi tiffin
id 37 line2: (blank line2) line1: Hjuu
id 39 line2: (blank line2) line1: near bharath talkies road,beside punjab bakery
id 40 line2: Address line 2 optional line1: Address line 1
id 53 line2: Opp golbanglaw beside royal cement n steel line1: House no 1-1-77/b/3
id 69 line2: Fz water plant patel masjid line1: 3-11-137/A/11Veernapet shareef calony
id 86 line2: (blank line2) line1: Balaji convention hall
id 87 line2: (blank line2) line1: rayeesa masjid trasfaram mbnr
id 94 line2: Near, Masjid e Mustafa line1: H.no 14-8-121
id 96 line2: (blank line2) line1: Opposite of Malabar gold and diamonds
id 126 line2: Opp rayeesa masjid line line1: H.no.5-7-30/L/10/C
id 138 line2: Pasula kistta reddy colony line1: 14_6_13/9/a2
id 147 line2: 1-10-87/3/A line1: 1-10-87/3/A
id 157 line2: Beside masjid e ibrahim back road line1: 14-6-14/6
id 184 line2: (blank line2) line1: 1-10-95/A/5 Behind Cosmic Sanitary Near Graveyard Main Gate
id 205 line2: (blank line2) line1: Near karishma kiranam
id 208 line2: Just opposite to dmart nallagandla line1: A 2004,aprna sarovar zenith near neo mall
id 210 line2: (blank line2) line1: Opposite pragna high school
id 214 line2: (blank line2) line1: C-71
id 215 line2: Near daksha high school line1: Malabargold beside lane
id 224 line2: 5-7-35/l/9 line1: Khaja kiranam
id 246 line2: Imran kiranam line1: Pochamma temple
id 249 line2: (blank line2) line1: Near Almas function hall
id 277 line2: Dargah line1: 5-64/c
id 285 line2: Mbnr line1: Mbnr
id 311 line2: H.no.1-10-19/3/6/a line1: Two taps
id 336 line2: (blank line2) line1: N
id 350 line2: (blank line2) line1: Neat o baby store
id 358 line2: (blank line2) line1: SVS medical collage pg boys hostel
id 363 line2: (blank line2) line1: Mahabubnagar
id 377 line2: (blank line2) line1: SVS staff quarters 303
id 382 line2: (blank line2) line1: Near fareed madarsa street no. 3
id 387 line2: Sofiya masjid line1: Devar katra raad
id 435 line2: Opp Hdfc bank Standard Electrical line1: 5-4-102 ,Taj-Un-Najm,
id 439 line2: Beside iron shop green gate 1st floor line1: 2-9-15 expert high school lane opposite transformer
id 465 line2: Near asif kiranam store line1: Basravi function hall
id 471 line2: Police headcoutar line1: Monappagutta chai duniya
id 477 line2: Grave yard line1: Behind Cosmic sanitary
id 488 line2: (blank line2) line1: Panchavati school
id 496 line2: Bsn Reddy apartment 1 flour line1: Goutam hospital opposite
id 525 line2: Ground floor line1: Near navodaya hospital
id 547 line2: (blank line2) line1: Mlm na 😜
id 564 line2: (blank line2) line1: Flat no 3007 3rd floor PBR Residency
id 573 line2: Near Nalanda Auto Stand line1: F.n.414,Metropolis Manatown Aprtment
id 602 line2: Shivalayam temple road line1: Near Fathima Vidyalayam school,
id 605 line2: (blank line2) line1: Near janatha garrage
id 640 line2: Old Central library line1: Old Central library
id 691 line2: Near svs near hospital and college line1: Sai ram mess
id 707 line2: (blank line2) line1: 14-11-8/5/2 near mi Eden plaza function hall
id 726 line2: Dk aruna downstreet line1: Bangaru mysamma temple opp street
id 735 line2: Meraj masjid gate opposite lane line1: Saddalgundu
id 744 line2: Opposite Gayatri appartment line1: Aleem trader's
id 788 line2: Near pista House bypass 🛣️ line1: PBR residency 3rd floor b block 3016
id 808 line2: Hanuman temple line1: Svdc college back side Hanuman temple
id 814 line2: Near srikrishna theatre mahabubnagar line1: Aleem traders opposite Gayatri appartment
id 820 line2: (blank line2) line1: Samreen chicken center
id 855 line2: Opposite Sarika township flat no.505 line1: Giridhari construction , green meridian county
id 856 line2: Opposite Sarika township line1: Giridhari construction green meridian apartment
id 859 line2: Akbar masjid road line1: Mg functional
id 862 line2: Near nalanda auto stand line1: Kakatiya techno school
id 898 line2: (blank line2) line1: Habeeb manzil
==============================================================================

View file

@ -1,378 +0,0 @@
#!/usr/bin/env bun
/**
* backfill-address-bounds — one-off data script (LOCAL DB -> SQL file).
*
* Reads a LOCAL SQLite copy of the D1 database, resolves every address to the
* bound of its region that contains its coordinates (lowest priority wins,
* exactly like `resolveRegionAndBound` in src/lib/region-geo.ts), and emits a
* plain SQL file:
*
* UPDATE addresses SET bound_id = 2 WHERE id = 123;
*
* Run the generated file against the remote DB yourself:
*
* wrangler d1 execute <database-name> --remote \
* --config wrangler.prod.toml --file address-bound-updates.sql
*
* Usage (from the repo root):
*
* bun run address_util/backfill-address-bounds.ts
* bun run address_util/backfill-address-bounds.ts --db apps/backend/dumps/copy.sqlite \
* --out /tmp/address-bound-updates.sql
* bun run address_util/backfill-address-bounds.ts --include-vague
* bun run address_util/backfill-address-bounds.ts --keep-outside
*
* Options:
* --db <path> Local SQLite file. Default: auto-discovers the D1 file
* under .wrangler/state/v3/d1/miniflare-D1DatabaseObject.
* --out <path> Output .sql file. Default: address_util/address-bound-updates.sql
* --include-vague Also resolve addresses whose coordinates are the migration's
* fabricated region centre (vague_backfilled_coords = 1).
* --keep-outside Do not touch addresses that fall outside every polygon.
* Default: set bound_id = NULL for them.
* --help Show this help.
*
* Nothing is written to the database: the only side effect is the .sql file.
*/
import { Database } from 'bun:sqlite'
import { existsSync, mkdirSync, readdirSync, writeFileSync } from 'node:fs'
import { dirname, join, resolve } from 'node:path'
import { booleanPointInPolygon } from '@turf/boolean-point-in-polygon'
import { point as turfPoint, polygon as turfPolygon } from '@turf/helpers'
const USAGE = `backfill-address-bounds — emit UPDATE statements for addresses.bound_id
Usage:
bun run address_util/backfill-address-bounds.ts [options]
Options:
--db <path> Local SQLite file (default: auto-discover .wrangler D1 file)
--out <path> Output .sql file (default: address_util/address-bound-updates.sql)
--include-vague Include vague_backfilled_coords = 1 rows
--keep-outside Leave addresses that fall outside all polygons untouched
--help Show this help
`
const argv = process.argv.slice(2)
const has = (name: string) => argv.includes(`--${name}`)
if (has('help') || has('h')) {
console.log(USAGE)
process.exit(0)
}
function option(name: string): string | undefined {
const eq = argv.find((arg) => arg.startsWith(`--${name}=`))
if (eq) return eq.slice(name.length + 3)
const index = argv.indexOf(`--${name}`)
if (index !== -1 && argv[index + 1] && !argv[index + 1].startsWith('--')) {
return argv[index + 1]
}
return undefined
}
const REPO_ROOT = resolve(import.meta.dir, '..')
const BACKEND_DIR = join(REPO_ROOT, 'apps/backend')
const includeVague = has('include-vague')
const keepOutside = has('keep-outside')
/* -------------------------------------------------------------------------- */
/* Resolve the local DB + output paths */
/* -------------------------------------------------------------------------- */
function discoverLocalDb(): string {
const d1Dir = join(BACKEND_DIR, '.wrangler/state/v3/d1/miniflare-D1DatabaseObject')
if (!existsSync(d1Dir)) {
throw new Error(`No local D1 directory at ${d1Dir}. Pass --db <path>.`)
}
const files = readdirSync(d1Dir).filter(
(file) => file.endsWith('.sqlite') && !file.startsWith('metadata')
)
for (const file of files) {
const fullPath = join(d1Dir, file)
try {
// Opened read-write: a WAL database cannot be opened read-only when the
// `-shm` file is absent (server stopped). This script never writes.
const db = new Database(fullPath)
const columns = db
.query("PRAGMA table_info('addresses')")
.all() as Array<{ name: string }>
db.close()
const names = new Set(columns.map((column) => column.name))
if (names.has('bound_id') && names.has('vague_backfilled_coords')) {
return fullPath
}
} catch {
// not a database this script can use; try the next one
}
}
throw new Error(
`No local D1 SQLite file with addresses.bound_id + vague_backfilled_coords under ${d1Dir}. ` +
`Pass --db <path>. Files found: ${files.join(', ') || '(none)'}`
)
}
const dbPath = resolve(option('db') ?? discoverLocalDb())
const outPath = resolve(option('out') ?? join(import.meta.dir, 'address-bound-updates.sql'))
if (!existsSync(dbPath)) {
throw new Error(`SQLite file not found: ${dbPath}`)
}
/* -------------------------------------------------------------------------- */
/* Load rows */
/* -------------------------------------------------------------------------- */
interface BoundRow {
id: number
region_id: number
priority: number
geojson: string | null
}
interface AddressRow {
id: number
region_id: number | null
latitude: number | null
longitude: number | null
bound_id: number | null
vague: number
}
const db = new Database(dbPath)
const addressColumns = (
db.query("PRAGMA table_info('addresses')").all() as Array<{ name: string }>
).map((column) => column.name)
for (const required of ['id', 'region_id', 'latitude', 'longitude', 'bound_id']) {
if (!addressColumns.includes(required)) {
throw new Error(
`addresses.${required} is missing in ${dbPath}. This script expects the regionalized schema.`
)
}
}
const hasVagueColumn = addressColumns.includes('vague_backfilled_coords')
const bounds = db
.query(
`SELECT id, region_id, CAST(priority AS REAL) AS priority, geojson
FROM region_bounds
WHERE geojson IS NOT NULL
ORDER BY region_id ASC, priority ASC, id ASC`
)
.all() as BoundRow[]
const addresses = db
.query(
`SELECT id, region_id, latitude, longitude, bound_id, ${
hasVagueColumn ? 'vague_backfilled_coords' : '0'
} AS vague
FROM addresses
ORDER BY id ASC`
)
.all() as AddressRow[]
db.close()
/* -------------------------------------------------------------------------- */
/* Turn every bound into turf polygons (identical to boundToPolygons) */
/* -------------------------------------------------------------------------- */
type TurfPolygon = ReturnType<typeof turfPolygon>
interface PreparedBound {
id: number
regionId: number
priority: number
polygons: TurfPolygon[]
}
let invalidGeometries = 0
function polygonsOf(geojson: string): TurfPolygon[] {
const polygons: TurfPolygon[] = []
let parsed: any
try {
parsed = JSON.parse(geojson)
} catch {
invalidGeometries += 1
return polygons
}
for (const feature of parsed?.features ?? []) {
const geometry = feature?.geometry
if (!geometry) continue
if (geometry.type === 'Polygon') {
polygons.push(turfPolygon(geometry.coordinates))
} else if (geometry.type === 'MultiPolygon') {
for (const coordinates of geometry.coordinates) {
polygons.push(turfPolygon(coordinates))
}
}
}
return polygons
}
const boundsByRegion = new Map<number, PreparedBound[]>()
for (const bound of bounds) {
const prepared: PreparedBound = {
id: bound.id,
regionId: bound.region_id,
priority: Number(bound.priority),
polygons: polygonsOf(bound.geojson!),
}
if (prepared.polygons.length === 0) continue
const list = boundsByRegion.get(prepared.regionId) ?? []
list.push(prepared)
boundsByRegion.set(prepared.regionId, list)
}
for (const list of boundsByRegion.values()) {
list.sort((a, b) => a.priority - b.priority || a.id - b.id)
}
/* -------------------------------------------------------------------------- */
/* Resolve + build the UPDATE statements */
/* -------------------------------------------------------------------------- */
type Resolution =
| { kind: 'bound'; boundId: number }
| { kind: 'outside' }
| { kind: 'no-bounds' }
function resolveBound(address: AddressRow): Resolution {
if (address.region_id == null) return { kind: 'no-bounds' }
const candidates = boundsByRegion.get(address.region_id)
if (!candidates || candidates.length === 0) return { kind: 'no-bounds' }
const location = turfPoint([address.longitude!, address.latitude!])
for (const bound of candidates) {
if (bound.polygons.some((poly) => booleanPointInPolygon(location, poly))) {
return { kind: 'bound', boundId: bound.id }
}
}
return { kind: 'outside' }
}
const updates: string[] = []
const stats = {
total: addresses.length,
skippedNoCoords: 0,
skippedVague: 0,
skippedNoBounds: 0,
unchanged: 0,
outside: 0,
outsideKept: 0,
bound1: 0,
bound2: 0,
boundOther: 0,
}
const perBound = new Map<number, number[]>()
for (const address of addresses) {
if (address.latitude == null || address.longitude == null) {
stats.skippedNoCoords += 1
continue
}
if (address.vague === 1 && !includeVague) {
stats.skippedVague += 1
continue
}
const resolution = resolveBound(address)
if (resolution.kind === 'no-bounds') {
stats.skippedNoBounds += 1
continue
}
if (resolution.kind === 'outside') {
stats.outside += 1
if (keepOutside) {
stats.outsideKept += 1
continue
}
if (address.bound_id == null) {
stats.unchanged += 1
continue
}
updates.push(`UPDATE addresses SET bound_id = NULL WHERE id = ${address.id};`)
continue
}
if (address.bound_id === resolution.boundId) {
stats.unchanged += 1
continue
}
if (resolution.boundId === 1) stats.bound1 += 1
else if (resolution.boundId === 2) stats.bound2 += 1
else stats.boundOther += 1
const list = perBound.get(resolution.boundId) ?? []
list.push(address.id)
perBound.set(resolution.boundId, list)
updates.push(
`UPDATE addresses SET bound_id = ${resolution.boundId} WHERE id = ${address.id};`
)
}
/* -------------------------------------------------------------------------- */
/* Emit the SQL file */
/* -------------------------------------------------------------------------- */
const generatedAt = new Date().toISOString()
const outsideMode = keepOutside ? 'kept as-is' : 'set to NULL'
const header = [
'-- Generated by address_util/backfill-address-bounds.ts',
`-- generated_at: ${generatedAt}`,
`-- source_db: ${dbPath}`,
`-- thresholds: vague_backfilled_coords excluded=${!includeVague}, outside=${outsideMode}`,
`-- addresses: total=${stats.total} no_coords=${stats.skippedNoCoords} vague=${stats.skippedVague} no_region_bounds=${stats.skippedNoBounds}`,
`-- unchanged: ${stats.unchanged}`,
`-- outside: ${stats.outside}${keepOutside ? ` (kept ${stats.outsideKept})` : ''}`,
`-- updates: ${updates.length}`,
`-- resolved: bound=${stats.bound1 + stats.bound2 + stats.boundOther} (1:${stats.bound1}, 2:${stats.bound2}, other:${stats.boundOther})`,
'--',
'-- Run against the remote DB with the generated file:',
'-- wrangler d1 execute <database-name> --remote --config wrangler.prod.toml --file <this file>',
'--',
'',
].join('\n')
const body = updates.length > 0 ? updates.join('\n') + '\n' : '-- nothing to update\n'
mkdirSync(dirname(outPath), { recursive: true })
writeFileSync(outPath, header + body, 'utf8')
/* -------------------------------------------------------------------------- */
/* Report */
/* -------------------------------------------------------------------------- */
console.log(`source db : ${dbPath}`)
console.log(`output : ${outPath}`)
console.log(
`addresses : ${stats.total} (no coords ${stats.skippedNoCoords}, vague ${stats.skippedVague}, no region bounds ${stats.skippedNoBounds})`
)
console.log(`outside : ${stats.outside} (${outsideMode})`)
console.log(`unchanged : ${stats.unchanged}`)
console.log(
`updates : ${updates.length}` +
(perBound.size
? ` (${[...perBound.entries()]
.sort((a, b) => a[0] - b[0])
.map(([boundId, ids]) => `bound ${boundId}: ${ids.length}`)
.join(', ')})`
: '')
)
if (invalidGeometries > 0) {
console.warn(`warning : ${invalidGeometries} bound geometry row(s) were not valid JSON; skipped.`)
}
console.log('')
console.log('Apply it with:')
console.log(
` wrangler d1 execute <database-name> --remote --config wrangler.prod.toml --file "${outPath}"`
)

View file

@ -1,59 +0,0 @@
-- ============================================================
-- backfill-admin-coords.sql
--
-- Prefer the admin-pinned coordinates over the user coordinates, and use the
-- Mahabubnagar region centre ("vague" coords) only when neither is available.
-- Mirrors the `__new_addresses` copy in
-- packages/db_helper_sqlite/drizzle/0006_regions_and_superadmins.sql.
--
-- Safe to re-run (every statement is idempotent).
--
-- Local:
-- wrangler d1 execute <db-name> --local --file address_util/backfill-admin-coords.sql
-- Remote:
-- wrangler d1 execute <db-name> --remote --config wrangler.prod.toml \
-- --file address_util/backfill-admin-coords.sql
-- ============================================================
-- 1) Both admin coordinates present: admin wins, even when the user's
-- latitude/longitude are also present. The row is no longer "vague".
UPDATE addresses
SET latitude = admin_latitude,
longitude = admin_longitude,
vague_backfilled_coords = 0
WHERE admin_latitude IS NOT NULL
AND admin_longitude IS NOT NULL;
-- 2) Only admin latitude present: take it. The longitude keeps whatever it had;
-- vague is left untouched because that longitude may still be the fabricated
-- region centre. (No such rows in the current DB.)
UPDATE addresses
SET latitude = admin_latitude
WHERE admin_latitude IS NOT NULL
AND admin_longitude IS NULL;
-- 3) Only admin longitude present: take it. (No such rows in the current DB.)
UPDATE addresses
SET longitude = admin_longitude
WHERE admin_longitude IS NOT NULL
AND admin_latitude IS NULL;
-- 4) No admin coordinates and a missing coordinate: backfill the Mahabubnagar
-- region centre and mark the row vague. (No such rows in the current DB;
-- kept so the rule is complete on other/future databases.)
UPDATE addresses
SET latitude = COALESCE(latitude, 16.750504),
longitude = COALESCE(longitude, 77.993621),
vague_backfilled_coords = 1
WHERE admin_latitude IS NULL
AND admin_longitude IS NULL
AND (latitude IS NULL OR longitude IS NULL);
-- Verify:
-- SELECT
-- SUM(vague_backfilled_coords = 1) AS vague,
-- SUM(admin_latitude IS NOT NULL AND admin_longitude IS NOT NULL) AS admin_rows,
-- SUM(admin_latitude IS NOT NULL AND admin_longitude IS NOT NULL
-- AND vague_backfilled_coords = 1) AS admin_still_vague
-- FROM addresses;
-- Expected after this file: admin_still_vague = 0.

View file

@ -1,486 +0,0 @@
-- ============================================================
-- computed-bounds-466.sql
--
-- 466 addresses that already had real coordinates before the manual vague review:
-- * 398 with real latitude/longitude (vague_backfilled_coords = 0)
-- * 68 whose admin coords replaced the vague region centre
--
-- Generated by address_util/backfill-address-bounds.ts (turf, same logic as
-- resolveRegionAndBound). The 416 vague rows are NOT included and are left untouched.
--
-- Note: the script ran against a throwaway copy with bound_id = 0 for these rows,
-- so every row is emitted below (otherwise bound-1 rows would be omitted as no-ops).
--
-- Result: bound 1 = 432, bound 2 = 12, outside both polygons = 22 (NULL)
--
-- Apply:
-- wrangler d1 execute <db-name> --remote --config wrangler.prod.toml \
-- --file address_util/computed-bounds-466.sql
-- ============================================================
UPDATE addresses SET bound_id = 1 WHERE id = 20;
UPDATE addresses SET bound_id = 1 WHERE id = 24;
UPDATE addresses SET bound_id = 1 WHERE id = 26;
UPDATE addresses SET bound_id = 1 WHERE id = 38;
UPDATE addresses SET bound_id = 1 WHERE id = 50;
UPDATE addresses SET bound_id = 1 WHERE id = 54;
UPDATE addresses SET bound_id = 1 WHERE id = 58;
UPDATE addresses SET bound_id = 1 WHERE id = 59;
UPDATE addresses SET bound_id = 1 WHERE id = 67;
UPDATE addresses SET bound_id = 2 WHERE id = 70;
UPDATE addresses SET bound_id = 1 WHERE id = 71;
UPDATE addresses SET bound_id = 1 WHERE id = 72;
UPDATE addresses SET bound_id = 1 WHERE id = 82;
UPDATE addresses SET bound_id = 1 WHERE id = 85;
UPDATE addresses SET bound_id = 1 WHERE id = 92;
UPDATE addresses SET bound_id = 1 WHERE id = 104;
UPDATE addresses SET bound_id = 1 WHERE id = 105;
UPDATE addresses SET bound_id = 1 WHERE id = 107;
UPDATE addresses SET bound_id = 1 WHERE id = 109;
UPDATE addresses SET bound_id = 1 WHERE id = 110;
UPDATE addresses SET bound_id = 1 WHERE id = 113;
UPDATE addresses SET bound_id = 1 WHERE id = 115;
UPDATE addresses SET bound_id = 1 WHERE id = 118;
UPDATE addresses SET bound_id = 1 WHERE id = 122;
UPDATE addresses SET bound_id = 1 WHERE id = 123;
UPDATE addresses SET bound_id = 1 WHERE id = 127;
UPDATE addresses SET bound_id = 1 WHERE id = 129;
UPDATE addresses SET bound_id = 1 WHERE id = 130;
UPDATE addresses SET bound_id = 1 WHERE id = 132;
UPDATE addresses SET bound_id = 1 WHERE id = 133;
UPDATE addresses SET bound_id = 1 WHERE id = 134;
UPDATE addresses SET bound_id = 1 WHERE id = 136;
UPDATE addresses SET bound_id = 1 WHERE id = 140;
UPDATE addresses SET bound_id = 1 WHERE id = 143;
UPDATE addresses SET bound_id = 1 WHERE id = 144;
UPDATE addresses SET bound_id = 1 WHERE id = 145;
UPDATE addresses SET bound_id = 1 WHERE id = 148;
UPDATE addresses SET bound_id = 1 WHERE id = 149;
UPDATE addresses SET bound_id = 1 WHERE id = 152;
UPDATE addresses SET bound_id = 1 WHERE id = 156;
UPDATE addresses SET bound_id = 1 WHERE id = 158;
UPDATE addresses SET bound_id = 1 WHERE id = 160;
UPDATE addresses SET bound_id = 1 WHERE id = 161;
UPDATE addresses SET bound_id = 1 WHERE id = 163;
UPDATE addresses SET bound_id = 1 WHERE id = 167;
UPDATE addresses SET bound_id = 1 WHERE id = 168;
UPDATE addresses SET bound_id = 1 WHERE id = 170;
UPDATE addresses SET bound_id = 1 WHERE id = 174;
UPDATE addresses SET bound_id = 1 WHERE id = 175;
UPDATE addresses SET bound_id = 1 WHERE id = 176;
UPDATE addresses SET bound_id = 1 WHERE id = 177;
UPDATE addresses SET bound_id = 1 WHERE id = 180;
UPDATE addresses SET bound_id = 1 WHERE id = 181;
UPDATE addresses SET bound_id = 1 WHERE id = 187;
UPDATE addresses SET bound_id = 1 WHERE id = 189;
UPDATE addresses SET bound_id = 1 WHERE id = 191;
UPDATE addresses SET bound_id = 1 WHERE id = 192;
UPDATE addresses SET bound_id = 1 WHERE id = 193;
UPDATE addresses SET bound_id = 1 WHERE id = 194;
UPDATE addresses SET bound_id = 1 WHERE id = 198;
UPDATE addresses SET bound_id = 1 WHERE id = 200;
UPDATE addresses SET bound_id = 1 WHERE id = 201;
UPDATE addresses SET bound_id = 1 WHERE id = 202;
UPDATE addresses SET bound_id = 1 WHERE id = 206;
UPDATE addresses SET bound_id = 1 WHERE id = 207;
UPDATE addresses SET bound_id = 1 WHERE id = 209;
UPDATE addresses SET bound_id = 1 WHERE id = 212;
UPDATE addresses SET bound_id = 1 WHERE id = 213;
UPDATE addresses SET bound_id = 1 WHERE id = 217;
UPDATE addresses SET bound_id = 1 WHERE id = 221;
UPDATE addresses SET bound_id = 1 WHERE id = 223;
UPDATE addresses SET bound_id = 1 WHERE id = 226;
UPDATE addresses SET bound_id = 1 WHERE id = 231;
UPDATE addresses SET bound_id = 1 WHERE id = 233;
UPDATE addresses SET bound_id = 1 WHERE id = 237;
UPDATE addresses SET bound_id = 1 WHERE id = 239;
UPDATE addresses SET bound_id = 1 WHERE id = 240;
UPDATE addresses SET bound_id = 1 WHERE id = 241;
UPDATE addresses SET bound_id = 1 WHERE id = 242;
UPDATE addresses SET bound_id = 1 WHERE id = 243;
UPDATE addresses SET bound_id = 1 WHERE id = 244;
UPDATE addresses SET bound_id = 1 WHERE id = 247;
UPDATE addresses SET bound_id = NULL WHERE id = 250;
UPDATE addresses SET bound_id = 1 WHERE id = 252;
UPDATE addresses SET bound_id = 1 WHERE id = 255;
UPDATE addresses SET bound_id = 1 WHERE id = 256;
UPDATE addresses SET bound_id = 1 WHERE id = 263;
UPDATE addresses SET bound_id = 1 WHERE id = 264;
UPDATE addresses SET bound_id = 1 WHERE id = 266;
UPDATE addresses SET bound_id = 1 WHERE id = 267;
UPDATE addresses SET bound_id = 1 WHERE id = 270;
UPDATE addresses SET bound_id = 1 WHERE id = 275;
UPDATE addresses SET bound_id = NULL WHERE id = 280;
UPDATE addresses SET bound_id = 1 WHERE id = 281;
UPDATE addresses SET bound_id = 1 WHERE id = 284;
UPDATE addresses SET bound_id = 1 WHERE id = 286;
UPDATE addresses SET bound_id = 1 WHERE id = 292;
UPDATE addresses SET bound_id = 1 WHERE id = 293;
UPDATE addresses SET bound_id = 1 WHERE id = 294;
UPDATE addresses SET bound_id = 1 WHERE id = 296;
UPDATE addresses SET bound_id = 1 WHERE id = 297;
UPDATE addresses SET bound_id = 1 WHERE id = 298;
UPDATE addresses SET bound_id = 1 WHERE id = 300;
UPDATE addresses SET bound_id = 1 WHERE id = 301;
UPDATE addresses SET bound_id = 1 WHERE id = 306;
UPDATE addresses SET bound_id = 1 WHERE id = 307;
UPDATE addresses SET bound_id = 1 WHERE id = 308;
UPDATE addresses SET bound_id = NULL WHERE id = 310;
UPDATE addresses SET bound_id = 1 WHERE id = 313;
UPDATE addresses SET bound_id = 1 WHERE id = 314;
UPDATE addresses SET bound_id = 1 WHERE id = 315;
UPDATE addresses SET bound_id = 1 WHERE id = 317;
UPDATE addresses SET bound_id = 1 WHERE id = 318;
UPDATE addresses SET bound_id = 1 WHERE id = 319;
UPDATE addresses SET bound_id = 1 WHERE id = 322;
UPDATE addresses SET bound_id = 1 WHERE id = 325;
UPDATE addresses SET bound_id = 1 WHERE id = 326;
UPDATE addresses SET bound_id = 1 WHERE id = 328;
UPDATE addresses SET bound_id = 1 WHERE id = 329;
UPDATE addresses SET bound_id = 1 WHERE id = 332;
UPDATE addresses SET bound_id = 1 WHERE id = 334;
UPDATE addresses SET bound_id = 1 WHERE id = 335;
UPDATE addresses SET bound_id = 1 WHERE id = 337;
UPDATE addresses SET bound_id = 1 WHERE id = 339;
UPDATE addresses SET bound_id = 1 WHERE id = 340;
UPDATE addresses SET bound_id = 1 WHERE id = 341;
UPDATE addresses SET bound_id = 1 WHERE id = 342;
UPDATE addresses SET bound_id = 1 WHERE id = 343;
UPDATE addresses SET bound_id = 1 WHERE id = 344;
UPDATE addresses SET bound_id = 1 WHERE id = 346;
UPDATE addresses SET bound_id = 1 WHERE id = 349;
UPDATE addresses SET bound_id = 1 WHERE id = 352;
UPDATE addresses SET bound_id = 1 WHERE id = 354;
UPDATE addresses SET bound_id = 1 WHERE id = 355;
UPDATE addresses SET bound_id = 1 WHERE id = 356;
UPDATE addresses SET bound_id = 1 WHERE id = 361;
UPDATE addresses SET bound_id = 1 WHERE id = 362;
UPDATE addresses SET bound_id = 1 WHERE id = 364;
UPDATE addresses SET bound_id = 1 WHERE id = 365;
UPDATE addresses SET bound_id = 1 WHERE id = 367;
UPDATE addresses SET bound_id = 1 WHERE id = 369;
UPDATE addresses SET bound_id = 1 WHERE id = 370;
UPDATE addresses SET bound_id = 1 WHERE id = 371;
UPDATE addresses SET bound_id = 1 WHERE id = 372;
UPDATE addresses SET bound_id = 1 WHERE id = 375;
UPDATE addresses SET bound_id = 1 WHERE id = 376;
UPDATE addresses SET bound_id = 1 WHERE id = 378;
UPDATE addresses SET bound_id = 1 WHERE id = 380;
UPDATE addresses SET bound_id = 1 WHERE id = 384;
UPDATE addresses SET bound_id = 2 WHERE id = 388;
UPDATE addresses SET bound_id = 2 WHERE id = 389;
UPDATE addresses SET bound_id = 1 WHERE id = 393;
UPDATE addresses SET bound_id = NULL WHERE id = 394;
UPDATE addresses SET bound_id = 1 WHERE id = 395;
UPDATE addresses SET bound_id = 1 WHERE id = 396;
UPDATE addresses SET bound_id = 1 WHERE id = 397;
UPDATE addresses SET bound_id = 1 WHERE id = 398;
UPDATE addresses SET bound_id = 1 WHERE id = 399;
UPDATE addresses SET bound_id = 1 WHERE id = 400;
UPDATE addresses SET bound_id = 1 WHERE id = 402;
UPDATE addresses SET bound_id = 1 WHERE id = 403;
UPDATE addresses SET bound_id = 1 WHERE id = 404;
UPDATE addresses SET bound_id = 1 WHERE id = 405;
UPDATE addresses SET bound_id = 1 WHERE id = 407;
UPDATE addresses SET bound_id = 1 WHERE id = 408;
UPDATE addresses SET bound_id = 2 WHERE id = 409;
UPDATE addresses SET bound_id = 1 WHERE id = 410;
UPDATE addresses SET bound_id = 1 WHERE id = 412;
UPDATE addresses SET bound_id = 1 WHERE id = 416;
UPDATE addresses SET bound_id = 1 WHERE id = 418;
UPDATE addresses SET bound_id = 1 WHERE id = 419;
UPDATE addresses SET bound_id = 1 WHERE id = 422;
UPDATE addresses SET bound_id = 1 WHERE id = 423;
UPDATE addresses SET bound_id = 1 WHERE id = 424;
UPDATE addresses SET bound_id = 1 WHERE id = 428;
UPDATE addresses SET bound_id = 1 WHERE id = 429;
UPDATE addresses SET bound_id = 1 WHERE id = 433;
UPDATE addresses SET bound_id = 1 WHERE id = 436;
UPDATE addresses SET bound_id = 1 WHERE id = 437;
UPDATE addresses SET bound_id = 1 WHERE id = 441;
UPDATE addresses SET bound_id = 1 WHERE id = 442;
UPDATE addresses SET bound_id = 1 WHERE id = 443;
UPDATE addresses SET bound_id = 1 WHERE id = 444;
UPDATE addresses SET bound_id = 1 WHERE id = 445;
UPDATE addresses SET bound_id = 1 WHERE id = 447;
UPDATE addresses SET bound_id = NULL WHERE id = 448;
UPDATE addresses SET bound_id = 1 WHERE id = 449;
UPDATE addresses SET bound_id = 1 WHERE id = 450;
UPDATE addresses SET bound_id = 1 WHERE id = 455;
UPDATE addresses SET bound_id = 1 WHERE id = 457;
UPDATE addresses SET bound_id = 1 WHERE id = 458;
UPDATE addresses SET bound_id = 1 WHERE id = 464;
UPDATE addresses SET bound_id = 1 WHERE id = 466;
UPDATE addresses SET bound_id = 1 WHERE id = 467;
UPDATE addresses SET bound_id = 1 WHERE id = 468;
UPDATE addresses SET bound_id = 1 WHERE id = 470;
UPDATE addresses SET bound_id = 1 WHERE id = 472;
UPDATE addresses SET bound_id = 1 WHERE id = 473;
UPDATE addresses SET bound_id = 1 WHERE id = 474;
UPDATE addresses SET bound_id = 1 WHERE id = 475;
UPDATE addresses SET bound_id = 1 WHERE id = 476;
UPDATE addresses SET bound_id = 1 WHERE id = 478;
UPDATE addresses SET bound_id = 1 WHERE id = 479;
UPDATE addresses SET bound_id = 1 WHERE id = 480;
UPDATE addresses SET bound_id = 1 WHERE id = 481;
UPDATE addresses SET bound_id = 1 WHERE id = 484;
UPDATE addresses SET bound_id = 1 WHERE id = 486;
UPDATE addresses SET bound_id = 1 WHERE id = 493;
UPDATE addresses SET bound_id = 1 WHERE id = 495;
UPDATE addresses SET bound_id = 1 WHERE id = 498;
UPDATE addresses SET bound_id = 1 WHERE id = 499;
UPDATE addresses SET bound_id = 1 WHERE id = 500;
UPDATE addresses SET bound_id = 1 WHERE id = 501;
UPDATE addresses SET bound_id = 1 WHERE id = 502;
UPDATE addresses SET bound_id = 1 WHERE id = 503;
UPDATE addresses SET bound_id = 1 WHERE id = 505;
UPDATE addresses SET bound_id = 1 WHERE id = 506;
UPDATE addresses SET bound_id = 1 WHERE id = 509;
UPDATE addresses SET bound_id = 1 WHERE id = 510;
UPDATE addresses SET bound_id = 1 WHERE id = 512;
UPDATE addresses SET bound_id = 1 WHERE id = 513;
UPDATE addresses SET bound_id = 1 WHERE id = 514;
UPDATE addresses SET bound_id = 1 WHERE id = 515;
UPDATE addresses SET bound_id = 1 WHERE id = 516;
UPDATE addresses SET bound_id = 1 WHERE id = 517;
UPDATE addresses SET bound_id = 1 WHERE id = 519;
UPDATE addresses SET bound_id = 1 WHERE id = 521;
UPDATE addresses SET bound_id = 1 WHERE id = 522;
UPDATE addresses SET bound_id = 1 WHERE id = 523;
UPDATE addresses SET bound_id = 1 WHERE id = 526;
UPDATE addresses SET bound_id = 1 WHERE id = 527;
UPDATE addresses SET bound_id = 1 WHERE id = 529;
UPDATE addresses SET bound_id = 1 WHERE id = 531;
UPDATE addresses SET bound_id = 1 WHERE id = 532;
UPDATE addresses SET bound_id = 1 WHERE id = 533;
UPDATE addresses SET bound_id = 1 WHERE id = 535;
UPDATE addresses SET bound_id = 1 WHERE id = 536;
UPDATE addresses SET bound_id = 1 WHERE id = 540;
UPDATE addresses SET bound_id = 1 WHERE id = 541;
UPDATE addresses SET bound_id = 1 WHERE id = 542;
UPDATE addresses SET bound_id = 1 WHERE id = 543;
UPDATE addresses SET bound_id = 1 WHERE id = 545;
UPDATE addresses SET bound_id = 2 WHERE id = 546;
UPDATE addresses SET bound_id = 1 WHERE id = 548;
UPDATE addresses SET bound_id = 1 WHERE id = 551;
UPDATE addresses SET bound_id = 1 WHERE id = 553;
UPDATE addresses SET bound_id = 1 WHERE id = 555;
UPDATE addresses SET bound_id = 1 WHERE id = 556;
UPDATE addresses SET bound_id = 1 WHERE id = 557;
UPDATE addresses SET bound_id = 1 WHERE id = 558;
UPDATE addresses SET bound_id = 1 WHERE id = 559;
UPDATE addresses SET bound_id = 1 WHERE id = 560;
UPDATE addresses SET bound_id = 1 WHERE id = 561;
UPDATE addresses SET bound_id = 1 WHERE id = 562;
UPDATE addresses SET bound_id = 1 WHERE id = 563;
UPDATE addresses SET bound_id = 1 WHERE id = 565;
UPDATE addresses SET bound_id = 1 WHERE id = 566;
UPDATE addresses SET bound_id = 1 WHERE id = 569;
UPDATE addresses SET bound_id = 1 WHERE id = 570;
UPDATE addresses SET bound_id = 1 WHERE id = 571;
UPDATE addresses SET bound_id = 1 WHERE id = 572;
UPDATE addresses SET bound_id = 1 WHERE id = 574;
UPDATE addresses SET bound_id = 1 WHERE id = 576;
UPDATE addresses SET bound_id = 1 WHERE id = 579;
UPDATE addresses SET bound_id = 1 WHERE id = 580;
UPDATE addresses SET bound_id = 1 WHERE id = 581;
UPDATE addresses SET bound_id = 1 WHERE id = 582;
UPDATE addresses SET bound_id = 1 WHERE id = 583;
UPDATE addresses SET bound_id = 1 WHERE id = 585;
UPDATE addresses SET bound_id = NULL WHERE id = 586;
UPDATE addresses SET bound_id = 1 WHERE id = 590;
UPDATE addresses SET bound_id = NULL WHERE id = 595;
UPDATE addresses SET bound_id = NULL WHERE id = 599;
UPDATE addresses SET bound_id = 1 WHERE id = 601;
UPDATE addresses SET bound_id = NULL WHERE id = 603;
UPDATE addresses SET bound_id = 1 WHERE id = 604;
UPDATE addresses SET bound_id = NULL WHERE id = 606;
UPDATE addresses SET bound_id = 1 WHERE id = 608;
UPDATE addresses SET bound_id = 1 WHERE id = 610;
UPDATE addresses SET bound_id = 2 WHERE id = 611;
UPDATE addresses SET bound_id = 1 WHERE id = 612;
UPDATE addresses SET bound_id = 1 WHERE id = 615;
UPDATE addresses SET bound_id = NULL WHERE id = 621;
UPDATE addresses SET bound_id = 1 WHERE id = 623;
UPDATE addresses SET bound_id = 1 WHERE id = 627;
UPDATE addresses SET bound_id = 1 WHERE id = 628;
UPDATE addresses SET bound_id = NULL WHERE id = 629;
UPDATE addresses SET bound_id = 1 WHERE id = 630;
UPDATE addresses SET bound_id = 1 WHERE id = 633;
UPDATE addresses SET bound_id = 1 WHERE id = 634;
UPDATE addresses SET bound_id = 1 WHERE id = 636;
UPDATE addresses SET bound_id = NULL WHERE id = 637;
UPDATE addresses SET bound_id = 1 WHERE id = 639;
UPDATE addresses SET bound_id = 1 WHERE id = 641;
UPDATE addresses SET bound_id = 1 WHERE id = 645;
UPDATE addresses SET bound_id = 1 WHERE id = 646;
UPDATE addresses SET bound_id = NULL WHERE id = 647;
UPDATE addresses SET bound_id = 1 WHERE id = 651;
UPDATE addresses SET bound_id = 1 WHERE id = 652;
UPDATE addresses SET bound_id = 1 WHERE id = 653;
UPDATE addresses SET bound_id = 1 WHERE id = 654;
UPDATE addresses SET bound_id = 1 WHERE id = 657;
UPDATE addresses SET bound_id = NULL WHERE id = 660;
UPDATE addresses SET bound_id = 1 WHERE id = 662;
UPDATE addresses SET bound_id = 1 WHERE id = 663;
UPDATE addresses SET bound_id = 2 WHERE id = 664;
UPDATE addresses SET bound_id = 1 WHERE id = 666;
UPDATE addresses SET bound_id = 1 WHERE id = 668;
UPDATE addresses SET bound_id = 1 WHERE id = 669;
UPDATE addresses SET bound_id = 1 WHERE id = 671;
UPDATE addresses SET bound_id = 1 WHERE id = 672;
UPDATE addresses SET bound_id = 1 WHERE id = 674;
UPDATE addresses SET bound_id = 1 WHERE id = 675;
UPDATE addresses SET bound_id = 1 WHERE id = 676;
UPDATE addresses SET bound_id = 1 WHERE id = 677;
UPDATE addresses SET bound_id = NULL WHERE id = 678;
UPDATE addresses SET bound_id = 1 WHERE id = 680;
UPDATE addresses SET bound_id = 1 WHERE id = 681;
UPDATE addresses SET bound_id = 1 WHERE id = 683;
UPDATE addresses SET bound_id = 1 WHERE id = 685;
UPDATE addresses SET bound_id = 1 WHERE id = 686;
UPDATE addresses SET bound_id = 1 WHERE id = 687;
UPDATE addresses SET bound_id = 1 WHERE id = 689;
UPDATE addresses SET bound_id = 1 WHERE id = 690;
UPDATE addresses SET bound_id = 1 WHERE id = 693;
UPDATE addresses SET bound_id = NULL WHERE id = 694;
UPDATE addresses SET bound_id = NULL WHERE id = 696;
UPDATE addresses SET bound_id = 1 WHERE id = 697;
UPDATE addresses SET bound_id = NULL WHERE id = 699;
UPDATE addresses SET bound_id = 1 WHERE id = 700;
UPDATE addresses SET bound_id = 1 WHERE id = 701;
UPDATE addresses SET bound_id = 1 WHERE id = 702;
UPDATE addresses SET bound_id = 1 WHERE id = 703;
UPDATE addresses SET bound_id = 1 WHERE id = 705;
UPDATE addresses SET bound_id = 1 WHERE id = 709;
UPDATE addresses SET bound_id = 1 WHERE id = 710;
UPDATE addresses SET bound_id = 1 WHERE id = 711;
UPDATE addresses SET bound_id = 1 WHERE id = 712;
UPDATE addresses SET bound_id = 1 WHERE id = 715;
UPDATE addresses SET bound_id = 1 WHERE id = 716;
UPDATE addresses SET bound_id = 1 WHERE id = 718;
UPDATE addresses SET bound_id = 1 WHERE id = 719;
UPDATE addresses SET bound_id = 2 WHERE id = 721;
UPDATE addresses SET bound_id = 1 WHERE id = 723;
UPDATE addresses SET bound_id = 1 WHERE id = 724;
UPDATE addresses SET bound_id = 1 WHERE id = 725;
UPDATE addresses SET bound_id = 1 WHERE id = 727;
UPDATE addresses SET bound_id = 1 WHERE id = 728;
UPDATE addresses SET bound_id = 1 WHERE id = 729;
UPDATE addresses SET bound_id = 1 WHERE id = 731;
UPDATE addresses SET bound_id = 1 WHERE id = 732;
UPDATE addresses SET bound_id = 1 WHERE id = 733;
UPDATE addresses SET bound_id = 2 WHERE id = 734;
UPDATE addresses SET bound_id = 1 WHERE id = 736;
UPDATE addresses SET bound_id = 2 WHERE id = 737;
UPDATE addresses SET bound_id = 1 WHERE id = 739;
UPDATE addresses SET bound_id = 1 WHERE id = 740;
UPDATE addresses SET bound_id = 1 WHERE id = 742;
UPDATE addresses SET bound_id = 1 WHERE id = 746;
UPDATE addresses SET bound_id = 1 WHERE id = 747;
UPDATE addresses SET bound_id = 1 WHERE id = 748;
UPDATE addresses SET bound_id = 1 WHERE id = 749;
UPDATE addresses SET bound_id = 1 WHERE id = 750;
UPDATE addresses SET bound_id = 1 WHERE id = 751;
UPDATE addresses SET bound_id = 1 WHERE id = 752;
UPDATE addresses SET bound_id = 1 WHERE id = 757;
UPDATE addresses SET bound_id = 1 WHERE id = 758;
UPDATE addresses SET bound_id = 1 WHERE id = 759;
UPDATE addresses SET bound_id = 1 WHERE id = 760;
UPDATE addresses SET bound_id = 1 WHERE id = 762;
UPDATE addresses SET bound_id = 1 WHERE id = 763;
UPDATE addresses SET bound_id = 1 WHERE id = 764;
UPDATE addresses SET bound_id = NULL WHERE id = 765;
UPDATE addresses SET bound_id = 1 WHERE id = 767;
UPDATE addresses SET bound_id = 1 WHERE id = 770;
UPDATE addresses SET bound_id = 1 WHERE id = 771;
UPDATE addresses SET bound_id = 1 WHERE id = 772;
UPDATE addresses SET bound_id = 1 WHERE id = 773;
UPDATE addresses SET bound_id = 2 WHERE id = 774;
UPDATE addresses SET bound_id = 1 WHERE id = 776;
UPDATE addresses SET bound_id = 1 WHERE id = 777;
UPDATE addresses SET bound_id = NULL WHERE id = 778;
UPDATE addresses SET bound_id = 1 WHERE id = 779;
UPDATE addresses SET bound_id = 1 WHERE id = 781;
UPDATE addresses SET bound_id = 1 WHERE id = 786;
UPDATE addresses SET bound_id = 1 WHERE id = 787;
UPDATE addresses SET bound_id = 1 WHERE id = 789;
UPDATE addresses SET bound_id = 1 WHERE id = 790;
UPDATE addresses SET bound_id = 1 WHERE id = 791;
UPDATE addresses SET bound_id = 1 WHERE id = 792;
UPDATE addresses SET bound_id = 1 WHERE id = 793;
UPDATE addresses SET bound_id = 1 WHERE id = 794;
UPDATE addresses SET bound_id = 1 WHERE id = 796;
UPDATE addresses SET bound_id = 1 WHERE id = 797;
UPDATE addresses SET bound_id = 1 WHERE id = 798;
UPDATE addresses SET bound_id = 1 WHERE id = 800;
UPDATE addresses SET bound_id = 1 WHERE id = 801;
UPDATE addresses SET bound_id = 1 WHERE id = 803;
UPDATE addresses SET bound_id = 1 WHERE id = 804;
UPDATE addresses SET bound_id = 1 WHERE id = 805;
UPDATE addresses SET bound_id = 1 WHERE id = 806;
UPDATE addresses SET bound_id = 1 WHERE id = 810;
UPDATE addresses SET bound_id = 1 WHERE id = 812;
UPDATE addresses SET bound_id = 1 WHERE id = 813;
UPDATE addresses SET bound_id = 1 WHERE id = 815;
UPDATE addresses SET bound_id = 1 WHERE id = 819;
UPDATE addresses SET bound_id = 1 WHERE id = 821;
UPDATE addresses SET bound_id = 1 WHERE id = 822;
UPDATE addresses SET bound_id = 1 WHERE id = 823;
UPDATE addresses SET bound_id = 1 WHERE id = 824;
UPDATE addresses SET bound_id = 1 WHERE id = 826;
UPDATE addresses SET bound_id = 1 WHERE id = 827;
UPDATE addresses SET bound_id = 1 WHERE id = 828;
UPDATE addresses SET bound_id = 1 WHERE id = 831;
UPDATE addresses SET bound_id = 1 WHERE id = 832;
UPDATE addresses SET bound_id = 1 WHERE id = 833;
UPDATE addresses SET bound_id = 1 WHERE id = 835;
UPDATE addresses SET bound_id = 1 WHERE id = 836;
UPDATE addresses SET bound_id = 1 WHERE id = 837;
UPDATE addresses SET bound_id = 1 WHERE id = 838;
UPDATE addresses SET bound_id = 1 WHERE id = 839;
UPDATE addresses SET bound_id = 1 WHERE id = 840;
UPDATE addresses SET bound_id = 1 WHERE id = 841;
UPDATE addresses SET bound_id = 1 WHERE id = 842;
UPDATE addresses SET bound_id = 1 WHERE id = 845;
UPDATE addresses SET bound_id = 2 WHERE id = 847;
UPDATE addresses SET bound_id = 1 WHERE id = 850;
UPDATE addresses SET bound_id = 1 WHERE id = 851;
UPDATE addresses SET bound_id = 1 WHERE id = 852;
UPDATE addresses SET bound_id = 1 WHERE id = 853;
UPDATE addresses SET bound_id = 1 WHERE id = 854;
UPDATE addresses SET bound_id = 1 WHERE id = 860;
UPDATE addresses SET bound_id = 1 WHERE id = 861;
UPDATE addresses SET bound_id = 1 WHERE id = 863;
UPDATE addresses SET bound_id = 1 WHERE id = 865;
UPDATE addresses SET bound_id = 1 WHERE id = 866;
UPDATE addresses SET bound_id = 1 WHERE id = 867;
UPDATE addresses SET bound_id = 1 WHERE id = 868;
UPDATE addresses SET bound_id = 1 WHERE id = 869;
UPDATE addresses SET bound_id = 1 WHERE id = 873;
UPDATE addresses SET bound_id = 1 WHERE id = 876;
UPDATE addresses SET bound_id = 1 WHERE id = 878;
UPDATE addresses SET bound_id = 1 WHERE id = 879;
UPDATE addresses SET bound_id = 1 WHERE id = 880;
UPDATE addresses SET bound_id = NULL WHERE id = 881;
UPDATE addresses SET bound_id = 1 WHERE id = 884;
UPDATE addresses SET bound_id = 1 WHERE id = 885;
UPDATE addresses SET bound_id = 1 WHERE id = 888;
UPDATE addresses SET bound_id = 1 WHERE id = 889;
UPDATE addresses SET bound_id = 1 WHERE id = 890;
UPDATE addresses SET bound_id = 1 WHERE id = 891;
UPDATE addresses SET bound_id = 1 WHERE id = 892;
UPDATE addresses SET bound_id = 1 WHERE id = 893;
UPDATE addresses SET bound_id = 1 WHERE id = 894;
UPDATE addresses SET bound_id = 1 WHERE id = 895;
UPDATE addresses SET bound_id = 1 WHERE id = 896;
UPDATE addresses SET bound_id = 1 WHERE id = 899;
UPDATE addresses SET bound_id = 1 WHERE id = 901;
UPDATE addresses SET bound_id = 1 WHERE id = 902;
UPDATE addresses SET bound_id = 1 WHERE id = 904;
UPDATE addresses SET bound_id = 1 WHERE id = 905;
UPDATE addresses SET bound_id = 1 WHERE id = 906;
UPDATE addresses SET bound_id = 1 WHERE id = 907;
UPDATE addresses SET bound_id = 1 WHERE id = 908;
UPDATE addresses SET bound_id = 1 WHERE id = 910;
UPDATE addresses SET bound_id = 1 WHERE id = 911;

View file

@ -1,83 +0,0 @@
-- ============================================================
-- delete-orders-before-2026-02-10.sql
--
-- DESTRUCTIVE. Deletes every order created before 2026-02-10 (midnight,
-- exclusive -- anything on/after 2026-02-10 00:00 is kept) and the rows that
-- hang off those orders.
--
-- Cutoff: `created_at < '2026-02-10'` compares correctly for the timestamp
-- shapes the app writes ('2026-02-09T23:00:00.000Z' and '2026-02-09 23:00:00').
--
-- Schema: this targets the post-0006 database (applied to the remote now).
-- 0006 removed online payments, so `payments`, `refunds` and `payment_info` no
-- longer exist and `orders.payment_info_id` is gone -- none are referenced here.
-- (The same statements also run on a pre-0006 copy; they just leave the dropped
-- payment tables alone.)
--
-- Per order it:
-- 1. detaches coupon_usage / complaints / user_incidents (rows kept, order
-- references set to NULL, so coupon limits and complaint history survive)
-- 2. deletes its order_items and order_status rows
-- 3. deletes the order
--
-- Post-0006 orders whose items were archived into `orders.items_json` have no
-- `order_items` rows, so only the order/status row is removed for them.
--
-- Counts from the local dump at time of writing (pre-0006 copy):
-- 110 of 2548 orders (oldest 2025-12-24), 194 order_items, 110 order_status,
-- 23 coupon_usage detached, 1 complaint detached, 0 user_incidents.
-- Counts will differ on the target database.
--
-- Apply from apps/backend:
-- wrangler d1 execute freshyo-backend-dev --file=../../address_util/delete-orders-before-2026-02-10.sql --config wrangler.dev.toml --remote
--
-- Dry run (counts only):
-- SELECT COUNT(*) FROM orders WHERE created_at < '2026-02-10';
-- ============================================================
-- 1. Preserve cross-cutting history; drop only the order references.
UPDATE coupon_usage
SET order_id = NULL,
order_item_id = NULL
WHERE order_id IN (SELECT id FROM orders WHERE created_at < '2026-02-10')
OR order_item_id IN (
SELECT oi.id FROM order_items oi
JOIN orders o ON o.id = oi.order_id
WHERE o.created_at < '2026-02-10'
);
UPDATE complaints
SET order_id = NULL
WHERE order_id IN (SELECT id FROM orders WHERE created_at < '2026-02-10');
UPDATE user_incidents
SET order_id = NULL
WHERE order_id IN (SELECT id FROM orders WHERE created_at < '2026-02-10');
-- 2. Delete the order-owned item/status rows.
DELETE FROM order_items
WHERE order_id IN (SELECT id FROM orders WHERE created_at < '2026-02-10');
DELETE FROM order_status
WHERE order_id IN (SELECT id FROM orders WHERE created_at < '2026-02-10');
-- 3. Delete the orders themselves.
DELETE FROM orders
WHERE created_at < '2026-02-10';
-- Verification (run after applying):
-- SELECT COUNT(*) FROM orders WHERE created_at < '2026-02-10'; -- expect 0
-- SELECT COUNT(*) FROM order_items
-- WHERE order_id NOT IN (SELECT id FROM orders); -- expect 0
-- SELECT COUNT(*) FROM order_status
-- WHERE order_id NOT IN (SELECT id FROM orders); -- expect 0
-- SELECT COUNT(*) FROM coupon_usage
-- WHERE order_id IS NOT NULL
-- AND order_id NOT IN (SELECT id FROM orders); -- expect 0
-- SELECT COUNT(*) FROM complaints
-- WHERE order_id IS NOT NULL
-- AND order_id NOT IN (SELECT id FROM orders); -- expect 0
-- SELECT COUNT(*) FROM user_incidents
-- WHERE order_id IS NOT NULL
-- AND order_id NOT IN (SELECT id FROM orders); -- expect 0
-- PRAGMA foreign_key_check; -- expect no rows

View file

@ -1,66 +0,0 @@
-- ============================================================
-- delete-outside-bound-addresses.sql
--
-- Targets 23 addresses:
-- * 22 whose computed bound is NULL in computed-bounds-466.sql
-- (addresses outside both region polygons), plus
-- * address 285 (user 388, mobile 9676651496, "Mbnr, Mbnr").
--
-- DESTRUCTIVE. For each address it:
-- 1. detaches coupon_usage / complaints / user_incidents from its orders
-- 2. deletes its order_items and order_status rows
-- 3. deletes its orders
-- 4. deletes the address
--
-- Local impact: 46 orders, 2 order_items, 46 order_status,
-- 3 coupon_usage rows (detached, kept), 0 complaints, 0 incidents.
-- 17 of the 23 addresses are users' default addresses.
-- User 388 keeps their account but will have no address after this.
-- If an address is already gone, every statement is a no-op.
--
-- Apply:
-- wrangler d1 execute <db-name> --remote --config wrangler.prod.toml \
-- --file address_util/delete-outside-bound-addresses.sql
-- ============================================================
-- Preserve coupon usage history; drop its reference to the deleted orders/items.
UPDATE coupon_usage
SET order_id = NULL,
order_item_id = NULL
WHERE order_id IN (SELECT id FROM orders WHERE address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881))
OR order_item_id IN (
SELECT oi.id FROM order_items oi
JOIN orders o ON o.id = oi.order_id
WHERE o.address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881)
);
-- Preserve complaints / incidents; drop their order reference.
UPDATE complaints
SET order_id = NULL
WHERE order_id IN (SELECT id FROM orders WHERE address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881));
UPDATE user_incidents
SET order_id = NULL
WHERE order_id IN (SELECT id FROM orders WHERE address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881));
-- Delete order dependents.
DELETE FROM order_items
WHERE order_id IN (SELECT id FROM orders WHERE address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881));
DELETE FROM order_status
WHERE order_id IN (SELECT id FROM orders WHERE address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881));
-- Delete the orders that belong to these addresses.
DELETE FROM orders WHERE address_id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881);
-- Delete the addresses.
DELETE FROM addresses WHERE id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881);
-- Verification:
-- SELECT COUNT(*) FROM addresses WHERE id IN (250, 280, 285, 310, 394, 448, 586, 595, 599, 603, 606, 621, 629, 637, 647, 660, 678, 694, 696, 699, 765, 778, 881); -- expect 0
-- SELECT COUNT(*) FROM orders WHERE id IN (649, 776, 815, 859, 860, 867, 910, 1038, 1050, 1060, 1209, 1394, 1397, 1471, 1570, 1597, 1654, 1796, 1950, 1952, 1953, 1982, 2009, 2023, 2037, 2040, 2042, 2043, 2085, 2102, 2128, 2153, 2171, 2284, 2317, 2352, 2429, 2455, 2466, 2467, 2522, 2557, 2562, 2590, 2693, 2702); -- expect 0
-- SELECT COUNT(*) FROM order_status WHERE order_id IN (649, 776, 815, 859, 860, 867, 910, 1038, 1050, 1060, 1209, 1394, 1397, 1471, 1570, 1597, 1654, 1796, 1950, 1952, 1953, 1982, 2009, 2023, 2037, 2040, 2042, 2043, 2085, 2102, 2128, 2153, 2171, 2284, 2317, 2352, 2429, 2455, 2466, 2467, 2522, 2557, 2562, 2590, 2693, 2702); -- expect 0
-- SELECT id, order_id, order_item_id FROM coupon_usage WHERE id IN (116, 147, 169);
-- -- expect all rows kept, order_id/order_item_id NULL
-- SELECT COUNT(*) FROM users WHERE id = 388; -- expect 1 (account kept)
-- PRAGMA foreign_key_check; -- expect no rows

Some files were not shown because too many files have changed in this diff Show more