222 lines
9.7 KiB
Text
222 lines
9.7 KiB
Text
Resolving dependencies
|
||
Resolved, downloaded and extracted [2]
|
||
|
||
Agent guidance
|
||
- Treat React Doctor diagnostics as starting hypotheses. Read the relevant code before confirming or suppressing each finding.
|
||
- For each group, decide true positive, false positive, or needs-human-review, then assign high/medium/low confidence.
|
||
- Do not suppress a finding without evidence from the file in question. Confidence requires code context.
|
||
- Understand the root cause before editing. Fix the underlying code instead of changing react-doctor config or suppressing rules unless explicitly asked.
|
||
- Investigate deeply where relevant: race conditions, security-sensitive flows, state propagation, multi-file refactors, and downstream dependency chains.
|
||
- Ignore pure style preferences, theoretical issues without real impact, missing features, and unrelated pre-existing code.
|
||
- Start with high-confidence fixes that preserve behavior. Leave low-confidence or product-dependent changes as notes.
|
||
- Run `npx react-doctor@latest --verbose --scope changed` before and after changes, plus relevant tests after each focused batch.
|
||
- When available, spawn subagents or isolated worktrees for independent rule families, then review and merge only the best safe fixes.
|
||
- Split unrelated, broad, or behavior-changing work into separate PRs/branches instead of one large cleanup.
|
||
- When one rule spans dozens of files (a migration-scale change), fix a representative sample first, confirm the recipe holds, and get the code owner's sign-off before changing the rest. Don't mass-fix a broad pattern in one unreviewed pass.
|
||
- For confirmed issues that cannot be fixed now, create GitHub issues with the rule, file/line, confidence, impact, and proposed fix.
|
||
- If a fix needs an API, UX, or architecture decision, stop and ask before editing.
|
||
|
||
✔ Scanned 219 files in 2.4s
|
||
|
||
React Doctor — user-ui
|
||
Score disabled by --no-score. Want something custom to your company? Contact us at https://react.doctor/enterprise.
|
||
|
||
121 issues
|
||
Maintainability: 30 warnings
|
||
Performance: 19 warnings
|
||
Bugs: 5 errors, 65 warnings
|
||
Correctness: 1 warning
|
||
Security: 1 error
|
||
|
||
⚠ React function has high control-flow complexity ×15
|
||
react-doctor/no-high-complexity-react-function
|
||
app/(auth)/login.tsx:15
|
||
app/(drawer)/(tabs)/me/my-orders/[id].tsx:14
|
||
app/(drawer)/(tabs)/me/my-orders/index.tsx:74
|
||
components/PaymentAndOrderComponent.tsx:32
|
||
components/ProductCard.tsx:40
|
||
components/ProductDetail.tsx:45
|
||
components/ProductDetail.tsx:708
|
||
components/cart-page.tsx:277
|
||
components/checkout-page.tsx:23
|
||
components/floating-cart-bar.tsx:90
|
||
components/registration-form.tsx:27
|
||
src/components/AddToCartDialog.tsx:41
|
||
src/components/LocationAttacher.tsx:19
|
||
src/components/location/LocationFallbackFlow.tsx:57
|
||
src/hooks/useRegion.ts:66
|
||
⚠ Large component is hard to read and change ×11
|
||
react-doctor/no-giant-component
|
||
app/(auth)/login.tsx:15
|
||
app/(drawer)/(tabs)/me/my-orders/[id].tsx:14
|
||
components/PaymentAndOrderComponent.tsx:32
|
||
components/ProductDetail.tsx:45
|
||
components/QuickDeliveryAddressSelector.tsx:23
|
||
components/cart-page.tsx:277
|
||
components/checkout-page.tsx:23
|
||
components/floating-cart-bar.tsx:90
|
||
components/registration-form.tsx:27
|
||
src/components/AddressForm.tsx:19
|
||
src/components/location/LocationFallbackFlow.tsx:57
|
||
⚠ State only used in handlers ×10
|
||
react-doctor/rerender-state-only-in-handlers
|
||
app/(auth)/login.tsx:19
|
||
app/(drawer)/(tabs)/me/my-orders/index.tsx:373
|
||
app/(drawer)/(tabs)/me/my-orders/index.tsx:374
|
||
components/ProductCard.tsx:55
|
||
components/ProductDetail.tsx:51
|
||
components/ProductDetail.tsx:52
|
||
components/ProductDetail.tsx:711
|
||
components/SlotSpecificView.tsx:341
|
||
components/SlotSpecificView.tsx:449
|
||
src/components/LocationAttacher.tsx:38
|
||
✖ State updater has side effects ×2
|
||
react-doctor/no-impure-state-updater
|
||
app/(auth)/login.tsx:78
|
||
app/(drawer)/(tabs)/home/index.tsx:555
|
||
⚠ Side effect inside a state updater function ×2
|
||
react-doctor/no-side-effect-in-state-updater-function
|
||
app/(auth)/login.tsx:80
|
||
app/(drawer)/(tabs)/home/index.tsx:557
|
||
⚠ Missing effect dependencies ×19
|
||
react-doctor/exhaustive-deps
|
||
app/(drawer)/(tabs)/flash-delivery/(products)/index.tsx:40
|
||
app/(drawer)/(tabs)/flash-delivery/(products)/index.tsx:74
|
||
app/(drawer)/(tabs)/home/index.tsx:552
|
||
app/(drawer)/(tabs)/home/index.tsx:601
|
||
app/(drawer)/(tabs)/home/index.tsx:667
|
||
app/(drawer)/(tabs)/home/search-results/index.tsx:75
|
||
components/ProductDetail.tsx:210
|
||
components/QuickDeliveryAddressSelector.tsx:57
|
||
components/cart-page.tsx:375
|
||
components/cart-page.tsx:701
|
||
components/cart-page.tsx:739
|
||
components/cart-page.tsx:767
|
||
components/cart-page.tsx:788
|
||
components/cart-page.tsx:834
|
||
components/floating-cart-bar.tsx:134
|
||
components/floating-cart-bar.tsx:155
|
||
services/notif-service/notif-checker.tsx:32
|
||
services/notif-service/notif-context.tsx:101
|
||
src/components/AddressForm.tsx:86
|
||
✖ Numeric && renders bare zero ×2
|
||
react-doctor/rn-no-falsy-and-render
|
||
app/(drawer)/(tabs)/flash-delivery/order-success.tsx:47
|
||
app/(drawer)/(tabs)/home/order-success.tsx:47
|
||
⚠ Non-virtualized mapped list in ScrollView ×8
|
||
react-doctor/rn-no-scrollview-mapped-list
|
||
app/(drawer)/(tabs)/home/index.tsx:231
|
||
app/(drawer)/(tabs)/me/my-orders/[id].tsx:294
|
||
app/(drawer)/(tabs)/stores/store-detail/[id].tsx:194
|
||
components/CheckoutAddressSelector.tsx:208
|
||
components/NextOrderGlimpse.tsx:198
|
||
components/ProductDetail.tsx:663
|
||
components/floating-cart-bar.tsx:288
|
||
src/components/AddToCartDialog.tsx:198
|
||
⚠ useMemo before an early return
|
||
react-doctor/rerender-memo-before-early-return
|
||
app/(drawer)/(tabs)/home/index.tsx:655
|
||
⚠ Inline renderItem on list ×3
|
||
react-doctor/rn-no-inline-flatlist-renderitem
|
||
app/(drawer)/(tabs)/home/index.tsx:726
|
||
app/(drawer)/(tabs)/stores/index.tsx:104
|
||
components/ProductDetail.tsx:556
|
||
⚠ Inline object in list renderItem ×4
|
||
react-doctor/rn-no-inline-object-in-list-item
|
||
app/(drawer)/(tabs)/home/index.tsx:736
|
||
app/(drawer)/(tabs)/stores/index.tsx:112
|
||
components/ProductDetail.tsx:595
|
||
components/ProductDetail.tsx:617
|
||
⚠ Inline handler in list renderItem ×5
|
||
react-doctor/rn-list-callback-per-row
|
||
app/(drawer)/(tabs)/home/search-results/index.tsx:98
|
||
app/(drawer)/(tabs)/me/my-orders/index.tsx:494
|
||
app/(drawer)/(tabs)/stores/store-detail/[id].tsx:131
|
||
components/SlotSpecificView.tsx:421
|
||
components/SlotSpecificView.tsx:538
|
||
⚠ Dimensions.get over useWindowDimensions ×2
|
||
react-doctor/rn-no-dimensions-get
|
||
app/(drawer)/(tabs)/me/addresses/index.tsx:262
|
||
components/QuickDeliveryAddressSelector.tsx:235
|
||
⚠ Array index used as a key ×7
|
||
react-doctor/no-array-index-as-key
|
||
app/(drawer)/(tabs)/me/my-orders/[id].tsx:295
|
||
app/(drawer)/(tabs)/me/my-orders/index.tsx:189
|
||
components/CheckoutAddressSelector.tsx:252
|
||
components/NextOrderGlimpse.tsx:213
|
||
components/ProductDetail.tsx:453
|
||
components/ProductDetail.tsx:524
|
||
components/ProductDetail.tsx:665
|
||
⚠ Data passed to parent via effect
|
||
react-doctor/no-pass-data-to-parent
|
||
components/CheckoutAddressSelector.tsx:81
|
||
✖ setState in onScroll handler
|
||
react-doctor/rn-no-scroll-state
|
||
components/CheckoutAddressSelector.tsx:94
|
||
⚠ Loading flag reset outside finally ×3
|
||
react-doctor/no-loading-flag-reset-outside-finally
|
||
components/CheckoutAddressSelector.tsx:164
|
||
components/ProductDetail.tsx:199
|
||
src/components/AddressForm.tsx:280
|
||
⚠ fetch Response consumed without status check ×3
|
||
react-doctor/no-fetch-response-used-without-status-check
|
||
components/ComplaintForm.tsx:46
|
||
components/ProductDetail.tsx:728
|
||
components/registration-form.tsx:170
|
||
⚠ URL hook value only read in handlers
|
||
react-doctor/rerender-defer-reads-hook
|
||
components/LoginWall.tsx:28
|
||
⚠ Non-component export in component file ×3
|
||
react-doctor/only-export-components
|
||
components/OrderStatusTracker.tsx:15
|
||
services/notif-service/notif-context.tsx:22
|
||
services/toaster.tsx:5
|
||
⚠ State adjusted after a prop changes ×7
|
||
react-doctor/no-adjust-state-on-prop-change
|
||
components/ProductCard.tsx:106
|
||
components/ProductCard.tsx:107
|
||
components/ProductCard.tsx:111
|
||
components/ProductCard.tsx:112
|
||
components/cart-page.tsx:787
|
||
components/cart-page.tsx:832
|
||
components/floating-cart-bar.tsx:133
|
||
⚠ State update after await in an effect
|
||
react-doctor/no-set-state-after-await-in-effect
|
||
components/ProductDetail.tsx:206
|
||
⚠ await inside a loop ×2
|
||
react-doctor/async-await-in-loop
|
||
components/ProductDetail.tsx:774
|
||
hooks/cart-query-hooks.tsx:218
|
||
⚠ Array lookup inside a loop ×2
|
||
react-doctor/js-set-map-lookups
|
||
components/cart-page.tsx:569
|
||
components/cart-page.tsx:570
|
||
⚠ Duplicated JSX structure
|
||
react-doctor/duplicate-jsx-subtree
|
||
components/cart-page.tsx:899
|
||
⚠ useEffect state synchronization flashes after paint
|
||
react-doctor/rendering-hydration-no-flicker
|
||
hooks/useColorScheme.web.ts:10
|
||
⚠ react-doctor/expo-lockfile
|
||
react-doctor/expo-lockfile
|
||
package.json
|
||
✖ socket/low-supply-chain-score
|
||
socket/low-supply-chain-score
|
||
package.json:28
|
||
⚠ Unstable context provider value
|
||
react-doctor/jsx-no-constructed-context-values
|
||
services/notif-service/notif-context.tsx:105
|
||
⚠ Context value from an unmemoized local literal
|
||
react-doctor/context-provider-value-from-unmemoized-local-literal
|
||
src/contexts/AuthContext.tsx:309
|
||
Full diagnostics written to /var/folders/6t/3blzq7_j6p95xzry6t7c14hw0000gn/T/react-doctor-329589f6-4770-4c88-9d7e-35cbe9eea9c9
|
||
|
||
────────────────────────────────────────────────────────────
|
||
|
||
Docs: https://react.doctor/docs
|
||
Learn more about fixing issues, setting up CI/CD, and
|
||
configuring rules with a config file
|
||
|
||
GitHub: https://github.com/millionco/react-doctor
|
||
Report issues and star the repository!
|
||
|