107 lines
5 KiB
Text
107 lines
5 KiB
Text
Resolving dependencies
|
||
Resolved, downloaded and extracted [2]
|
||
|
||
Agent guidance
|
||
- Treat React Doctor diagnostics as starting hypotheses. Read the relevant code before confirming or suppressing each finding.
|
||
- For each group, decide true positive, false positive, or needs-human-review, then assign high/medium/low confidence.
|
||
- Do not suppress a finding without evidence from the file in question. Confidence requires code context.
|
||
- Understand the root cause before editing. Fix the underlying code instead of changing react-doctor config or suppressing rules unless explicitly asked.
|
||
- Investigate deeply where relevant: race conditions, security-sensitive flows, state propagation, multi-file refactors, and downstream dependency chains.
|
||
- Ignore pure style preferences, theoretical issues without real impact, missing features, and unrelated pre-existing code.
|
||
- Start with high-confidence fixes that preserve behavior. Leave low-confidence or product-dependent changes as notes.
|
||
- Run `npx react-doctor@latest --verbose --scope changed` before and after changes, plus relevant tests after each focused batch.
|
||
- When available, spawn subagents or isolated worktrees for independent rule families, then review and merge only the best safe fixes.
|
||
- Split unrelated, broad, or behavior-changing work into separate PRs/branches instead of one large cleanup.
|
||
- When one rule spans dozens of files (a migration-scale change), fix a representative sample first, confirm the recipe holds, and get the code owner's sign-off before changing the rest. Don't mass-fix a broad pattern in one unreviewed pass.
|
||
- For confirmed issues that cannot be fixed now, create GitHub issues with the rule, file/line, confidence, impact, and proposed fix.
|
||
- If a fix needs an API, UX, or architecture decision, stop and ask before editing.
|
||
|
||
✔ Scanned 47 files in 1.7s
|
||
|
||
React Doctor — common-ui
|
||
Score disabled by --no-score. Want something custom to your company? Contact us at https://react.doctor/enterprise.
|
||
|
||
27 issues
|
||
Maintainability: 2 warnings
|
||
Performance: 6 warnings
|
||
Bugs: 2 errors, 15 warnings
|
||
Correctness: 1 warning
|
||
Security: 1 error
|
||
|
||
⚠ Non-component export in component file
|
||
react-doctor/only-export-components
|
||
hooks/theme-context.tsx:12
|
||
⚠ Unstable context provider value ×2
|
||
react-doctor/jsx-no-constructed-context-values
|
||
hooks/theme-context.tsx:30
|
||
src/lib/refresh-context.tsx:12
|
||
⚠ Missing effect dependencies ×3
|
||
react-doctor/exhaustive-deps
|
||
hooks/useDrawerTitle.ts:18
|
||
src/components/dialog.tsx:28
|
||
src/components/dialog.tsx:88
|
||
⚠ Listener re-subscribes on every handler change
|
||
react-doctor/advanced-event-handler-refs
|
||
hooks/useManualRefresh.ts:6
|
||
✖ Ref mutated during render
|
||
react-doctor/no-ref-current-in-render
|
||
hooks/useMarkDataFetchers.ts:9
|
||
⚠ Whole Zustand store subscribed during render
|
||
react-doctor/zustand-no-whole-store-destructure
|
||
hooks/useNavigationTarget.ts:24
|
||
⚠ react-doctor/expo-lockfile
|
||
react-doctor/expo-lockfile
|
||
package.json
|
||
✖ socket/low-supply-chain-score
|
||
socket/low-supply-chain-score
|
||
package.json:16
|
||
✖ setState in onScroll handler
|
||
react-doctor/rn-no-scroll-state
|
||
src/components/ImageCarousel.tsx:29
|
||
⚠ Array index used as a key ×4
|
||
react-doctor/no-array-index-as-key
|
||
src/components/ImageCarousel.tsx:64
|
||
src/components/ImageUploader.tsx:25
|
||
src/components/ImageUploader.tsx:40
|
||
src/components/ImageUploaderNeo.tsx:45
|
||
⚠ Legacy platform-specific shadow styles ×4
|
||
react-doctor/rn-no-legacy-shadow-styles
|
||
src/components/ImageCarousel.tsx:83
|
||
src/components/date-picker.tsx:77
|
||
src/components/date-time-picker.tsx:135
|
||
src/components/dialog.tsx:132
|
||
⚠ React function has high control-flow complexity
|
||
react-doctor/no-high-complexity-react-function
|
||
src/components/bottom-dropdown.tsx:61
|
||
⚠ Array lookup inside a loop
|
||
react-doctor/js-set-map-lookups
|
||
src/components/bottom-dropdown.tsx:114
|
||
⚠ Platform-specific shadow keys over boxShadow ×2
|
||
react-doctor/rn-style-prefer-boxshadow
|
||
src/components/date-picker.tsx:77
|
||
src/components/date-time-picker.tsx:135
|
||
⚠ Eager constructor in useState initializer ×2
|
||
react-doctor/no-eager-new-in-use-state-initializer
|
||
src/components/dialog.tsx:11
|
||
src/components/dialog.tsx:71
|
||
⚠ Dimensions.get over useWindowDimensions
|
||
react-doctor/rn-no-dimensions-get
|
||
src/components/image-viewer.tsx:21
|
||
Full diagnostics written to /var/folders/6t/3blzq7_j6p95xzry6t7c14hw0000gn/T/react-doctor-41950915-da76-4a99-bded-93319ceb4bd7
|
||
|
||
────────────────────────────────────────────────────────────
|
||
|
||
Docs: https://react.doctor/docs
|
||
Learn more about fixing issues, setting up CI/CD, and
|
||
configuring rules with a config file
|
||
|
||
GitHub: https://github.com/millionco/react-doctor
|
||
Report issues and star the repository!
|
||
|
||
|
||
React Doctor is not installed in this project.
|
||
Ask the user if they would like to set it up, then run:
|
||
|
||
npx react-doctor install --yes
|
||
|
||
This adds agent skill files, a `doctor` package script, and react-doctor as a dev dependency.
|