35 lines
No EOL
2.7 KiB
Text
35 lines
No EOL
2.7 KiB
Text
Review and fix the top 3 React Doctor findings in user-ui. Leave the rest for a follow-up.
|
||
|
||
1. WARN Maintainability: React function has high control-flow complexity (×15)
|
||
`Login` has cyclomatic complexity 30, cognitive complexity 30, and maximum nesting depth 3, so its React logic is hard to understand and change. Extract independent branches into components or hooks.
|
||
Curl with no cache & follow the canonical fix and false positive check recipe before fixing: https://react.doctor/docs/rules/react-doctor/no-high-complexity-react-function
|
||
- app/(auth)/login.tsx:15
|
||
- app/(drawer)/(tabs)/me/my-orders/[id].tsx:14
|
||
- app/(drawer)/(tabs)/me/my-orders/index.tsx:74
|
||
- +11 more files
|
||
2. WARN Maintainability: Large component is hard to read and change (×11)
|
||
Component "Login" is over 300 lines long, which is hard to read & change. Split it into a few smaller components.
|
||
Curl with no cache & follow the canonical fix and false positive check recipe before fixing: https://react.doctor/docs/rules/react-doctor/no-giant-component
|
||
- app/(auth)/login.tsx:15
|
||
- app/(drawer)/(tabs)/me/my-orders/[id].tsx:14
|
||
- components/PaymentAndOrderComponent.tsx:32
|
||
- +8 more files
|
||
3. WARN Performance: State only used in handlers (×10)
|
||
Each update to "passwordBackTo" redraws your component for nothing because this useState is set but never shown on screen.
|
||
Curl with no cache & follow the canonical fix and false positive check recipe before fixing: https://react.doctor/docs/rules/react-doctor/rerender-state-only-in-handlers
|
||
- app/(auth)/login.tsx:19
|
||
- app/(drawer)/(tabs)/me/my-orders/index.tsx:373
|
||
- components/ProductCard.tsx:55
|
||
- +3 more files
|
||
|
||
Full results for all 121 issues (diagnostics.json + a .txt per rule): /var/folders/6t/3blzq7_j6p95xzry6t7c14hw0000gn/T/react-doctor-d12050a6-1365-4f35-8c90-23fa748a45bd
|
||
|
||
Read each file and fix the root cause — don't suppress or silence the rule.
|
||
|
||
Findings that share a `fixGroupId` (in diagnostics.json) are one root cause — a single fix clears all of them, so treat each `fixGroupId` as ONE task, not one per site.
|
||
|
||
Verify against the real thing, don't assume: confirm each change matches the canonical fix recipe you fetched for that rule, then re-run `npx react-doctor@latest --verbose` and check the issue is actually gone against the real tool before moving on.
|
||
|
||
Teach me as you go: for every issue you touch, explain it in plain language (no jargon) — what the problem is, why it's a problem, and how serious it is in human terms. Describe the real-world impact and severity concretely (e.g. "this crashes the page for users on Safari" vs. "this is a minor cleanup with no user impact") so I understand why it matters, not just what changed.
|
||
|
||
Stop after this pass. Summarize the remaining findings for a follow-up. |