271 lines
12 KiB
Text
271 lines
12 KiB
Text
Resolving dependencies
|
||
Resolved, downloaded and extracted [2]
|
||
|
||
Agent guidance
|
||
- Treat React Doctor diagnostics as starting hypotheses. Read the relevant code before confirming or suppressing each finding.
|
||
- For each group, decide true positive, false positive, or needs-human-review, then assign high/medium/low confidence.
|
||
- Do not suppress a finding without evidence from the file in question. Confidence requires code context.
|
||
- Understand the root cause before editing. Fix the underlying code instead of changing react-doctor config or suppressing rules unless explicitly asked.
|
||
- Investigate deeply where relevant: race conditions, security-sensitive flows, state propagation, multi-file refactors, and downstream dependency chains.
|
||
- Ignore pure style preferences, theoretical issues without real impact, missing features, and unrelated pre-existing code.
|
||
- Start with high-confidence fixes that preserve behavior. Leave low-confidence or product-dependent changes as notes.
|
||
- Run `npx react-doctor@latest --verbose --scope changed` before and after changes, plus relevant tests after each focused batch.
|
||
- When available, spawn subagents or isolated worktrees for independent rule families, then review and merge only the best safe fixes.
|
||
- Split unrelated, broad, or behavior-changing work into separate PRs/branches instead of one large cleanup.
|
||
- When one rule spans dozens of files (a migration-scale change), fix a representative sample first, confirm the recipe holds, and get the code owner's sign-off before changing the rest. Don't mass-fix a broad pattern in one unreviewed pass.
|
||
- For confirmed issues that cannot be fixed now, create GitHub issues with the rule, file/line, confidence, impact, and proposed fix.
|
||
- If a fix needs an API, UX, or architecture decision, stop and ask before editing.
|
||
|
||
✔ Scanned 82 files in 3.9s
|
||
|
||
React Doctor — admin-web
|
||
Score disabled by --no-score. Want something custom to your company? Contact us at https://react.doctor/enterprise.
|
||
|
||
161 issues
|
||
Security: 2 errors
|
||
Performance: 31 warnings
|
||
Maintainability: 27 warnings
|
||
Bugs: 5 errors, 46 warnings
|
||
Accessibility: 50 warnings
|
||
|
||
✖ socket/low-supply-chain-score ×2
|
||
socket/low-supply-chain-score
|
||
package.json:24
|
||
package.json:29
|
||
⚠ State only used in handlers ×4
|
||
react-doctor/rerender-state-only-in-handlers
|
||
src/components/BannerForm.tsx:49
|
||
src/routes/dashboard.banners.tsx:23
|
||
src/routes/dashboard.banners.tsx:29
|
||
src/routes/dashboard.products.$id.tsx:34
|
||
⚠ Large component is hard to read and change ×11
|
||
react-doctor/no-giant-component
|
||
src/components/CouponForm.tsx:92
|
||
src/components/ProductForm.tsx:179
|
||
src/routes/dashboard.banners.tsx:20
|
||
src/routes/dashboard.complaints.tsx:12
|
||
src/routes/dashboard.customize-app.popular.tsx:103
|
||
src/routes/dashboard.customize-app.tsx:259
|
||
src/routes/dashboard.orders.$id.tsx:34
|
||
src/routes/dashboard.orders.list.tsx:112
|
||
src/routes/dashboard.orders.list.tsx:510
|
||
src/routes/dashboard.orders.sequence.tsx:270
|
||
src/routes/dashboard.products.$id.tsx:135
|
||
⚠ Effects chained together
|
||
react-doctor/no-effect-chain
|
||
src/components/CouponForm.tsx:121
|
||
⚠ Array index used as a key ×16
|
||
react-doctor/no-array-index-as-key
|
||
src/components/CouponForm.tsx:222
|
||
src/components/SlotForm.tsx:171
|
||
src/components/SnippetOrdersView.tsx:67
|
||
src/components/SnippetOrdersView.tsx:141
|
||
src/components/TagMenu.tsx:103
|
||
src/routes/dashboard.complaints.tsx:178
|
||
src/routes/dashboard.orders.$id.tsx:352
|
||
src/routes/dashboard.orders.list.tsx:429
|
||
src/routes/dashboard.orders.sequence.tsx:92
|
||
src/routes/dashboard.orders.tsx:86
|
||
src/routes/dashboard.products.$id.tsx:313
|
||
src/routes/dashboard.products.$id.tsx:333
|
||
src/routes/dashboard.products.$id.tsx:381
|
||
src/routes/dashboard.products.$id.tsx:396
|
||
src/routes/dashboard.rebalance.tsx:239
|
||
src/routes/dashboard.slots.tsx:298
|
||
⚠ Control missing accessible label ×24
|
||
react-doctor/control-has-associated-label
|
||
src/components/DateInput.tsx:22
|
||
src/components/DateTimeInput.tsx:48
|
||
src/components/DateTimeInput.tsx:62
|
||
src/components/DateTimeInput.tsx:72
|
||
src/routes/dashboard.customize-app.ordering.tsx:190
|
||
src/routes/dashboard.customize-app.ordering.tsx:215
|
||
src/routes/dashboard.customize-app.ordering.tsx:245
|
||
src/routes/dashboard.customize-app.popular.tsx:91
|
||
src/routes/dashboard.customize-app.popular.tsx:215
|
||
src/routes/dashboard.customize-app.popular.tsx:243
|
||
src/routes/dashboard.customize-app.popular.tsx:276
|
||
src/routes/dashboard.customize-app.popular.tsx:339
|
||
src/routes/dashboard.prices.tsx:99
|
||
src/routes/dashboard.prices.tsx:109
|
||
src/routes/dashboard.prices.tsx:119
|
||
src/routes/dashboard.prices.tsx:129
|
||
src/routes/dashboard.prices.tsx:324
|
||
src/routes/dashboard.product-groupings.tsx:50
|
||
src/routes/dashboard.product-groupings.tsx:56
|
||
src/routes/dashboard.product-tags.order.tsx:181
|
||
src/routes/dashboard.product-tags.order.tsx:203
|
||
src/routes/dashboard.product-tags.order.tsx:230
|
||
src/routes/dashboard.products.$id.tsx:201
|
||
src/routes/dashboard.products.$id.tsx:432
|
||
⚠ Missing effect dependencies ×9
|
||
react-doctor/exhaustive-deps
|
||
src/components/GlobalProductForm.tsx:47
|
||
src/components/ProductsSelector.tsx:98
|
||
src/components/VendorSnippetForm.tsx:105
|
||
src/routes/dashboard.banners.tsx:51
|
||
src/routes/dashboard.orders.sequence.tsx:430
|
||
src/routes/dashboard.prices.tsx:181
|
||
src/routes/dashboard.prices.tsx:196
|
||
src/routes/dashboard.prices.tsx:208
|
||
src/routes/dashboard.products.tsx:75
|
||
⚠ Click handler missing keyboard handler ×5
|
||
react-doctor/click-events-have-key-events
|
||
src/components/MultiSelect.tsx:105
|
||
src/components/ProductGroupForm.tsx:122
|
||
src/components/ProductGroupForm.tsx:128
|
||
src/routes/dashboard.complaints.tsx:177
|
||
src/routes/dashboard.tsx:156
|
||
⚠ Interaction on static element ×4
|
||
react-doctor/no-static-element-interactions
|
||
src/components/MultiSelect.tsx:105
|
||
src/components/ProductGroupForm.tsx:122
|
||
src/components/ProductGroupForm.tsx:128
|
||
src/routes/dashboard.tsx:156
|
||
⚠ Empty default prop breaks memo ×2
|
||
react-doctor/rerender-memo-with-default-value
|
||
src/components/ProductsSelector.tsx:43
|
||
src/components/ProductsSelector.tsx:45
|
||
⚠ Array lookup inside a loop ×18
|
||
react-doctor/js-set-map-lookups
|
||
src/components/ProductsSelector.tsx:59
|
||
src/components/ProductsSelector.tsx:60
|
||
src/components/ProductsSelector.tsx:79
|
||
src/components/ProductsSelector.tsx:104
|
||
src/components/SlotForm.tsx:186
|
||
src/components/SlotForm.tsx:189
|
||
src/components/SlotForm.tsx:195
|
||
src/components/SnippetOrdersView.tsx:64
|
||
src/routes/dashboard.banners.tsx:341
|
||
src/routes/dashboard.coupons.tsx:247
|
||
src/routes/dashboard.coupons.tsx:390
|
||
src/routes/dashboard.orders.sequence.tsx:371
|
||
src/routes/dashboard.orders.sequence.tsx:573
|
||
src/routes/dashboard.orders.sequence.tsx:606
|
||
src/routes/dashboard.orders.sequence.tsx:639
|
||
src/routes/dashboard.prices.tsx:213
|
||
src/routes/dashboard.product-tags.edit.tsx:93
|
||
src/routes/dashboard.product-tags.edit.tsx:94
|
||
⚠ State adjusted after a prop changes ×3
|
||
react-doctor/no-adjust-state-on-prop-change
|
||
src/components/TagForm.tsx:133
|
||
src/components/TagForm.tsx:143
|
||
src/components/TagForm.tsx:145
|
||
⚠ array.find() inside a loop ×2
|
||
react-doctor/js-index-maps
|
||
src/components/TagForm.tsx:164
|
||
src/routes/dashboard.customize-app.popular.tsx:134
|
||
✖ Hook called conditionally ×2
|
||
react-doctor/rules-of-hooks
|
||
src/components/TagForm.tsx:195
|
||
src/components/TagForm.tsx:205
|
||
⚠ React function has high control-flow complexity ×10
|
||
react-doctor/no-high-complexity-react-function
|
||
src/components/VendorSnippetForm.tsx:17
|
||
src/routes/dashboard.banners.tsx:20
|
||
src/routes/dashboard.coupons.tsx:14
|
||
src/routes/dashboard.customize-app.popular.tsx:103
|
||
src/routes/dashboard.customize-app.tsx:133
|
||
src/routes/dashboard.orders.$id.tsx:34
|
||
src/routes/dashboard.orders.list.tsx:112
|
||
src/routes/dashboard.orders.sequence.tsx:270
|
||
src/routes/dashboard.prices.tsx:28
|
||
src/routes/dashboard.products.$id.tsx:135
|
||
⚠ Locale/timezone formatting during render ×4
|
||
react-doctor/no-locale-format-in-render
|
||
src/components/VendorSnippetForm.tsx:108
|
||
src/routes/dashboard.banners.tsx:404
|
||
src/routes/dashboard.coupons.tsx:89
|
||
src/routes/dashboard.products.$id.tsx:336
|
||
⚠ Unstable context provider value ×2
|
||
react-doctor/jsx-no-constructed-context-values
|
||
src/components/context/staff-auth-context.tsx:94
|
||
src/lib/refresh-context.tsx:17
|
||
⚠ Whole Zustand store subscribed during render
|
||
react-doctor/zustand-no-whole-store-destructure
|
||
src/lib/navigation-target.ts:25
|
||
✖ Ref mutated during render ×3
|
||
react-doctor/no-ref-current-in-render
|
||
src/lib/refresh-context.tsx:28
|
||
src/lib/refresh-context.tsx:40
|
||
src/lib/refresh-context.tsx:56
|
||
⚠ Non-component export in component file
|
||
react-doctor/only-export-components
|
||
src/lib/refresh-context.tsx:54
|
||
⚠ Loading flag reset outside finally ×6
|
||
react-doctor/no-loading-flag-reset-outside-finally
|
||
src/routes/dashboard.banners.tsx:56
|
||
src/routes/dashboard.coupons.tsx:255
|
||
src/routes/dashboard.coupons.tsx:398
|
||
src/routes/dashboard.rebalance.tsx:138
|
||
src/routes/dashboard.slots.tsx:248
|
||
src/routes/dashboard.users.tsx:183
|
||
⚠ Async mutating handler without re-entry guard
|
||
react-doctor/no-async-event-handler-without-reentry-guard
|
||
src/routes/dashboard.banners.tsx:160
|
||
⚠ Handler on non-interactive element
|
||
react-doctor/no-noninteractive-element-interactions
|
||
src/routes/dashboard.complaints.tsx:177
|
||
⚠ Duplicated JSX structure ×5
|
||
react-doctor/duplicate-jsx-subtree
|
||
src/routes/dashboard.coupons.tsx:80
|
||
src/routes/dashboard.customize-app.ordering.tsx:187
|
||
src/routes/dashboard.customize-app.ordering.tsx:212
|
||
src/routes/dashboard.customize-app.ordering.tsx:244
|
||
src/routes/dashboard.users.$id.tsx:131
|
||
⚠ navigate() called during render
|
||
react-doctor/tanstack-start-no-navigate-in-render
|
||
src/routes/dashboard.customize-app.tsx:262
|
||
⚠ ARIA button handles only one activation key ×5
|
||
react-doctor/role-button-requires-complete-keyboard-activation
|
||
src/routes/dashboard.orders.list.tsx:187
|
||
src/routes/dashboard.rebalance.tsx:37
|
||
src/routes/dashboard.slots.tsx:61
|
||
src/routes/dashboard.users.$id.tsx:45
|
||
src/routes/dashboard.users.tsx:39
|
||
⚠ Interactive control contains another focusable control ×10
|
||
react-doctor/html-no-nested-interactive
|
||
src/routes/dashboard.orders.list.tsx:224
|
||
src/routes/dashboard.orders.list.tsx:297
|
||
src/routes/dashboard.orders.list.tsx:344
|
||
src/routes/dashboard.orders.list.tsx:355
|
||
src/routes/dashboard.rebalance.tsx:104
|
||
src/routes/dashboard.slots.tsx:79
|
||
src/routes/dashboard.slots.tsx:96
|
||
src/routes/dashboard.slots.tsx:148
|
||
src/routes/dashboard.slots.tsx:160
|
||
src/routes/dashboard.slots.tsx:211
|
||
⚠ fetch Response consumed without status check ×4
|
||
react-doctor/no-fetch-response-used-without-status-check
|
||
src/routes/dashboard.product-tags.edit.tsx:39
|
||
src/routes/dashboard.product-tags.new.tsx:27
|
||
src/routes/dashboard.products.edit.tsx:127
|
||
src/routes/dashboard.products.new.tsx:55
|
||
⚠ createObjectURL without revokeObjectURL
|
||
react-doctor/no-create-object-url-without-revoke
|
||
src/routes/dashboard.products.$id.tsx:50
|
||
⚠ Field relies on placeholder text for its label
|
||
react-doctor/no-placeholder-only-field
|
||
src/routes/dashboard.products.$id.tsx:93
|
||
⚠ await inside a loop ×2
|
||
react-doctor/async-await-in-loop
|
||
src/routes/dashboard.products.edit.tsx:127
|
||
src/routes/dashboard.products.new.tsx:55
|
||
Full diagnostics written to /var/folders/6t/3blzq7_j6p95xzry6t7c14hw0000gn/T/react-doctor-bb92b47e-e51e-4e36-aeb7-7603e73464dd
|
||
|
||
────────────────────────────────────────────────────────────
|
||
|
||
Docs: https://react.doctor/docs
|
||
Learn more about fixing issues, setting up CI/CD, and
|
||
configuring rules with a config file
|
||
|
||
GitHub: https://github.com/millionco/react-doctor
|
||
Report issues and star the repository!
|
||
|
||
|
||
React Doctor is not installed in this project.
|
||
Ask the user if they would like to set it up, then run:
|
||
|
||
npx react-doctor install --yes
|
||
|
||
This adds agent skill files, a `doctor` package script, and react-doctor as a dev dependency.
|