107 lines
5 KiB
Text
107 lines
5 KiB
Text
Resolving dependencies
|
||
Resolved, downloaded and extracted [2]
|
||
|
||
Agent guidance
|
||
- Treat React Doctor diagnostics as starting hypotheses. Read the relevant code before confirming or suppressing each finding.
|
||
- For each group, decide true positive, false positive, or needs-human-review, then assign high/medium/low confidence.
|
||
- Do not suppress a finding without evidence from the file in question. Confidence requires code context.
|
||
- Understand the root cause before editing. Fix the underlying code instead of changing react-doctor config or suppressing rules unless explicitly asked.
|
||
- Investigate deeply where relevant: race conditions, security-sensitive flows, state propagation, multi-file refactors, and downstream dependency chains.
|
||
- Ignore pure style preferences, theoretical issues without real impact, missing features, and unrelated pre-existing code.
|
||
- Start with high-confidence fixes that preserve behavior. Leave low-confidence or product-dependent changes as notes.
|
||
- Run `npx react-doctor@latest --verbose --scope changed` before and after changes, plus relevant tests after each focused batch.
|
||
- When available, spawn subagents or isolated worktrees for independent rule families, then review and merge only the best safe fixes.
|
||
- Split unrelated, broad, or behavior-changing work into separate PRs/branches instead of one large cleanup.
|
||
- When one rule spans dozens of files (a migration-scale change), fix a representative sample first, confirm the recipe holds, and get the code owner's sign-off before changing the rest. Don't mass-fix a broad pattern in one unreviewed pass.
|
||
- For confirmed issues that cannot be fixed now, create GitHub issues with the rule, file/line, confidence, impact, and proposed fix.
|
||
- If a fix needs an API, UX, or architecture decision, stop and ask before editing.
|
||
|
||
✔ Scanned 32 files in 2.1s
|
||
|
||
React Doctor — superadmin-ui
|
||
Score disabled by --no-score. Want something custom to your company? Contact us at https://react.doctor/enterprise.
|
||
|
||
30 issues
|
||
Security: 2 errors, 1 warning
|
||
Accessibility: 10 warnings
|
||
Bugs: 5 warnings
|
||
Maintainability: 6 warnings
|
||
Performance: 6 warnings
|
||
|
||
✖ socket/low-supply-chain-score ×2
|
||
socket/low-supply-chain-score
|
||
package.json:24
|
||
package.json:29
|
||
⚠ Click handler missing keyboard handler
|
||
react-doctor/click-events-have-key-events
|
||
src/components/AppShell.tsx:79
|
||
⚠ Interaction on static element
|
||
react-doctor/no-static-element-interactions
|
||
src/components/AppShell.tsx:79
|
||
⚠ Missing effect dependencies ×2
|
||
react-doctor/exhaustive-deps
|
||
src/components/ProtectedRoute.tsx:16
|
||
src/components/ui/dialog-host.tsx:113
|
||
⚠ Non-component export in component file ×3
|
||
react-doctor/only-export-components
|
||
src/components/ui/dialog-host.tsx:58
|
||
src/components/ui/dialog-host.tsx:66
|
||
src/components/ui/dialog-host.tsx:74
|
||
⚠ State only used in handlers
|
||
react-doctor/rerender-state-only-in-handlers
|
||
src/components/ui/dialog-host.tsx:97
|
||
⚠ Auth token in web storage
|
||
react-doctor/auth-token-in-web-storage
|
||
src/lib/auth-context.tsx:58
|
||
⚠ Unstable context provider value
|
||
react-doctor/jsx-no-constructed-context-values
|
||
src/lib/auth-context.tsx:86
|
||
⚠ State initializer runs on every render
|
||
react-doctor/rerender-lazy-state-init
|
||
src/routes/coupons.tsx:58
|
||
⚠ React function has high control-flow complexity ×2
|
||
react-doctor/no-high-complexity-react-function
|
||
src/routes/coupons.tsx:284
|
||
src/routes/global-products.tsx:331
|
||
⚠ Array lookup inside a loop
|
||
react-doctor/js-set-map-lookups
|
||
src/routes/coupons.tsx:418
|
||
⚠ State adjusted after a prop changes
|
||
react-doctor/no-adjust-state-on-prop-change
|
||
src/routes/global-products.tsx:124
|
||
⚠ Field relies on placeholder text for its label ×6
|
||
react-doctor/no-placeholder-only-field
|
||
src/routes/global-products.tsx:162
|
||
src/routes/global-products.tsx:567
|
||
src/routes/global-products.tsx:573
|
||
src/routes/regions.tsx:271
|
||
src/routes/regions.tsx:409
|
||
src/routes/send-notifications.tsx:71
|
||
⚠ Large component is hard to read and change
|
||
react-doctor/no-giant-component
|
||
src/routes/global-products.tsx:331
|
||
⚠ createObjectURL without revokeObjectURL
|
||
react-doctor/no-create-object-url-without-revoke
|
||
src/routes/global-products.tsx:373
|
||
⚠ await inside a loop
|
||
react-doctor/async-await-in-loop
|
||
src/routes/global-products.tsx:408
|
||
⚠ Array index used as a key ×2
|
||
react-doctor/no-array-index-as-key
|
||
src/routes/global-products.tsx:504
|
||
src/routes/regions.tsx:240
|
||
⚠ Control missing accessible label ×2
|
||
react-doctor/control-has-associated-label
|
||
src/routes/global-products.tsx:522
|
||
src/routes/global-products.tsx:534
|
||
Full diagnostics written to /var/folders/6t/3blzq7_j6p95xzry6t7c14hw0000gn/T/react-doctor-0630a984-ccf6-4c44-aab6-f0be068c2339
|
||
|
||
────────────────────────────────────────────────────────────
|
||
|
||
Docs: https://react.doctor/docs
|
||
Learn more about fixing issues, setting up CI/CD, and
|
||
configuring rules with a config file
|
||
|
||
GitHub: https://github.com/millionco/react-doctor
|
||
Report issues and star the repository!
|
||
|